coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[M] Change in coreboot[main]: soc/mediatek: Add support for MediaTek firmware support package
by Yidi Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85665?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: soc/mediatek: Add support for MediaTek firmware support package ...................................................................... soc/mediatek: Add support for MediaTek firmware support package Starting from MT8196, MediaTek platform introudces a new blob named MediaTek firmware support package (mtk-fsp). The features of mtk-fsp include but not limit to, - Security settings, e.g: Device Access Proctection Control, Security Memory Protection Unit. - Initialization for advanced CPU frequency control. This patch implements APIs for 1) Exchanging data between coreboot and mtk-fsp. 2) Loading and running the mtk-fsp blob at a specific bootstage. BUG=b:373797027 TEST=emerge-rauru coreboot; Run mock blob and return from mock blob. Change-Id: Idef3518f9763fe5f74adb459c137db164563e483 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- A src/soc/mediatek/common/include/soc/mtk_fsp.h A src/soc/mediatek/common/include/soc/mtk_fsp_common.h A src/soc/mediatek/common/mtk_fsp.c M src/soc/mediatek/mt8196/Makefile.mk 4 files changed, 184 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/85665/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idef3518f9763fe5f74adb459c137db164563e483 Gerrit-Change-Number: 85665 Gerrit-PatchSet: 6 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8189: Add timer support
by Yidi Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Vince Liu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85689?usp=email ) Change subject: soc/mediatek/mt8189: Add timer support ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85689/comment/9a7db6ee_8b9528b8?us… : PS1, Line 9: Add timer support for MT8189. : : The new ICs(e.g. mt8196, mt8189) will no longer use GPT, and in order : to improve code readability, the macro name TIMER_MHZ will be used. Add ARM arch timer support for MT8189. -- To view, visit https://review.coreboot.org/c/coreboot/+/85689?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I28c051c2e51481464f5dacb4c93f41e4f7e62501 Gerrit-Change-Number: 85689 Gerrit-PatchSet: 1 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 08:44:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8189: Add timer support
by Paul Menzel (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Vince Liu, Yidi Lin, Yu-Ping Wu. Paul Menzel has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85689?usp=email ) Change subject: soc/mediatek/mt8189: Add timer support ...................................................................... Patch Set 1: (1 comment) File src/soc/mediatek/mt8189/timer.c: https://review.coreboot.org/c/coreboot/+/85689/comment/c06d9e5a_8215e7fb?us… : PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only OR MIT */ Please make this relicensing a separate commit. -- To view, visit https://review.coreboot.org/c/coreboot/+/85689?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I28c051c2e51481464f5dacb4c93f41e4f7e62501 Gerrit-Change-Number: 85689 Gerrit-PatchSet: 1 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 08:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/mediatek/common: Rename GPT_MHZ to TIMER_MHZ for readability
by Vince Liu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin. Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85681?usp=email ) Change subject: soc/mediatek/common: Rename GPT_MHZ to TIMER_MHZ for readability ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85681/comment/191dede0_789fb96b?us… : PS1, Line 7: Update timer macro name > Or `Rename GPT_MHZ to TIMER_MHZ for readability` Done https://review.coreboot.org/c/coreboot/+/85681/comment/9e12acfe_c366716a?us… : PS1, Line 11: The new ICs(e.g. mt8196, mt8189) will no longer use GPT, and in order : to improve code readability, so replace GPT_MHZ of existing Soc's : with macro name TIMER_MHZ. > nit: space before `(` Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02f18bfa5b5912f28e322d40cd46823a0095bbf4 Gerrit-Change-Number: 85681 Gerrit-PatchSet: 2 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Fri, 20 Dec 2024 08:35:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8189: Add timer support
by Vince Liu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Vince Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85689?usp=email ) Change subject: soc/mediatek/mt8189: Add timer support ...................................................................... soc/mediatek/mt8189: Add timer support Add timer support for MT8189. The new ICs(e.g. mt8196, mt8189) will no longer use GPT, and in order to improve code readability, the macro name TIMER_MHZ will be used. BUG=b:379008996 BRANCH=none TEST=Check SYSTIMER_BASE register is configurated correctly. Change-Id: I28c051c2e51481464f5dacb4c93f41e4f7e62501 Signed-off-by: Ke Zheng <ot_ke.zheng(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/mt8189/Makefile.mk M src/soc/mediatek/mt8189/timer.c 2 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/85689/1 diff --git a/src/soc/mediatek/mt8189/Makefile.mk b/src/soc/mediatek/mt8189/Makefile.mk index 9b09628..efc8ff5 100644 --- a/src/soc/mediatek/mt8189/Makefile.mk +++ b/src/soc/mediatek/mt8189/Makefile.mk @@ -3,7 +3,7 @@ ifeq ($(CONFIG_SOC_MEDIATEK_MT8189),y) all-$(CONFIG_SPI_FLASH) += spi.c -all-y += timer.c +all-y += timer.c ../common/timer_prepare.c all-y += ../common/uart.c bootblock-y += bootblock.c diff --git a/src/soc/mediatek/mt8189/timer.c b/src/soc/mediatek/mt8189/timer.c index 2f299ea..0d9776b 100644 --- a/src/soc/mediatek/mt8189/timer.c +++ b/src/soc/mediatek/mt8189/timer.c @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ /* * This file is created based on MT8189 Functional Specification @@ -8,8 +8,11 @@ #include <arch/lib_helpers.h> #include <commonlib/helpers.h> #include <delay.h> +#include <soc/timer.h> void init_timer(void) { - raw_write_cntfrq_el0(13 * MHz); + timer_prepare(); + + raw_write_cntfrq_el0(TIMER_MHZ * MHz); } -- To view, visit https://review.coreboot.org/c/coreboot/+/85689?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I28c051c2e51481464f5dacb4c93f41e4f7e62501 Gerrit-Change-Number: 85689 Gerrit-PatchSet: 1 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/common: Rename GPT_MHZ to TIMER_MHZ for readability
by Vince Liu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Vince Liu. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85681?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/common: Rename GPT_MHZ to TIMER_MHZ for readability ...................................................................... soc/mediatek/common: Rename GPT_MHZ to TIMER_MHZ for readability Update timer macro name for common. The new ICs (e.g. mt8196, mt8189) will no longer use GPT. In order to improve code readability, replace GPT_MHZ with TIMER_MHZ for existing SoCs. BUG=b:379008996 BRANCH=none TEST=Build pass, Macro name is correct. Change-Id: I02f18bfa5b5912f28e322d40cd46823a0095bbf4 Signed-off-by: Ke Zheng <ot_ke.zheng(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/common/include/soc/timer_v1.h M src/soc/mediatek/common/include/soc/timer_v2.h M src/soc/mediatek/common/timer.c M src/soc/mediatek/mt8173/timer.c M src/soc/mediatek/mt8196/timer.c 5 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/85681/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02f18bfa5b5912f28e322d40cd46823a0095bbf4 Gerrit-Change-Number: 85681 Gerrit-PatchSet: 2 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com>

1 0

[M] Change in coreboot[main]: mb/google/rauru: Implement SKU ID
by Jarried Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Knox Chiou, Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email ) Change subject: mb/google/rauru: Implement SKU ID ...................................................................... Patch Set 8: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85666/comment/f960289e_361d41c9?us… : PS7, Line 9: Geralt > Rauru Done File src/mainboard/google/rauru/boardid.c: https://review.coreboot.org/c/coreboot/+/85666/comment/4a74c103_d71fc87e?us… : PS7, Line 38: printk(BIOS_DEBUG, "AUXADC: channel=%u\n", channel); : printk(BIOS_DEBUG, "AUXADC: VIN1=%d VIN2=%d\n", AUXADC_CHAN_VIN1, AUXADC_CHAN_VIN2); > These 2 logs don't seem needed. Done https://review.coreboot.org/c/coreboot/+/85666/comment/c956dc7c_b1fb7732?us… : PS7, Line 41: printk(BIOS_DEBUG, "AUXADC: value=%d\n", value); > Don't need this either. We already print `value` in the other log below. Done https://review.coreboot.org/c/coreboot/+/85666/comment/75862ee0_96b0003f?us… : PS7, Line 65: (get_adc_index(SKU_ID_HIGH_CHANNEL) << 4 > We don't use VIN2 for neither Rauru nor Navi Done File src/mainboard/google/rauru/mainboard.c: https://review.coreboot.org/c/coreboot/+/85666/comment/7a5a57b6_582b0e79?us… : PS7, Line 59: configure_audio(); > Need `mt6363_init_pmif_arb`. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece Gerrit-Change-Number: 85666 Gerrit-PatchSet: 8 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 08:18:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/rauru: Implement SKU ID
by Jarried Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Knox Chiou. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85666?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/rauru: Implement SKU ID ...................................................................... mb/google/rauru: Implement SKU ID Retrieve the SKU ID for Rauru via CBI interface. If that failed (or no data found), fall back to ADC channels for SKU ID. TEST=Build pass, boot ok, log show: SKU Code: 0x2 BUG=b:317009620 Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com> --- M src/mainboard/google/rauru/Kconfig M src/mainboard/google/rauru/Makefile.mk A src/mainboard/google/rauru/boardid.c M src/mainboard/google/rauru/mainboard.c 4 files changed, 76 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/85666/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/85666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece Gerrit-Change-Number: 85666 Gerrit-PatchSet: 8 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add SPM loader
by Yidi Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Alicja Michalska, Ccong Chen, Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email ) Change subject: soc/mediatek/mt8196: Add SPM loader ...................................................................... Patch Set 15: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85599?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie09346f46cb734c74776b760485e7f35d4357e5e Gerrit-Change-Number: 85599 Gerrit-PatchSet: 15 Gerrit-Owner: Ccong Chen <ot_ccong.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-CC: Wenzhen Yu <wenzhen.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Ccong Chen <ot_ccong.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 08:04:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add SPM loader
by Jarried Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Alicja Michalska, Ccong Chen, Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email ) Change subject: soc/mediatek/mt8196: Add SPM loader ...................................................................... Patch Set 15: (1 comment) File src/soc/mediatek/mt8196/include/soc/spm.h: https://review.coreboot.org/c/coreboot/+/85599/comment/60322d24_7c64468b?us… : PS14, Line 1133: check_member(mtk_spm_regs, spm_twam_timer_out, 0xFFC); > Add `check_member(mtk_spm_regs, md1_pwr_con, 0xE00);` (for CB:85651) Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85599?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie09346f46cb734c74776b760485e7f35d4357e5e Gerrit-Change-Number: 85599 Gerrit-PatchSet: 15 Gerrit-Owner: Ccong Chen <ot_ccong.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-CC: Wenzhen Yu <wenzhen.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Ccong Chen <ot_ccong.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 08:00:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024