coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: Revert "mb/starlabs/*: Disable c6dram"
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85704?usp=email ) Change subject: Revert "mb/starlabs/*: Disable c6dram" ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85704?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If69bb946d31e842af9caf84470ddd32900e56456 Gerrit-Change-Number: 85704 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 20 Dec 2024 10:56:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starlite: Adjust the touchscreen reset delay
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85700?usp=email ) Change subject: mb/starlabs/starlite: Adjust the touchscreen reset delay ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85700?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8e608347efec03b408a5f44c4f8f2221855e2532 Gerrit-Change-Number: 85700 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 20 Dec 2024 10:30:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starlite: Set Touch Panel Reset (GPP_F17) to host owned
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85699?usp=email ) Change subject: mb/starlabs/starlite: Set Touch Panel Reset (GPP_F17) to host owned ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85699?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3e1249addcfb831deee81024a37a867c79b1b0f9 Gerrit-Change-Number: 85699 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 20 Dec 2024 10:30:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: commonlib: Refactor CSE sync eventLog
by Subrata Banik (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Karthik Ramasubramanian. Subrata Banik has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/85622?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: commonlib: Refactor CSE sync eventLog ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85622/comment/6bce5c77_96a18561?us… : PS2, Line 24: Post RAM CSE Sync is this hand edited ? here is the actual string ``` Post-RAM CSE Sync ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/85622?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5db3ffb43b2ceac821de72ef9e88ed62e617d41 Gerrit-Change-Number: 85622 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 10:28:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: commonlib: Refactor CSE sync eventLog
by Subrata Banik (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Karthik Ramasubramanian. Subrata Banik has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/85622?usp=email ) Change subject: commonlib: Refactor CSE sync eventLog ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85622?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5db3ffb43b2ceac821de72ef9e88ed62e617d41 Gerrit-Change-Number: 85622 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 10:28:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/starlabs/*: Configure GPIO UPDs for eSPI
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85691?usp=email ) Change subject: mb/starlabs/*: Configure GPIO UPDs for eSPI ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85691?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide4d92211fa7ab496c38ce1c4e895337c269d247 Gerrit-Change-Number: 85691 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 20 Dec 2024 10:22:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/google/rauru: Implement SKU ID
by Yidi Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Jarried Lin. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email ) Change subject: mb/google/rauru: Implement SKU ID ...................................................................... Patch Set 8: (2 comments) File src/mainboard/google/rauru/boardid.c: https://review.coreboot.org/c/coreboot/+/85666/comment/d9ffef33_09764510?us… : PS7, Line 66: get_adc_index(SKU_ID_LOW_CHANNEL)) > I'd like to suggest the 0x7FFFXFFF and take "X" as storage type usage, […] Synced with @knoxchiou@google.com, ``` bit[7:0] reserved for panel type, bit[8] reserved for CPU type, bit[11:9] reserved for storage type. ``` @jarried.lin@mediatek.com Please add a `storage_id` function similar to `panel_id` in corsola/geralt and declare storage_id in `storage.h`. Combine storage_id with unprovisioned value. ``` cached_sku_code = CROS_SKU_UNPROVISIONED; cached_sku_code &= ~(7 << 8); cached_sku_code |= (storage_id() << 8); ``` File src/mainboard/google/rauru/boardid.c: https://review.coreboot.org/c/coreboot/+/85666/comment/d04a616d_67b66644?us… : PS8, Line 60: cached_sku_code == CROS_SKU_UNKNOWN) `|| cached_sku_code == CROS_SKU_UNPROVISIONED` -- To view, visit https://review.coreboot.org/c/coreboot/+/85666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece Gerrit-Change-Number: 85666 Gerrit-PatchSet: 8 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 10:07:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Knox Chiou <knoxchiou(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[L] Change in coreboot[main]: haswell NRI: Add write leveling
by Angel Pons (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Arthur Heymans, Nico Huber. Angel Pons has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/64197?usp=email ) Change subject: haswell NRI: Add write leveling ...................................................................... Patch Set 9: (2 comments) File src/northbridge/intel/haswell/native_raminit/train_jedec_write_leveling.c: https://review.coreboot.org/c/coreboot/+/64197/comment/6833ec07_5e74900d?us… : PS9, Line 191: pass This should be called `fail` - there's a few other things I would like to clean up but I'd rather take care of them in a follow-up since I would need to test them on hardware. https://review.coreboot.org/c/coreboot/+/64197/comment/b76bf0fe_4f79c4e2?us… : PS9, Line 193: if (skip_me & BIT(byte)) > `Too many leading tabs - consider code refactoring` Problem is that there's lots of nested loops. I thought about extracting the inner loop to a separate function, but then I'd have to pass about half a dozen parameters (`channel, byte, off, skip_me, byte_pass, byte_off, byte_sum`), and the function signature would be awful. -- To view, visit https://review.coreboot.org/c/coreboot/+/64197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I27678523fe22c38173a688e2a4751c259a20f009 Gerrit-Change-Number: 64197 Gerrit-PatchSet: 9 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 20 Dec 2024 10:03:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/google/rauru: Implement SKU ID
by Knox Chiou (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Jarried Lin, Yidi Lin. Knox Chiou has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email ) Change subject: mb/google/rauru: Implement SKU ID ...................................................................... Patch Set 8: (1 comment) File src/mainboard/google/rauru/boardid.c: https://review.coreboot.org/c/coreboot/+/85666/comment/f8ee5481_02ff6c7d?us… : PS7, Line 66: get_adc_index(SKU_ID_LOW_CHANNEL)) > @knoxchiou@google. […] I'd like to suggest the 0x7FFFXFFF and take "X" as storage type usage, so we could reserve other bits for another unprovisioned domain needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/85666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece Gerrit-Change-Number: 85666 Gerrit-PatchSet: 8 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 09:50:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[M] Change in coreboot[main]: soc/mediatek: Add support for MediaTek firmware support package
by Yu-Ping Wu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85665?usp=email ) Change subject: soc/mediatek: Add support for MediaTek firmware support package ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idef3518f9763fe5f74adb459c137db164563e483 Gerrit-Change-Number: 85665 Gerrit-PatchSet: 7 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 09:50:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024