coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[S] Change in coreboot[main]: mb/starlabs/starfighter: Enable TBT GPIOs
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84733?usp=email ) Change subject: mb/starlabs/starfighter: Enable TBT GPIOs ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84733?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id3f42b28258424d713325b19e317583494111577 Gerrit-Change-Number: 84733 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Dec 2024 14:15:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starfighter: Disable EC SCI and SMI GPIOs
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84732?usp=email ) Change subject: mb/starlabs/starfighter: Disable EC SCI and SMI GPIOs ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84732?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied0ffb2999ef0582570b94d756c2fcbd131b7ccf Gerrit-Change-Number: 84732 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Dec 2024 14:15:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/rauru: Implement SKU ID
by Yidi Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Knox Chiou, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email ) Change subject: mb/google/rauru: Implement SKU ID ...................................................................... Patch Set 9: Code-Review+1 (3 comments) File src/mainboard/google/rauru/boardid.c: https://review.coreboot.org/c/coreboot/+/85666/comment/3b10ed0f_898f7714?us… : PS7, Line 66: get_adc_index(SKU_ID_LOW_CHANNEL)) > Synced with @knoxchiou@google.com, […] Done File src/mainboard/google/rauru/boardid.c: https://review.coreboot.org/c/coreboot/+/85666/comment/b021c8f6_f1ba486f?us… : PS8, Line 60: cached_sku_code == CROS_SKU_UNKNOWN) > `|| cached_sku_code == CROS_SKU_UNPROVISIONED` Done File src/mainboard/google/rauru/boardid.c: https://review.coreboot.org/c/coreboot/+/85666/comment/ca8ec217_0e962808?us… : PS9, Line 65: ``` /* * Bit definition for unprovisioned SKU ID. * * bit[7:0] reserved for panel type, * bit[8] reserved for CPU type, * bit[11:9] reserved for storage type. */ ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/85666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece Gerrit-Change-Number: 85666 Gerrit-PatchSet: 9 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 14:06:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Knox Chiou <knoxchiou(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: commonlib: Refactor CSE sync eventLog
by Dinesh Gehlot (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Kapil Porwal, Karthik Ramasubramanian, Subrata Banik. Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/85622?usp=email ) Change subject: commonlib: Refactor CSE sync eventLog ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85622/comment/e502857e_ef7f818f?us… : PS2, Line 24: Post RAM CSE Sync > is this hand edited ? […] This is not a hand editing, but exact output with patch update#1". Will update the output with patch update#2 in description -- To view, visit https://review.coreboot.org/c/coreboot/+/85622?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5db3ffb43b2ceac821de72ef9e88ed62e617d41 Gerrit-Change-Number: 85622 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 14:03:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/rauru: Add support for getting storage id
by Yidi Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85717?usp=email ) Change subject: mb/google/rauru: Add support for getting storage id ...................................................................... Patch Set 1: (6 comments) File src/mainboard/google/rauru/boardid.c: https://review.coreboot.org/c/coreboot/+/85717/comment/aaa92057_9341ddd1?us… : PS1, Line 14: SKU IDs Storage ID https://review.coreboot.org/c/coreboot/+/85717/comment/a8f5bcd7_12c5d19f?us… : PS1, Line 61: printk(BIOS_DEBUG, "Storage ID: %#02x\n", cached_panel_id); insert the blank line on above https://review.coreboot.org/c/coreboot/+/85717/comment/8963a858_88e8ad81?us… : PS1, Line 62: remove this blank line File src/mainboard/google/rauru/mainboard.c: https://review.coreboot.org/c/coreboot/+/85717/comment/59599bd4_251d14ef?us… : PS1, Line 14: #include <soc/mt6363_sdmadc.h> remove ? https://review.coreboot.org/c/coreboot/+/85717/comment/37da7354_bb4a8726?us… : PS1, Line 63: mt6363_get_vtref18_voltage(); Remove `mt6363_get_vtref18_voltage`. It is not needed. https://review.coreboot.org/c/coreboot/+/85717/comment/c331e64d_01309fbb?us… : PS1, Line 60: mt6363_init_pmif_arb(); : mt6363_enable_vtref18(true); : mt6363_set_vtref18_voltage(1800000); : mt6363_get_vtref18_voltage(); Move to `romstage`. We will determine _PCIe initialization_ (for NVMe storage) by `storage_id` right after jumping into `ramstage` (in `enable_soc_dev()`). It will be too late to power on `vtref18`. -- To view, visit https://review.coreboot.org/c/coreboot/+/85717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I036df324cd6644ff69110c6247af29360b83225f Gerrit-Change-Number: 85717 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 14:01:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/google/rauru: Add support for getting storage id
by Jarried Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Yidi Lin. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85717?usp=email ) Change subject: mb/google/rauru: Add support for getting storage id ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/85717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I036df324cd6644ff69110c6247af29360b83225f Gerrit-Change-Number: 85717 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 13:23:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/rauru: Implement SKU ID
by Jarried Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email ) Change subject: mb/google/rauru: Implement SKU ID ...................................................................... Patch Set 9: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/85666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece Gerrit-Change-Number: 85666 Gerrit-PatchSet: 9 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 13:23:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/brya: Adjust EC memory map range to support indexed IO
by Jayvik Desai (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85547?usp=email ) Change subject: mb/google/brya: Adjust EC memory map range to support indexed IO ...................................................................... Patch Set 7: (2 comments) File src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85547/comment/072eda0c_c3ecbf9f?us… : PS3, Line 11: # EC memory map range is 0x900-0x9ff and indexed access is through 0x380 > Updated, Can you confirm based on the range is the programmed value correct ? Thanks! Acknowledged File src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85547/comment/a4da5599_64db77c6?us… : PS6, Line 15: (0x00010001 | CONFIG(EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO_PO > I guess this will cause issue, `EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO_PORT` is a hex value Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85547?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide5026b35da7c00deab4464eedfca9d52d294fd6 Gerrit-Change-Number: 85547 Gerrit-PatchSet: 7 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 20 Dec 2024 12:56:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jayvik Desai <jayvik(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add indexed IO support
by Jayvik Desai (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Kapil Porwal, Subrata Banik. Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85449?usp=email ) Change subject: ec/google/chromeec: Add indexed IO support ...................................................................... Patch Set 6: (3 comments) File src/ec/google/chromeec/ec_commands.h: https://review.coreboot.org/c/coreboot/+/85449/comment/341d30cd_387350b0?us… : PS4, Line 152: 0x380 > Added a Kconfig option Resolved File src/ec/google/chromeec/ec_lpc.c: https://review.coreboot.org/c/coreboot/+/85449/comment/acd4b00c_8d96ba4a?us… : PS5, Line 57: port > > `port` is always `EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO_PORT` […] Acknowledged https://review.coreboot.org/c/coreboot/+/85449/comment/f3e53f17_52b7d5fd?us… : PS5, Line 169: EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO_PORT > CONFIG_EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO_PORT Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85449?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c1aab3fc914eb5af2736a8ea3adf447040905e0 Gerrit-Change-Number: 85449 Gerrit-PatchSet: 6 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 12:56:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jayvik Desai <jayvik(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add indexed IO support
by Jayvik Desai (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Boris Mittelberg, Jayvik Desai, Kapil Porwal. Hello Boris Mittelberg, Caveh Jalali, Kapil Porwal, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85449?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: ec/google/chromeec: Add indexed IO support ...................................................................... ec/google/chromeec: Add indexed IO support Add support for indexed IO for ec communication, Indexed I/O allows memory access using a single I/O port base address usually called an index register and another port address called a data register. BUG=b:379224648 TEST= able to build nissa/trulo. Change-Id: I6c1aab3fc914eb5af2736a8ea3adf447040905e0 Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/ec/google/chromeec/Kconfig M src/ec/google/chromeec/ec_lpc.c 2 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/85449/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85449?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c1aab3fc914eb5af2736a8ea3adf447040905e0 Gerrit-Change-Number: 85449 Gerrit-PatchSet: 6 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024