coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: vboot: update submodule to upstream main
by Yu-Ping Wu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Carlos López, Julius Werner. Yu-Ping Wu has posted comments on this change by Carlos López. ( https://review.coreboot.org/c/coreboot/+/85676?usp=email ) Change subject: vboot: update submodule to upstream main ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85676/comment/a2b331e1_4fda6502?us… : PS1, Line 9: Updating from commit f1f70f46 to 3f94e2c7. This brings, among other Run `util/scripts/update_submodules -R ./3rdparty/vboot/ -c 1` to generate the changelog for you. -- To view, visit https://review.coreboot.org/c/coreboot/+/85676?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I48f960235088c17dc59235b07926acd52e03deb2 Gerrit-Change-Number: 85676 Gerrit-PatchSet: 1 Gerrit-Owner: Carlos López <carlos.lopezr4096(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Carlos López <carlos.lopezr4096(a)gmail.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 16:06:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Declare all DDI interfaces
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85693?usp=email ) Change subject: mb/starlabs/*: Declare all DDI interfaces ...................................................................... Patch Set 1: -Code-Review This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/85693?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f736761bcc177afebb98eb2f612b089bc6f13a4 Gerrit-Change-Number: 85693 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Dec 2024 15:57:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/rauru: Implement SKU ID
by Yu-Ping Wu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Knox Chiou. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email ) Change subject: mb/google/rauru: Implement SKU ID ...................................................................... Patch Set 9: (2 comments) File src/mainboard/google/rauru/boardid.c: https://review.coreboot.org/c/coreboot/+/85666/comment/e2916a5b_5cab2e9f?us… : PS9, Line 65: > ``` […] If the definition starts getting that complicated, I'd suggest using `DEFINE_BITFIELD` API: ``` DEFINE_BITFIELD(STORAGE_TYPE, 11, 9); DEFINE_BITFIELD(CPU_TYPE, 8, 8); DEFINE_BITFIELD(PANEL_TYPE, 7, 0); // sku_id() cached_sku_code = CROS_SKU_UNPROVISIONED; SET32_BITFIELDS(&cached_sku_code, STORAGE_TYPE, storage_id()); ``` The code is self-explanatory. It's a little bit weird to use MMIO functions, but I guess the extra `dmb` calls don't hurt. https://review.coreboot.org/c/coreboot/+/85666/comment/a9243fe6_c3a6ed4a?us… : PS9, Line 77: 8 Shouldn't this be 9 if bit[11:9] is for storage id? -- To view, visit https://review.coreboot.org/c/coreboot/+/85666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece Gerrit-Change-Number: 85666 Gerrit-PatchSet: 9 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 15:45:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/rauru: Add support for getting storage id
by Yu-Ping Wu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85717?usp=email ) Change subject: mb/google/rauru: Add support for getting storage id ...................................................................... Patch Set 1: (3 comments) File src/mainboard/google/rauru/boardid.c: https://review.coreboot.org/c/coreboot/+/85717/comment/a7801f49_fbb8be88?us… : PS1, Line 16: STORAGE_ID_HIGH_CHANNEL Do we need this if not used? https://review.coreboot.org/c/coreboot/+/85717/comment/ee2eb5b8_d89f0505?us… : PS1, Line 57: panel storage File src/mainboard/google/rauru/storage.h: https://review.coreboot.org/c/coreboot/+/85717/comment/8fea3406_75d39c83?us… : PS1, Line 5: > ``` […] Can we add another function `storage_type()` to return that enum? I think the UFS driver in mtk-fsp will need it, so that the mtk-fsp repo will have the same enum definition. `storage_id()` can still return the ADC index. -- To view, visit https://review.coreboot.org/c/coreboot/+/85717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I036df324cd6644ff69110c6247af29360b83225f Gerrit-Change-Number: 85717 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 15:45:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
by Alicja Michalska (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Balaji Manigandan, Jakub Czapiga, Jędrzej Ciupis, Matt DeVillier, Pratikkumar V Prajapati, Sowmya Aralguppe, Subrata Banik. Alicja Michalska has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email ) Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: IMO it's a good workaround until crashlog gets fixed. -- To view, visit https://review.coreboot.org/c/coreboot/+/84359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b Gerrit-Change-Number: 84359 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Balaji Manigandan <balaji.bmg(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jędrzej Ciupis <jciupis(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Jędrzej Ciupis <jciupis(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Balaji Manigandan <balaji.bmg(a)gmail.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 15:37:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87 Extreme4 (Haswell)
by Jan Philipp Groß (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Angel Pons, Nicholas Chin. Jan Philipp Groß has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/84672?usp=email ) Change subject: mb/asrock: Add Z87 Extreme4 (Haswell) ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84672/comment/0b01d33b_0fe61982?us… : PS1, Line 50: resulting in the wrong : fan being controlled. > For the HWM, you may need to set `irq 0x30 = 0xe1`. […] Isn't that set in the devicetree.cb already? File src/mainboard/asrock/z87_extreme4/Kconfig: https://review.coreboot.org/c/coreboot/+/84672/comment/16ca5a41_ae05a0be?us… : PS1, Line 28: config USBDEBUG_HCD_INDEX # FIXME: check this : int : default 2 > Yes. […] I got no match in any of the tested USB ports. I've tried with a USB mouse and a USB-2.0-Stick. Maybe one of the three USB-2.0-Headers would give off a signal, but I have no way of testing them. 😞 -- To view, visit https://review.coreboot.org/c/coreboot/+/84672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I78791aa9877a3ad79bf8b896c583fedf37e96d9a Gerrit-Change-Number: 84672 Gerrit-PatchSet: 2 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 15:14:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jan Philipp Groß <jeangrande(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XL] Change in coreboot[main]: util/intelp2m: Rework platforms and fields packages
by Maxim (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: David Hendricks. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71167?usp=email to look at the new patch set (#15). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/intelp2m: Rework platforms and fields packages ...................................................................... util/intelp2m: Rework platforms and fields packages - Add the base platform interface to be able to reuse its methods. - The macro structure is excluded from the platform structure. - Instead of a global macro instance, create a new local structure for each generated macro. TEST: 1) 'make test' = PASS 2) './intelp2m -p cnl -iiii -file inteltool.log' = gpio.h before and after the commit is the same. Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/intelp2m/fields/cb/cb.go M util/intelp2m/fields/cb/cb_test.go M util/intelp2m/fields/fields.go M util/intelp2m/fields/fsp/fsp.go M util/intelp2m/fields/fsp/fsp_test.go M util/intelp2m/fields/raw/raw.go M util/intelp2m/fields/raw/raw_test.go M util/intelp2m/fields/test/suite.go M util/intelp2m/parser/parser.go M util/intelp2m/platforms/adl/adl_test.go M util/intelp2m/platforms/adl/macro.go M util/intelp2m/platforms/adl/template.go M util/intelp2m/platforms/apl/apl_test.go M util/intelp2m/platforms/apl/macro.go M util/intelp2m/platforms/apl/template.go M util/intelp2m/platforms/cnl/cnl_test.go M util/intelp2m/platforms/cnl/macro.go M util/intelp2m/platforms/cnl/template.go A util/intelp2m/platforms/common/common.go D util/intelp2m/platforms/common/macro.go A util/intelp2m/platforms/common/macros/macros.go A util/intelp2m/platforms/common/register/helper.go M util/intelp2m/platforms/ebg/ebg_test.go M util/intelp2m/platforms/ebg/macro.go M util/intelp2m/platforms/ebg/template.go D util/intelp2m/platforms/interfaces.go M util/intelp2m/platforms/jsl/jsl_test.go M util/intelp2m/platforms/jsl/macro.go M util/intelp2m/platforms/jsl/template.go M util/intelp2m/platforms/lbg/lbg_test.go M util/intelp2m/platforms/lbg/macro.go M util/intelp2m/platforms/lbg/template.go M util/intelp2m/platforms/mtl/macro.go M util/intelp2m/platforms/mtl/mtl_test.go M util/intelp2m/platforms/mtl/template.go A util/intelp2m/platforms/platforms.go M util/intelp2m/platforms/snr/macro.go M util/intelp2m/platforms/snr/snr_test.go M util/intelp2m/platforms/snr/template.go M util/intelp2m/platforms/test/suite.go M util/intelp2m/platforms/tgl/macro.go M util/intelp2m/platforms/tgl/template.go M util/intelp2m/platforms/tgl/tgl_test.go 43 files changed, 1,373 insertions(+), 1,695 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/71167/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/71167?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9 Gerrit-Change-Number: 71167 Gerrit-PatchSet: 15 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>

1 0

[M] Change in coreboot[main]: mb/google/rauru: Add support for getting storage id
by Yidi Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85717?usp=email ) Change subject: mb/google/rauru: Add support for getting storage id ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/rauru/mainboard.c: https://review.coreboot.org/c/coreboot/+/85717/comment/1b447840_ca291771?us… : PS1, Line 60: mt6363_init_pmif_arb(); : mt6363_enable_vtref18(true); : mt6363_set_vtref18_voltage(1800000); : mt6363_get_vtref18_voltage(); > Move to `romstage`. […] An alternative is powering on `vtref18` in `storage_id` (since this power rail is board-specific design). But it may take times to ramp up. File src/mainboard/google/rauru/storage.h: https://review.coreboot.org/c/coreboot/+/85717/comment/8c7f992d_6e76373e?us… : PS1, Line 5: ``` enum storage_type { .... }; ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/85717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I036df324cd6644ff69110c6247af29360b83225f Gerrit-Change-Number: 85717 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 14:45:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has uploaded a new patch set (#4). ( https://review.coreboot.org/c/coreboot/+/84734?usp=email ) Change subject: ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory ...................................................................... ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory Ensure any reads or writes to the EC memory, are performed with ECRD (Read) and ECWR (Write) as these methods use a mutex. Also, use local variables to cache reads of the same variable. This solves: Initialized Arguments for Method [ECRD]: (1 arguments defined for method invocation) Arg0: 00000000967261a4 [RefOf] <Node> Name ECPS RegionField 000000007d4b8073 ACPI Error: Aborting method \_SB.PCI0.LPCB.EC.ECRD due to previous error (AE_BAD_PARAMETER) (20230628/psparse-529) ACPI Error: Aborting method \_SB.PCI0.LPCB.EC.ADP1._PSR due to previous error (AE_BAD_PARAMETER) (20230628/psparse-529) Change-Id: I0bbb538017cc004bff1989a8017ccfcd1ba9ab5c Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/ec/starlabs/merlin/acpi/battery.asl M src/ec/starlabs/merlin/acpi/ec.asl M src/ec/starlabs/merlin/acpi/suspend.asl M src/ec/starlabs/merlin/variants/apl/events.asl M src/ec/starlabs/merlin/variants/cezanne/events.asl M src/ec/starlabs/merlin/variants/glk/events.asl M src/ec/starlabs/merlin/variants/glkr/events.asl M src/ec/starlabs/merlin/variants/kbl/events.asl M src/ec/starlabs/merlin/variants/merlin/events.asl 9 files changed, 46 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/84734/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/84734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0bbb538017cc004bff1989a8017ccfcd1ba9ab5c Gerrit-Change-Number: 84734 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/84734?usp=email ) Change subject: ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory ...................................................................... ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory Ensure any reads or writes to the EC memory, are performed with ECRD (Read) and ECWR (Write) as these methods use a mutex. Also, use local variables to cache reads of the same variable. This solves: Initialized Arguments for Method [ECRD]: (1 arguments defined for method invocation) Arg0: 00000000967261a4 [RefOf] <Node> Name ECPS RegionField 000000007d4b8073 ACPI Error: Aborting method \_SB.PCI0.LPCB.EC.ECRD due to previous error (AE_BAD_PARAMETER) (20230628/psparse-529) ACPI Error: Aborting method \_SB.PCI0.LPCB.EC.ADP1._PSR due to previous error (AE_BAD_PARAMETER) (20230628/psparse-529) Change-Id: I0bbb538017cc004bff1989a8017ccfcd1ba9ab5c Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/ec/starlabs/merlin/acpi/battery.asl M src/ec/starlabs/merlin/acpi/ec.asl M src/ec/starlabs/merlin/acpi/suspend.asl M src/ec/starlabs/merlin/variants/apl/events.asl M src/ec/starlabs/merlin/variants/cezanne/events.asl M src/ec/starlabs/merlin/variants/glk/events.asl M src/ec/starlabs/merlin/variants/glkr/events.asl M src/ec/starlabs/merlin/variants/kbl/events.asl M src/ec/starlabs/merlin/variants/merlin/events.asl 9 files changed, 50 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/84734/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0bbb538017cc004bff1989a8017ccfcd1ba9ab5c Gerrit-Change-Number: 84734 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024