coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[S] Change in coreboot[main]: ec/google/chromeec: Add indexed IO support
by Jayvik Desai (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Boris Mittelberg, Jayvik Desai, Kapil Porwal. Hello Boris Mittelberg, Caveh Jalali, Kapil Porwal, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85449?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: ec/google/chromeec: Add indexed IO support ...................................................................... ec/google/chromeec: Add indexed IO support Add support for indexed IO for ec communication, Indexed I/O allows memory access using a single I/O port base address usually called an index register and another port address called a data register. BUG=b:379224648 TEST= able to build nissa/trulo. Change-Id: I6c1aab3fc914eb5af2736a8ea3adf447040905e0 Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/ec/google/chromeec/Kconfig M src/ec/google/chromeec/ec_lpc.c 2 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/85449/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85449?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c1aab3fc914eb5af2736a8ea3adf447040905e0 Gerrit-Change-Number: 85449 Gerrit-PatchSet: 6 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Add ACPI name for GSPI2
by Subrata Banik (Code Review) 20 Dec '24

20 Dec '24

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85712?usp=email ) Change subject: soc/intel/pantherlake: Add ACPI name for GSPI2 ...................................................................... soc/intel/pantherlake: Add ACPI name for GSPI2 This change adds the ACPI name "SPI2" for the GSPI2 device in the Panther Lake SOC. Replace space with tab for PCI_DEVFN_GSPI2 macro. w/o this patch: [ERROR] Missing ACPI Name for PCI: 00:12.6 [ERROR] Missing ACPI Name for PCI: 00:12.6 w/ this patch: No error Change-Id: I404ddb893b82836e06d0f52a6d6f2aff2273d8c6 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/pantherlake/chip.c M src/soc/intel/pantherlake/include/soc/pci_devs.h 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/85712/1 diff --git a/src/soc/intel/pantherlake/chip.c b/src/soc/intel/pantherlake/chip.c index 2c79fe7..5fe2a37 100644 --- a/src/soc/intel/pantherlake/chip.c +++ b/src/soc/intel/pantherlake/chip.c @@ -86,6 +86,7 @@ case PCI_DEVFN_NPU: return "NPU"; case PCI_DEVFN_IPU: return "IPU0"; case PCI_DEVFN_ISH: return "ISHB"; + case PCI_DEVFN_GSPI2: return "SPI2"; case PCI_DEVFN_XHCI: return "XHCI"; case PCI_DEVFN_SRAM: return "SRAM"; case PCI_DEVFN_I2C0: return "I2C0"; diff --git a/src/soc/intel/pantherlake/include/soc/pci_devs.h b/src/soc/intel/pantherlake/include/soc/pci_devs.h index bff5bd3..5c74b6d 100644 --- a/src/soc/intel/pantherlake/include/soc/pci_devs.h +++ b/src/soc/intel/pantherlake/include/soc/pci_devs.h @@ -95,7 +95,7 @@ #define PCI_DEVFN_ISH _PCI_DEVFN(ISH, 0) #define PCI_DEVFN_P2SB2 _PCI_DEVFN(ISH, 1) #define PCI_DEVFN_IEH_1 _PCI_DEVFN(ISH, 3) -#define PCI_DEVFN_GSPI2 _PCI_DEVFN(ISH, 6) +#define PCI_DEVFN_GSPI2 _PCI_DEVFN(ISH, 6) #define PCI_DEV_ISH _PCI_DEV(ISH, 0) #define PCI_DEV_P2SB2 _PCI_DEV(ISH, 1) #define PCI_DEV_IEH_1 _PCI_DEV(ISH, 3) -- To view, visit https://review.coreboot.org/c/coreboot/+/85712?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I404ddb893b82836e06d0f52a6d6f2aff2273d8c6 Gerrit-Change-Number: 85712 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starfighter: Correct USB port index
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85705?usp=email ) Change subject: mb/starlabs/starfighter: Correct USB port index ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85705?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib59ce76523aad40790dac00f31e4388497294d37 Gerrit-Change-Number: 85705 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 20 Dec 2024 11:33:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[NoOp] Change in coreboot[main]: mb/starlabs/byte: Update the VBT to 251
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Sean Rhodes. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85706?usp=email ) Change subject: mb/starlabs/byte: Update the VBT to 251 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85706?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3bef919d1c6fcb9abff4fc49300321c9d471cb82 Gerrit-Change-Number: 85706 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 20 Dec 2024 11:33:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/intel/mtl: Enable all bits for IO decode register
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85707?usp=email ) Change subject: soc/intel/mtl: Enable all bits for IO decode register ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85707?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ace878faa09b959384338efcdbdfce390145002 Gerrit-Change-Number: 85707 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 20 Dec 2024 11:32:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: AB recovery: AB recovery is exclusive with VBOOT and ChromeOS
by Paul Menzel (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Marshall Dawson, Matt DeVillier, Zheng Bao. Paul Menzel has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/85664?usp=email ) Change subject: AB recovery: AB recovery is exclusive with VBOOT and ChromeOS ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85664/comment/1ce9cedb_1cc678fb?us… : PS2, Line 8: Could you please describe, why they are exclusive. -- To view, visit https://review.coreboot.org/c/coreboot/+/85664?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b89e7be11c198ab1819a3506dc55127345e5279 Gerrit-Change-Number: 85664 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 11:03:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: AB recovery: AB recovery is exclusive with VBOOT and ChromeOS
by Paul Menzel (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Marshall Dawson, Matt DeVillier, Zheng Bao. Paul Menzel has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/85664?usp=email ) Change subject: AB recovery: AB recovery is exclusive with VBOOT and ChromeOS ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85664/comment/49261075_bda9695b?us… : PS2, Line 7: AB recovery is exclusive with VBOOT and ChromeOS Please make the statement about the action, and not a problem/issue description. https://review.coreboot.org/c/coreboot/+/85664/comment/2f56c591_15f0b96b?us… : PS2, Line 7: AB recovery soc/amd/cezanne File src/soc/amd/cezanne/Kconfig: https://review.coreboot.org/c/coreboot/+/85664/comment/fbac3856_e4e346a5?us… : PS2, Line 414: select CBFS_VERIFICATION Why do you select this? -- To view, visit https://review.coreboot.org/c/coreboot/+/85664?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b89e7be11c198ab1819a3506dc55127345e5279 Gerrit-Change-Number: 85664 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 11:02:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/starlabs/starlite: Add smart battery variant
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85701?usp=email ) Change subject: mb/starlabs/starlite: Add smart battery variant ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85701?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e04ea26ef597ce542a7348982d056fb55de0d22 Gerrit-Change-Number: 85701 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 20 Dec 2024 10:56:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: ec/starlabs/merlin: Add the option to reduce the LED brightness
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85702?usp=email ) Change subject: ec/starlabs/merlin: Add the option to reduce the LED brightness ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85702?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39507d4f2e572ca31ad982ce0d730a0d00f6ca32 Gerrit-Change-Number: 85702 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 20 Dec 2024 10:56:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Add a CMOS option to disable the GNA
by Sean Rhodes (Code Review) 20 Dec '24

20 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85703?usp=email ) Change subject: mb/starlabs/*: Add a CMOS option to disable the GNA ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85703?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I99f015cf1b5e21e8b524c4aa9bd3e94f86908ca1 Gerrit-Change-Number: 85703 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 20 Dec 2024 10:56:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024