Attention is currently required from: Felix Singer, Martin L Roth.
Nicholas Chin has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/85726?usp=email )
Change subject: util/docker/doc.coreboot.org: Use Alpine minor instead of point releases
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85726?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic947f99ae7231918ec2e6105f8f3050a17fd1176
Gerrit-Change-Number: 85726
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sun, 22 Dec 2024 21:53:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: David Hendricks.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/71167?usp=email
to look at the new patch set (#20).
Change subject: util/intelp2m: Rework platforms and fields packages
......................................................................
util/intelp2m: Rework platforms and fields packages
- embedding the structure of the base platform;
- separate the macro structures from the platform;
- move more functions to common;
- undo use of a single global instance of the microstructure.
TEST:
1) 'make test' = PASS
2) './intelp2m -p cnl -iiii -file inteltool.log' = gpio.h before and
after the commit is the same.
Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/fields/cb/cb.go
M util/intelp2m/fields/cb/cb_test.go
M util/intelp2m/fields/fields.go
M util/intelp2m/fields/fsp/fsp.go
M util/intelp2m/fields/fsp/fsp_test.go
M util/intelp2m/fields/raw/raw.go
M util/intelp2m/fields/raw/raw_test.go
M util/intelp2m/fields/test/suite.go
M util/intelp2m/parser/parser.go
M util/intelp2m/platforms/adl/adl_test.go
M util/intelp2m/platforms/adl/macro.go
M util/intelp2m/platforms/adl/template.go
M util/intelp2m/platforms/apl/apl_test.go
M util/intelp2m/platforms/apl/macro.go
M util/intelp2m/platforms/apl/template.go
M util/intelp2m/platforms/cnl/cnl_test.go
M util/intelp2m/platforms/cnl/macro.go
M util/intelp2m/platforms/cnl/template.go
A util/intelp2m/platforms/common/common.go
M util/intelp2m/platforms/common/macro.go
A util/intelp2m/platforms/common/register/helper.go
M util/intelp2m/platforms/ebg/ebg_test.go
M util/intelp2m/platforms/ebg/macro.go
M util/intelp2m/platforms/ebg/template.go
D util/intelp2m/platforms/interfaces.go
M util/intelp2m/platforms/jsl/jsl_test.go
M util/intelp2m/platforms/jsl/macro.go
M util/intelp2m/platforms/jsl/template.go
M util/intelp2m/platforms/lbg/lbg_test.go
M util/intelp2m/platforms/lbg/macro.go
M util/intelp2m/platforms/lbg/template.go
M util/intelp2m/platforms/mtl/macro.go
M util/intelp2m/platforms/mtl/mtl_test.go
M util/intelp2m/platforms/mtl/template.go
A util/intelp2m/platforms/platforms.go
M util/intelp2m/platforms/snr/macro.go
M util/intelp2m/platforms/snr/snr_test.go
M util/intelp2m/platforms/snr/template.go
M util/intelp2m/platforms/test/suite.go
M util/intelp2m/platforms/tgl/macro.go
M util/intelp2m/platforms/tgl/template.go
M util/intelp2m/platforms/tgl/tgl_test.go
42 files changed, 1,178 insertions(+), 1,503 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/71167/20
--
To view, visit https://review.coreboot.org/c/coreboot/+/71167?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9
Gerrit-Change-Number: 71167
Gerrit-PatchSet: 20
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85731?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/intelp2m: Move remapping reset source to common
......................................................................
util/intelp2m: Move remapping reset source to common
TEST: 'make test' = PASS
Change-Id: I315541b12f5f1fdf7c97c2ff8ddd305e30a447cc
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/platforms/adl/macro.go
M util/intelp2m/platforms/apl/macro.go
M util/intelp2m/platforms/cnl/macro.go
M util/intelp2m/platforms/common/common.go
M util/intelp2m/platforms/common/macro.go
M util/intelp2m/platforms/ebg/macro.go
M util/intelp2m/platforms/jsl/macro.go
M util/intelp2m/platforms/lbg/macro.go
M util/intelp2m/platforms/mtl/macro.go
M util/intelp2m/platforms/snr/macro.go
M util/intelp2m/platforms/tgl/macro.go
11 files changed, 91 insertions(+), 155 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/85731/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85731?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I315541b12f5f1fdf7c97c2ff8ddd305e30a447cc
Gerrit-Change-Number: 85731
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Angel Pons, Nicholas Chin.
Jan Philipp Groß has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/84672?usp=email )
Change subject: mb/asrock: Add Z87 Extreme4 (Haswell)
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/asrock/z87_extreme4/bootblock.c:
https://review.coreboot.org/c/coreboot/+/84672/comment/df05c8d6_9c79f0f3?us… :
PS1, Line 5: /* FIXME: remove this if not needed */
: void mainboard_config_superio(void)
: {
: }
> Program the Super I/O as per superiotool output (global registers, i.e. […]
Done
File src/mainboard/asrock/z87_extreme4/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/84672/comment/a6afdce2_8bad6d28?us… :
PS1, Line 20: LVDS,
: eDP);
> Fix didn't get applied, it seems
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84672?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I78791aa9877a3ad79bf8b896c583fedf37e96d9a
Gerrit-Change-Number: 84672
Gerrit-PatchSet: 4
Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sun, 22 Dec 2024 13:43:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jan Philipp Groß <jeangrande(a)mailbox.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Angel Pons, Jan Philipp Groß, Nicholas Chin.
Hello Angel Pons, Nicholas Chin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84672?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons, Verified+1 by build bot (Jenkins)
Change subject: mb/asrock: Add Z87 Extreme4 (Haswell)
......................................................................
mb/asrock: Add Z87 Extreme4 (Haswell)
This port was done via autoport and subsequent manual tweaking.
The board features two socketed DIP-8 SPI flash chips, as well as a
BIOS selection via jumper and onboard Power and Reset switches.
Working:
- Haswell MRC.bin
- All four DDR3/DDR3L DIMM slots
- HDMI-Out Port
- DVI-D Port
- RJ-45 Gigabit LAN Port
- Both USB 2.0 Ports
- All four USB 3.1 Gen1 Ports
- Both USB 3.1 Gen1 headers
- Vertical Type A USB 3.1 Gen1 (located next to RAM slots and PCH)
- All six SATA3 6.0 Gb/s connectors by Intel
- All three PCI Express 3.0 x16 slots (tested with NV 1080 Ti dGPU)
- Both PCI Express 2.0 x1 slots (tested with TL-WDN4800 WiFi adapter)
- HD Audio Jack (Audio output tested only)
- Front Audio Jack (Audio output tested only)
Working (board-specific)
- Power Switch with LED (functional, yet no LED)
- Reset Switch with LED (functional, yet no LED)
- BIOS Selection via jumper
not working:
- both SATA3 6.0 Gb/s connectors by ASMedia ASM1061
not (yet) tested:
- IR header
- COM Port header
- DisplayPort
- eSATA connector
- USB 2.0 headers
- PS/2 Mouse/Keyboard Port
- HDMI-In Port
- PCI slots
not (yet) working:
- Software fan control: While the Nuvoton chip is correctly discovered,
the numbering of the fan connectors is faulty, resulting in the wrong
fan being controlled.
- Dr. Debug: on vendor firmware, the LEDs turn off after successful
boot. On coreboot, the LED shows two bright zeros after boot.
Change-Id: I78791aa9877a3ad79bf8b896c583fedf37e96d9a
Signed-off-by: Jan Philipp Groß <jeangrande(a)mailbox.org>
---
A src/mainboard/asrock/z87_extreme4/Kconfig
A src/mainboard/asrock/z87_extreme4/Kconfig.name
A src/mainboard/asrock/z87_extreme4/Makefile.mk
A src/mainboard/asrock/z87_extreme4/acpi/ec.asl
A src/mainboard/asrock/z87_extreme4/acpi/platform.asl
A src/mainboard/asrock/z87_extreme4/acpi/superio.asl
A src/mainboard/asrock/z87_extreme4/board_info.txt
A src/mainboard/asrock/z87_extreme4/bootblock.c
A src/mainboard/asrock/z87_extreme4/data.vbt
A src/mainboard/asrock/z87_extreme4/devicetree.cb
A src/mainboard/asrock/z87_extreme4/dsdt.asl
A src/mainboard/asrock/z87_extreme4/gma-mainboard.ads
A src/mainboard/asrock/z87_extreme4/gpio.c
A src/mainboard/asrock/z87_extreme4/hda_verb.c
A src/mainboard/asrock/z87_extreme4/romstage.c
15 files changed, 531 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/84672/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/84672?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I78791aa9877a3ad79bf8b896c583fedf37e96d9a
Gerrit-Change-Number: 84672
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin.
Hello Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85630?usp=email
to look at the new patch set (#5).
Change subject: soc/mediatek/mt8196: Add PMIC MT6316 driver
......................................................................
soc/mediatek/mt8196: Add PMIC MT6316 driver
Add MT6316 driver in SoC folder
TEST=Build pass
BUG=b:317009620
Change-Id: I39e91d64e77cff03281845dfbea565e6ddf748f6
Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
---
A src/soc/mediatek/common/include/soc/mt6316.h
A src/soc/mediatek/common/mt6316.c
M src/soc/mediatek/mt8196/Makefile.mk
A src/soc/mediatek/mt8196/mt6316.c
4 files changed, 1,162 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/85630/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/85630?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I39e91d64e77cff03281845dfbea565e6ddf748f6
Gerrit-Change-Number: 85630
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Attention is currently required from: Hung-Te Lin, Jarried Lin.
Hello Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85630?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/mediatek/mt8196: Add PMIC MT6316 driver
......................................................................
soc/mediatek/mt8196: Add PMIC MT6316 driver
Add MT6316 driver in SoC folder
TEST=Build pass
BUG=b:317009620
Change-Id: I39e91d64e77cff03281845dfbea565e6ddf748f6
Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
---
A src/soc/mediatek/common/include/soc/mt6316.h
A src/soc/mediatek/common/mt6316.c
M src/soc/mediatek/mt8196/Makefile.mk
A src/soc/mediatek/mt8196/mt6316.c
4 files changed, 1,162 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/85630/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/85630?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I39e91d64e77cff03281845dfbea565e6ddf748f6
Gerrit-Change-Number: 85630
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Attention is currently required from: David Hendricks.
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/71167?usp=email )
Change subject: util/intelp2m: Rework platforms and fields packages
......................................................................
Patch Set 19:
(1 comment)
Patchset:
PS12:
> Hi David, […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/71167?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9
Gerrit-Change-Number: 71167
Gerrit-PatchSet: 19
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Comment-Date: Sun, 22 Dec 2024 12:14:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim <max.senia.poliak(a)gmail.com>
Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/71167?usp=email )
Change subject: util/intelp2m: Rework platforms and fields packages
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/71167?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e0aa56efa2430ac6524c6977f8b6fd13113edf9
Gerrit-Change-Number: 71167
Gerrit-PatchSet: 19
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Comment-Date: Sun, 22 Dec 2024 12:13:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No