coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: soc/mediatek/mt8189: Replace SPDX identifiers to GPL-2.0-only OR MIT
by Felix Singer (Code Review) 22 Dec '24

22 Dec '24

Attention is currently required from: Hung-Te Lin, Vince Liu, Yidi Lin, Yu-Ping Wu. Felix Singer has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85723?usp=email ) Change subject: soc/mediatek/mt8189: Replace SPDX identifiers to GPL-2.0-only OR MIT ...................................................................... Patch Set 1: (1 comment) File src/soc/mediatek/mt8189/timer.c: https://review.coreboot.org/c/coreboot/+/85723/comment/3de7ddb9_13fe8c3a?us… : PS1, Line 1: OR MIT I know GPLv2 is compatible to MIT, but I don't know if MIT can just be added like that afterwards. Is it actually needed? -- To view, visit https://review.coreboot.org/c/coreboot/+/85723?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2821a8c097b8d22e1aa91b316ae0fdce80f342de Gerrit-Change-Number: 85723 Gerrit-PatchSet: 1 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Sun, 22 Dec 2024 07:22:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: util/docker/doc.coreboot.org: Get rid of bash workarounds
by Nicholas Chin (Code Review) 22 Dec '24

22 Dec '24

Attention is currently required from: Felix Singer, Martin L Roth. Nicholas Chin has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/85725?usp=email ) Change subject: util/docker/doc.coreboot.org: Get rid of bash workarounds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85725?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I544a15c86c212e91ece59b583fb61dad37fca337 Gerrit-Change-Number: 85725 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 22 Dec 2024 00:29:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: util/docker/doc.coreboot.org: Don't create volumes
by Nicholas Chin (Code Review) 22 Dec '24

22 Dec '24

Attention is currently required from: Felix Singer, Martin L Roth. Nicholas Chin has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/85724?usp=email ) Change subject: util/docker/doc.coreboot.org: Don't create volumes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9b3551cca34d846aba5ca5c89162f82baa6de768 Gerrit-Change-Number: 85724 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 22 Dec 2024 00:25:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: util/docker/doc.coreboot.org: Allow git to work in envs owned by root
by Felix Singer (Code Review) 22 Dec '24

22 Dec '24

Attention is currently required from: Martin L Roth, Nicholas Chin. Hello Martin L Roth, Nicholas Chin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85727?usp=email to look at the new patch set (#2). Change subject: util/docker/doc.coreboot.org: Allow git to work in envs owned by root ...................................................................... util/docker/doc.coreboot.org: Allow git to work in envs owned by root Depending on the environment, the /data-in directory might be owned by root and recent git versions refuse to work in these. So explicitly mark /data-in as a safe environment. Change-Id: Ia534928f759e50c2dfb1df8af653dee74c734603 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/docker/doc.coreboot.org/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/85727/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85727?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia534928f759e50c2dfb1df8af653dee74c734603 Gerrit-Change-Number: 85727 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[XS] Change in coreboot[main]: util/docker/doc.coreboot.org: Allow git to work in envs owner by root
by Felix Singer (Code Review) 22 Dec '24

22 Dec '24

Attention is currently required from: Martin L Roth. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85727?usp=email ) Change subject: util/docker/doc.coreboot.org: Allow git to work in envs owner by root ...................................................................... util/docker/doc.coreboot.org: Allow git to work in envs owner by root Depending on the environment, the /data-in directory might be owned by root and recent git versions refuse to work in these. So explicitly mark /data-in as a safe environment. Change-Id: Ia534928f759e50c2dfb1df8af653dee74c734603 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/docker/doc.coreboot.org/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/85727/1 diff --git a/util/docker/doc.coreboot.org/Dockerfile b/util/docker/doc.coreboot.org/Dockerfile index 9e3da11..8ab1a49 100644 --- a/util/docker/doc.coreboot.org/Dockerfile +++ b/util/docker/doc.coreboot.org/Dockerfile @@ -34,6 +34,8 @@ sphinx_autobuild===2024.2.4 \ sphinx_rtd_theme===2.0.0 +RUN git config --global --add safe.directory /data-in + # For Sphinx-autobuild # Port 8000 - HTTP server # Port 35729 - websockets connection to allow automatic browser reloads after each build -- To view, visit https://review.coreboot.org/c/coreboot/+/85727?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia534928f759e50c2dfb1df8af653dee74c734603 Gerrit-Change-Number: 85727 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[XS] Change in coreboot[main]: util/docker/doc.coreboot.org: Use Alpine minor instead of point releases
by Felix Singer (Code Review) 22 Dec '24

22 Dec '24

Attention is currently required from: Martin L Roth. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85726?usp=email ) Change subject: util/docker/doc.coreboot.org: Use Alpine minor instead of point releases ...................................................................... util/docker/doc.coreboot.org: Use Alpine minor instead of point releases There is no reason to stick to the point releases. So use the 3.19 base image referring to the latest minor release instead. Also, update installed packages to latest versions from that release. Change-Id: Ic947f99ae7231918ec2e6105f8f3050a17fd1176 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/docker/doc.coreboot.org/Dockerfile 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/85726/1 diff --git a/util/docker/doc.coreboot.org/Dockerfile b/util/docker/doc.coreboot.org/Dockerfile index 1864063..9e3da11 100644 --- a/util/docker/doc.coreboot.org/Dockerfile +++ b/util/docker/doc.coreboot.org/Dockerfile @@ -1,8 +1,10 @@ -FROM alpine:3.19.1 +FROM alpine:3.19 COPY makeSphinx.sh /makeSphinx.sh RUN \ + apk update && \ + apk upgrade --no-cache && \ apk add --no-cache \ python3 \ py3-pip \ -- To view, visit https://review.coreboot.org/c/coreboot/+/85726?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic947f99ae7231918ec2e6105f8f3050a17fd1176 Gerrit-Change-Number: 85726 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[S] Change in coreboot[main]: util/docker/doc.coreboot.org: Get rid of bash workarounds
by Felix Singer (Code Review) 22 Dec '24

22 Dec '24

Attention is currently required from: Martin L Roth. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85725?usp=email ) Change subject: util/docker/doc.coreboot.org: Get rid of bash workarounds ...................................................................... util/docker/doc.coreboot.org: Get rid of bash workarounds It seems the .bashrc is not loaded as intended and thus the bash mechanisms never worked. So drop the bash invocations and replace them with the ash shell. Also, don't modify the PATH variable since this is done by the activation script. Change-Id: I544a15c86c212e91ece59b583fb61dad37fca337 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/docker/doc.coreboot.org/Dockerfile M util/docker/doc.coreboot.org/makeSphinx.sh 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/85725/1 diff --git a/util/docker/doc.coreboot.org/Dockerfile b/util/docker/doc.coreboot.org/Dockerfile index 0979daf..1864063 100644 --- a/util/docker/doc.coreboot.org/Dockerfile +++ b/util/docker/doc.coreboot.org/Dockerfile @@ -7,7 +7,6 @@ python3 \ py3-pip \ make \ - bash \ git \ ttf-dejavu \ fontconfig \ @@ -21,11 +20,10 @@ USER coreboot ENV VIRTUAL_ENV="/home/coreboot/python3" -ENV PATH=$VIRTUAL_ENV/bin:$PATH:/home/coreboot/.local/bin RUN \ python3 -m venv $VIRTUAL_ENV && \ - echo "source ${VIRTUAL_ENV}/bin/activate" >> /home/coreboot/.bashrc && \ + source ${VIRTUAL_ENV}/bin/activate && \ pip3 install --upgrade --no-cache-dir pip && \ pip3 install --no-cache-dir \ jinja2==3.1.3 \ @@ -39,5 +37,5 @@ # Port 35729 - websockets connection to allow automatic browser reloads after each build EXPOSE 8000 35729 -ENTRYPOINT ["/bin/bash", "/makeSphinx.sh"] +ENTRYPOINT [ "/makeSphinx.sh" ] CMD [] diff --git a/util/docker/doc.coreboot.org/makeSphinx.sh b/util/docker/doc.coreboot.org/makeSphinx.sh index 96a593c..577e487 100755 --- a/util/docker/doc.coreboot.org/makeSphinx.sh +++ b/util/docker/doc.coreboot.org/makeSphinx.sh @@ -1,4 +1,6 @@ -#!/usr/bin/env bash +#!/usr/bin/env ash + +source ${VIRTUAL_ENV}/bin/activate if [ "$1" == "livehtml" ]; then echo "Starting live documentation build" -- To view, visit https://review.coreboot.org/c/coreboot/+/85725?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I544a15c86c212e91ece59b583fb61dad37fca337 Gerrit-Change-Number: 85725 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[XS] Change in coreboot[main]: util/docker/doc.coreboot.org: Don't create volumes
by Felix Singer (Code Review) 22 Dec '24

22 Dec '24

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85724?usp=email ) Change subject: util/docker/doc.coreboot.org: Don't create volumes ...................................................................... util/docker/doc.coreboot.org: Don't create volumes Volumes are mounted with the command line parameter. Using the VOLUME directive creates a persistent storage in a standard path, which is not intended. So drop that and create equal directories in order to keep the container working. Change-Id: I9b3551cca34d846aba5ca5c89162f82baa6de768 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/docker/doc.coreboot.org/Dockerfile 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/85724/1 diff --git a/util/docker/doc.coreboot.org/Dockerfile b/util/docker/doc.coreboot.org/Dockerfile index fdb4bbe..0979daf 100644 --- a/util/docker/doc.coreboot.org/Dockerfile +++ b/util/docker/doc.coreboot.org/Dockerfile @@ -14,6 +14,9 @@ && chmod 755 /makeSphinx.sh RUN adduser -D coreboot +RUN \ + mkdir /data-in /data-out && \ + chown -R coreboot:coreboot /data-in /data-out USER coreboot @@ -31,8 +34,6 @@ sphinx_autobuild===2024.2.4 \ sphinx_rtd_theme===2.0.0 -VOLUME /data-in /data-out - # For Sphinx-autobuild # Port 8000 - HTTP server # Port 35729 - websockets connection to allow automatic browser reloads after each build -- To view, visit https://review.coreboot.org/c/coreboot/+/85724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9b3551cca34d846aba5ca5c89162f82baa6de768 Gerrit-Change-Number: 85724 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[XS] Change in coreboot[main]: soc/intel/common/block/power_limit: Disable RAPL via MSR completely
by Mario Scheithauer (Code Review) 21 Dec '24

21 Dec '24

Attention is currently required from: Johannes Hahn, Werner Zeh. Mario Scheithauer has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/85606?usp=email ) Change subject: soc/intel/common/block/power_limit: Disable RAPL via MSR completely ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/soc/intel/common/block/power_limit/power_limit.c: https://review.coreboot.org/c/coreboot/+/85606/comment/171186de_a5008fa3?us… : PS3, Line 95: * I think you don't need the star at this point. look https://doc.coreboot.org/contributing/coding_style.html 'Commenting' ...and you should put a period at the end of the sentence. -- To view, visit https://review.coreboot.org/c/coreboot/+/85606?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8272339a991667d5ba177f4755ec40e1961d729e Gerrit-Change-Number: 85606 Gerrit-PatchSet: 3 Gerrit-Owner: Johannes Hahn <johannes-hahn(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: siemens-bot Gerrit-Attention: Johannes Hahn <johannes-hahn(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sat, 21 Dec 2024 21:09:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: 3rdparty/fsp: Update submodule to upstream master
by Felix Singer (Code Review) 21 Dec '24

21 Dec '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85610?usp=email ) Change subject: 3rdparty/fsp: Update submodule to upstream master ...................................................................... 3rdparty/fsp: Update submodule to upstream master Updating from commit id 851f7105d803: 2024-11-22 14:59:29 +0800 - (NEX TGL IPU 2025.1 (7341_01) FSP) to commit id 909cf43ad6cc: 2024-12-09 14:08:48 +0800 - (IoT ADL-N IPU25.1 (5354_00)) This brings in 2 new commits: 909cf43ad6cc IoT ADL-N IPU25.1 (5354_00) 5d25d0b9b6c7 IoT RPL-PS MR1 (5274_42) FSP Change-Id: I13e5a1f0f8e16af46693174541bc666363bc0e71 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85610 Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/3rdparty/fsp b/3rdparty/fsp index 851f710..909cf43 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 851f7105d803672e17202bc2f598a5a4dbf659d3 +Subproject commit 909cf43ad6ccebb6adee482bc0a4f098c32c9a6d -- To view, visit https://review.coreboot.org/c/coreboot/+/85610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I13e5a1f0f8e16af46693174541bc666363bc0e71 Gerrit-Change-Number: 85610 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024