Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85689?usp=email )
Change subject: soc/mediatek/mt8189: Add timer support
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8189/timer.c:
https://review.coreboot.org/c/coreboot/+/85689/comment/0257f202_4113763c?us… :
PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only OR MIT */
> Fixed in [CL#85723](https://review.coreboot. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85689?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I28c051c2e51481464f5dacb4c93f41e4f7e62501
Gerrit-Change-Number: 85689
Gerrit-PatchSet: 3
Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Sat, 21 Dec 2024 14:15:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Vince Liu <vince-wl.liu(a)mediatek.com>
Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85689?usp=email )
Change subject: soc/mediatek/mt8189: Add timer support
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85689/comment/7b5a416d_07c8b9f7?us… :
PS1, Line 9: Add timer support for MT8189.
:
: The new ICs(e.g. mt8196, mt8189) will no longer use GPT, and in order
: to improve code readability, the macro name TIMER_MHZ will be used.
> Add ARM arch timer support for MT8189.
Done
File src/soc/mediatek/mt8189/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/85689/comment/237c3798_a615004d?us… :
PS1, Line 6: timer.c ../common/timer_prepare.c
> `../common/timer_prepare.c timer. […]
Done
File src/soc/mediatek/mt8189/timer.c:
https://review.coreboot.org/c/coreboot/+/85689/comment/26b4e339_8f9b4c13?us… :
PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only OR MIT */
> Please make this relicensing a separate commit.
Fixed in [CL#85723](https://review.coreboot.org/c/coreboot/+/85723/)
--
To view, visit https://review.coreboot.org/c/coreboot/+/85689?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I28c051c2e51481464f5dacb4c93f41e4f7e62501
Gerrit-Change-Number: 85689
Gerrit-PatchSet: 3
Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Sat, 21 Dec 2024 14:14:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Hung-Te Lin, Vince Liu, Yu-Ping Wu.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85689?usp=email
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8189: Add timer support
......................................................................
soc/mediatek/mt8189: Add timer support
Add ARM arch timer support for MT8189.
BUG=b:379008996
BRANCH=none
TEST=Check SYSTIMER_BASE register is configurated correctly.
Change-Id: I28c051c2e51481464f5dacb4c93f41e4f7e62501
Signed-off-by: Ke Zheng <ot_ke.zheng(a)mediatek.corp-partner.google.com>
---
M src/soc/mediatek/mt8189/Makefile.mk
M src/soc/mediatek/mt8189/timer.c
2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/85689/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/85689?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I28c051c2e51481464f5dacb4c93f41e4f7e62501
Gerrit-Change-Number: 85689
Gerrit-PatchSet: 3
Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Vince Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85723?usp=email )
Change subject: soc/mediatek/mt8189: Replace SPDX identifiers to GPL-2.0-only OR MIT
......................................................................
soc/mediatek/mt8189: Replace SPDX identifiers to GPL-2.0-only OR MIT
These files were originally from MediaTek and follow coreboot's main
license: "GPL-2.0-only". Now MediaTek replaces this file to
"GPL-2.0-only OR MIT" license for better code re-use in other open
source software stack.
BUG=b:379008996
BRANCH=none
TEST=build pass
Change-Id: I2821a8c097b8d22e1aa91b316ae0fdce80f342de
Signed-off-by: Vince Liu <vince-wl.liu(a)mediatek.corp-partner.google.com>
---
M src/soc/mediatek/mt8189/timer.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/85723/1
diff --git a/src/soc/mediatek/mt8189/timer.c b/src/soc/mediatek/mt8189/timer.c
index 2f299ea..c010d58 100644
--- a/src/soc/mediatek/mt8189/timer.c
+++ b/src/soc/mediatek/mt8189/timer.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
+/* SPDX-License-Identifier: GPL-2.0-only OR MIT */
/*
* This file is created based on MT8189 Functional Specification
--
To view, visit https://review.coreboot.org/c/coreboot/+/85723?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2821a8c097b8d22e1aa91b316ae0fdce80f342de
Gerrit-Change-Number: 85723
Gerrit-PatchSet: 1
Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Hung-Te Lin, Vince Liu, Yu-Ping Wu.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85689?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Yu-Ping Wu, Verified+1 by build bot (Jenkins)
Change subject: soc/mediatek/mt8189: Add timer support
......................................................................
soc/mediatek/mt8189: Add timer support
Add timer support for MT8189.
BUG=b:379008996
BRANCH=none
TEST=Check SYSTIMER_BASE register is configurated correctly.
Change-Id: I28c051c2e51481464f5dacb4c93f41e4f7e62501
Signed-off-by: Ke Zheng <ot_ke.zheng(a)mediatek.corp-partner.google.com>
---
M src/soc/mediatek/mt8189/Makefile.mk
M src/soc/mediatek/mt8189/timer.c
2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/85689/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85689?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I28c051c2e51481464f5dacb4c93f41e4f7e62501
Gerrit-Change-Number: 85689
Gerrit-PatchSet: 2
Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85547?usp=email )
Change subject: mb/google/brya: Adjust EC memory map range to support indexed IO
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
> Pushed CB:85722 , to serve as an example to enable indexed memmap access.
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/85547?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide5026b35da7c00deab4464eedfca9d52d294fd6
Gerrit-Change-Number: 85547
Gerrit-PatchSet: 7
Gerrit-Owner: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Sat, 21 Dec 2024 12:52:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jayvik Desai <jayvik(a)google.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85547?usp=email )
Change subject: mb/google/brya: Adjust EC memory map range to support indexed IO
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
> can you please push one CL (WIP) that selects EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO Kconfig
Pushed CB:85722 , to serve as an example to enable indexed memmap access.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85547?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide5026b35da7c00deab4464eedfca9d52d294fd6
Gerrit-Change-Number: 85547
Gerrit-PatchSet: 7
Gerrit-Owner: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Sat, 21 Dec 2024 12:51:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Marshall Dawson, Zheng Bao.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Marshall Dawson, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85648?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/amd/majolica: Add flashmap data for B partition
......................................................................
mb/amd/majolica: Add flashmap data for B partition
Split the amdfw.rom into three parts, EFS, Partition A and Partition
B.
Change-Id: I5eb4cc8a5a64f47a9a7fe2085e3b601fe7162ffb
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/mainboard/amd/majolica/Kconfig
A src/mainboard/amd/majolica/board_ab.fmd
2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/85648/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/85648?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5eb4cc8a5a64f47a9a7fe2085e3b601fe7162ffb
Gerrit-Change-Number: 85648
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Bao Zheng, Julius Werner, Zheng Bao.
Hello Julius Werner, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85645?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: WIP:A/B RECOVERY: Add setting boot status and corrupt type
......................................................................
WIP:A/B RECOVERY: Add setting boot status and corrupt type
Change-Id: I55a379b9c9f85fabbd8a1f98fbef3f57d7d8118d
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/lib/cbfs.c
M src/lib/prog_loaders.c
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/85645/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/85645?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I55a379b9c9f85fabbd8a1f98fbef3f57d7d8118d
Gerrit-Change-Number: 85645
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Zheng Bao