coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[S] Change in coreboot[main]: mb/google/nissa/var/rull: Add G2 touchscreen to devicetree
by Rui Zhou (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Subrata Banik. Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85656?usp=email ) Change subject: mb/google/nissa/var/rull: Add G2 touchscreen to devicetree ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/rull/overridetree.cb: https://review.coreboot.org/c/coreboot/+/85656/comment/fe70b558_c0f3184f?us… : PS1, Line 363: reset_delay_ms" = "120" > i will confirm it Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85656?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0d68b8d09f2fd280dea17a0542243b88618b5fa1 Gerrit-Change-Number: 85656 Gerrit-PatchSet: 3 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 23 Dec 2024 06:13:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>

1 0

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6316 driver
by Yidi Lin (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85630?usp=email ) Change subject: soc/mediatek/mt8196: Add PMIC MT6316 driver ...................................................................... Patch Set 9: (4 comments) File src/soc/mediatek/common/mt6316.c: https://review.coreboot.org/c/coreboot/+/85630/comment/4b068bd6_4d5ee739?us… : PS9, Line 59: 0x%x %#x https://review.coreboot.org/c/coreboot/+/85630/comment/3638da49_527994be?us… : PS9, Line 86: 0x%x %#x https://review.coreboot.org/c/coreboot/+/85630/comment/963b3dfa_007ad297?us… : PS9, Line 113: 0x%x %#x https://review.coreboot.org/c/coreboot/+/85630/comment/c69f8602_a4323b5f?us… : PS9, Line 164: d %u ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85630?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39e91d64e77cff03281845dfbea565e6ddf748f6 Gerrit-Change-Number: 85630 Gerrit-PatchSet: 9 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 23 Dec 2024 05:46:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add MT6685 adc init
by Yidi Lin (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85734?usp=email ) Change subject: soc/mediatek/mt8196: Add MT6685 adc init ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Please follow MT6316 coding style and review comment. -- To view, visit https://review.coreboot.org/c/coreboot/+/85734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I26ae4f416202f04a8030259c49e009b19a60712e Gerrit-Change-Number: 85734 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 23 Dec 2024 05:44:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6316 driver
by Jarried Lin (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85630?usp=email ) Change subject: soc/mediatek/mt8196: Add PMIC MT6316 driver ...................................................................... Patch Set 9: (8 comments) File src/soc/mediatek/common/mt6316.c: https://review.coreboot.org/c/coreboot/+/85630/comment/dc0b81f5_7966e601?us… : PS7, Line 48: 0x%x > %#x Done https://review.coreboot.org/c/coreboot/+/85630/comment/9149de5a_d96541ec?us… : PS7, Line 78: %u > `%u\n` Done https://review.coreboot.org/c/coreboot/+/85630/comment/5d9e04d2_4c3296eb?us… : PS7, Line 106: %u > \n Done https://review.coreboot.org/c/coreboot/+/85630/comment/e0a59694_f50f8ed0?us… : PS7, Line 132: %u > `%u\n` Done https://review.coreboot.org/c/coreboot/+/85630/comment/1f211c1c_751e6340?us… : PS7, Line 158: -1 > false Done https://review.coreboot.org/c/coreboot/+/85630/comment/9984889a_7e12e6df?us… : PS7, Line 170: { > remove Done https://review.coreboot.org/c/coreboot/+/85630/comment/4231afe0_30850975?us… : PS7, Line 184: : printk(BIOS_INFO, "[%s][MT6316_6]CHIP ID = 0x%x\n", __func__, : mt6316_read_field(SPMI_SLAVE_6, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0)); : printk(BIOS_INFO, "[%s][MT6316_7]CHIP ID = 0x%x\n", __func__, : mt6316_read_field(SPMI_SLAVE_7, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0)); : printk(BIOS_INFO, "[%s][MT6316_8]CHIP ID = 0x%x\n", __func__, : mt6316_read_field(SPMI_SLAVE_8, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0)); : printk(BIOS_INFO, "[%s][MT6316_15]CHIP ID = 0x%x\n", __func__, : mt6316_read_field(SPMI_SLAVE_15, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0)); > ``` […] Done https://review.coreboot.org/c/coreboot/+/85630/comment/8cb4af4e_7707ea7f?us… : PS7, Line 199: { > remove Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85630?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39e91d64e77cff03281845dfbea565e6ddf748f6 Gerrit-Change-Number: 85630 Gerrit-PatchSet: 9 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 23 Dec 2024 05:41:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6316 driver
by Jarried Lin (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Hello Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85630?usp=email to look at the new patch set (#9). Change subject: soc/mediatek/mt8196: Add PMIC MT6316 driver ...................................................................... soc/mediatek/mt8196: Add PMIC MT6316 driver Add MT6316 driver in SoC folder. TEST=Build pass BUG=b:317009620 Change-Id: I39e91d64e77cff03281845dfbea565e6ddf748f6 Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> --- A src/soc/mediatek/common/include/soc/mt6316.h A src/soc/mediatek/common/mt6316.c M src/soc/mediatek/mt8196/Makefile.mk A src/soc/mediatek/mt8196/mt6316.c 4 files changed, 1,156 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/85630/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/85630?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39e91d64e77cff03281845dfbea565e6ddf748f6 Gerrit-Change-Number: 85630 Gerrit-PatchSet: 9 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add MT6685 adc init
by Jarried Lin (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Hello Hope Wang, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/85734?usp=email to review the following change. Change subject: soc/mediatek/mt8196: Add MT6685 adc init ...................................................................... soc/mediatek/mt8196: Add MT6685 adc init Add MT6685 adc init. TEST=Build pass BUG=b:317009620 Change-Id: I26ae4f416202f04a8030259c49e009b19a60712e Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> --- A src/soc/mediatek/common/include/soc/mt6685_adc_init.h A src/soc/mediatek/common/mt6685.c M src/soc/mediatek/mt8196/Makefile.mk A src/soc/mediatek/mt8196/mt6685.c M src/soc/mediatek/mt8196/pmif_init.c 5 files changed, 183 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/85734/1 diff --git a/src/soc/mediatek/common/include/soc/mt6685_adc_init.h b/src/soc/mediatek/common/include/soc/mt6685_adc_init.h new file mode 100644 index 0000000..96a010e --- /dev/null +++ b/src/soc/mediatek/common/include/soc/mt6685_adc_init.h @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef __SOC_MEDIATEK_MT6685_ADC_INIT_H__ +#define __SOC_MEDIATEK_MT6685_ADC_INIT_H__ + +#include <soc/spmi.h> +#include <types.h> + +struct mt6685_setting { + unsigned short addr; + unsigned short val; + unsigned short mask; + unsigned char shift; +}; + +void mt6685_adc_init(void); +void mt6685_init_pmif_arb(void); +void mt6685_write_field(u32 reg, u32 val, u32 mask, u32 shift); +u32 mt6685_read_field(u32 reg, u32 mask, u32 shift); +u32 mt6685_get_reg_value16(u32 reg); +u32 mt6685_set_reg_value16(u32 reg, u16 reg_val); +void mt6685_init_setting(void); + +#endif diff --git a/src/soc/mediatek/common/mt6685.c b/src/soc/mediatek/common/mt6685.c new file mode 100644 index 0000000..c29bdb6 --- /dev/null +++ b/src/soc/mediatek/common/mt6685.c @@ -0,0 +1,92 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <assert.h> +#include <console/console.h> +#include <delay.h> +#include <soc/mt6685_adc_init.h> +#include <soc/pmif.h> +#include <timer.h> + +static const struct mt6685_setting key_protect_setting[] = { + {0x39E, 0x7A, 0xFF, 0}, + {0x39F, 0x99, 0xFF, 0}, + {0x3A8, 0x15, 0xFF, 0}, + {0x3A9, 0x63, 0xFF, 0}, + {0x3AA, 0x30, 0xFF, 0}, + {0x3AB, 0x63, 0xFF, 0}, + {0x9A5, 0x29, 0xFF, 0}, + {0x9A6, 0x47, 0xFF, 0}, + {0xF98, 0x85, 0xFF, 0}, + {0xF99, 0x66, 0xFF, 0}, +}; + +static struct pmif *pmif_arb; +static void mt6685_write(u32 reg, u32 data) +{ + pmif_arb->write(pmif_arb, 0x9, reg, data); +} + +u32 mt6685_read_field(u32 reg, u32 mask, u32 shift) +{ + return pmif_arb->read_field(pmif_arb, 0x9, reg, mask, shift); +} + +void mt6685_write_field(u32 reg, u32 val, u32 mask, u32 shift) +{ + pmif_arb->write_field(pmif_arb, 0x9, reg, val, mask, shift); +} + +u32 mt6685_get_reg_value16(u32 reg) +{ + u16 rdata = 0; + + pmif_arb->read16(pmif_arb, 0x9, reg, &rdata); + return rdata; +} + +u32 mt6685_set_reg_value16(u32 reg, u16 reg_val) +{ + pmif_arb->write16(pmif_arb, 0x9, reg, reg_val); + return 0; +} + +static void mt6685_wdt_set(void) +{ + u32 wdata = 0; + + wdata = mt6685_read_field(0x127, 0xFFFF, 0); + printk(BIOS_INFO, "[%s]MT6685 TOP_RST_MISC=0x%x++\n", __func__, wdata); + mt6685_write_field(0x128, 0x3, 0xFFFF, 0); +} + +static void mt6685_unlock(bool unlock) +{ + for (int i = 0; i < ARRAY_SIZE(key_protect_setting); i++) + mt6685_write(key_protect_setting[i].addr, + unlock ? key_protect_setting[i].val : 0); + printk(BIOS_INFO, "%s done\n", __func__); +} + +void mt6685_init_pmif_arb(void) +{ + if (!pmif_arb) { + pmif_arb = get_pmif_controller(PMIF_SPMI, SPMI_MASTER_1); + if (!pmif_arb) + die("ERROR: No spmi device"); + } + + if (pmif_arb->is_pmif_init_done(pmif_arb)) + die("ERROR - Failed to initialize pmif spi"); + + printk(BIOS_INFO, "[mt6685]CHIP ID = 0x%x\n", mt6685_read_field(0xb, 0xFF, 0)); +} + +void mt6685_adc_init(void) +{ + mt6685_init_pmif_arb(); + mt6685_unlock(true); + mt6685_wdt_set(); + mt6685_init_setting(); + mt6685_unlock(false); + printk(BIOS_INFO, "MT6685 TOP_RST_MISC=0x%x--\n", mt6685_read_field(0x127, 0xFFFF, 0)); +} diff --git a/src/soc/mediatek/mt8196/Makefile.mk b/src/soc/mediatek/mt8196/Makefile.mk index d46ddb1..da2bcbd 100644 --- a/src/soc/mediatek/mt8196/Makefile.mk +++ b/src/soc/mediatek/mt8196/Makefile.mk @@ -33,6 +33,7 @@ romstage-y += ../common/mt6316.c mt6316.c romstage-y += ../common/mt6363.c mt6363.c romstage-y += ../common/mt6373.c mt6373.c +romstage-y += ../common/mt6685.c mt6685.c romstage-y += ../common/pmif_clk.c pmif_clk.c romstage-y += ../common/pmif.c pmif_init.c romstage-y += pmif_spmi.c diff --git a/src/soc/mediatek/mt8196/mt6685.c b/src/soc/mediatek/mt8196/mt6685.c new file mode 100644 index 0000000..ffad13d --- /dev/null +++ b/src/soc/mediatek/mt8196/mt6685.c @@ -0,0 +1,60 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ + +#include <console/console.h> +#include <soc/mt6685_adc_init.h> + +static const struct mt6685_setting init_setting[] = { + {0x18, 0x2, 0x2, 0}, + {0x1A, 0x1F, 0x1F, 0}, + {0x27, 0x10, 0x10, 0}, + {0x8A, 0x0, 0x1F, 0}, + {0x10B, 0x8, 0x8, 0}, + {0x11E, 0x1, 0x1, 0}, + {0x127, 0x2, 0x2, 0}, + {0x193, 0x1, 0x1, 0}, + {0x19C, 0x3, 0xF, 0}, + {0x389, 0x0, 0xFF, 0}, + {0x38A, 0x0, 0x7, 0}, + {0x413, 0x7, 0xFF, 0}, + {0x418, 0x10, 0xF0, 0}, + {0x789, 0x6, 0x6, 0}, + {0x9B3, 0x0, 0x7F, 0}, + {0x9B4, 0x7E, 0x7E, 0}, + {0xF8C, 0x15, 0x15, 0}, + {0xF8D, 0x5, 0x5, 0}, + {0x1B0D, 0xF, 0xF, 0}, + {0x1B0E, 0x1, 0x1, 0}, + {0x1B0F, 0x0, 0x1, 0}, + {0x1B10, 0x7F, 0x7F, 0}, + {0x1B1A, 0x8, 0x8, 0}, + {0x1B89, 0x0, 0x80, 0}, + {0x1B8E, 0x40, 0x40, 0}, + {0x1B99, 0x0, 0x80, 0}, + {0x1B9E, 0x40, 0x40, 0}, + {0x1BA9, 0x0, 0x80, 0}, + {0x1BAE, 0x40, 0x40, 0}, + {0x1BB9, 0x0, 0x80, 0}, + {0x1BC9, 0x0, 0x80, 0}, + {0x1BD9, 0x0, 0x80, 0}, + {0x1C09, 0x0, 0x80, 0}, + {0x1C0B, 0x1, 0x5, 0}, + {0x1C0E, 0xC0, 0xC0, 0}, + {0x1C8E, 0x1, 0x1, 0}, + + /* Add UVLO 2.0 setting, also need to modify dts setting for main pmic */ + {0x7F1, 0x1, 0xF, 0}, + {0x9a3, 0xD, 0x1F, 0}, + {0x9b2, 0x80, 0x80, 0}, + {0xA8b, 0x4, 0x4, 0}, +}; + +static inline void write_field(const struct mt6685_setting *setting) +{ + mt6685_write_field(setting->addr, setting->val, setting->mask, setting->shift); +} + +void mt6685_init_setting(void) +{ + for (int i = 0; i < ARRAY_SIZE(init_setting); i++) + write_field(&init_setting[i]); +} diff --git a/src/soc/mediatek/mt8196/pmif_init.c b/src/soc/mediatek/mt8196/pmif_init.c index 0fda348..0baf720 100644 --- a/src/soc/mediatek/mt8196/pmif_init.c +++ b/src/soc/mediatek/mt8196/pmif_init.c @@ -20,6 +20,8 @@ .pmifid = PMIF_SPMI, .write = pmif_spmi_write, .read = pmif_spmi_read, + .write16 = pmif_spmi_write16, + .read16 = pmif_spmi_read16, .write_field = pmif_spmi_write_field, .read_field = pmif_spmi_read_field, .is_pmif_init_done = pmif_check_init_done, @@ -30,6 +32,8 @@ .pmifid = PMIF_SPMI, .write = pmif_spmi_write, .read = pmif_spmi_read, + .write16 = pmif_spmi_write16, + .read16 = pmif_spmi_read16, .write_field = pmif_spmi_write_field, .read_field = pmif_spmi_read_field, .is_pmif_init_done = pmif_check_init_done, @@ -40,6 +44,8 @@ .pmifid = PMIF_SPMI, .write = pmif_spmi_write, .read = pmif_spmi_read, + .write16 = pmif_spmi_write16, + .read16 = pmif_spmi_read16, .write_field = pmif_spmi_write_field, .read_field = pmif_spmi_read_field, .is_pmif_init_done = pmif_check_init_done, -- To view, visit https://review.coreboot.org/c/coreboot/+/85734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I26ae4f416202f04a8030259c49e009b19a60712e Gerrit-Change-Number: 85734 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6316 driver
by Jarried Lin (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Hello Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85630?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/mediatek/mt8196: Add PMIC MT6316 driver ...................................................................... soc/mediatek/mt8196: Add PMIC MT6316 driver Add MT6316 driver in SoC folder. TEST=Build pass BUG=b:317009620 Change-Id: I39e91d64e77cff03281845dfbea565e6ddf748f6 Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> --- A src/soc/mediatek/common/include/soc/mt6316.h A src/soc/mediatek/common/mt6316.c M src/soc/mediatek/mt8196/Makefile.mk A src/soc/mediatek/mt8196/mt6316.c 4 files changed, 1,157 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/85630/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/85630?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39e91d64e77cff03281845dfbea565e6ddf748f6 Gerrit-Change-Number: 85630 Gerrit-PatchSet: 8 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8189: Add timer support
by Yidi Lin (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Vince Liu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85689?usp=email ) Change subject: soc/mediatek/mt8189: Add timer support ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85689/comment/6fffb04e_5f72b000?us… : PS3, Line 7: dd timer support : : Add ARM arch timer support for MT8189. This patch should be `Enable timer compensation` -- To view, visit https://review.coreboot.org/c/coreboot/+/85689?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I28c051c2e51481464f5dacb4c93f41e4f7e62501 Gerrit-Change-Number: 85689 Gerrit-PatchSet: 3 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 23 Dec 2024 04:59:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8189: Replace SPDX identifiers to GPL-2.0-only OR MIT
by Yidi Lin (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Felix Singer, Hung-Te Lin, Vince Liu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85723?usp=email ) Change subject: soc/mediatek/mt8189: Replace SPDX identifiers to GPL-2.0-only OR MIT ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85723?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2821a8c097b8d22e1aa91b316ae0fdce80f342de Gerrit-Change-Number: 85723 Gerrit-PatchSet: 1 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 23 Dec 2024 04:54:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Enable FPS
by Pranava Y N (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Subrata Banik. Pranava Y N has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85687?usp=email ) Change subject: mb/google/fatcat/var/fatcat: Enable FPS ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85687?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifced5c779407b4ffcc69a7ed1297704def09b554 Gerrit-Change-Number: 85687 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Mon, 23 Dec 2024 04:42:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024