Attention is currently required from: Felix Singer, Filip Lewiński, Paul Menzel.
Maxim Polyakov has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/71757?usp=email )
Change subject: Documentation: Update information about intelp2m
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS8:
> I've found these changes useful when getting round to adding MTL support, so it's a +1 from me
Thx
--
To view, visit https://review.coreboot.org/c/coreboot/+/71757?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80d5fb5d46b50193e8fecc647d9052a2e29af93f
Gerrit-Change-Number: 71757
Gerrit-PatchSet: 10
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Filip Lewiński <filip.lewinski(a)3mdeb.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Filip Lewiński <filip.lewinski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 23 Dec 2024 19:44:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Filip Lewiński <filip.lewinski(a)3mdeb.com>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70310?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/intelp2m: Update cli options
......................................................................
util/intelp2m: Update cli options
- Redesign the options format.
- Add automatic completion of arguments for bash.
[complete -C `pwd`/intelp2m ./intelp2m] to enable
TEST: make test = PASS
Change-Id: I08ff379b99b018b1099aa5d70fea47026bc84045
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
A util/intelp2m/cli/completion.go
A util/intelp2m/cli/options.go
M util/intelp2m/config/p2m/config.go
M util/intelp2m/main.go
M util/intelp2m/version.txt
5 files changed, 270 insertions(+), 81 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/70310/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/70310?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I08ff379b99b018b1099aa5d70fea47026bc84045
Gerrit-Change-Number: 70310
Gerrit-PatchSet: 15
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/71235?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/intelp2m: Move fields pakage to common
......................................................................
util/intelp2m: Move fields pakage to common
According to the architecture, this is part of the common block.
TEST: 'make test' = PASS
Change-Id: I6390182ab00d9ebd787e8da6f341e3ef85572991
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/intelp2m/parser/parser.go
R util/intelp2m/platforms/common/fields/cb/cb.go
R util/intelp2m/platforms/common/fields/cb/cb_test.go
R util/intelp2m/platforms/common/fields/fields.go
R util/intelp2m/platforms/common/fields/fsp/fsp.go
R util/intelp2m/platforms/common/fields/fsp/fsp_test.go
R util/intelp2m/platforms/common/fields/raw/raw.go
R util/intelp2m/platforms/common/fields/raw/raw_test.go
R util/intelp2m/platforms/common/fields/test/suite.go
M util/intelp2m/platforms/test/suite.go
10 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/71235/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/71235?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6390182ab00d9ebd787e8da6f341e3ef85572991
Gerrit-Change-Number: 71235
Gerrit-PatchSet: 9
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Filip Lewiński, Maxim Polyakov.
Hello Filip Lewiński, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/71757?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Code-Review+1 by Filip Lewiński, Verified+1 by build bot (Jenkins)
Change subject: Documentation: Update information about intelp2m
......................................................................
Documentation: Update information about intelp2m
Change-Id: I80d5fb5d46b50193e8fecc647d9052a2e29af93f
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M Documentation/util.md
D Documentation/util/intelp2m/gopackages.png
M Documentation/util/intelp2m/index.md
M util/README.md
4 files changed, 201 insertions(+), 155 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/71757/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/71757?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80d5fb5d46b50193e8fecc647d9052a2e29af93f
Gerrit-Change-Number: 71757
Gerrit-PatchSet: 9
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Filip Lewiński <filip.lewinski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Filip Lewiński <filip.lewinski(a)3mdeb.com>
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier, Paul Menzel, Varshit Pandya.
Nick Kochlowski has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85631?usp=email )
Change subject: drivers/amd/opensil: Add openSIL timepoint calls
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85631/comment/5e68712a_23f4e66f?us… :
PS7, Line 12:
> Please mention the new Kconfig and also describe timepoints 1 to 3 in the commit message as their na […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85631?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0559fc0ff0ec55e9ef131e5ed20dfb5baa651da
Gerrit-Change-Number: 85631
Gerrit-PatchSet: 8
Gerrit-Owner: Nick Kochlowski <nickkochlowski(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 23 Dec 2024 19:32:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier, Nick Kochlowski, Varshit Pandya.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Varshit Pandya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85631?usp=email
to look at the new patch set (#8).
Change subject: drivers/amd/opensil: Add openSIL timepoint calls
......................................................................
drivers/amd/opensil: Add openSIL timepoint calls
Place openSIL timepoints 1, 2 and 3 calls in the driver, which will
serve as the central point for invoking SoC-specific vendorcode
implementations. TP1 and TP2 will initialize silicon pre- and post-PCIe
enumeration, respectively. TP3 then performs late SoC IPs programming
and register locking closer to payload load prior to OS handoff. Add a
Kconfig option for selecting and including the openSIL driver source
code in the build.
Change-Id: If0559fc0ff0ec55e9ef131e5ed20dfb5baa651da
Signed-off-by: Nicolas Kochlowski <nickkochlowski(a)gmail.com>
---
A src/drivers/amd/opensil/Kconfig
A src/drivers/amd/opensil/Makefile.mk
A src/drivers/amd/opensil/opensil.h
A src/drivers/amd/opensil/ramstage.c
M src/soc/amd/genoa_poc/Kconfig
M src/soc/amd/genoa_poc/chip.c
M src/soc/amd/phoenix/Kconfig
M src/soc/amd/phoenix/chip.c
8 files changed, 55 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/85631/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/85631?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0559fc0ff0ec55e9ef131e5ed20dfb5baa651da
Gerrit-Change-Number: 85631
Gerrit-PatchSet: 8
Gerrit-Owner: Nick Kochlowski <nickkochlowski(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Nick Kochlowski <nickkochlowski(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Nick Kochlowski has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/85746?usp=email )
Change subject: drivers/amd/opensil/mpio: Extract chip ops and per-device MPIO config
......................................................................
Abandoned
Merged with previous patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/85746?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e496ab9df07f2f2ba32314cf5c5fd2861333e67
Gerrit-Change-Number: 85746
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Kochlowski <nickkochlowski(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier, Varshit Pandya.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Varshit Pandya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85632?usp=email
to look at the new patch set (#9).
Change subject: drivers/amd/opensil/mpio: Factor out common MPIO symbols from vendorcode
......................................................................
drivers/amd/opensil/mpio: Factor out common MPIO symbols from vendorcode
Refactor vendorcode MPIO configuration functions to be invoked from
the openSIL driver.
Change-Id: I8b1f92f08565216dd93203a06015e3eec1e7bb69
Signed-off-by: Nicolas Kochlowski <nickkochlowski(a)gmail.com>
---
M src/drivers/amd/opensil/Makefile.mk
A src/drivers/amd/opensil/mpio/Makefile.mk
A src/drivers/amd/opensil/mpio/chip.c
R src/drivers/amd/opensil/mpio/chip.h
M src/drivers/amd/opensil/opensil.h
M src/drivers/amd/opensil/ramstage.c
M src/mainboard/amd/birman/devicetree_phoenix_opensil.cb
M src/mainboard/amd/birman/update_devicetree_phoenix_opensil.c
M src/mainboard/amd/onyx_poc/devicetree.cb
M src/soc/amd/genoa_poc/chipset.cb
M src/soc/amd/phoenix/chipset_opensil.cb
M src/vendorcode/amd/opensil/Kconfig
M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.h
M src/vendorcode/amd/opensil/genoa_poc/ramstage.c
M src/vendorcode/amd/opensil/opensil.h
M src/vendorcode/amd/opensil/stub/mpio/chip.c
M src/vendorcode/amd/opensil/stub/mpio/chip.h
18 files changed, 202 insertions(+), 163 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/85632/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/85632?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8b1f92f08565216dd93203a06015e3eec1e7bb69
Gerrit-Change-Number: 85632
Gerrit-PatchSet: 9
Gerrit-Owner: Nick Kochlowski <nickkochlowski(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Subrata Banik.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85662?usp=email )
Change subject: mb/google/fatcat: Remove bluetooth over USB
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
File src/mainboard/google/fatcat/variants/felino/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85662/comment/fadb439f_26d032e2?us… :
PS1, Line 208: device ref cnvi_bluetooth on end
> do you want to define `cnvi_bluetooth` at baseboard level ?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85662?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ida95d1898d24898880de567db7c0ac8ac053eeaa
Gerrit-Change-Number: 85662
Gerrit-PatchSet: 2
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Mon, 23 Dec 2024 17:52:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Jérémy Compostella has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85661?usp=email )
Change subject: mb/google/fatcat: Suppress unnecessary extra space in device trees
......................................................................
mb/google/fatcat: Suppress unnecessary extra space in device trees
Change-Id: I546e704fa1c525406edede24cf0b4485276b878e
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85661
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Pranava Y N <pranavayn(a)google.com>
Reviewed-by: Subrata Banik <subratabanik(a)google.com>
---
M src/mainboard/google/fatcat/variants/fatcat/overridetree.cb
M src/mainboard/google/fatcat/variants/felino/overridetree.cb
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Pranava Y N: Looks good to me, approved
Subrata Banik: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb
index 44ea511..ca2ebb0 100644
--- a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb
+++ b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb
@@ -497,7 +497,7 @@
register "wake" = "GPE0_DW0_12" # GPP_A12
use usb2_port7 as bluetooth_companion
device pci 00.0 on end
- end
+ end
end # discrete WLAN
device ref pcie_rp5 on
probe STORAGE STORAGE_NVME_GEN4
diff --git a/src/mainboard/google/fatcat/variants/felino/overridetree.cb b/src/mainboard/google/fatcat/variants/felino/overridetree.cb
index 2b34f03..1f3d07b 100644
--- a/src/mainboard/google/fatcat/variants/felino/overridetree.cb
+++ b/src/mainboard/google/fatcat/variants/felino/overridetree.cb
@@ -173,7 +173,7 @@
register "wake" = "GPE0_DW0_12" # GPP_A12
use usb2_port7 as bluetooth_companion
device pci 00.0 on end
- end
+ end
end # WLAN
device ref pcie_rp9 on
--
To view, visit https://review.coreboot.org/c/coreboot/+/85661?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I546e704fa1c525406edede24cf0b4485276b878e
Gerrit-Change-Number: 85661
Gerrit-PatchSet: 2
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>