coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[M] Change in coreboot[main]: mb/google/corsola: Add new board variant Wyrdeer
by Yang Wu (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yidi Lin, Yu-Ping Wu. Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85742?usp=email ) Change subject: mb/google/corsola: Add new board variant Wyrdeer ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/corsola/panel_wyrdeer.c: https://review.coreboot.org/c/coreboot/+/85742/comment/cb6a941b_99edb9d2?us… : PS2, Line 12: static void mipi_panel_power_on(void) : { : const struct tps65132s_reg_setting reg_settings[] = { : { PMIC_TPS65132_VPOS, 0x14, 0x1F }, : { PMIC_TPS65132_VNEG, 0x14, 0x1F }, : { PMIC_TPS65132_DLYX, 0x95, 0xFF }, : { PMIC_TPS65132_ASSDD, 0x5b, 0xFF }, : }; : const struct tps65132s_cfg cfg = { : .i2c_bus = PMIC_I2C_BUS, : .en = GPIO_EN_PP3300_DISP_X, : .sync = GPIO_TCHPAD_INT_ODL, : .settings = reg_settings, : .setting_counts = ARRAY_SIZE(reg_settings), : }; : : mainboard_set_regulator_voltage(MTK_REGULATOR_VIO18, 1800000); : mtk_i2c_bus_init(PMIC_I2C_BUS, I2C_SPEED_FAST); : : if (is_pmic_aw37503(PMIC_I2C_BUS)) { : printk(BIOS_DEBUG, "Initialize and power on PMIC AW37503\n"); : aw37503_init(PMIC_I2C_BUS); : gpio_output(GPIO_EN_PP3300_DISP_X, 1); : mdelay(2); : gpio_output(GPIO_TCHPAD_INT_ODL, 1); : mdelay(3); : } else if (tps65132s_setup(&cfg) != CB_SUCCESS) { : printk(BIOS_ERR, "Failed to setup tps65132s\n"); : } : : /* DISP_RST_1V8_L */ : gpio_output(GPIO_EDPBRDG_RST_L, 1); : mdelay(1); : gpio_output(GPIO_EDPBRDG_RST_L, 0); : udelay(20); : gpio_output(GPIO_EDPBRDG_RST_L, 1); : } > This function is identical to the function in `panel_starmie.c`. Move it to a separate file. There is one difference between starmie and wyrdeer, starmie uses `GPIO_EN_PP3300_SDBRDG_X` as `EN_PP6000_MIPI_DISP_150MA` pin, but wyrdeer uses `GPIO_TCHPAD_INT_ODL` -- To view, visit https://review.coreboot.org/c/coreboot/+/85742?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07b73c97d8d51b32f557e31d834ffc6cfb8420ed Gerrit-Change-Number: 85742 Gerrit-PatchSet: 2 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 23 Dec 2024 11:22:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[NoOp] Change in coreboot[main]: mb/starlabs/byte: Update the VBT from 249 to 251
by Sean Rhodes (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Sean Rhodes. Sean Rhodes has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/85706?usp=email ) Change subject: mb/starlabs/byte: Update the VBT from 249 to 251 ...................................................................... mb/starlabs/byte: Update the VBT from 249 to 251 This silences a few warnings in FSP. Change-Id: I3bef919d1c6fcb9abff4fc49300321c9d471cb82 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/85706/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85706?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3bef919d1c6fcb9abff4fc49300321c9d471cb82 Gerrit-Change-Number: 85706 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XS] Change in coreboot[main]: mb/starlabs/*: Select TPM2 so PPI is generated
by Sean Rhodes (Code Review) 23 Dec '24

23 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85697?usp=email ) Change subject: mb/starlabs/*: Select TPM2 so PPI is generated ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85697?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4d6633291ba635c5a2f7eb36e64a327d9a4da5cf Gerrit-Change-Number: 85697 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 23 Dec 2024 11:21:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: intel/common/rtd3: Allow emitting PSD0 Method for CPU Root Ports
by Sean Rhodes (Code Review) 23 Dec '24

23 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85696?usp=email ) Change subject: intel/common/rtd3: Allow emitting PSD0 Method for CPU Root Ports ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85696?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia34cc1f9099ca88fa16a83174ec90ca14f43ab56 Gerrit-Change-Number: 85696 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 23 Dec 2024 11:21:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Use the new Intel Bluetooth driver
by Sean Rhodes (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Alicja Michalska. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84636?usp=email ) Change subject: mb/starlabs/*: Use the new Intel Bluetooth driver ...................................................................... Patch Set 24: (1 comment) Patchset: PS24: > Just to clarify - it only affects CNVi cards, right? No, works for full PCI too. -- To view, visit https://review.coreboot.org/c/coreboot/+/84636?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6438a21a73e8ddab21fb5b9021fb4d5e2f8c1c22 Gerrit-Change-Number: 84636 Gerrit-PatchSet: 24 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Comment-Date: Mon, 23 Dec 2024 11:10:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alicja Michalska <ahplka19(a)gmail.com>

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Unify WiFi driver settings
by Sean Rhodes (Code Review) 23 Dec '24

23 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85692?usp=email ) Change subject: mb/starlabs/*: Unify WiFi driver settings ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85692?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0fd6b3dd67583842e4520679b7a9c3ab9f433c4 Gerrit-Change-Number: 85692 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 23 Dec 2024 11:09:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/starlabs/*: Tweak the performance profiles
by Sean Rhodes (Code Review) 23 Dec '24

23 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85694?usp=email ) Change subject: mb/starlabs/*: Tweak the performance profiles ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85694?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8375428e9ace8e505e8cb53b2e4912592715b79a Gerrit-Change-Number: 85694 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 23 Dec 2024 11:09:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Add SSDT entry for volume keys
by Sean Rhodes (Code Review) 23 Dec '24

23 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85695?usp=email ) Change subject: mb/starlabs/starlite_adl: Add SSDT entry for volume keys ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie80491559de50d72bf1ff97fd30c1a74e6b0f7a6 Gerrit-Change-Number: 85695 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 23 Dec 2024 11:09:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/starlabs/*: Configure GPIO UPDs for eSPI
by Sean Rhodes (Code Review) 23 Dec '24

23 Dec '24

Sean Rhodes has uploaded a new patch set (#4). ( https://review.coreboot.org/c/coreboot/+/85691?usp=email ) Change subject: mb/starlabs/*: Configure GPIO UPDs for eSPI ...................................................................... mb/starlabs/*: Configure GPIO UPDs for eSPI FSP defaults to using pins that are used for LPC; given that coreboot and these boards only supports eSPI, set these pins accordingly. Change-Id: Ide4d92211fa7ab496c38ce1c4e895337c269d247 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.mk A src/mainboard/starlabs/byte_adl/variants/mk_ii/ramstage.c M src/mainboard/starlabs/starbook/variants/adl/ramstage.c M src/mainboard/starlabs/starbook/variants/rpl/ramstage.c M src/mainboard/starlabs/starfighter/variants/rpl/ramstage.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/Makefile.mk A src/mainboard/starlabs/starlite_adl/variants/mk_v/ramstage.c 7 files changed, 53 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/85691/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85691?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide4d92211fa7ab496c38ce1c4e895337c269d247 Gerrit-Change-Number: 85691 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/telith: Disable stylus function
by Kun Liu (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Kun Liu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/85738?usp=email ) Change subject: mb/google/nissa/var/telith: Disable stylus function ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/telith/gpio.c: https://review.coreboot.org/c/coreboot/+/85738/comment/0f64dde1_3e7be66f?us… : PS2, Line 46: PAD_CFG_GPO > Why GPO and not NC? Because the external environment is floating, EE requires setting GPIO output to be pulled high or low -- To view, visit https://review.coreboot.org/c/coreboot/+/85738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b72284ab173633405d5de9541f0ea7520d09658 Gerrit-Change-Number: 85738 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 23 Dec 2024 11:01:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024