coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: mb/google/nissa/var/pujjo: Add new supported memory part
by Luca Lai (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Luca Lai has posted comments on this change by Luca Lai. ( https://review.coreboot.org/c/coreboot/+/85735?usp=email ) Change subject: mb/google/nissa/var/pujjo: Add new supported memory part ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/variants/pujjo/memory/mem_parts_used.txt: https://review.coreboot.org/c/coreboot/+/85735/comment/2f9aaa96_df2c8ecb?us… : PS3, Line 22: + > why `+`? Done. Thank you. -- To view, visit https://review.coreboot.org/c/coreboot/+/85735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb48e849424aac79ef9af29f21b84194455c813e Gerrit-Change-Number: 85735 Gerrit-PatchSet: 4 Gerrit-Owner: Luca Lai <luca.lai(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 23 Dec 2024 09:49:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/intel/xeon_sp: Remove assert when creating DMAR component
by Patrick Rudolph (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Shuo Liu, Tim Chu. Patrick Rudolph has posted comments on this change by Jincheng Li. ( https://review.coreboot.org/c/coreboot/+/85737?usp=email ) Change subject: soc/intel/xeon_sp: Remove assert when creating DMAR component ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85737/comment/d122a4d5_2bb7cd8d?us… : PS1, Line 10: Remove > Good question. Got a quick check but agree that more checks are needed before moving ahead. […] Thanks for explaining. When you found no problems on gen6 I'm fine this change. -- To view, visit https://review.coreboot.org/c/coreboot/+/85737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I64256baf10abb509d48267e58e6a9e264b916e72 Gerrit-Change-Number: 85737 Gerrit-PatchSet: 1 Gerrit-Owner: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 23 Dec 2024 09:39:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Define MFGPLL_*_BASE using MFGSYS_BASE
by Yidi Lin (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/85740?usp=email ) Change subject: soc/mediatek/mt8196: Define MFGPLL_*_BASE using MFGSYS_BASE ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85740?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd5d77b95c698cb6030c58ba259f2cdf2a29d87b Gerrit-Change-Number: 85740 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 23 Dec 2024 09:37:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/google/corsola: Add new board variant Wyrdeer
by Yang Wu (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Xinxiong Xu, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85742?usp=email to look at the new patch set (#2). Change subject: mb/google/corsola: Add new board variant Wyrdeer ...................................................................... mb/google/corsola: Add new board variant Wyrdeer Add a new Staryu follower device 'Wyrdeer'. And add MIPI panel support. BUG=b:379810871 TEST=emerge-staryu coreboot chromeos-bootimage and check FW screen BRANCH=corsola Change-Id: I07b73c97d8d51b32f557e31d834ffc6cfb8420ed Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name M src/mainboard/google/corsola/Makefile.mk A src/mainboard/google/corsola/panel_wyrdeer.c 4 files changed, 78 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/85742/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85742?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07b73c97d8d51b32f557e31d834ffc6cfb8420ed Gerrit-Change-Number: 85742 Gerrit-PatchSet: 2 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Define MFGPLL_*_BASE using MFGSYS_BASE
by Yu-Ping Wu (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hung-Te Lin, Yidi Lin. Hello Hung-Te Lin, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85740?usp=email to look at the new patch set (#3). Change subject: soc/mediatek/mt8196: Define MFGPLL_*_BASE using MFGSYS_BASE ...................................................................... soc/mediatek/mt8196: Define MFGPLL_*_BASE using MFGSYS_BASE The MFGPLL_*_BASE addresses are based on MFGSYS_BASE (0x40000000) instead of IO_PHYS (0x10000000). Rewrite the address calculation for readability. Also rename these macros to MFG_PLL_* to make them consistent with other macros to be added in CB:85654. Change-Id: Ifd5d77b95c698cb6030c58ba259f2cdf2a29d87b Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/soc/mediatek/mt8196/include/soc/addressmap.h M src/soc/mediatek/mt8196/include/soc/pll.h 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/85740/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85740?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd5d77b95c698cb6030c58ba259f2cdf2a29d87b Gerrit-Change-Number: 85740 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Define MFGPLL_*_BASE using MFGSYS_BASE
by Yu-Ping Wu (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hung-Te Lin, Yidi Lin. Hello Hung-Te Lin, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85740?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/mt8196: Define MFGPLL_*_BASE using MFGSYS_BASE ...................................................................... soc/mediatek/mt8196: Define MFGPLL_*_BASE using MFGSYS_BASE The MFGPLL_*_BASE addresses are based on MFGSYS_BASE (0x40000000) instead of IO_PHYS (0x10000000). Rewrite the address calculation for readability. Also rename these macros to MFG_PLL_* to make them consistent with other macros to be added in CB:85654. Change-Id: Ifd5d77b95c698cb6030c58ba259f2cdf2a29d87b Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/soc/mediatek/mt8196/include/soc/addressmap.h M src/soc/mediatek/mt8196/include/soc/pll.h 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/85740/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85740?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd5d77b95c698cb6030c58ba259f2cdf2a29d87b Gerrit-Change-Number: 85740 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add API to check if a USB PD charger is attached
by Subrata Banik (Code Review) 23 Dec '24

23 Dec '24

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85743?usp=email ) Change subject: ec/google/chromeec: Add API to check if a USB PD charger is attached ...................................................................... ec/google/chromeec: Add API to check if a USB PD charger is attached This change introduces a new API, `google_chromeec_is_usb_pd_attached()` which checks the current status of the USB-C port and returns whether a USB Power Delivery (PD) charger is currently connected. This API is useful for determining if the system is currently being powered by a PD charger. BUG=b:377798581 TEST=Able to read the PD status correctly while booting google/fatcat. Change-Id: I47c934ee8a7563d4ba5124bff5613e61dd66e923 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/85743/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index af5c235..d0c5fc5 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -966,6 +966,28 @@ return 0; } +/* + * This API checks the current status of the USB-C port and returns + * whether a USB Power Delivery (PD) charger is currently connected. + */ +bool google_chromeec_is_usb_pd_attached(void) +{ + const struct ec_params_usb_pd_power_info params = { + .port = PD_POWER_CHARGING_PORT, + }; + struct ec_response_usb_pd_power_info resp = {}; + int rv; + + rv = ec_cmd_usb_pd_power_info(PLAT_EC, &params, &resp); + if (rv != 0) + return false; + + if (resp.type == USB_CHG_TYPE_PD) + return true; + + return false; +} + int google_chromeec_override_dedicated_charger_limit(uint16_t current_lim, uint16_t voltage_lim) { diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index 31c7671..cdea70f 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -137,6 +137,9 @@ int google_chromeec_get_usb_pd_power_info(enum usb_chg_type *type, uint16_t *current_max, uint16_t *voltage_max); +/* Check if a USB Power Delivery (PD) charger is attached */ +bool google_chromeec_is_usb_pd_attached(void); + /* * Set max current and voltage of a dedicated charger. * -- To view, visit https://review.coreboot.org/c/coreboot/+/85743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I47c934ee8a7563d4ba5124bff5613e61dd66e923 Gerrit-Change-Number: 85743 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/corsola: Add new board variant Wyrdeer
by Yang Wu (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Yang Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85742?usp=email ) Change subject: mb/google/corsola: Add new board variant Wyrdeer ...................................................................... mb/google/corsola: Add new board variant Wyrdeer Add a new Staryu follower device 'Wyrdeer'. And add MIPI panel support. BUG=b:379810871 TEST=emerge-staryu coreboot chromeos-bootimage and check FW screen BRANCH=corsola Change-Id: I07b73c97d8d51b32f557e31d834ffc6cfb8420ed Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name M src/mainboard/google/corsola/Makefile.mk A src/mainboard/google/corsola/panel_wyrdeer.c 4 files changed, 78 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/85742/1 diff --git a/src/mainboard/google/corsola/Kconfig b/src/mainboard/google/corsola/Kconfig index 41f9845..f2342c2 100644 --- a/src/mainboard/google/corsola/Kconfig +++ b/src/mainboard/google/corsola/Kconfig @@ -23,7 +23,8 @@ config BOARD_GOOGLE_STARYU_COMMON def_bool BOARD_GOOGLE_STARMIE || \ - BOARD_GOOGLE_WUGTRIO + BOARD_GOOGLE_WUGTRIO || \ + BOARD_GOOGLE_WYRDEER if BOARD_GOOGLE_CORSOLA_COMMON @@ -31,7 +32,8 @@ def_bool BOARD_GOOGLE_KINGLER_COMMON || \ BOARD_GOOGLE_MAGIKARP || \ BOARD_GOOGLE_TENTACRUEL || \ - BOARD_GOOGLE_WUGTRIO + BOARD_GOOGLE_WUGTRIO || \ + BOARD_GOOGLE_WYRDEER config BOARD_SPECIFIC_OPTIONS def_bool y @@ -72,6 +74,7 @@ select MIPI_PANEL_KD_KD101NE3_40TI if BOARD_GOOGLE_WUGTRIO select MIPI_PANEL_LCE_LMFBX101117480 if BOARD_GOOGLE_WUGTRIO select MIPI_PANEL_STA_ER88577 if BOARD_GOOGLE_WUGTRIO + select MIPI_PANEL_KD_KD110N11_51IE if BOARD_GOOGLE_WYRDEER select MIPI_PANEL_STA_HIMAX83102_J02 if BOARD_GOOGLE_STARMIE select MIPI_PANEL_STA_ILI9882T if BOARD_GOOGLE_STARMIE @@ -99,6 +102,7 @@ default "Veluza" if BOARD_GOOGLE_VELUZA default "Voltorb" if BOARD_GOOGLE_VOLTORB default "Wugtrio" if BOARD_GOOGLE_WUGTRIO + default "Wyrdeer" if BOARD_GOOGLE_WYRDEER config BOOT_DEVICE_SPI_FLASH_BUS int diff --git a/src/mainboard/google/corsola/Kconfig.name b/src/mainboard/google/corsola/Kconfig.name index ab6a1328..5de50c3 100644 --- a/src/mainboard/google/corsola/Kconfig.name +++ b/src/mainboard/google/corsola/Kconfig.name @@ -47,3 +47,6 @@ config BOARD_GOOGLE_WUGTRIO bool "-> Wugtrio" + +config BOARD_GOOGLE_WYRDEER + bool "-> Wyrdeer" diff --git a/src/mainboard/google/corsola/Makefile.mk b/src/mainboard/google/corsola/Makefile.mk index 09e9b91..b0d87e58 100644 --- a/src/mainboard/google/corsola/Makefile.mk +++ b/src/mainboard/google/corsola/Makefile.mk @@ -27,3 +27,4 @@ ramstage-$(CONFIG_BOARD_GOOGLE_STARMIE) += panel_starmie.c ramstage-$(CONFIG_BOARD_GOOGLE_WUGTRIO) += panel_wugtrio.c +ramstage-$(CONFIG_BOARD_GOOGLE_WYRDEER) += panel_wyrdeer.c diff --git a/src/mainboard/google/corsola/panel_wyrdeer.c b/src/mainboard/google/corsola/panel_wyrdeer.c new file mode 100644 index 0000000..2c984ac --- /dev/null +++ b/src/mainboard/google/corsola/panel_wyrdeer.c @@ -0,0 +1,68 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <console/console.h> +#include <delay.h> +#include <gpio.h> +#include <soc/regulator.h> +#include <soc/tps65132s.h> + +#include "gpio.h" +#include "panel.h" + +static void mipi_panel_power_on(void) +{ + const struct tps65132s_reg_setting reg_settings[] = { + { PMIC_TPS65132_VPOS, 0x14, 0x1F }, + { PMIC_TPS65132_VNEG, 0x14, 0x1F }, + { PMIC_TPS65132_DLYX, 0x95, 0xFF }, + { PMIC_TPS65132_ASSDD, 0x5b, 0xFF }, + }; + const struct tps65132s_cfg cfg = { + .i2c_bus = PMIC_I2C_BUS, + .en = GPIO_EN_PP3300_DISP_X, + .sync = GPIO_TCHPAD_INT_ODL, + .settings = reg_settings, + .setting_counts = ARRAY_SIZE(reg_settings), + }; + + mainboard_set_regulator_voltage(MTK_REGULATOR_VIO18, 1800000); + mtk_i2c_bus_init(PMIC_I2C_BUS, I2C_SPEED_FAST); + + if (is_pmic_aw37503(PMIC_I2C_BUS)) { + printk(BIOS_DEBUG, "Initialize and power on PMIC AW37503\n"); + aw37503_init(PMIC_I2C_BUS); + gpio_output(GPIO_EN_PP3300_DISP_X, 1); + mdelay(2); + gpio_output(GPIO_TCHPAD_INT_ODL, 1); + mdelay(3); + } else if (tps65132s_setup(&cfg) != CB_SUCCESS) { + printk(BIOS_ERR, "Failed to setup tps65132s\n"); + } + + /* DISP_RST_1V8_L */ + gpio_output(GPIO_EDPBRDG_RST_L, 1); + mdelay(1); + gpio_output(GPIO_EDPBRDG_RST_L, 0); + udelay(20); + gpio_output(GPIO_EDPBRDG_RST_L, 1); +} + +static struct panel_description wyrdeer_panels[] = { + /* K&D Technology panel */ + [6] = { + .configure_backlight = backlight_control, + .power_on = mipi_panel_power_on, + .name = "KD_KD110N11_51IE", + .disp_path = DISP_PATH_MIPI, + .orientation = LB_FB_ORIENTATION_LEFT_UP, + }, +}; + +struct panel_description *get_panel_description(void) +{ + uint32_t id = panel_id() & 0xF; + if (id >= ARRAY_SIZE(wyrdeer_panels)) + return NULL; + + return &wyrdeer_panels[id]; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/85742?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07b73c97d8d51b32f557e31d834ffc6cfb8420ed Gerrit-Change-Number: 85742 Gerrit-PatchSet: 1 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for KD_KD110N11_51IE panel
by Yang Wu (Code Review) 23 Dec '24

23 Dec '24

Yang Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85741?usp=email ) Change subject: drivers/mipi: Add support for KD_KD110N11_51IE panel ...................................................................... drivers/mipi: Add support for KD_KD110N11_51IE panel Add K&D panel KD_KD110N11_51IE serializable data to CBFS. Datasheet: KD110N11-51IE-A008_SPEC_A00_20241219.pdf BUG=b:379810871 TEST=build and check the CBFS include the panel BRANCH=None Change-Id: Iecf7957185afd1c62f768d163bba69ed373b7f92 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.mk A src/drivers/mipi/panel-KD_KD110N11_51IE.c 3 files changed, 110 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/85741/1 diff --git a/src/drivers/mipi/Kconfig b/src/drivers/mipi/Kconfig index d70e92d..a7049ba 100644 --- a/src/drivers/mipi/Kconfig +++ b/src/drivers/mipi/Kconfig @@ -48,6 +48,9 @@ config MIPI_PANEL_KD_KD101NE3_40TI bool +config MIPI_PANEL_KD_KD110N11_51IE + bool + config MIPI_PANEL_LCE_LMFBX101117480 bool diff --git a/src/drivers/mipi/Makefile.mk b/src/drivers/mipi/Makefile.mk index a71cff6..0c4a5c9 100644 --- a/src/drivers/mipi/Makefile.mk +++ b/src/drivers/mipi/Makefile.mk @@ -24,6 +24,7 @@ panel-params-$(CONFIG_MIPI_PANEL_IVO_T109NW41) += panel-IVO_T109NW41 panel-params-$(CONFIG_MIPI_PANEL_KD_KD101NE3_40TI) += panel-KD_KD101NE3_40TI +panel-params-$(CONFIG_MIPI_PANEL_KD_KD110N11_51IE) += panel-KD_KD110N11_51IE panel-params-$(CONFIG_MIPI_PANEL_LCE_LMFBX101117480) += panel-LCE_LMFBX101117480 diff --git a/src/drivers/mipi/panel-KD_KD110N11_51IE.c b/src/drivers/mipi/panel-KD_KD110N11_51IE.c new file mode 100644 index 0000000..6d44375 --- /dev/null +++ b/src/drivers/mipi/panel-KD_KD110N11_51IE.c @@ -0,0 +1,106 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <mipi/panel.h> + +struct panel_serializable_data KD_KD110N11_51IE = { + .edid = { + .ascii_string = "KD110N11-51IE", + .manufacturer_name = "KD", + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .pixel_clock = 182888, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 1200, .hbl = 284, .hso = 124, .hspw = 80, + .va = 1920, .vbl = 134, .vso = 88, .vspw = 8, + .phsync = '-', .pvsync = '-', + .x_mm = 147, .y_mm = 235, + }, + }, + + .init = { + PANEL_DELAY(24), + PANEL_DCS(0x11), + PANEL_DCS(0xB9, 0x83, 0x10, 0x21, 0x55, 0x00), + PANEL_DCS(0xE9, 0xC4), + PANEL_DCS(0xD9, 0xD1), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xB1, 0x2C, 0xB3, 0xB3, 0x31, 0xF1, 0x33, 0xE0, 0x54, + 0x36, 0x36, 0x3A, 0x3A, 0x32, 0x8B, 0x11, 0xE5, 0x98), + PANEL_DCS(0xE9, 0xD9), + PANEL_DCS(0xB1, 0x8B, 0x33), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xB2, 0x00, 0x47, 0xB0, 0x80, 0x00, 0x2C, 0x80, 0x3C, + 0x9F, 0x22, 0x20, 0x00, 0x00, 0x98, 0x51), + PANEL_DCS(0xB4, 0x64, 0x64, 0x64, 0x64, 0x64, 0x64, 0x40, 0x84, + 0x64, 0x84, 0x01, 0x9D, 0x01, 0x02, 0x01, 0x00, 0x00), + PANEL_DCS(0xBC, 0x1B, 0x04), + PANEL_DCS(0xBE, 0x20), + PANEL_DCS(0xBF, 0xFC, 0xC4, 0x80, 0x9C, 0x36, 0x00, 0x0D, 0x04), + PANEL_DCS(0xC0, 0x32, 0x32, 0x22, 0x11, 0x22, 0xA0, 0x31, 0x08, + 0xF5, 0x03), + PANEL_DCS(0xE9, 0xCC), + PANEL_DCS(0xC7, 0x80), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xE9, 0xC6), + PANEL_DCS(0xC8, 0x97), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xC9, 0x00, 0x1E, 0x13, 0x88, 0x01), + PANEL_DCS(0xCB, 0x08, 0x13, 0x07, 0x00, 0x0F, 0x36), + PANEL_DCS(0xCC, 0x02, 0x03, 0x44), + PANEL_DCS(0xD1, 0x07, 0x06, 0x00, 0x02, 0x04, 0x2C, 0xFF), + PANEL_DCS(0xD3, 0x06, 0x00, 0x00, 0x00, 0x40, 0x04, 0x08, 0x04, + 0x08, 0x37, 0x07, 0x44, 0x37, 0x2B, 0x2B, 0x03, 0x03, 0x32, + 0x10, 0x22, 0x00, 0x25, 0x32, 0x10, 0x29, 0x00, 0x29, 0x32, + 0x10, 0x08, 0x00, 0x08, 0x00, 0x00), + PANEL_DCS(0xD5, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, + 0x18, 0x18, 0x07, 0x06, 0x07, 0x06, 0x05, 0x04, 0x05, 0x04, + 0x03, 0x02, 0x03, 0x02, 0x01, 0x00, 0x01, 0x00, 0x18, 0x18, + 0x25, 0x24, 0x25, 0x24, 0x1F, 0x1F, 0x1F, 0x1F, 0x1E, 0x1E, + 0x1E, 0x1E, 0x20, 0x20, 0x20, 0x20), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, + 0xAA, 0x8A, 0xAA, 0xA0), + PANEL_DCS(0xE7, 0xE0, 0x10, 0x10, 0x0D, 0x1E, 0x9D, 0x02, 0x52, + 0x9D, 0x14, 0x14), + PANEL_DCS(0xBD, 0x01), + PANEL_DCS(0xB1, 0x01, 0x7F, 0x11, 0xFD), + PANEL_DCS(0xE9, 0xC5), + PANEL_DCS(0xBA, 0x4F), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xCB, 0x86), + PANEL_DCS(0xD2, 0x64), + PANEL_DCS(0xE9, 0xC5), + PANEL_DCS(0xD3, 0x00), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, + 0xAA, 0x8A, 0xAA, 0xA0, 0x05, 0x15, 0x55, 0x45, 0x55, 0x50, + 0x05, 0x15, 0x55, 0x45, 0x55, 0x50), + PANEL_DCS(0xE7, 0x02, 0x00, 0x24, 0x01, 0x7E, 0x0F, 0x7C, 0x10, + 0xA0, 0x00, 0x00), + PANEL_DCS(0xBD, 0x02), + PANEL_DCS(0xCB, 0x03, 0x07, 0x00, 0x10, 0x7B), + PANEL_DCS(0xD8, 0x0F, 0x3F, 0xFF, 0xCF, 0xFF, 0xF0, 0x0F, 0x3F, + 0xFF, 0xCF, 0xFF, 0xF0), + PANEL_DCS(0xE7, 0xFE, 0x01, 0xFE, 0x01, 0xFE, 0x01, 0x00, 0x00, + 0x00, 0x23, 0x00, 0x23, 0x81, 0x02, 0x40, 0x00, 0x20, 0x9D, + 0x02, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00), + PANEL_DCS(0xBD, 0x03), + PANEL_DCS(0xB2, 0x66, 0x81), + PANEL_DCS(0xE9, 0xC6), + PANEL_DCS(0xB4, 0x03, 0xFF, 0xF8), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, + 0xAA, 0x8A, 0xAA, 0xA0, 0x0F, 0x2A, 0xAA, 0x8A, 0xAA, 0xF0, + 0x0F, 0x2A, 0xAA, 0x8A, 0xAA, 0xF0, 0x0A, 0x2A, 0xAA, 0x8A, + 0xAA, 0xA0, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0), + PANEL_DCS(0xBD, 0x00), + PANEL_DCS(0xB9, 0x00, 0x00, 0x00, 0x00), + + PANEL_DCS(0x11), + PANEL_DELAY(120), + PANEL_DCS(0x29), + PANEL_DELAY(20), + PANEL_END, + }, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/85741?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iecf7957185afd1c62f768d163bba69ed373b7f92 Gerrit-Change-Number: 85741 Gerrit-PatchSet: 1 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/telith: Disable stylus function
by Kun Liu (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Subrata Banik. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rui Zhou, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85738?usp=email to look at the new patch set (#2). Change subject: mb/google/nissa/var/telith: Disable stylus function ...................................................................... mb/google/nissa/var/telith: Disable stylus function Disable stylus function based on hardware schematic diagram. BUG=b:372506691 TEST=Local build successfully. Change-Id: I7b72284ab173633405d5de9541f0ea7520d09658 Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/telith/gpio.c M src/mainboard/google/brya/variants/telith/overridetree.cb 2 files changed, 4 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/85738/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b72284ab173633405d5de9541f0ea7520d09658 Gerrit-Change-Number: 85738 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024