coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[L] Change in coreboot[main]: mb/starlabs/starbook: Put options in CFR cbtable
by Sean Rhodes (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Angel Pons, Christian Walter. Hello Angel Pons, Christian Walter, Lean Sheng Tan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74743?usp=email to look at the new patch set (#33). Change subject: mb/starlabs/starbook: Put options in CFR cbtable ...................................................................... mb/starlabs/starbook: Put options in CFR cbtable Change-Id: I816893e5c2663ed55ae9fa5dd662489b27332aa6 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/starbook/Kconfig M src/mainboard/starlabs/starbook/Makefile.mk A src/mainboard/starlabs/starbook/cfr.c M src/mainboard/starlabs/starbook/cmos.default M src/mainboard/starlabs/starbook/cmos.layout D src/mainboard/starlabs/starbook/variants/tgl/cmos.default D src/mainboard/starlabs/starbook/variants/tgl/cmos.layout 7 files changed, 383 insertions(+), 231 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/74743/33 -- To view, visit https://review.coreboot.org/c/coreboot/+/74743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I816893e5c2663ed55ae9fa5dd662489b27332aa6 Gerrit-Change-Number: 74743 Gerrit-PatchSet: 33 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z77 Extreme4
by Riku Viitanen (Code Review) 31 Dec '24

31 Dec '24

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z77 Extreme4
by Riku Viitanen (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Angel Pons, Nicholas Chin. Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85772?usp=email ) Change subject: mb/asrock: Add Z77 Extreme4 ...................................................................... Patch Set 10: (12 comments) File src/mainboard/asrock/z77_extreme4/Kconfig: https://review.coreboot.org/c/coreboot/+/85772/comment/972ba1ea_a354bc99?us… : PS10, Line 27: int > Type not needed here as it's defined in `sb/intel/bd82x6x/Kconfig` Done File src/mainboard/asrock/z77_extreme4/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85772/comment/97297a51_a4f4ee11?us… : PS10, Line 4: register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" > Move under igd device Done https://review.coreboot.org/c/coreboot/+/85772/comment/7d628fab_a315e565?us… : PS10, Line 24: register "gen1_dec" = "0x000c0291" : register "gen2_dec" = "0x000c0241" : register "gen3_dec" = "0x000c0251" > Move under lpc device (probably between subsystem and the superio) Done https://review.coreboot.org/c/coreboot/+/85772/comment/0d01f1d2_d0d8a74a?us… : PS10, Line 28: register "sata_interface_speed_support" = "0x3" : register "sata_port_map" = "0x3f" > Move under sata1 device Done https://review.coreboot.org/c/coreboot/+/85772/comment/407095d4_01c93514?us… : PS10, Line 32: register "superspeed_capable_ports" = "0x0000000f" > Move under xhci device Done https://review.coreboot.org/c/coreboot/+/85772/comment/384559ad_a936d905?us… : PS10, Line 49: register "xhci_overcurrent_mapping" = "0x00000c03" : register "xhci_switchable_ports" = "0x0000000f" > Move under xhci device Done https://review.coreboot.org/c/coreboot/+/85772/comment/a765092c_e526de29?us… : PS10, Line 57: device ref mei2 off end : device ref me_ide_r off end : device ref me_kt off end : device ref gbe off end > Defaults to off in chipset devicetree, could be removed Done https://review.coreboot.org/c/coreboot/+/85772/comment/fbf21b94_774a8e25?us… : PS10, Line 71: device ref pcie_rp2 off end : device ref pcie_rp3 off end > Defaults to off in chipset devicetree, could be removed Done https://review.coreboot.org/c/coreboot/+/85772/comment/ecd48884_d65fbd29?us… : PS10, Line 91: device ref pci_bridge off end > Defaults to off in chipset devicetree, could be removed. Done https://review.coreboot.org/c/coreboot/+/85772/comment/67766911_fbe2e5fb?us… : PS10, Line 157: end > Move to previous line Done https://review.coreboot.org/c/coreboot/+/85772/comment/33d8cd55_b4d50923?us… : PS10, Line 166: device ref sata2 off end : device ref thermal off end > Defaults to off in chipset devicetree, could be removed Done File src/mainboard/asrock/z77_extreme4/mainboard.c: https://review.coreboot.org/c/coreboot/+/85772/comment/abf9e7d7_3b2c6d45?us… : PS10, Line 5: #include <southbridge/intel/bd82x6x/pch.h> > Doesn't seem to be used, remove. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idf028c6d411bd501b73a3c526240d0b1d6ecaa0c Gerrit-Change-Number: 85772 Gerrit-PatchSet: 10 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 31 Dec 2024 13:41:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z77 Extreme4
by Riku Viitanen (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Angel Pons, Nicholas Chin. Hello Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85772?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/asrock: Add Z77 Extreme4 ...................................................................... mb/asrock: Add Z77 Extreme4 New port based on logs extracted from a board running OEM firmware. VBT extracted from a running system with "intelvbttool --inlegacy". Tested: - i7-3770K CPU (native raminit) - 2x8GB: G.skill F3-1600C9-8GAR (@1600MHz) - 4x8GB: Corsair CMY16GX3M2A2400C (@1333MHz) - libgfxinit txtmode with onboard HDMI, DVI and VGA - Gigabit Ethernet - CPU fan - PS/2 keyboard or mouse (but not at the same time) - SeaBIOS 1.16.3 booting to Devuan and Void Linux - All internal SATA ports - Rear USB ports - Line out - me_cleaner - PCIe x16 slots, including automatic bifurcation (x8/x8) - PCI slots - Suspend and resume (S3) - Serial port header COM1 (including coreboot output) Untested: - Intel VBIOS - USB headers - Other fans - LED headers - eSATA, SPDIF - PCIe x1 slots Change-Id: Idf028c6d411bd501b73a3c526240d0b1d6ecaa0c Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- A src/mainboard/asrock/z77_extreme4/Kconfig A src/mainboard/asrock/z77_extreme4/Kconfig.name A src/mainboard/asrock/z77_extreme4/Makefile.mk A src/mainboard/asrock/z77_extreme4/acpi/ec.asl A src/mainboard/asrock/z77_extreme4/acpi/platform.asl A src/mainboard/asrock/z77_extreme4/acpi/superio.asl A src/mainboard/asrock/z77_extreme4/board_info.txt A src/mainboard/asrock/z77_extreme4/cmos.default A src/mainboard/asrock/z77_extreme4/cmos.layout A src/mainboard/asrock/z77_extreme4/data.vbt A src/mainboard/asrock/z77_extreme4/devicetree.cb A src/mainboard/asrock/z77_extreme4/dsdt.asl A src/mainboard/asrock/z77_extreme4/early_init.c A src/mainboard/asrock/z77_extreme4/gma-mainboard.ads A src/mainboard/asrock/z77_extreme4/gpio.c A src/mainboard/asrock/z77_extreme4/hda_verb.c A src/mainboard/asrock/z77_extreme4/mainboard.c 17 files changed, 622 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/85772/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/85772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idf028c6d411bd501b73a3c526240d0b1d6ecaa0c Gerrit-Change-Number: 85772 Gerrit-PatchSet: 11 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[XS] Change in coreboot[main]: Revert "mb/starlabs/*: Disable c6dram"
by Sean Rhodes (Code Review) 31 Dec '24

31 Dec '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85704?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Revert "mb/starlabs/*: Disable c6dram" ...................................................................... Revert "mb/starlabs/*: Disable c6dram" This reverts commit 9e3f614598ae9ede85fb9cdd436ae53c62cfdefd. This is used for S3, so keep it in the devicetree. Change-Id: If69bb946d31e842af9caf84470ddd32900e56456 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb M src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb M src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb 6 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/85704/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85704?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If69bb946d31e842af9caf84470ddd32900e56456 Gerrit-Change-Number: 85704 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: mb/starlabs/starbook: Put options in CFR cbtable
by Sean Rhodes (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Angel Pons, Christian Walter. Hello Angel Pons, Christian Walter, Lean Sheng Tan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74743?usp=email to look at the new patch set (#31). Change subject: mb/starlabs/starbook: Put options in CFR cbtable ...................................................................... mb/starlabs/starbook: Put options in CFR cbtable Change-Id: I816893e5c2663ed55ae9fa5dd662489b27332aa6 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/starbook/Kconfig M src/mainboard/starlabs/starbook/Makefile.mk A src/mainboard/starlabs/starbook/cfr.c M src/mainboard/starlabs/starbook/cmos.default M src/mainboard/starlabs/starbook/cmos.layout D src/mainboard/starlabs/starbook/variants/tgl/cmos.default D src/mainboard/starlabs/starbook/variants/tgl/cmos.layout 7 files changed, 384 insertions(+), 231 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/74743/31 -- To view, visit https://review.coreboot.org/c/coreboot/+/74743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I816893e5c2663ed55ae9fa5dd662489b27332aa6 Gerrit-Change-Number: 74743 Gerrit-PatchSet: 31 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/hp/snb_ivb_desktops: Remove unused includes
by Riku Viitanen (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Elyes Haouas, Nicholas Chin. Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85815?usp=email ) Change subject: mb/hp/snb_ivb_desktops: Remove unused includes ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > Not directly related to the comment in CB:79583, but `compaq_elite_8300_usdt/early_init. […] Done Commit Message: https://review.coreboot.org/c/coreboot/+/85815/comment/f90c03cd_55527672?us… : PS2, Line 9: CB:79583 > Since this is merged, please use the commit hash. […] since the scope has expanded a lot from that anyway, i just removed it in favour of brevity. -- To view, visit https://review.coreboot.org/c/coreboot/+/85815?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4082a2589441b1d257db622380733e2825b27c2 Gerrit-Change-Number: 85815 Gerrit-PatchSet: 3 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 31 Dec 2024 12:50:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/hp/snb_ivb_desktops: Remove unused includes
by Riku Viitanen (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Elyes Haouas, Nicholas Chin, Riku Viitanen. Hello Elyes Haouas, Nicholas Chin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85815?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Elyes Haouas, Code-Review+2 by Nicholas Chin, Verified+1 by build bot (Jenkins) Change subject: mb/hp/snb_ivb_desktops: Remove unused includes ...................................................................... mb/hp/snb_ivb_desktops: Remove unused includes There are several unused includes here. TEST=Built 8200 usdt with BUILD_TIMELESS=1, no change in output ROM. Change-Id: Ib4082a2589441b1d257db622380733e2825b27c2 Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- M src/mainboard/hp/snb_ivb_desktops/mainboard.c M src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_sff/early_init.c M src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_usdt/early_init.c M src/mainboard/hp/snb_ivb_desktops/variants/compaq_8300_elite_sff/early_init.c M src/mainboard/hp/snb_ivb_desktops/variants/compaq_elite_8300_usdt/early_init.c 5 files changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/85815/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85815?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4082a2589441b1d257db622380733e2825b27c2 Gerrit-Change-Number: 85815 Gerrit-PatchSet: 3 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z77 Extreme4
by Riku Viitanen (Code Review) 31 Dec '24

31 Dec '24

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Set SPMI-P SCL/SDA pins to pull-down
by Jarried Lin (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85751?usp=email ) Change subject: soc/mediatek/mt8196: Set SPMI-P SCL/SDA pins to pull-down ...................................................................... Patch Set 9: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85751/comment/a8920187_4afbd566?us… : PS8, Line 7: SoC PD > pins to pull-down. Done https://review.coreboot.org/c/coreboot/+/85751/comment/21ddd374_696f3585?us… : PS8, Line 9: , > SoC side. Done https://review.coreboot.org/c/coreboot/+/85751/comment/0a058da8_5c29e055?us… : PS8, Line 10: it is done only once during the SPMI read check to fix SPMI clock : calibration failure. > Can you explain why ? Done File src/soc/mediatek/mt8196/pmif_spmi.c: https://review.coreboot.org/c/coreboot/+/85751/comment/5a301315_0ebab124?us… : PS8, Line 170: /* SPMI-P set Pull-Down mode*/ > Space after "mode" Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85751?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idbf8ed8e31850ca81c823db1b25bde4a83a48c4f Gerrit-Change-Number: 85751 Gerrit-PatchSet: 9 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 31 Dec 2024 12:16:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

← Newer
1
2
3
4
5
6
7
8
...
302
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024