coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: soc/intel/alderlake: Correctly set SATA Device Sleep pins
by Sean Rhodes (Code Review) 31 Dec '24

31 Dec '24

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83877?usp=email ) Change subject: soc/intel/alderlake: Correctly set SATA Device Sleep pins ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/83877?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icf6135fd58142636c3fc2210b3dc0e23870aeb09 Gerrit-Change-Number: 83877 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin: Only include battery ACPI for systems with a battery
by Sean Rhodes (Code Review) 31 Dec '24

31 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85716?usp=email ) Change subject: ec/starlabs/merlin: Only include battery ACPI for systems with a battery ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85716?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I381714887f4319d8e1a25c1e493ba03631cbf082 Gerrit-Change-Number: 85716 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 31 Dec 2024 15:27:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/starlabs/starbook: Add Meteor Lake (165H) variant
by Sean Rhodes (Code Review) 31 Dec '24

31 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85715?usp=email ) Change subject: mb/starlabs/starbook: Add Meteor Lake (165H) variant ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85715?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6621585086c58d19574841314796ed9db779036e Gerrit-Change-Number: 85715 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 31 Dec 2024 15:27:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XL] Change in coreboot[main]: mb/starlabs/starbook: Add AlderLake-N variant
by Sean Rhodes (Code Review) 31 Dec '24

31 Dec '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85714?usp=email ) Change subject: mb/starlabs/starbook: Add AlderLake-N variant ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85714?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04 Gerrit-Change-Number: 85714 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 31 Dec 2024 15:27:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/hp/snb_ivb_desktops/z220*: Remove leftover old usb configurations
by Elyes Haouas (Code Review) 31 Dec '24

31 Dec '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85817?usp=email ) Change subject: mb/hp/snb_ivb_desktops/z220*: Remove leftover old usb configurations ...................................................................... mb/hp/snb_ivb_desktops/z220*: Remove leftover old usb configurations Since all USB configurations are read from the southbridge devicetree, these configurations aren't used anymore. TEST=Built Z220 CMT with BUILD_TIMELESS=1, output ROMs are identical. Change-Id: I8f478625ad4928cf23bbb8ac2689004010bbdd4b Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85817 Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c M src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c 2 files changed, 0 insertions(+), 36 deletions(-) Approvals: build bot (Jenkins): Verified Nicholas Chin: Looks good to me, approved Elyes Haouas: Looks good to me, approved diff --git a/src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c b/src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c index 74a6462..aace18d 100644 --- a/src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c +++ b/src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c @@ -3,27 +3,9 @@ #include <bootblock_common.h> #include <superio/nuvoton/npcd378/npcd378.h> #include <superio/nuvoton/common/nuvoton.h> -#include <southbridge/intel/bd82x6x/pch.h> #define SERIAL_DEV PNP_DEV(0x2e, NPCD378_SP2) -const struct southbridge_usb_port mainboard_usb_ports[] = { - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 1, 5 }, - { 1, 0, 5 }, - { 1, 0, 5 }, - { 1, 0, 5 }, - { 1, 0, 7 }, - { 1, 0, 7 }, -}; - void bootblock_mainboard_early_init(void) { if (CONFIG(CONSOLE_SERIAL)) diff --git a/src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c b/src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c index 74a6462..aace18d 100644 --- a/src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c +++ b/src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c @@ -3,27 +3,9 @@ #include <bootblock_common.h> #include <superio/nuvoton/npcd378/npcd378.h> #include <superio/nuvoton/common/nuvoton.h> -#include <southbridge/intel/bd82x6x/pch.h> #define SERIAL_DEV PNP_DEV(0x2e, NPCD378_SP2) -const struct southbridge_usb_port mainboard_usb_ports[] = { - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 1, 5 }, - { 1, 0, 5 }, - { 1, 0, 5 }, - { 1, 0, 5 }, - { 1, 0, 7 }, - { 1, 0, 7 }, -}; - void bootblock_mainboard_early_init(void) { if (CONFIG(CONSOLE_SERIAL)) -- To view, visit https://review.coreboot.org/c/coreboot/+/85817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f478625ad4928cf23bbb8ac2689004010bbdd4b Gerrit-Change-Number: 85817 Gerrit-PatchSet: 2 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/hp/snb_ivb_desktops: Remove unused includes
by Elyes Haouas (Code Review) 31 Dec '24

31 Dec '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85815?usp=email ) Change subject: mb/hp/snb_ivb_desktops: Remove unused includes ...................................................................... mb/hp/snb_ivb_desktops: Remove unused includes There are several unused includes here. TEST=Built 8200 usdt with BUILD_TIMELESS=1, no change in output ROM. Change-Id: Ib4082a2589441b1d257db622380733e2825b27c2 Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85815 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/hp/snb_ivb_desktops/mainboard.c M src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_sff/early_init.c M src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_usdt/early_init.c M src/mainboard/hp/snb_ivb_desktops/variants/compaq_8300_elite_sff/early_init.c M src/mainboard/hp/snb_ivb_desktops/variants/compaq_elite_8300_usdt/early_init.c 5 files changed, 0 insertions(+), 6 deletions(-) Approvals: Elyes Haouas: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/hp/snb_ivb_desktops/mainboard.c b/src/mainboard/hp/snb_ivb_desktops/mainboard.c index 75dc330..22f0e26 100644 --- a/src/mainboard/hp/snb_ivb_desktops/mainboard.c +++ b/src/mainboard/hp/snb_ivb_desktops/mainboard.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <southbridge/intel/bd82x6x/pch.h> #include <smbios.h> #if CONFIG(GENERATE_SMBIOS_TABLES) diff --git a/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_sff/early_init.c b/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_sff/early_init.c index 8d10c63..aace18d 100644 --- a/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_sff/early_init.c +++ b/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_sff/early_init.c @@ -3,7 +3,6 @@ #include <bootblock_common.h> #include <superio/nuvoton/npcd378/npcd378.h> #include <superio/nuvoton/common/nuvoton.h> -#include <southbridge/intel/bd82x6x/pch.h> #define SERIAL_DEV PNP_DEV(0x2e, NPCD378_SP2) diff --git a/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_usdt/early_init.c b/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_usdt/early_init.c index d2d9762..40b3f3e 100644 --- a/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_usdt/early_init.c +++ b/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_usdt/early_init.c @@ -3,7 +3,6 @@ #include <bootblock_common.h> #include <superio/nuvoton/npcd378/npcd378.h> #include <superio/nuvoton/common/nuvoton.h> -#include <southbridge/intel/bd82x6x/pch.h> #define SERIAL_DEV PNP_DEV(0x2e, NPCD378_SP2) diff --git a/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8300_elite_sff/early_init.c b/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8300_elite_sff/early_init.c index 8d10c63..aace18d 100644 --- a/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8300_elite_sff/early_init.c +++ b/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8300_elite_sff/early_init.c @@ -3,7 +3,6 @@ #include <bootblock_common.h> #include <superio/nuvoton/npcd378/npcd378.h> #include <superio/nuvoton/common/nuvoton.h> -#include <southbridge/intel/bd82x6x/pch.h> #define SERIAL_DEV PNP_DEV(0x2e, NPCD378_SP2) diff --git a/src/mainboard/hp/snb_ivb_desktops/variants/compaq_elite_8300_usdt/early_init.c b/src/mainboard/hp/snb_ivb_desktops/variants/compaq_elite_8300_usdt/early_init.c index 889da05..c7c207a 100644 --- a/src/mainboard/hp/snb_ivb_desktops/variants/compaq_elite_8300_usdt/early_init.c +++ b/src/mainboard/hp/snb_ivb_desktops/variants/compaq_elite_8300_usdt/early_init.c @@ -1,8 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootblock_common.h> -#include <superio/nuvoton/npcd378/npcd378.h> -#include <superio/nuvoton/common/nuvoton.h> #include <device/pci_ops.h> void bootblock_mainboard_early_init(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/85815?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4082a2589441b1d257db622380733e2825b27c2 Gerrit-Change-Number: 85815 Gerrit-PatchSet: 4 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/hp/snb_ivb_desktops/z220*: Remove leftover old usb configurations
by Elyes Haouas (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Riku Viitanen. Elyes Haouas has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85817?usp=email ) Change subject: mb/hp/snb_ivb_desktops/z220*: Remove leftover old usb configurations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f478625ad4928cf23bbb8ac2689004010bbdd4b Gerrit-Change-Number: 85817 Gerrit-PatchSet: 1 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Comment-Date: Tue, 31 Dec 2024 14:30:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/starlabs/starbook: Put options in CFR cbtable
by Sean Rhodes (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Angel Pons, Christian Walter. Hello Angel Pons, Christian Walter, Lean Sheng Tan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74743?usp=email to look at the new patch set (#34). Change subject: mb/starlabs/starbook: Put options in CFR cbtable ...................................................................... mb/starlabs/starbook: Put options in CFR cbtable Change-Id: I816893e5c2663ed55ae9fa5dd662489b27332aa6 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/starbook/Kconfig M src/mainboard/starlabs/starbook/Makefile.mk A src/mainboard/starlabs/starbook/cfr.c M src/mainboard/starlabs/starbook/cmos.default M src/mainboard/starlabs/starbook/cmos.layout D src/mainboard/starlabs/starbook/variants/tgl/cmos.default D src/mainboard/starlabs/starbook/variants/tgl/cmos.layout 7 files changed, 394 insertions(+), 231 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/74743/34 -- To view, visit https://review.coreboot.org/c/coreboot/+/74743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I816893e5c2663ed55ae9fa5dd662489b27332aa6 Gerrit-Change-Number: 74743 Gerrit-PatchSet: 34 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/hp/snb_ivb_desktops: Remove unused includes
by Elyes Haouas (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Nicholas Chin, Riku Viitanen. Elyes Haouas has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85815?usp=email ) Change subject: mb/hp/snb_ivb_desktops: Remove unused includes ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85815?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4082a2589441b1d257db622380733e2825b27c2 Gerrit-Change-Number: 85815 Gerrit-PatchSet: 3 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 31 Dec 2024 14:01:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Set SPMI-P SCL/SDA pins to pull-down
by Yu-Ping Wu (Code Review) 31 Dec '24

31 Dec '24

Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85751?usp=email ) Change subject: soc/mediatek/mt8196: Set SPMI-P SCL/SDA pins to pull-down ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85751?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idbf8ed8e31850ca81c823db1b25bde4a83a48c4f Gerrit-Change-Number: 85751 Gerrit-PatchSet: 9 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 31 Dec 2024 13:58:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

← Newer
1
2
3
4
5
6
7
...
302
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024