coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add MT6685 Clock IC driver
by Yidi Lin (Code Review) 25 Dec '24

25 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85734?usp=email ) Change subject: soc/mediatek/mt8196: Add MT6685 Clock IC driver ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I26ae4f416202f04a8030259c49e009b19a60712e Gerrit-Change-Number: 85734 Gerrit-PatchSet: 6 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 25 Dec 2024 21:17:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: util/amdfwtool: Add binary parsing
by Maximilian Brune (Code Review) 25 Dec '24

25 Dec '24

Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Felix Held, Marshall Dawson, Paul Menzel. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84373?usp=email ) Change subject: util/amdfwtool: Add binary parsing ...................................................................... Patch Set 9: (3 comments) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/84373/comment/6009d1b5_116aaf67?us… : PS8, Line 263: { .type = AMD_FW_MINIMSMU, .subprog = 0, .level = PSP_BOTH | PSP_LVL2_AB }, : { .type = AMD_FW_MINIMSMU, .subprog = 1, .level = PSP_BOTH | PSP_LVL2_AB }, > this adds the inst=0, subprog=1 case, but drops the inst=1, subprog=0 case The only thing I know for certain is that I need the subprog=1,inst=0 case to keep my board booting. I changed it up in order to not remove the inst=1,subprog=0 case. https://review.coreboot.org/c/coreboot/+/84373/comment/ed1b488f_72948d04?us… : PS8, Line 324: { .type = AMD_BIOS_APOB_NV, .level = BDT_BOTH }, > iirc glinda doesn't use/have a level 1 bios directory table Done https://review.coreboot.org/c/coreboot/+/84373/comment/1a3dff7f_33849aeb?us… : PS8, Line 381: { .type = AMD_BIOS_MP2_CFG, .level = BDT_BOTH }, > Same as above. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84373?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef Gerrit-Change-Number: 84373 Gerrit-PatchSet: 9 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Ana Carolina Cabral Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 25 Dec 2024 21:03:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[M] Change in coreboot[main]: util/amdfwtool: Add binary parsing
by Maximilian Brune (Code Review) 25 Dec '24

25 Dec '24

Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Marshall Dawson, Maximilian Brune, Paul Menzel. Hello Anand Vaikar, Bao Zheng, Felix Held, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84373?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/amdfwtool: Add binary parsing ...................................................................... util/amdfwtool: Add binary parsing This adds parsing for some more possible firmware blobs on AMD. These binaries are used on a mainboard based on glinda SOC. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef Original-signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 3 files changed, 110 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/84373/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/84373?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef Gerrit-Change-Number: 84373 Gerrit-PatchSet: 9 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Ana Carolina Cabral

1 0

[M] Change in coreboot[main]: mb/asrock/h77pro4-m/dt: Remove superfluous comments
by Felix Singer (Code Review) 25 Dec '24

25 Dec '24

Attention is currently required from: Riku Viitanen. Felix Singer has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85761?usp=email ) Change subject: mb/asrock/h77pro4-m/dt: Remove superfluous comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85761?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8d8d5287af8f3084f23c9d882202aa6ac8d4c5f Gerrit-Change-Number: 85761 Gerrit-PatchSet: 1 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Comment-Date: Wed, 25 Dec 2024 20:45:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/asrock/h77pro4-m: Add SMBIOS slot descriptions
by Felix Singer (Code Review) 25 Dec '24

25 Dec '24

Attention is currently required from: Riku Viitanen. Felix Singer has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85760?usp=email ) Change subject: mb/asrock/h77pro4-m: Add SMBIOS slot descriptions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85760?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I706910dd192ca3415082955a7611d17702d3cfba Gerrit-Change-Number: 85760 Gerrit-PatchSet: 2 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Comment-Date: Wed, 25 Dec 2024 20:45:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Documentation: Fix snb/ivb nri frequency table
by Nicholas Chin (Code Review) 25 Dec '24

25 Dec '24

Attention is currently required from: Riku Viitanen. Nicholas Chin has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85757?usp=email ) Change subject: Documentation: Fix snb/ivb nri frequency table ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85757?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5e6120aaa9fe7db2a3c1651d2ea9443a24e7c4d Gerrit-Change-Number: 85757 Gerrit-PatchSet: 1 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Comment-Date: Wed, 25 Dec 2024 20:32:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/asrock/h77pro4-m/dt: Remove superfluous comments
by Nicholas Chin (Code Review) 25 Dec '24

25 Dec '24

Attention is currently required from: Riku Viitanen. Nicholas Chin has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85761?usp=email ) Change subject: mb/asrock/h77pro4-m/dt: Remove superfluous comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85761?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8d8d5287af8f3084f23c9d882202aa6ac8d4c5f Gerrit-Change-Number: 85761 Gerrit-PatchSet: 1 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Comment-Date: Wed, 25 Dec 2024 20:31:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[NoOp] Change in coreboot[main]: intelp2m/platforms: Rename macro.go to match module name
by Maxim (Code Review) 25 Dec '24

25 Dec '24

Maxim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85770?usp=email ) Change subject: intelp2m/platforms: Rename macro.go to match module name ...................................................................... intelp2m/platforms: Rename macro.go to match module name Change-Id: I5eeb24d668a8d478720ecccf1522238e70dd8a71 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- R util/intelp2m/platforms/adl/adl.go R util/intelp2m/platforms/apl/apl.go R util/intelp2m/platforms/cnl/cnl.go R util/intelp2m/platforms/ebg/ebg.go R util/intelp2m/platforms/jsl/jsl.go R util/intelp2m/platforms/lbg/lbg.go R util/intelp2m/platforms/mtl/mtl.go R util/intelp2m/platforms/snr/snr.go R util/intelp2m/platforms/tgl/tgl.go 9 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/85770/1 diff --git a/util/intelp2m/platforms/adl/macro.go b/util/intelp2m/platforms/adl/adl.go similarity index 100% rename from util/intelp2m/platforms/adl/macro.go rename to util/intelp2m/platforms/adl/adl.go diff --git a/util/intelp2m/platforms/apl/macro.go b/util/intelp2m/platforms/apl/apl.go similarity index 100% rename from util/intelp2m/platforms/apl/macro.go rename to util/intelp2m/platforms/apl/apl.go diff --git a/util/intelp2m/platforms/cnl/macro.go b/util/intelp2m/platforms/cnl/cnl.go similarity index 100% rename from util/intelp2m/platforms/cnl/macro.go rename to util/intelp2m/platforms/cnl/cnl.go diff --git a/util/intelp2m/platforms/ebg/macro.go b/util/intelp2m/platforms/ebg/ebg.go similarity index 100% rename from util/intelp2m/platforms/ebg/macro.go rename to util/intelp2m/platforms/ebg/ebg.go diff --git a/util/intelp2m/platforms/jsl/macro.go b/util/intelp2m/platforms/jsl/jsl.go similarity index 100% rename from util/intelp2m/platforms/jsl/macro.go rename to util/intelp2m/platforms/jsl/jsl.go diff --git a/util/intelp2m/platforms/lbg/macro.go b/util/intelp2m/platforms/lbg/lbg.go similarity index 100% rename from util/intelp2m/platforms/lbg/macro.go rename to util/intelp2m/platforms/lbg/lbg.go diff --git a/util/intelp2m/platforms/mtl/macro.go b/util/intelp2m/platforms/mtl/mtl.go similarity index 100% rename from util/intelp2m/platforms/mtl/macro.go rename to util/intelp2m/platforms/mtl/mtl.go diff --git a/util/intelp2m/platforms/snr/macro.go b/util/intelp2m/platforms/snr/snr.go similarity index 100% rename from util/intelp2m/platforms/snr/macro.go rename to util/intelp2m/platforms/snr/snr.go diff --git a/util/intelp2m/platforms/tgl/macro.go b/util/intelp2m/platforms/tgl/tgl.go similarity index 100% rename from util/intelp2m/platforms/tgl/macro.go rename to util/intelp2m/platforms/tgl/tgl.go -- To view, visit https://review.coreboot.org/c/coreboot/+/85770?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5eeb24d668a8d478720ecccf1522238e70dd8a71 Gerrit-Change-Number: 85770 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>

1 0

[L] Change in coreboot[main]: util/intelp2m: Provide GPP group slice from each platform
by Maxim (Code Review) 25 Dec '24

25 Dec '24

Maxim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85769?usp=email ) Change subject: util/intelp2m: Provide GPP group slice from each platform ...................................................................... util/intelp2m: Provide GPP group slice from each platform Instead of a pointer to a function for analyzing the pad name, provide GPP group slice with pad names to the parser. This will get rid of some functions and files and make the code cleaner. TEST: - 'make test' = PASS; - 'intelp2m -file parser/testlog/inteltool_test.log' = no errors. Change-Id: I0d7818d3892450a37bffbf1ffd9524888e4675bf Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/intelp2m/parser/parser.go M util/intelp2m/platforms/adl/macro.go D util/intelp2m/platforms/adl/template.go M util/intelp2m/platforms/apl/macro.go D util/intelp2m/platforms/apl/template.go M util/intelp2m/platforms/cnl/macro.go D util/intelp2m/platforms/cnl/template.go D util/intelp2m/platforms/common/template.go M util/intelp2m/platforms/ebg/macro.go D util/intelp2m/platforms/ebg/template.go M util/intelp2m/platforms/jsl/macro.go D util/intelp2m/platforms/jsl/template.go M util/intelp2m/platforms/lbg/macro.go D util/intelp2m/platforms/lbg/template.go M util/intelp2m/platforms/mtl/macro.go D util/intelp2m/platforms/mtl/template.go M util/intelp2m/platforms/platforms.go M util/intelp2m/platforms/snr/macro.go D util/intelp2m/platforms/snr/template.go M util/intelp2m/platforms/tgl/macro.go D util/intelp2m/platforms/tgl/template.go 21 files changed, 92 insertions(+), 173 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/85769/1 diff --git a/util/intelp2m/parser/parser.go b/util/intelp2m/parser/parser.go index 8e0d7c0..050c679 100644 --- a/util/intelp2m/parser/parser.go +++ b/util/intelp2m/parser/parser.go @@ -83,15 +83,25 @@ return group } +// checkGPPG() checks whether the desired group is present in the string +func checkKeywords(line string, slice []string) bool { + for _, key := range slice { + if strings.Contains(line, key) { + return true + } + } + return false +} + // Extract() extracts pad information from a string func Extract(line string) Entry { - if included, _ := common.KeywordsCheck(line, "GPIO Community", "GPIO Group"); included { + if checkKeywords(line, []string{"GPIO Community", "GPIO Group"}) { return extractGroup(line) } - if checkKeyword := platforms.GetKeywordChekingAction(); checkKeyword == nil { - logs.Errorf("information extraction error: skip line <%s>", line) + if gppg, err := platforms.GetGPPGroups(); err != nil { + logs.Errorf("extract error: %v: skip line <%s>", err, line) return Entry{EType: EntryEmpty} - } else if checkKeyword(line) { + } else if checkKeywords(line, gppg) { pad, err := extractPad(line) if err != nil { logs.Errorf("extract pad info from %s: %v", line, err) diff --git a/util/intelp2m/platforms/adl/macro.go b/util/intelp2m/platforms/adl/macro.go index a7a7362..e66a827 100644 --- a/util/intelp2m/platforms/adl/macro.go +++ b/util/intelp2m/platforms/adl/macro.go @@ -14,6 +14,11 @@ DW1Mask uint32 = 0b11111101111111111100001111111111 ) +// "GPP_A", "GPP_B", "GPP_C", "GPP_D", "GPP_E", "GPP_F", "GPP_G", +// "GPP_H", "GPP_I", "GPP_J", "GPP_K", "GPP_R", "GPP_S", "GPP_T", +// "GPD", "VGPIO_USB", "VGPIO_PCIE" +var GPPGroups = []string{"GPP_", "GPD", "VGPIO"} + var remapping = common.ResetSources{ 0b00: bits.RstCfgRSMRST << bits.DW0PadRstCfg, 0b01: bits.RstCfgDEEP << bits.DW0PadRstCfg, diff --git a/util/intelp2m/platforms/adl/template.go b/util/intelp2m/platforms/adl/template.go deleted file mode 100644 index 4af499d..0000000 --- a/util/intelp2m/platforms/adl/template.go +++ /dev/null @@ -1,13 +0,0 @@ -package adl - -import "review.coreboot.org/coreboot.git/util/intelp2m/platforms/common" - -// CheckKeyword() parses lines of the configuration file and returns true if the keyword is -// contained in the line -// "GPP_A", "GPP_B", "GPP_C", "GPP_D", "GPP_E", "GPP_F", "GPP_G", -// "GPP_H", "GPP_I", "GPP_J", "GPP_K", "GPP_R", "GPP_S", "GPP_T", -// "GPD", "VGPIO_USB", "VGPIO_PCIE" -func CheckKeyword(line string) bool { - isIncluded, _ := common.KeywordsCheck(line, "GPP_", "GPD", "VGPIO") - return isIncluded -} diff --git a/util/intelp2m/platforms/apl/macro.go b/util/intelp2m/platforms/apl/macro.go index 614d0be..103d602 100644 --- a/util/intelp2m/platforms/apl/macro.go +++ b/util/intelp2m/platforms/apl/macro.go @@ -12,6 +12,18 @@ DW1Mask uint32 = 0b11111111111111000000000011111111 ) +var GPPGroups = []string{ + "GPIO_", "TCK", "TRST_B", "TMS", "TDI", "CX_PMODE", "CX_PREQ_B", "JTAGX", "CX_PRDY_B", + "TDO", "CNV_BRI_DT", "CNV_BRI_RSP", "CNV_RGI_DT", "CNV_RGI_RSP", "SVID0_ALERT_B", + "SVID0_DATA", "SVID0_CLK", "PMC_SPI_FS", "PMC_SPI_RXD", "PMC_SPI_TXD", "PMC_SPI_CLK", + "PMIC_PWRGOOD", "PMIC_RESET_B", "PMIC_THERMTRIP_B", "PMIC_STDBY", "PROCHOT_B", + "PMIC_I2C_SCL", "PMIC_I2C_SDA", "FST_SPI_CLK_FB", "OSC_CLK_OUT_", "PMU_AC_PRESENT", + "PMU_BATLOW_B", "PMU_PLTRST_B", "PMU_PWRBTN_B", "PMU_RESETBUTTON_B", "PMU_SLP_S0_B", + "PMU_SLP_S3_B", "PMU_SLP_S4_B", "PMU_SUSCLK", "PMU_WAKE_B", "SUS_STAT_B", "SUSPWRDNACK", + "SMB_ALERTB", "SMB_CLK", "SMB_DATA", "LPC_ILB_SERIRQ", "LPC_CLKOUT", "LPC_AD", "LPC_CLKRUNB", + "LPC_FRAMEB", +} + type BasePlatform struct { common.BasePlatform } diff --git a/util/intelp2m/platforms/apl/template.go b/util/intelp2m/platforms/apl/template.go deleted file mode 100644 index 014431d..0000000 --- a/util/intelp2m/platforms/apl/template.go +++ /dev/null @@ -1,19 +0,0 @@ -package apl - -import "review.coreboot.org/coreboot.git/util/intelp2m/platforms/common" - -// CheckKeyword() parses lines of the configuration file and returns true if the keyword is -// contained in the line -func CheckKeyword(line string) bool { - isIncluded, _ := common.KeywordsCheck(line, - "GPIO_", "TCK", "TRST_B", "TMS", "TDI", "CX_PMODE", "CX_PREQ_B", "JTAGX", "CX_PRDY_B", - "TDO", "CNV_BRI_DT", "CNV_BRI_RSP", "CNV_RGI_DT", "CNV_RGI_RSP", "SVID0_ALERT_B", - "SVID0_DATA", "SVID0_CLK", "PMC_SPI_FS", "PMC_SPI_RXD", "PMC_SPI_TXD", "PMC_SPI_CLK", - "PMIC_PWRGOOD", "PMIC_RESET_B", "PMIC_THERMTRIP_B", "PMIC_STDBY", "PROCHOT_B", - "PMIC_I2C_SCL", "PMIC_I2C_SDA", "FST_SPI_CLK_FB", "OSC_CLK_OUT_", "PMU_AC_PRESENT", - "PMU_BATLOW_B", "PMU_PLTRST_B", "PMU_PWRBTN_B", "PMU_RESETBUTTON_B", "PMU_SLP_S0_B", - "PMU_SLP_S3_B", "PMU_SLP_S4_B", "PMU_SUSCLK", "PMU_WAKE_B", "SUS_STAT_B", "SUSPWRDNACK", - "SMB_ALERTB", "SMB_CLK", "SMB_DATA", "LPC_ILB_SERIRQ", "LPC_CLKOUT", "LPC_AD", "LPC_CLKRUNB", - "LPC_FRAMEB") - return isIncluded -} diff --git a/util/intelp2m/platforms/cnl/macro.go b/util/intelp2m/platforms/cnl/macro.go index dc54475..740c83b 100644 --- a/util/intelp2m/platforms/cnl/macro.go +++ b/util/intelp2m/platforms/cnl/macro.go @@ -15,6 +15,26 @@ DW1Mask uint32 = 0b11111101111111111100001111111111 ) +var GPPGroups = []string{ + "GPP_", "GPD", // "GPP_A", "GPP_B", "GPP_G", "GPP_D", "GPP_F", "GPP_H", "GPP_C", "GPP_E" + "I2S1_TXD", "CNV_BTEN", "CNV_GNEN", "CNV_WFEN", "CNV_WCEN", "vCNV_GNSS_HOST_WAKE_B", + "vSD3_CD_B", "CNV_BT_HOST_WAKE_B", "CNV_BT_IF_SELECT", "vCNV_BT_UART_TXD", + "vCNV_BT_UART_RXD", "vCNV_BT_UART_CTS_B", "vCNV_BT_UART_RTS_B", "vCNV_MFUART1_TXD", + "vCNV_MFUART1_RXD", "vCNV_MFUART1_CTS_B", "vCNV_MFUART1_RTS_B", "vCNV_GNSS_UART_TXD", + "vCNV_GNSS_UART_RXD", "vCNV_GNSS_UART_CTS_B", "vCNV_GNSS_UART_RTS_B", "vUART0_TXD", + "vUART0_RXD", "vUART0_CTS_B", "vUART0_RTS_B", "vISH_UART0_TXD", "vISH_UART0_RXD", + "vISH_UART0_CTS_B", "vISH_UART0_RTS_B", "vISH_UART1_TXD", "vISH_UART1_RXD", + "vISH_UART1_CTS_B", "vISH_UART1_RTS_B", "vCNV_BT_I2S_BCLK", "vCNV_BT_I2S_WS_SYNC", + "vCNV_BT_I2S_SDO", "vCNV_BT_I2S_SDI", "vSSP2_SCLK", "vSSP2_SFRM", "vSSP2_TXD", + "vSSP2_RXD", "SLP_LAN_B", "SLP_SUS_B", "WAKE_B", "DRAM_RESET_B", "SPI0_IO_2", + "SPI0_IO_3", "SPI0_MISO", "SPI0_MOSI", "SPI0_CS2_B", "SPI0_CS0_B", "SPI0_CS1_B", + "SPI0_CLK", "SPI0_CLK_LOOPBK", "HDACPU_SDI", "HDACPU_SDO", "HDACPU_SCLK", "PM_SYNC", + "PECI", "CPUPWRGD", "THRMTRIP_B", "PLTRST_CPU_B", "PM_DOWN", "TRIGGER_IN", + "TRIGGER_OUT", "PCH_TDO", "PCH_JTAGX", "PROC_PRDY_B", "PROC_PREQ_B", "CPU_TRST_B", + "PCH_TDI", "PCH_TMS", "PCH_TCK", "ITP_PMODE", "SYS_PWROK", "SYS_RESET_B", "CL_RST_B", + "HDA_BCLK", "HDA_RST_B", "HDA_SYNC", "HDA_SDO", "HDA_SDI0", "HDA_SDI1", "I2S1_SFRM", +} + var remapping = common.ResetSources{ 0b00: bits.RstCfgRSMRST << bits.DW0PadRstCfg, 0b01: bits.RstCfgDEEP << bits.DW0PadRstCfg, diff --git a/util/intelp2m/platforms/cnl/template.go b/util/intelp2m/platforms/cnl/template.go deleted file mode 100644 index f1bb525..0000000 --- a/util/intelp2m/platforms/cnl/template.go +++ /dev/null @@ -1,25 +0,0 @@ -package cnl - -import "review.coreboot.org/coreboot.git/util/intelp2m/platforms/common" - -func CheckKeyword(line string) bool { - // "GPP_" : "GPP_A", "GPP_B", "GPP_G", "GPP_D", "GPP_F", "GPP_H", "GPP_C", "GPP_E" - included, _ := common.KeywordsCheck(line, "GPP_", "GPD", - "I2S1_TXD", "CNV_BTEN", "CNV_GNEN", "CNV_WFEN", "CNV_WCEN", "vCNV_GNSS_HOST_WAKE_B", - "vSD3_CD_B", "CNV_BT_HOST_WAKE_B", "CNV_BT_IF_SELECT", "vCNV_BT_UART_TXD", - "vCNV_BT_UART_RXD", "vCNV_BT_UART_CTS_B", "vCNV_BT_UART_RTS_B", "vCNV_MFUART1_TXD", - "vCNV_MFUART1_RXD", "vCNV_MFUART1_CTS_B", "vCNV_MFUART1_RTS_B", "vCNV_GNSS_UART_TXD", - "vCNV_GNSS_UART_RXD", "vCNV_GNSS_UART_CTS_B", "vCNV_GNSS_UART_RTS_B", "vUART0_TXD", - "vUART0_RXD", "vUART0_CTS_B", "vUART0_RTS_B", "vISH_UART0_TXD", "vISH_UART0_RXD", - "vISH_UART0_CTS_B", "vISH_UART0_RTS_B", "vISH_UART1_TXD", "vISH_UART1_RXD", - "vISH_UART1_CTS_B", "vISH_UART1_RTS_B", "vCNV_BT_I2S_BCLK", "vCNV_BT_I2S_WS_SYNC", - "vCNV_BT_I2S_SDO", "vCNV_BT_I2S_SDI", "vSSP2_SCLK", "vSSP2_SFRM", "vSSP2_TXD", - "vSSP2_RXD", "SLP_LAN_B", "SLP_SUS_B", "WAKE_B", "DRAM_RESET_B", "SPI0_IO_2", - "SPI0_IO_3", "SPI0_MISO", "SPI0_MOSI", "SPI0_CS2_B", "SPI0_CS0_B", "SPI0_CS1_B", - "SPI0_CLK", "SPI0_CLK_LOOPBK", "HDACPU_SDI", "HDACPU_SDO", "HDACPU_SCLK", "PM_SYNC", - "PECI", "CPUPWRGD", "THRMTRIP_B", "PLTRST_CPU_B", "PM_DOWN", "TRIGGER_IN", - "TRIGGER_OUT", "PCH_TDO", "PCH_JTAGX", "PROC_PRDY_B", "PROC_PREQ_B", "CPU_TRST_B", - "PCH_TDI", "PCH_TMS", "PCH_TCK", "ITP_PMODE", "SYS_PWROK", "SYS_RESET_B", "CL_RST_B", - "HDA_BCLK", "HDA_RST_B", "HDA_SYNC", "HDA_SDO", "HDA_SDI0", "HDA_SDI1", "I2S1_SFRM") - return included -} diff --git a/util/intelp2m/platforms/common/template.go b/util/intelp2m/platforms/common/template.go deleted file mode 100644 index 296f169..0000000 --- a/util/intelp2m/platforms/common/template.go +++ /dev/null @@ -1,15 +0,0 @@ -package common - -import "strings" - -// KeywordsCheck - check if one of the keyword from the <keywords> group is included in the -// <line> string. Returns false if no word was found, or true otherwise and also this word -// itself -func KeywordsCheck(line string, keywords ...string) (bool, string) { - for _, key := range keywords { - if strings.Contains(line, key) { - return true, key - } - } - return false, "" -} diff --git a/util/intelp2m/platforms/ebg/macro.go b/util/intelp2m/platforms/ebg/macro.go index e05d06d..05710d1 100644 --- a/util/intelp2m/platforms/ebg/macro.go +++ b/util/intelp2m/platforms/ebg/macro.go @@ -12,6 +12,10 @@ DW1Mask = 0b11111101111111111100001111111111 ) +// "GPPC_A", "GPPC_B", "GPPC_S", "GPPC_C", "GPP_D", "GPP_E", "GPPC_H", "GPP_J", "GPP_I", +// "GPP_L", "GPP_M", "GPP_N" +var GPPGroups = []string{"GPP_", "GPPC_"} + var remapping = common.ResetSources{ 0b00: bits.RstCfgRSMRST << bits.DW0PadRstCfg, 0b01: bits.RstCfgDEEP << bits.DW0PadRstCfg, diff --git a/util/intelp2m/platforms/ebg/template.go b/util/intelp2m/platforms/ebg/template.go deleted file mode 100644 index 451bd5d..0000000 --- a/util/intelp2m/platforms/ebg/template.go +++ /dev/null @@ -1,14 +0,0 @@ -package ebg - -import "review.coreboot.org/coreboot.git/util/intelp2m/platforms/common" - -// Group : "GPPC_A", "GPPC_B", "GPPC_S", "GPPC_C", "GPP_D", "GPP_E", "GPPC_H", "GPP_J", -// "GPP_I", "GPP_L", "GPP_M", "GPP_N" - -// CheckKeyword - This function is used to filter parsed lines of the configuration file and -// returns true if the keyword is contained in the line. -// line : string from the configuration file -func CheckKeyword(line string) bool { - isIncluded, _ := common.KeywordsCheck(line, "GPP_", "GPPC_") - return isIncluded -} diff --git a/util/intelp2m/platforms/jsl/macro.go b/util/intelp2m/platforms/jsl/macro.go index 7a64274..a7565e0 100644 --- a/util/intelp2m/platforms/jsl/macro.go +++ b/util/intelp2m/platforms/jsl/macro.go @@ -14,6 +14,10 @@ DW1Mask = 0b11111101111111111100001111111111 ) +// "GPP_A", "GPP_B", "GPP_C", "GPP_D", "GPP_E", "GPP_F", "GPP_G", "GPP_H", "GPP_R", "GPP_S", +// "GPP_T", "GPD", "HVMOS", "VGPIO5" +var GPPGroups = []string{"GPP_", "GPD", "VGPIO"} + var remapping = common.ResetSources{ 0b00: bits.RstCfgRSMRST << bits.DW0PadRstCfg, 0b01: bits.RstCfgDEEP << bits.DW0PadRstCfg, diff --git a/util/intelp2m/platforms/jsl/template.go b/util/intelp2m/platforms/jsl/template.go deleted file mode 100644 index acf6a5a..0000000 --- a/util/intelp2m/platforms/jsl/template.go +++ /dev/null @@ -1,14 +0,0 @@ -package jsl - -import "review.coreboot.org/coreboot.git/util/intelp2m/platforms/common" - -// Group : "GPP_A", "GPP_B", "GPP_C", "GPP_D", "GPP_E", "GPP_F", "GPP_G", "GPP_H", "GPP_R", -// "GPP_S", "GPP_T", "GPD", "HVMOS", "VGPIO5" - -// CheckKeyword - This function is used to filter parsed lines of the configuration file and -// returns true if the keyword is contained in the line. -// line : string from the configuration file -func CheckKeyword(line string) bool { - isIncluded, _ := common.KeywordsCheck(line, "GPP_", "GPD", "VGPIO") - return isIncluded -} diff --git a/util/intelp2m/platforms/lbg/macro.go b/util/intelp2m/platforms/lbg/macro.go index dc0ce26..4b3dc7e 100644 --- a/util/intelp2m/platforms/lbg/macro.go +++ b/util/intelp2m/platforms/lbg/macro.go @@ -12,6 +12,10 @@ DW1Mask uint32 = 0b11111101111111111100001111111111 ) +// "GPP_A", "GPP_B", "GPP_F", "GPP_C", "GPP_D", "GPP_E", "GPD", "GPP_I", "GPP_J", "GPP_K", +// "GPP_G", "GPP_H", "GPP_L" +var GPPGroups = []string{"GPP_", "GPD"} + var remapping = common.ResetSources{ 0b00: bits.RstCfgRSMRST << bits.DW0PadRstCfg, 0b01: bits.RstCfgDEEP << bits.DW0PadRstCfg, diff --git a/util/intelp2m/platforms/lbg/template.go b/util/intelp2m/platforms/lbg/template.go deleted file mode 100644 index f460085..0000000 --- a/util/intelp2m/platforms/lbg/template.go +++ /dev/null @@ -1,12 +0,0 @@ -package lbg - -import "review.coreboot.org/coreboot.git/util/intelp2m/platforms/common" - -// CheckKeyword() parses lines of the configuration file and returns true if the keyword is -// contained in the line -// "GPP_A", "GPP_B", "GPP_F", "GPP_C", "GPP_D", "GPP_E", "GPD", "GPP_I", "GPP_J", -// "GPP_K", "GPP_G", "GPP_H", "GPP_L" -func CheckKeyword(line string) bool { - included, _ := common.KeywordsCheck(line, "GPP_", "GPD") - return included -} diff --git a/util/intelp2m/platforms/mtl/macro.go b/util/intelp2m/platforms/mtl/macro.go index 89bd629..d1ee56a 100644 --- a/util/intelp2m/platforms/mtl/macro.go +++ b/util/intelp2m/platforms/mtl/macro.go @@ -14,6 +14,10 @@ DW1Mask = 0b11111101111111111100001111111111 ) +// "GPP_V", "GPP_C", "GPP_A", "GPP_E", "GPP_H", "GPP_F", "GPP_S", "GPP_B", "GPP_D", "GPD", +// "VGPIO_USB", "VGPIO_PCIE" +var GPPGroups = []string{"GPP_", "GPD", "VGPIO"} + var remapping = common.ResetSources{ 0b00: bits.RstCfgRSMRST << bits.DW0PadRstCfg, 0b01: bits.RstCfgDEEP << bits.DW0PadRstCfg, diff --git a/util/intelp2m/platforms/mtl/template.go b/util/intelp2m/platforms/mtl/template.go deleted file mode 100644 index 27951fe..0000000 --- a/util/intelp2m/platforms/mtl/template.go +++ /dev/null @@ -1,14 +0,0 @@ -package mtl - -import "review.coreboot.org/coreboot.git/util/intelp2m/platforms/common" - -// Group : "GPP_V", "GPP_C", "GPP_A", "GPP_E", "GPP_H", "GPP_F", "GPP_S", "GPP_B", "GPP_D", -// "GPD", "VGPIO_USB", "VGPIO_PCIE" - -// CheckKeyword - This function is used to filter parsed lines of the configuration file and -// returns true if the keyword is contained in the line. -// line : string from the configuration file -func CheckKeyword(line string) bool { - isIncluded, _ := common.KeywordsCheck(line, "GPP_", "GPD", "VGPIO") - return isIncluded -} diff --git a/util/intelp2m/platforms/platforms.go b/util/intelp2m/platforms/platforms.go index b77e910..89ac548 100644 --- a/util/intelp2m/platforms/platforms.go +++ b/util/intelp2m/platforms/platforms.go @@ -1,6 +1,8 @@ package platforms import ( + "fmt" + "review.coreboot.org/coreboot.git/util/intelp2m/config/p2m" "review.coreboot.org/coreboot.git/util/intelp2m/logs" "review.coreboot.org/coreboot.git/util/intelp2m/platforms/adl" @@ -15,26 +17,24 @@ "review.coreboot.org/coreboot.git/util/intelp2m/platforms/tgl" ) -type KeywordAction func(line string) bool +var GppMap = map[p2m.PlatformType][]string{ + p2m.Alder: adl.GPPGroups, + p2m.Apollo: apl.GPPGroups, + p2m.Cannon: cnl.GPPGroups, + p2m.Sunrise: snr.GPPGroups, + p2m.Tiger: tgl.GPPGroups, + p2m.Jasper: jsl.GPPGroups, + p2m.Meteor: mtl.GPPGroups, + p2m.Emmitsburg: ebg.GPPGroups, + p2m.Lewisburg: lbg.GPPGroups, +} -func GetKeywordChekingAction() KeywordAction { - actions := map[p2m.PlatformType]KeywordAction{ - p2m.Alder: adl.CheckKeyword, - p2m.Apollo: apl.CheckKeyword, - p2m.Cannon: cnl.CheckKeyword, - p2m.Sunrise: snr.CheckKeyword, - p2m.Tiger: tgl.CheckKeyword, - p2m.Jasper: jsl.CheckKeyword, - p2m.Meteor: mtl.CheckKeyword, - p2m.Emmitsburg: ebg.CheckKeyword, - p2m.Lewisburg: lbg.CheckKeyword, - } - action, exist := actions[p2m.Config.Platform] +func GetGPPGroups() ([]string, error) { + groups, exist := GppMap[p2m.Config.Platform] if !exist { - logs.Errorf("unregistered platform type %d", p2m.Config.Platform) - return nil + return nil, fmt.Errorf("unregistered platform type %d", p2m.Config.Platform) } - return action + return groups, nil } func Get(dw0, dw1 uint32) common.PlatformIf { diff --git a/util/intelp2m/platforms/snr/macro.go b/util/intelp2m/platforms/snr/macro.go index 110225b..47c06bc 100644 --- a/util/intelp2m/platforms/snr/macro.go +++ b/util/intelp2m/platforms/snr/macro.go @@ -14,6 +14,10 @@ DW1Mask uint32 = 0b11111101111111111100001111111111 ) +// "GPP_A", "GPP_B", "GPP_F", "GPP_C", "GPP_D", "GPP_E", "GPD", "GPP_I", "GPP_J", "GPP_G", +// "GPP_H", "GPP_L" +var GPPGroups = []string{"GPP_", "GPD"} + var remapping = common.ResetSources{ 0b00: bits.RstCfgRSMRST << bits.DW0PadRstCfg, 0b01: bits.RstCfgDEEP << bits.DW0PadRstCfg, diff --git a/util/intelp2m/platforms/snr/template.go b/util/intelp2m/platforms/snr/template.go deleted file mode 100644 index 22f477e..0000000 --- a/util/intelp2m/platforms/snr/template.go +++ /dev/null @@ -1,12 +0,0 @@ -package snr - -import "review.coreboot.org/coreboot.git/util/intelp2m/platforms/common" - -// CheckKeyword() parses lines of the configuration file and returns true if the keyword is -// contained in the line -// "GPP_A", "GPP_B", "GPP_F", "GPP_C", "GPP_D", "GPP_E", "GPD", "GPP_I", "GPP_J", -// "GPP_K", "GPP_G", "GPP_H", "GPP_L" -func CheckKeyword(line string) bool { - included, _ := common.KeywordsCheck(line, "GPP_", "GPD") - return included -} diff --git a/util/intelp2m/platforms/tgl/macro.go b/util/intelp2m/platforms/tgl/macro.go index d558cb4..28212d5 100644 --- a/util/intelp2m/platforms/tgl/macro.go +++ b/util/intelp2m/platforms/tgl/macro.go @@ -14,6 +14,10 @@ DW1Mask = 0b11111101111111111100001111111111 ) +// "GPP_A", "GPP_R", "GPP_B", "GPP_D", "GPP_C", "GPP_S", "GPP_G", "GPD", "GPP_E", "GPP_F", +// "GPP_H", "GPP_J", "GPP_K", "GPP_I", "VGPIO_USB", "VGPIO_PCIE" +var GPPGroups = []string{"GPP_", "GPD", "VGPIO"} + var remapping = common.ResetSources{ 0b00: bits.RstCfgRSMRST << bits.DW0PadRstCfg, 0b01: bits.RstCfgDEEP << bits.DW0PadRstCfg, diff --git a/util/intelp2m/platforms/tgl/template.go b/util/intelp2m/platforms/tgl/template.go deleted file mode 100644 index f6a0bcd..0000000 --- a/util/intelp2m/platforms/tgl/template.go +++ /dev/null @@ -1,14 +0,0 @@ -package tgl - -import "review.coreboot.org/coreboot.git/util/intelp2m/platforms/common" - -// Group : "GPP_A", "GPP_R", "GPP_B", "GPP_D", "GPP_C", "GPP_S", "GPP_G", "GPD", "GPP_E", -// "GPP_F", "GPP_H", "GPP_J", "GPP_K", "GPP_I", "VGPIO_USB", "VGPIO_PCIE" - -// CheckKeyword - This function is used to filter parsed lines of the configuration file -// and returns true if the keyword is contained in the line. -// line : string from the configuration file -func CheckKeyword(line string) bool { - isIncluded, _ := common.KeywordsCheck(line, "GPP_", "GPD", "VGPIO") - return isIncluded -} -- To view, visit https://review.coreboot.org/c/coreboot/+/85769?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0d7818d3892450a37bffbf1ffd9524888e4675bf Gerrit-Change-Number: 85769 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>

1 0

[M] Change in coreboot[main]: util/intelp2m/platforms: Add support for Elkhart Lake
by Maxim (Code Review) 25 Dec '24

25 Dec '24

Attention is currently required from: Alexander Couzens. Maxim has uploaded a new patch set (#6) to the change originally created by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/84191?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/intelp2m/platforms: Add support for Elkhart Lake ...................................................................... util/intelp2m/platforms: Add support for Elkhart Lake TEST: - 'make test' = PASS; - 'intelp2m -p ehl -file parser/testlog/inteltool_test.log' = no errors. Change-Id: I0f60d182bc5cc3d0d1d1177fbda0cfe8e2279e46 Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M Documentation/util/intelp2m/index.md M util/intelp2m/cli/options.go M util/intelp2m/config/p2m/config.go A util/intelp2m/platforms/ehl/ehl.go A util/intelp2m/platforms/ehl/ehl_test.go M util/intelp2m/platforms/platforms.go 6 files changed, 166 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/84191/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/84191?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f60d182bc5cc3d0d1d1177fbda0cfe8e2279e46 Gerrit-Change-Number: 84191 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024