Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85360?usp=email )
Change subject: mb/google/rauru: Add 2nd source tas2563 amps to support beep
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85360/comment/0b46fa71_2602723c?us… :
PS3, Line 12: 357969183
b:357969183
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85360/comment/327649da_cb2fd6f4?us… :
PS3, Line 31: printk(BIOS_INFO, "Audio configure.\n");
Move to the end of the function. and print
```
printk(BIOS_INFO, "%s: done\n", __func__);
```
https://review.coreboot.org/c/coreboot/+/85360/comment/a55f1cc2_ba5afb21?us… :
PS3, Line 33: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_NAU8318))) {
: return;
: } else
Just remove.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85360?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I10cba7964d3847f2a74341b3130ff1e7bfd8d37a
Gerrit-Change-Number: 85360
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Darren Ye <darren.ye(a)mediatek.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Mon, 02 Dec 2024 06:46:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85361?usp=email )
Change subject: soc/meidatek/mt8196: Add audio base address definition
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85361/comment/d5ffc809_f8918d02?us… :
PS3, Line 9: Add audio base address definition
Missing `.` at the end
--
To view, visit https://review.coreboot.org/c/coreboot/+/85361?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07d272fddfe50e73adc6f4c7d401f3391b0c145d
Gerrit-Change-Number: 85361
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Mon, 02 Dec 2024 06:43:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85361?usp=email )
Change subject: soc/meidatek/mt8196: Add audio base address definition
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
> Wrong patch order.
Please fix it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85361?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07d272fddfe50e73adc6f4c7d401f3391b0c145d
Gerrit-Change-Number: 85361
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Mon, 02 Dec 2024 06:43:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85360?usp=email )
Change subject: mb/google/rauru: Add 2nd source tas2563 amps to support beep
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85360/comment/b040b542_50057ea5?us… :
PS3, Line 7: tas
TAS
https://review.coreboot.org/c/coreboot/+/85360/comment/b7621f0f_8fe3682b?us… :
PS3, Line 9: Set 2nd source used i2s and i2c interface
Derive the audio amplifier from FW_CONFIG, and set up I2C and I2S for TAS2563. Also pass the corresponding GPIO(s) to the payload.
File src/mainboard/google/rauru/chromeos.c:
https://review.coreboot.org/c/coreboot/+/85360/comment/38c10938_39059ba8?us… :
PS3, Line 49: {
remove
--
To view, visit https://review.coreboot.org/c/coreboot/+/85360?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I10cba7964d3847f2a74341b3130ff1e7bfd8d37a
Gerrit-Change-Number: 85360
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Darren Ye <darren.ye(a)mediatek.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Mon, 02 Dec 2024 06:43:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No