Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85774?usp=email )
Change subject: soc/mediatek/mt8196: Add dynamic power-saving for peripheral clocks
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/85774/comment/70ed2d4e_82e300a2?us… :
PS3, Line 20:
> Please send a separate patch to fix the indent.
OK, please check 85801. thanks
--
To view, visit https://review.coreboot.org/c/coreboot/+/85774?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70f710f068d7d882037691930a90c83adaab15d2
Gerrit-Change-Number: 85774
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 30 Dec 2024 08:42:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Joel Bueno has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85800?usp=email )
Change subject: mb/emulation/spike-riscv: Define default DRAM_SIZE to avoid crash when probing memory
......................................................................
mb/emulation/spike-riscv: Define default DRAM_SIZE to avoid crash when probing memory
For RISC-V emulated targets (using SOC_UCB_RISCV), the top of memory is calculated in
cbmem_top_chipset() by calling probe_ramsize() with a size of CONFIG_DRAM_SIZE_MB.
This causes an access fault when the size is set to zero, which is the case for Spike.
This does not happen on qemu because, for that target, we parse the FDT instead of manually probing memory.
TEST=boot verified on SPIKE-RISCV
Fixes: 2fa8caba507a ("lib/ramdetect: Limit probe size to function argument") on SPIKE-RISCV
Change-Id: I567103bcd956b10fab64c5e63018315924ec0d2b
Signed-off-by: joel.bueno <joel.bueno(a)openchip.com>
---
M src/mainboard/emulation/spike-riscv/Kconfig
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/85800/1
diff --git a/src/mainboard/emulation/spike-riscv/Kconfig b/src/mainboard/emulation/spike-riscv/Kconfig
index 5160125..7bf7ed0 100644
--- a/src/mainboard/emulation/spike-riscv/Kconfig
+++ b/src/mainboard/emulation/spike-riscv/Kconfig
@@ -25,4 +25,8 @@
int
default 1
+config DRAM_SIZE_MB
+ int
+ default 1024
+
endif # BOARD_EMULATION_SPIKE_RISCV
--
To view, visit https://review.coreboot.org/c/coreboot/+/85800?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I567103bcd956b10fab64c5e63018315924ec0d2b
Gerrit-Change-Number: 85800
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Bueno <joel.bueno(a)openchip.com>
Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Rui Zhou.
Eric Lai has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85798?usp=email )
Change subject: mb/google/nissa/var/rull: Configure Acoustic noise mitigation
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85798?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib7f60f1248c6b46f4f9bac1731be4f0396766ae2
Gerrit-Change-Number: 85798
Gerrit-PatchSet: 1
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 30 Dec 2024 07:53:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85751?usp=email )
Change subject: soc/mediatek/mt8196: Set SPMI-P SCL/SDA SoC PD
......................................................................
Patch Set 8:
(1 comment)
File src/soc/mediatek/mt8196/pmif_spmi.c:
https://review.coreboot.org/c/coreboot/+/85751/comment/72fee0c0_e44d9a38?us… :
PS1, Line 177: if (dev->slvid == SPMI_SLAVE_6) {
: setbits32p(SPMI_SCL_P_PD_ADDR,
: BIT(SPMI_SCL_P_PD_OFFSET) | BIT(SPMI_SDA_P_PD_OFFSET));
: printk(BIOS_INFO, "%s, Set SoC PD for SPMI-P SCL/SDA, [0x%x] = 0x%x\n",
: __func__, SPMI_SCL_P_PD_ADDR, read32p(SPMI_SCL_P_PD_ADDR));
: }
> If so, we can do that in `pmif_spmi_iocfg`. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85751?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idbf8ed8e31850ca81c823db1b25bde4a83a48c4f
Gerrit-Change-Number: 85751
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Mon, 30 Dec 2024 07:07:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Hello Hope Wang,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/coreboot/+/85799?usp=email
to review the following change.
Change subject: soc/mediatek/mt8196: Add delay in pmif_spmi.c
......................................................................
soc/mediatek/mt8196: Add delay in pmif_spmi.c
The initialization process of SPMI requires a certain amount of time
(0.5ms) to ensure all components are correctly configured and
synchronized. Otherwise, if the SPMI calibration fails, it will result
in the non-serial firmware failing to boot.
TEST=Build pass, non-serial firmware boot ok.
BUG=b:341054056
Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Change-Id: I63df384061e4ed2629238f1843decd18d1ad1ac4
Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
---
M src/soc/mediatek/mt8196/pmif_spmi.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/85799/1
diff --git a/src/soc/mediatek/mt8196/pmif_spmi.c b/src/soc/mediatek/mt8196/pmif_spmi.c
index 326c247..e780d2f 100644
--- a/src/soc/mediatek/mt8196/pmif_spmi.c
+++ b/src/soc/mediatek/mt8196/pmif_spmi.c
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only OR MIT */
#include <console/console.h>
+#include <delay.h>
#include <device/mmio.h>
#include <gpio.h>
#include <soc/addressmap.h>
@@ -285,6 +286,7 @@
{
write32(&arb->mtk_pmif->inf_en, PMIF_SPMI_SW_CHAN);
write32(&arb->mtk_pmif->arb_en, PMIF_SPMI_SW_CHAN);
+ udelay(500);
printk(BIOS_INFO, "%s done\n", __func__);
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/85799?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I63df384061e4ed2629238f1843decd18d1ad1ac4
Gerrit-Change-Number: 85799
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Hello Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85751?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/mediatek/mt8196: Set SPMI-P SCL/SDA SoC PD
......................................................................
soc/mediatek/mt8196: Set SPMI-P SCL/SDA SoC PD
Configure the SCL and SDA of the SPMI-P to Pull-Down mode on MT8196 SoC,
it is done only once during the SPMI read check to fix SPMI clock
calibration failure.
TEST=Build pass
BUG=b:361174333
Change-Id: Idbf8ed8e31850ca81c823db1b25bde4a83a48c4f
Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
---
M src/soc/mediatek/mt8196/pmif_spmi.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/85751/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/85751?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idbf8ed8e31850ca81c823db1b25bde4a83a48c4f
Gerrit-Change-Number: 85751
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>