Attention is currently required from: Marek Maślanka, Subrata Banik.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79909?usp=email )
Change subject: soc/intel/common/block: Add support for watchdog
......................................................................
Patch Set 9:
(3 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/79909/comment/1cda89ce_bc8b2c9a :
PS9, Line 405: wdat->min_count = 1;
Can we be sure this value is always correct? Is there a way to get this value from somewhere in TCO maybe?
https://review.coreboot.org/c/coreboot/+/79909/comment/253dfe35_46bf602f :
PS9, Line 406: tco_get_timer_max_value() * tco_get_timer_period() / 1000;
I think this code should be protected against overflow with u64 used for calculations before assigning.
https://review.coreboot.org/c/coreboot/+/79909/comment/da7b03f8_c2de7795 :
PS9, Line 443: entry->mask = 0x02;
Why is set mask different from get mask above?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79909?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf7971f8407920a553fd91d2ed04193c882e08f1
Gerrit-Change-Number: 79909
Gerrit-PatchSet: 9
Gerrit-Owner: Marek Maślanka <mmaslanka(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marek Maślanka <mmaslanka(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Thu, 25 Jan 2024 13:28:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Morris Hsu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79831?usp=email )
Change subject: mb/google/dedede/var/metaknight:Add fw_config probe for multi codec and amplifier
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79831/comment/fc6b7fc6_35036e76 :
PS6, Line 7: mb/google/dedede/var/metaknight:Add
Please add a space after the colon.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79831?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f212f063a1180d7a1c14769f61b0afef7565cad
Gerrit-Change-Number: 79831
Gerrit-PatchSet: 6
Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 25 Jan 2024 12:55:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ruihai Zhou.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80086?usp=email )
Change subject: drivers/mipi: Fine tune VFP, CLK and init code for IVO_T109NW41 panel
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80086/comment/42e504f0_a4030525 :
PS2, Line 12: Fixes: 520137f("drivers/mipi: Add support for IVO_T109NW41 panel")
Please add a space before the ('
--
To view, visit https://review.coreboot.org/c/coreboot/+/80086?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4d7c7bd4d79301fbb6d555117d190c358bceafcc
Gerrit-Change-Number: 80086
Gerrit-PatchSet: 2
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 25 Jan 2024 12:54:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Derek Huang, Eric Lai, Ivan Chen, Jamie Chen, Kapil Porwal, Nick Vaccaro.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80152?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya/var/omniknight: Add WIFI SAR table
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/brya/variants/omnigul/variant.c:
https://review.coreboot.org/c/coreboot/+/80152/comment/2e647041_4a25fb54 :
PS10, Line 11: _1
Could we get better names, than just adding numbers?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80152?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70e79577612b3d5c4dc0f92211f87cbea0532d5d
Gerrit-Change-Number: 80152
Gerrit-PatchSet: 10
Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Comment-Date: Thu, 25 Jan 2024 12:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80182?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/purism/librem_cnl: Set edk2 boot timeout for Librem Mini
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80182/comment/4e83a67d_67416fa8 :
PS1, Line 7: Set edk2 boot timeout for Librem Mini
Maybe more specific: Add 4 s edk2 boot timeout for Librem Mini
https://review.coreboot.org/c/coreboot/+/80182/comment/2f60ce21_209dc1c3 :
PS1, Line 9: display init
Is that dependent on the connected monitor?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80182?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9d2d514719a9918ee58cc63969b3adae44ac1632
Gerrit-Change-Number: 80182
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Thu, 25 Jan 2024 12:53:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Varshit Pandya.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80204?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/amd/onyx_poc: Add and use APCB configuration data
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80204/comment/1767e719_b2879c40 :
PS2, Line 9: This patch replaces [76445](https://review.coreboot.org/c/blobs/+/76445)
This could go to the end. Maybe also name it change-set ….
https://review.coreboot.org/c/coreboot/+/80204/comment/c1007e58_17983f33 :
PS2, Line 10: It brings onyx_poc in-line with skyrim, guybrush and zork.
Please elaborate? What does that mean?
How are the APCB created? What do the different names mean?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80204?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c34528fa0fd15b847c22c995713078c60ac3873
Gerrit-Change-Number: 80204
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Thu, 25 Jan 2024 12:13:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Held.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80203?usp=email )
Change subject: vc/amd/opensil/genoa_poc/opensil_console: fix host debug print function
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80203?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia931cc80dea5b7eabb75cfb19f8baa9a09cd2dbf
Gerrit-Change-Number: 80203
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 25 Jan 2024 11:35:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80203?usp=email )
Change subject: vc/amd/opensil/genoa_poc/opensil_console: fix host debug print function
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80203/comment/7f0af4ae_38cbcd57 :
PS1, Line 1: Parent: 204703db (vc/amd/opensil/genoa_poc/mpio: rename mpio_config to configure_mpio)
> i'll update the commit message
done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80203?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia931cc80dea5b7eabb75cfb19f8baa9a09cd2dbf
Gerrit-Change-Number: 80203
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Comment-Date: Thu, 25 Jan 2024 11:24:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit Pandya <pandyavarshit(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Varshit Pandya.
Hello Arthur Heymans, Varshit Pandya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80203?usp=email
to look at the new patch set (#2).
Change subject: vc/amd/opensil/genoa_poc/opensil_console: fix host debug print function
......................................................................
vc/amd/opensil/genoa_poc/opensil_console: fix host debug print function
Since we pass va_list list to the print function, we need to use vprintk
instead of printk. Earlier versions of this code used vsnprintf and a
local buffer, but when that code was reworked to not need the temporary
buffer, it was replaced by printk instead of the correct vprintk.
TEST=Now the console output from openSIL looks as expected:
Example line from openSIL's console output when it prints the MPIO
configuration from a log some commits before this patch:
Host PCI Address - -1352681400:-1353251983:7
Same line with this patch applied looks how it's supposed to:
Host PCI Address - 0:0:0
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Tested-by: Varshit Pandya <pandyavarshit(a)gmail.com>
Change-Id: Ia931cc80dea5b7eabb75cfb19f8baa9a09cd2dbf
---
M src/vendorcode/amd/opensil/genoa_poc/opensil_console.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/80203/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80203?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia931cc80dea5b7eabb75cfb19f8baa9a09cd2dbf
Gerrit-Change-Number: 80203
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Felix Held, Martin L Roth.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/76445?usp=email )
Change subject: mb/amd/onyx: Add 1P Genoa reference board APCB blobs
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> We've already added the google ABCBs to the coreboot mainboard as data.apcb files. […]
done, https://review.coreboot.org/c/coreboot/+/80204
I think this patch can be abandoned now
--
To view, visit https://review.coreboot.org/c/blobs/+/76445?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I0689dabd90e06190c3b3779675586d8220f7076a
Gerrit-Change-Number: 76445
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 25 Jan 2024 11:23:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit Pandya <pandyavarshit(a)gmail.com>
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment