coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[XS] Change in coreboot[main]: soc/intel/mtl: Override the `SOC_PHYSICAL_ADDRESS_WIDTH` as integer
by Subrata Banik (Code Review) 09 Jan '24

09 Jan '24

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79842?usp=email ) Change subject: soc/intel/mtl: Override the `SOC_PHYSICAL_ADDRESS_WIDTH` as integer ...................................................................... soc/intel/mtl: Override the `SOC_PHYSICAL_ADDRESS_WIDTH` as integer This patch enforces consistent override handling for integer `SOC_PHYSICAL_ADDRESS_WIDTH` config Change-Id: Ib5bdfdb8c2689803c9d3c2bfd353609edae91ab3 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79842 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jakub Czapiga <czapiga(a)google.com> --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jakub Czapiga: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index 5b78fdf..298bb83 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -466,6 +466,7 @@ and CSME update. config SOC_PHYSICAL_ADDRESS_WIDTH + int default 42 endif -- To view, visit https://review.coreboot.org/c/coreboot/+/79842?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib5bdfdb8c2689803c9d3c2bfd353609edae91ab3 Gerrit-Change-Number: 79842 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for IVO_T109NW41 panel
by Yu-Ping Wu (Code Review) 09 Jan '24

09 Jan '24

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79844?usp=email ) Change subject: drivers/mipi: Add support for IVO_T109NW41 panel ...................................................................... drivers/mipi: Add support for IVO_T109NW41 panel Add IVO_T109NW41 serializable data to CBFS. Datasheet: T109NW41 R0 Tentative Product Specification.docx BUG=b:319025360 TEST=build and check the CBFS include the panel BRANCH=None Change-Id: Id740e3a21f72bbcd6e5c2b56b31ac90f4990d475 Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79844 Reviewed-by: Yidi Lin <yidilin(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.inc A src/drivers/mipi/panel-IVO_T109NW41.c 3 files changed, 116 insertions(+), 0 deletions(-) Approvals: Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, approved cong yang: Looks good to me, but someone else must approve build bot (Jenkins): Verified diff --git a/src/drivers/mipi/Kconfig b/src/drivers/mipi/Kconfig index 00c072b..9aba7bb 100644 --- a/src/drivers/mipi/Kconfig +++ b/src/drivers/mipi/Kconfig @@ -42,6 +42,9 @@ config MIPI_PANEL_INX_OTA7290D10P bool +config MIPI_PANEL_IVO_T109NW41 + bool + config MIPI_PANEL_STA_2081101QFH032011_53G bool diff --git a/src/drivers/mipi/Makefile.inc b/src/drivers/mipi/Makefile.inc index 95c5f95..ffa90f9 100644 --- a/src/drivers/mipi/Makefile.inc +++ b/src/drivers/mipi/Makefile.inc @@ -21,6 +21,8 @@ panel-params-$(CONFIG_MIPI_PANEL_INX_HJ110IZ_01A_B2) += panel-INX_HJ110IZ_01A_B2 panel-params-$(CONFIG_MIPI_PANEL_INX_OTA7290D10P) += panel-INX_OTA7290D10P +panel-params-$(CONFIG_MIPI_PANEL_IVO_T109NW41) += panel-IVO_T109NW41 + panel-params-$(CONFIG_MIPI_PANEL_STA_2081101QFH032011_53G) += panel-STA_2081101QFH032011_53G panel-params-$(CONFIG_MIPI_PANEL_STA_HIMAX83102_J02) += panel-STA_HIMAX83102_J02 panel-params-$(CONFIG_MIPI_PANEL_STA_ILI9882T) += panel-STA_ILI9882T diff --git a/src/drivers/mipi/panel-IVO_T109NW41.c b/src/drivers/mipi/panel-IVO_T109NW41.c new file mode 100644 index 0000000..ca8e8d5 --- /dev/null +++ b/src/drivers/mipi/panel-IVO_T109NW41.c @@ -0,0 +1,111 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <mipi/panel.h> + +struct panel_serializable_data IVO_T109NW41 = { + .edid = { + .ascii_string = "T109NW41", + .manufacturer_name = "IVO", + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .pixel_clock = 158400, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 1200, .hbl = 120, .hso = 60, .hspw = 20, + .va = 1920, .vbl = 80, .vso = 60, .vspw = 8, + .phsync = '-', .pvsync = '-', + .x_mm = 147, .y_mm = 235, + }, + }, + .init = { + PANEL_DELAY(60), + PANEL_DCS(0xB9, 0x83, 0x10, 0x21, 0x55, 0x00), + PANEL_DCS(0xB1, 0x2C, 0xED, 0xED, 0x27, 0xE7, 0x52, 0xF5, 0x39, + 0x36, 0x36, 0x36, 0x36, 0x32, 0x8B, 0x11, 0x65, 0x00, 0x88, + 0xFA, 0xFF, 0xFF, 0x8F, 0xFF, 0x08, 0xD6, 0x33), + PANEL_DCS(0xB2, 0x00, 0x47, 0xB0, 0x80, 0x00, 0x12, 0x3A, 0x3C, + 0xA3, 0x22, 0x20, 0x00, 0x00, 0x88, 0x01), + PANEL_DCS(0xB4, 0x35, 0x35, 0x43, 0x43, 0x35, 0x35, 0x30, 0x7A, + 0x30, 0x7A, 0x00, 0x9D), + PANEL_DCS(0xE9, 0xCD), + PANEL_DCS(0xBA, 0x84), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xBC, 0x1B, 0x04), + PANEL_DCS(0xBE, 0x20), + PANEL_DCS(0xBF, 0xFC, 0xC4), + PANEL_DCS(0xC0, 0x34, 0x34, 0x22, 0x11, 0x22, 0xA0, 0x31, 0x08, + 0xF5, 0x03), + PANEL_DCS(0xE9, 0xCC), + PANEL_DCS(0xC7, 0x80), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xE9, 0xC9), + PANEL_DCS(0xC8, 0x00), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xC9, 0x00, 0x1E, 0x13, 0x88, 0x01), + PANEL_DCS(0xCB, 0x08, 0x13, 0x07, 0x00, 0x0F, 0x34), + PANEL_DCS(0xCC, 0x02, 0x03, 0x44), + PANEL_DCS(0xE9, 0xC4), + PANEL_DCS(0xD0, 0x03), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD1, 0x37, 0x06, 0x00, 0x02, 0x04, 0x2C, 0xFF), + PANEL_DCS(0xD3, 0x06, 0x00, 0x00, 0x00, 0x00, 0x08, 0x08, 0x08, + 0x08, 0x37, 0x07, 0x64, 0x7C, 0x11, 0x11, 0x03, 0x03, 0x32, + 0x10, 0x0E, 0x00, 0x0E, 0x32, 0x17, 0x97, 0x07, 0x97, 0x32, + 0x00, 0x02, 0x00, 0x02, 0x00, 0x00), + PANEL_DCS(0xD5, 0x25, 0x24, 0x25, 0x24, 0x18, 0x18, 0x18, 0x18, + 0x07, 0x06, 0x07, 0x06, 0x05, 0x04, 0x05, 0x04, 0x03, 0x02, + 0x03, 0x02, 0x01, 0x00, 0x01, 0x00, 0xA8, 0xA8, 0xA8, 0xA8, + 0x29, 0x29, 0x29, 0x29, 0x21, 0x20, 0x21, 0x20, 0x18, 0x18, + 0x18, 0x18, 0x18, 0x18, 0x18, 0x18), + PANEL_DCS(0xD8, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xA0, 0xAA, 0xAA, + 0xAA, 0xAA, 0xAA, 0xA0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00), + PANEL_DCS(0xE7, 0x07, 0x10, 0x10, 0x1A, 0x26, 0x9E, 0x00, 0x4F, + 0xA0, 0x14, 0x14, 0x00, 0x00, 0x00, 0x00, 0x12, 0x0A, 0x02, + 0x02, 0x00, 0x33, 0x02, 0x04, 0x18, 0x01), + PANEL_DCS(0xBD, 0x01), + PANEL_DCS(0xB1, 0x01, 0x7F, 0x11, 0xFD), + PANEL_DCS(0xCB, 0x86), + PANEL_DCS(0xD8, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xA0, + 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xA0, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00), + PANEL_DCS(0xE7, 0x02, 0x00, 0x2B, 0x01, 0x7E, 0x0F, 0x7E, 0x10, + 0xA0, 0x00, 0x00, 0x77, 0x00, 0x00, 0x00), + PANEL_DCS(0xBD, 0x02), + PANEL_DCS(0xBF, 0xF2), + PANEL_DCS(0xCB, 0x03, 0x07, 0x00, 0x10, 0x79), + PANEL_DCS(0xD8, 0xFF, 0xFF, 0xFF, 0xFF, 0xFA, 0xA0, 0xFF, 0xFF, + 0xFF, 0xFF, 0xFA, 0xA0), + PANEL_DCS(0xE7, 0xFE, 0x01, 0xFE, 0x01, 0xFE, 0x01, 0x00, 0x00, + 0x00, 0x23, 0x00, 0x23, 0x81, 0x02, 0x40, 0x00, 0x20, 0x6E, + 0x02, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00), + PANEL_DCS(0xBD, 0x03), + PANEL_DCS(0xD8, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xA0, 0xAA, 0xAA, + 0xAA, 0xAA, 0xAA, 0xA0, 0xFF, 0xFF, 0xFF, 0xFF, 0xFA, 0xA0, + 0xFF, 0xFF, 0xFF, 0xFF, 0xFA, 0xA0, 0xAA, 0xAA, 0xAA, 0xAA, + 0xAA, 0xA0, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xA0, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00), + PANEL_DCS(0xE9, 0xC6), + PANEL_DCS(0xB4, 0x03, 0xFF, 0xF8), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xE1, 0x00), + PANEL_DCS(0xBD, 0x00), + PANEL_DCS(0xD2, 0x35, 0x35, 0x35, 0x35, 0x35, 0x35), + PANEL_DCS(0xE9, 0xC4), + PANEL_DCS(0xBA, 0x96), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xBD, 0x01), + PANEL_DCS(0xE9, 0xC5), + PANEL_DCS(0xBA, 0x4F), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xBD, 0x00), + PANEL_DCS(0x11), + PANEL_DELAY(120), + PANEL_DCS(0x29), + PANEL_DELAY(20), + PANEL_END, + }, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/79844?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id740e3a21f72bbcd6e5c2b56b31ac90f4990d475 Gerrit-Change-Number: 79844 Gerrit-PatchSet: 2 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for IVO_T109NW41 panel
by Yu-Ping Wu (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Ruihai Zhou. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79844?usp=email ) Change subject: drivers/mipi: Add support for IVO_T109NW41 panel ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79844?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id740e3a21f72bbcd6e5c2b56b31ac90f4990d475 Gerrit-Change-Number: 79844 Gerrit-PatchSet: 1 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 06:41:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for IVO_T109NW41 panel
by Yidi Lin (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Ruihai Zhou, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79844?usp=email ) Change subject: drivers/mipi: Add support for IVO_T109NW41 panel ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79844?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id740e3a21f72bbcd6e5c2b56b31ac90f4990d475 Gerrit-Change-Number: 79844 Gerrit-PatchSet: 1 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 04:26:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/google/corsola: Use common mtk_display_init()
by Yidi Lin (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79777?usp=email to look at the new patch set (#4). Change subject: mb/google/corsola: Use common mtk_display_init() ...................................................................... mb/google/corsola: Use common mtk_display_init() TEST=check FW screen on Steelix, Tentacruel and Starmie Change-Id: I429218d59389a6ab86b522dd597c07fa5b8ea821 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/mainboard/google/corsola/Makefile.inc M src/mainboard/google/corsola/boardid.c D src/mainboard/google/corsola/display.c D src/mainboard/google/corsola/display.h M src/mainboard/google/corsola/mainboard.c A src/mainboard/google/corsola/panel.c A src/mainboard/google/corsola/panel.h M src/mainboard/google/corsola/panel_anx7625.c M src/mainboard/google/corsola/panel_ps8640.c M src/mainboard/google/corsola/panel_starmie.c M src/soc/mediatek/common/display.c M src/soc/mediatek/mt8186/Makefile.inc M src/soc/mediatek/mt8186/ddp.c M src/soc/mediatek/mt8186/include/soc/ddp.h 14 files changed, 136 insertions(+), 203 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/79777/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79777?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I429218d59389a6ab86b522dd597c07fa5b8ea821 Gerrit-Change-Number: 79777 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: soc/mediatek: Add common implementation to configure display
by Yidi Lin (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79776?usp=email ) Change subject: soc/mediatek: Add common implementation to configure display ...................................................................... Patch Set 3: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79776/comment/74cf15d8_a15c9370 : PS1, Line 13: mtcmos_display_power_on > nit: `mtcmos_display_power_on()` Done https://review.coreboot.org/c/coreboot/+/79776/comment/a8ac3594_3846ba1c : PS1, Line 28: soc > nit: `mediatek` Done https://review.coreboot.org/c/coreboot/+/79776/comment/a1870b3d_fc062035 : PS1, Line 29: refacts > Do you mean `refactors`? Done Commit Message: https://review.coreboot.org/c/coreboot/+/79776/comment/ea2dcaf5_576b9bd7 : PS2, Line 7: implmentation > typo Done File src/soc/mediatek/common/display.c: https://review.coreboot.org/c/coreboot/+/79776/comment/6d3536f8_e5736714 : PS1, Line 13: configure_display > Consider renaming it to `mtk_display_init`? Done https://review.coreboot.org/c/coreboot/+/79776/comment/2cf671d9_a609d393 : PS1, Line 42: if (panel->get_edid && panel->get_edid(panel) < 0) > I think we just need a local variable to store panel_serializable_data. […] ``` struct panel_serializable_data { struct edid edid; /* edid info of this panel */ u8 init[]; /* A packed array of panel_init_command */ }; ``` Since `init` is always pointing to the address next to `edid`, we can't pass `panel_serializable_data` variable and copy the serializable data from `get_mipi_cmd_from_cbfs`. I pass the pointer to get `buffer` address instead. File src/soc/mediatek/common/include/soc/ddp_common.h: https://review.coreboot.org/c/coreboot/+/79776/comment/17bf8740_eaa63fed : PS1, Line 142: enum disp_path_sel { > I think this should be put in mediatek/common/.../display.h, and then include display. […] Done File src/soc/mediatek/common/include/soc/display.h: https://review.coreboot.org/c/coreboot/+/79776/comment/baf55bd7_fb98ccbe : PS1, Line 13: configure_panel_backlight > configure_backlight Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I403bba8a826de5f3fb2ea96a5403725ff194164f Gerrit-Change-Number: 79776 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 04:03:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/cherry: Use common mtk_display_init()
by Yidi Lin (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79778?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/cherry: Use common mtk_display_init() ...................................................................... mb/google/cherry: Use common mtk_display_init() TEST=check FW screen on dojo Change-Id: Ie870899226588ac2a2e80f77e434455f4913d387 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/mainboard/google/cherry/mainboard.c M src/soc/mediatek/common/display.c M src/soc/mediatek/mt8195/Makefile.inc M src/soc/mediatek/mt8195/ddp.c M src/soc/mediatek/mt8195/include/soc/ddp.h A src/soc/mediatek/mt8195/include/soc/dsi.h 6 files changed, 31 insertions(+), 42 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/79778/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79778?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie870899226588ac2a2e80f77e434455f4913d387 Gerrit-Change-Number: 79778 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: mb/google/corsola: Use common mtk_display_init()
by Yidi Lin (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79777?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/corsola: Use common mtk_display_init() ...................................................................... mb/google/corsola: Use common mtk_display_init() TEST=check FW screen on Steelix, Tentacruel and Starmie Change-Id: I429218d59389a6ab86b522dd597c07fa5b8ea821 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/mainboard/google/corsola/Makefile.inc M src/mainboard/google/corsola/boardid.c D src/mainboard/google/corsola/display.c M src/mainboard/google/corsola/mainboard.c A src/mainboard/google/corsola/panel.c R src/mainboard/google/corsola/panel.h M src/mainboard/google/corsola/panel_anx7625.c M src/mainboard/google/corsola/panel_ps8640.c M src/mainboard/google/corsola/panel_starmie.c M src/soc/mediatek/common/display.c M src/soc/mediatek/mt8186/Makefile.inc M src/soc/mediatek/mt8186/ddp.c M src/soc/mediatek/mt8186/include/soc/ddp.h 13 files changed, 111 insertions(+), 175 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/79777/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79777?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I429218d59389a6ab86b522dd597c07fa5b8ea821 Gerrit-Change-Number: 79777 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: soc/mediatek: Add common implementation to configure display
by Yidi Lin (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79776?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/mediatek: Add common implementation to configure display ...................................................................... soc/mediatek: Add common implementation to configure display The sequences of configure_display() are similar on MediaTek platforms. The sequences usually involve following steps: 1. Setup mtcmos for display hardware block. - mtcmos_display_power_on() - mtcmos_protect_display_bus() 2. Configure backlight pins 3. Power on the panel - It also powers on the bridge in MIPI DSI to eDP case. 4. General initialization for DDP(display data path) 5. Initialize eDP/MIPI DSI accordingly, - For eDP path, it calls mtk_edp_init() to get edid from the panel and initializes eDP driver. - For MIPI DSI path, the edid is retrieved either from the bridge or from CBFS (the serializable data), and then initializes DSI driver. 6. Set framebuffer bits per pixel 7. Setup DDP mode 8. Setup panel orientation This patch extracts geralt/display.c to mediatek/common/display.c and refactors `struct panel_description` to generalize the display init sequences. configure_display() is also renamed to mtk_display_init(). TEST=check FW screen on geralt. Change-Id: I403bba8a826de5f3fb2ea96a5403725ff194164f Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/mainboard/google/geralt/Makefile.inc D src/mainboard/google/geralt/display.c M src/mainboard/google/geralt/mainboard.c M src/mainboard/google/geralt/panel.c M src/mainboard/google/geralt/panel.h M src/mainboard/google/geralt/panel_geralt.c A src/soc/mediatek/common/display.c A src/soc/mediatek/common/include/soc/display.h M src/soc/mediatek/mt8188/Makefile.inc M src/soc/mediatek/mt8188/include/soc/ddp.h 10 files changed, 151 insertions(+), 141 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/79776/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I403bba8a826de5f3fb2ea96a5403725ff194164f Gerrit-Change-Number: 79776 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Add FW_CONFIG probe for mipi camera
by Eric Lai (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Nick Vaccaro, Subrata Banik, Weimin Wu. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79802?usp=email ) Change subject: mb/google/nissa/var/anraggar: Add FW_CONFIG probe for mipi camera ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79802?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa8649a603c59946b530abd315113b405ceaf35a Gerrit-Change-Number: 79802 Gerrit-PatchSet: 1 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 03:08:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024