coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[S] Change in coreboot[main]: mb/intel/mtlrvp: streamline Chrome EC configs
by Felix Held (Code Review) 10 Jan '24

10 Jan '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79211?usp=email ) Change subject: mb/intel/mtlrvp: streamline Chrome EC configs ...................................................................... mb/intel/mtlrvp: streamline Chrome EC configs Chrome EC configuration options that are common among various boards have been consolidated under the "BOARD_EXT_EC_SPECIFIC_OPTIONS" config. BUG=b:289783489 TEST=emerge-rex coreboot chromeos-bootimage is successful Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f Signed-off-by: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79211 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> --- M src/mainboard/intel/mtlrvp/Kconfig 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Subrata Banik: Looks good to me, approved diff --git a/src/mainboard/intel/mtlrvp/Kconfig b/src/mainboard/intel/mtlrvp/Kconfig index b541b76..c4478d1 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig +++ b/src/mainboard/intel/mtlrvp/Kconfig @@ -41,6 +41,10 @@ def_bool n select BOARD_INTEL_MTLRVP_COMMON select DRIVERS_INTEL_PMC + select EC_ACPI + select EC_GOOGLE_CHROMEEC + select EC_GOOGLE_CHROMEEC_ESPI + select EC_GOOGLE_CHROMEEC_BOARDID select FW_CONFIG select FW_CONFIG_SOURCE_CHROMEEC_CBI @@ -109,11 +113,7 @@ Select whether the board has Intel EC or/and Chrome EC config MTL_CHROME_EC - bool "Chrome EC" - select EC_ACPI - select EC_GOOGLE_CHROMEEC - select EC_GOOGLE_CHROMEEC_ESPI - select EC_GOOGLE_CHROMEEC_BOARDID + bool "Chrome EC with Internal SPI flash" config MTL_INTEL_EC bool "Intel EC" -- To view, visit https://review.coreboot.org/c/coreboot/+/79211?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f Gerrit-Change-Number: 79211 Gerrit-PatchSet: 12 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: southbridge: Remove last dummy SOUTH_BRIDGE_OPTIONS Kconfig symbol
by Felix Held (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Elyes Haouas, Felix Singer, Martin L Roth, Nico Huber. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77532?usp=email ) Change subject: southbridge: Remove last dummy SOUTH_BRIDGE_OPTIONS Kconfig symbol ...................................................................... Patch Set 8: Code-Review+1 (1 comment) Patchset: PS8: might be good to split this patch since it does two logical changes in one patch -- To view, visit https://review.coreboot.org/c/coreboot/+/77532?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If4ae9c800325f5de8f170f8922bacffad1c9bb20 Gerrit-Change-Number: 77532 Gerrit-PatchSet: 8 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 10 Jan 2024 14:17:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/pcengines/apu2/BiosCallOuts: don't have binaryPI clear LPC decodes
by Arthur Heymans (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Felix Held, Martin L Roth, Matt DeVillier, Michał Żygowski, Piotr Król. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79852?usp=email ) Change subject: mb/pcengines/apu2/BiosCallOuts: don't have binaryPI clear LPC decodes ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Can the OS find the serial port too? Otherwise just flipping HUDSON_LEGACY_FREE to 'no' might be a sensible thing to do. I don't see serial port in ACPI DSDT and SSDT for the SIO. -- To view, visit https://review.coreboot.org/c/coreboot/+/79852?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91ef4423bd7bf6c1d7a175336f0f89479f2cde02 Gerrit-Change-Number: 79852 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 10 Jan 2024 13:50:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload: Remove shell for loops in install Makefile target
by Paul Menzel (Code Review) 10 Jan '24

10 Jan '24

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79523?usp=email ) Change subject: libpayload: Remove shell for loops in install Makefile target ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: After this commit FILO fails to build: <command-line>: fatal error: /dev/shm/coreboot/payloads/external/FILO/filo/build/libpayload/bin/../include/commonlib/bsd/compiler.h: No such file or directory Reverting this commit on main also fixes the issue. -- To view, visit https://review.coreboot.org/c/coreboot/+/79523?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210 Gerrit-Change-Number: 79523 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 10 Jan 2024 12:56:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/pcengines/apu2/BiosCallOuts: don't have binaryPI clear LPC decodes
by Paul Menzel (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Felix Held, Martin L Roth, Matt DeVillier, Michał Żygowski, Piotr Król. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79852?usp=email ) Change subject: mb/pcengines/apu2/BiosCallOuts: don't have binaryPI clear LPC decodes ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79852?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91ef4423bd7bf6c1d7a175336f0f89479f2cde02 Gerrit-Change-Number: 79852 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 10 Jan 2024 12:46:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/pcengines/apu2/BiosCallOuts: don't have binaryPI clear LPC decodes
by Krystian Hebel (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Felix Held, Martin L Roth, Matt DeVillier, Michał Żygowski, Piotr Król. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79852?usp=email ) Change subject: mb/pcengines/apu2/BiosCallOuts: don't have binaryPI clear LPC decodes ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79852?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91ef4423bd7bf6c1d7a175336f0f89479f2cde02 Gerrit-Change-Number: 79852 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 10 Jan 2024 12:38:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: libpayload: Move back the ttb_buffer section
by Paul Menzel (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Yi Chou. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79800?usp=email ) Change subject: libpayload: Move back the ttb_buffer section ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79800?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb08878dd4be01d9ed3f96933f774dd6296f76e Gerrit-Change-Number: 79800 Gerrit-PatchSet: 5 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Comment-Date: Wed, 10 Jan 2024 12:12:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brox: Enable WLAN
by Paul Menzel (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Shelley Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79888?usp=email ) Change subject: mb/google/brox: Enable WLAN ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79888/comment/77f4de74_e0d7253a : PS2, Line 7: mb/google/brox: Enable WLAN … on root port X -- To view, visit https://review.coreboot.org/c/coreboot/+/79888?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I361bef13ebd073b6fccb729a1960d3832cf2681a Gerrit-Change-Number: 79888 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Comment-Date: Wed, 10 Jan 2024 12:12:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/volteer/eldrid: Set touchsreen reset time back to 30ms
by Paul Menzel (Code Review) 10 Jan '24

10 Jan '24

Attention is currently required from: Casper Chang, Nick Vaccaro. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79891?usp=email ) Change subject: mb/google/volteer/eldrid: Set touchsreen reset time back to 30ms ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79891/comment/ab02685a_d9be1b45 : PS1, Line 7: Set Decrease https://review.coreboot.org/c/coreboot/+/79891/comment/f69da261_a694134d : PS1, Line 9: Set touchscreen reset time back to 30ms for Goodix touchscreen to : match resume time requirement (0.5s). Why do you think that it will work always with the smaller value? Where is the delay happening. Please paste the corresponding lines. https://review.coreboot.org/c/coreboot/+/79891/comment/88d70ece_573f6b15 : PS1, Line 11: Please mention the commit you are reverting here. -- To view, visit https://review.coreboot.org/c/coreboot/+/79891?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I88432629d82ce0aee670f84cf0a3e65f4052b503 Gerrit-Change-Number: 79891 Gerrit-PatchSet: 1 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 10 Jan 2024 10:16:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/volteer/eldrid: Set touchsreen reset time back to 30ms
by Casper Chang (Code Review) 10 Jan '24

10 Jan '24

Casper Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79891?usp=email ) Change subject: mb/google/volteer/eldrid: Set touchsreen reset time back to 30ms ...................................................................... mb/google/volteer/eldrid: Set touchsreen reset time back to 30ms Set touchscreen reset time back to 30ms for Goodix touchscreen to match resume time requirement (0.5s). TEST=verify Goodix touchscreen functional on Eldrid Change-Id: I88432629d82ce0aee670f84cf0a3e65f4052b503 Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> --- M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/79891/1 diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb index 7bb91ea..862e4c8 100644 --- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb +++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb @@ -147,7 +147,7 @@ register "generic.detect" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" - register "generic.reset_delay_ms" = "120" + register "generic.reset_delay_ms" = "30" register "generic.reset_off_delay_ms" = "3" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)" register "generic.enable_delay_ms" = "12" -- To view, visit https://review.coreboot.org/c/coreboot/+/79891?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I88432629d82ce0aee670f84cf0a3e65f4052b503 Gerrit-Change-Number: 79891 Gerrit-PatchSet: 1 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024