Attention is currently required from: Erik van den Bogaert, Frans Hendriks, Xi Chen.
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80067?usp=email )
Change subject: vendorcode: Rename Makefiles from .inc to .mak
......................................................................
vendorcode: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I80559b7c86a8fd2583cb0335279f676e0aa0209e
---
R src/vendorcode/Makefile.mak
R src/vendorcode/amd/Makefile.mak
R src/vendorcode/amd/opensil/Makefile.mak
R src/vendorcode/amd/opensil/genoa_poc/Makefile.mak
R src/vendorcode/amd/opensil/genoa_poc/mpio/Makefile.mak
A src/vendorcode/amd/opensil_org/genoa_poc/openSIL
R src/vendorcode/amd/pi/00670F00/Makefile.mak
R src/vendorcode/amd/pi/Makefile.mak
R src/vendorcode/cavium/Makefile.mak
R src/vendorcode/eltan/Makefile.mak
R src/vendorcode/eltan/security/Makefile.mak
R src/vendorcode/eltan/security/mboot/Makefile.mak
R src/vendorcode/eltan/security/verified_boot/Makefile.mak
R src/vendorcode/google/Makefile.mak
R src/vendorcode/google/chromeos/Makefile.mak
R src/vendorcode/intel/Makefile.mak
R src/vendorcode/mediatek/Makefile.mak
R src/vendorcode/mediatek/mt8192/Makefile.mak
R src/vendorcode/mediatek/mt8192/dramc/Makefile.mak
R src/vendorcode/mediatek/mt8195/Makefile.mak
R src/vendorcode/mediatek/mt8195/dramc/Makefile.mak
R src/vendorcode/siemens/Makefile.mak
R src/vendorcode/siemens/hwilib/Makefile.mak
23 files changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/80067/1
diff --git a/src/vendorcode/Makefile.inc b/src/vendorcode/Makefile.mak
similarity index 100%
rename from src/vendorcode/Makefile.inc
rename to src/vendorcode/Makefile.mak
diff --git a/src/vendorcode/amd/Makefile.inc b/src/vendorcode/amd/Makefile.mak
similarity index 100%
rename from src/vendorcode/amd/Makefile.inc
rename to src/vendorcode/amd/Makefile.mak
diff --git a/src/vendorcode/amd/opensil/Makefile.inc b/src/vendorcode/amd/opensil/Makefile.mak
similarity index 100%
rename from src/vendorcode/amd/opensil/Makefile.inc
rename to src/vendorcode/amd/opensil/Makefile.mak
diff --git a/src/vendorcode/amd/opensil/genoa_poc/Makefile.inc b/src/vendorcode/amd/opensil/genoa_poc/Makefile.mak
similarity index 100%
rename from src/vendorcode/amd/opensil/genoa_poc/Makefile.inc
rename to src/vendorcode/amd/opensil/genoa_poc/Makefile.mak
diff --git a/src/vendorcode/amd/opensil/genoa_poc/mpio/Makefile.inc b/src/vendorcode/amd/opensil/genoa_poc/mpio/Makefile.mak
similarity index 100%
rename from src/vendorcode/amd/opensil/genoa_poc/mpio/Makefile.inc
rename to src/vendorcode/amd/opensil/genoa_poc/mpio/Makefile.mak
diff --git a/src/vendorcode/amd/opensil_org/genoa_poc/openSIL b/src/vendorcode/amd/opensil_org/genoa_poc/openSIL
new file mode 160000
index 0000000..d81517e
--- /dev/null
+++ b/src/vendorcode/amd/opensil_org/genoa_poc/openSIL
@@ -0,0 +1 @@
+Subproject commit d81517ec318455de7c18070340e891e120e22bfb
diff --git a/src/vendorcode/amd/pi/00670F00/Makefile.inc b/src/vendorcode/amd/pi/00670F00/Makefile.mak
similarity index 100%
rename from src/vendorcode/amd/pi/00670F00/Makefile.inc
rename to src/vendorcode/amd/pi/00670F00/Makefile.mak
diff --git a/src/vendorcode/amd/pi/Makefile.inc b/src/vendorcode/amd/pi/Makefile.mak
similarity index 100%
rename from src/vendorcode/amd/pi/Makefile.inc
rename to src/vendorcode/amd/pi/Makefile.mak
diff --git a/src/vendorcode/cavium/Makefile.inc b/src/vendorcode/cavium/Makefile.mak
similarity index 100%
rename from src/vendorcode/cavium/Makefile.inc
rename to src/vendorcode/cavium/Makefile.mak
diff --git a/src/vendorcode/eltan/Makefile.inc b/src/vendorcode/eltan/Makefile.mak
similarity index 100%
rename from src/vendorcode/eltan/Makefile.inc
rename to src/vendorcode/eltan/Makefile.mak
diff --git a/src/vendorcode/eltan/security/Makefile.inc b/src/vendorcode/eltan/security/Makefile.mak
similarity index 100%
rename from src/vendorcode/eltan/security/Makefile.inc
rename to src/vendorcode/eltan/security/Makefile.mak
diff --git a/src/vendorcode/eltan/security/mboot/Makefile.inc b/src/vendorcode/eltan/security/mboot/Makefile.mak
similarity index 100%
rename from src/vendorcode/eltan/security/mboot/Makefile.inc
rename to src/vendorcode/eltan/security/mboot/Makefile.mak
diff --git a/src/vendorcode/eltan/security/verified_boot/Makefile.inc b/src/vendorcode/eltan/security/verified_boot/Makefile.mak
similarity index 100%
rename from src/vendorcode/eltan/security/verified_boot/Makefile.inc
rename to src/vendorcode/eltan/security/verified_boot/Makefile.mak
diff --git a/src/vendorcode/google/Makefile.inc b/src/vendorcode/google/Makefile.mak
similarity index 100%
rename from src/vendorcode/google/Makefile.inc
rename to src/vendorcode/google/Makefile.mak
diff --git a/src/vendorcode/google/chromeos/Makefile.inc b/src/vendorcode/google/chromeos/Makefile.mak
similarity index 100%
rename from src/vendorcode/google/chromeos/Makefile.inc
rename to src/vendorcode/google/chromeos/Makefile.mak
diff --git a/src/vendorcode/intel/Makefile.inc b/src/vendorcode/intel/Makefile.mak
similarity index 100%
rename from src/vendorcode/intel/Makefile.inc
rename to src/vendorcode/intel/Makefile.mak
diff --git a/src/vendorcode/mediatek/Makefile.inc b/src/vendorcode/mediatek/Makefile.mak
similarity index 100%
rename from src/vendorcode/mediatek/Makefile.inc
rename to src/vendorcode/mediatek/Makefile.mak
diff --git a/src/vendorcode/mediatek/mt8192/Makefile.inc b/src/vendorcode/mediatek/mt8192/Makefile.mak
similarity index 100%
rename from src/vendorcode/mediatek/mt8192/Makefile.inc
rename to src/vendorcode/mediatek/mt8192/Makefile.mak
diff --git a/src/vendorcode/mediatek/mt8192/dramc/Makefile.inc b/src/vendorcode/mediatek/mt8192/dramc/Makefile.mak
similarity index 100%
rename from src/vendorcode/mediatek/mt8192/dramc/Makefile.inc
rename to src/vendorcode/mediatek/mt8192/dramc/Makefile.mak
diff --git a/src/vendorcode/mediatek/mt8195/Makefile.inc b/src/vendorcode/mediatek/mt8195/Makefile.mak
similarity index 100%
rename from src/vendorcode/mediatek/mt8195/Makefile.inc
rename to src/vendorcode/mediatek/mt8195/Makefile.mak
diff --git a/src/vendorcode/mediatek/mt8195/dramc/Makefile.inc b/src/vendorcode/mediatek/mt8195/dramc/Makefile.mak
similarity index 100%
rename from src/vendorcode/mediatek/mt8195/dramc/Makefile.inc
rename to src/vendorcode/mediatek/mt8195/dramc/Makefile.mak
diff --git a/src/vendorcode/siemens/Makefile.inc b/src/vendorcode/siemens/Makefile.mak
similarity index 100%
rename from src/vendorcode/siemens/Makefile.inc
rename to src/vendorcode/siemens/Makefile.mak
diff --git a/src/vendorcode/siemens/hwilib/Makefile.inc b/src/vendorcode/siemens/hwilib/Makefile.mak
similarity index 100%
rename from src/vendorcode/siemens/hwilib/Makefile.inc
rename to src/vendorcode/siemens/hwilib/Makefile.mak
--
To view, visit https://review.coreboot.org/c/coreboot/+/80067?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80559b7c86a8fd2583cb0335279f676e0aa0209e
Gerrit-Change-Number: 80067
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-MessageType: newchange
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80066?usp=email )
Change subject: acpi,arch,commonlib: Rename Makefiles from .inc to Makefile.mak
......................................................................
acpi,arch,commonlib: Rename Makefiles from .inc to Makefile.mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ice5dadd3eaadfa9962225520a3a75b05b44518ca
---
R src/acpi/Makefile.mak
R src/arch/arm/Makefile.mak
R src/arch/arm/armv4/Makefile.mak
R src/arch/arm/armv7/Makefile.mak
R src/arch/arm/libgcc/Makefile.mak
R src/arch/arm64/Makefile.mak
R src/arch/arm64/armv8/Makefile.mak
R src/arch/ppc64/Makefile.mak
R src/arch/riscv/Makefile.mak
R src/arch/x86/Makefile.mak
R src/commonlib/Makefile.mak
R src/commonlib/storage/Makefile.mak
12 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/80066/1
diff --git a/src/acpi/Makefile.inc b/src/acpi/Makefile.mak
similarity index 100%
rename from src/acpi/Makefile.inc
rename to src/acpi/Makefile.mak
diff --git a/src/arch/arm/Makefile.inc b/src/arch/arm/Makefile.mak
similarity index 100%
rename from src/arch/arm/Makefile.inc
rename to src/arch/arm/Makefile.mak
diff --git a/src/arch/arm/armv4/Makefile.inc b/src/arch/arm/armv4/Makefile.mak
similarity index 100%
rename from src/arch/arm/armv4/Makefile.inc
rename to src/arch/arm/armv4/Makefile.mak
diff --git a/src/arch/arm/armv7/Makefile.inc b/src/arch/arm/armv7/Makefile.mak
similarity index 100%
rename from src/arch/arm/armv7/Makefile.inc
rename to src/arch/arm/armv7/Makefile.mak
diff --git a/src/arch/arm/libgcc/Makefile.inc b/src/arch/arm/libgcc/Makefile.mak
similarity index 100%
rename from src/arch/arm/libgcc/Makefile.inc
rename to src/arch/arm/libgcc/Makefile.mak
diff --git a/src/arch/arm64/Makefile.inc b/src/arch/arm64/Makefile.mak
similarity index 100%
rename from src/arch/arm64/Makefile.inc
rename to src/arch/arm64/Makefile.mak
diff --git a/src/arch/arm64/armv8/Makefile.inc b/src/arch/arm64/armv8/Makefile.mak
similarity index 100%
rename from src/arch/arm64/armv8/Makefile.inc
rename to src/arch/arm64/armv8/Makefile.mak
diff --git a/src/arch/ppc64/Makefile.inc b/src/arch/ppc64/Makefile.mak
similarity index 100%
rename from src/arch/ppc64/Makefile.inc
rename to src/arch/ppc64/Makefile.mak
diff --git a/src/arch/riscv/Makefile.inc b/src/arch/riscv/Makefile.mak
similarity index 100%
rename from src/arch/riscv/Makefile.inc
rename to src/arch/riscv/Makefile.mak
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.mak
similarity index 100%
rename from src/arch/x86/Makefile.inc
rename to src/arch/x86/Makefile.mak
diff --git a/src/commonlib/Makefile.inc b/src/commonlib/Makefile.mak
similarity index 100%
rename from src/commonlib/Makefile.inc
rename to src/commonlib/Makefile.mak
diff --git a/src/commonlib/storage/Makefile.inc b/src/commonlib/storage/Makefile.mak
similarity index 100%
rename from src/commonlib/storage/Makefile.inc
rename to src/commonlib/storage/Makefile.mak
--
To view, visit https://review.coreboot.org/c/coreboot/+/80066?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice5dadd3eaadfa9962225520a3a75b05b44518ca
Gerrit-Change-Number: 80066
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Jonathon Hall, Nico Huber.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80065?usp=email )
Change subject: mb/purism/librem_skl: Fix pcie_rp5 in device tree (WLAN)
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80065?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a724a01b5f171a16de83ff6122630e2d66557c1
Gerrit-Change-Number: 80065
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Comment-Date: Thu, 18 Jan 2024 19:22:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email )
Change subject: Makefiles: Rename top-level Makefiles from .inc to .mak
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80063?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
Gerrit-Change-Number: 80063
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 19:17:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80064?usp=email )
Change subject: tests: Fix ending newlines in Makefiles
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80064?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9440d7a81e2a8b2bed87838fd5b11e71ac744f12
Gerrit-Change-Number: 80064
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 19:14:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80055?usp=email )
Change subject: mb/purism/librem_l1um_v2: Use chipset dt reference names
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/purism/librem_l1um_v2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80055/comment/6198a8cd_fa942ca5 :
PS1, Line 44: device pci 01.0 on # PCIE6 - x16 or x8
> I thought they might be superfluous since the smbios lines say the same. […]
Ah, on second thought I'm fine with that then. Should have read a few more lines down. No need to write the same thing twice.
Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/80055?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id592241a1dc33559115800da10a57a5fc10867f9
Gerrit-Change-Number: 80055
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 19:02:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Jeremy Soller, Michael Niewöhner, Michał Żygowski, Nick Vaccaro, Nico Huber, Patrick Rudolph, Piotr Król, Subrata Banik, Tim Crawford.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79918?usp=email )
Change subject: soc/intel/cannonlake: Drop redundant PcieRpEnable
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/purism/librem_l1um_v2/bootblock.c:
https://review.coreboot.org/c/coreboot/+/79918/comment/995b76f7_7b6cf60c :
PS2, Line 15: #include <delay.h>
This brings back a duplicate #include that was recently cleaned up, please remove that again.
Rest looks fine to me, thanks
--
To view, visit https://review.coreboot.org/c/coreboot/+/79918?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I734262c8191bc217c721c0174d0f844755bc73a9
Gerrit-Change-Number: 79918
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 19:00:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79919?usp=email )
Change subject: soc/intel/jasperlake: Drop redundant PcieRpEnable
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79919?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iea7f616f6db579c06722369c08de7cf7261dece8
Gerrit-Change-Number: 79919
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 18:58:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Nico Huber.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80065?usp=email )
Change subject: mb/purism/librem_skl: Fix pcie_rp5 in device tree (WLAN)
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Relates to 79958 and 79917, addresses mismatched root port enable / device tree for librem_skl.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80065?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a724a01b5f171a16de83ff6122630e2d66557c1
Gerrit-Change-Number: 80065
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 18:55:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Jonathon Hall has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80065?usp=email )
Change subject: mb/purism/librem_skl: Fix pcie_rp5 in device tree (WLAN)
......................................................................
mb/purism/librem_skl: Fix pcie_rp5 in device tree (WLAN)
WLAN has always been pcie_rp5, there is nothing on pcie_rp1. RP5 gets
promoted to function 0 (RP1's function) since no earlier functions are
enabled.
This simplifies later refactoring that will handle the FSP root port
enable flags (which were correctly set already) using the device tree
enables.
Test: Boot librem_13v2 and verify WLAN is enabled.
Change-Id: I7a724a01b5f171a16de83ff6122630e2d66557c1
Signed-off-by: Jonathon Hall <jonathon.hall(a)puri.sm>
---
M src/mainboard/purism/librem_skl/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/80065/1
diff --git a/src/mainboard/purism/librem_skl/devicetree.cb b/src/mainboard/purism/librem_skl/devicetree.cb
index 1928d15..08a88d6 100644
--- a/src/mainboard/purism/librem_skl/devicetree.cb
+++ b/src/mainboard/purism/librem_skl/devicetree.cb
@@ -157,7 +157,7 @@
device ref south_xdci on end
device ref thermal on end
device ref sata on end
- device ref pcie_rp1 on end
+ device ref pcie_rp5 on end
device ref pcie_rp9 on end
device ref lpc_espi on
chip drivers/pc80/tpm
--
To view, visit https://review.coreboot.org/c/coreboot/+/80065?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a724a01b5f171a16de83ff6122630e2d66557c1
Gerrit-Change-Number: 80065
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-MessageType: newchange