Attention is currently required from: Arthur Heymans, Christian Walter, Jeff Daly, Johnny Lin, Marek Maślanka, Sean Rhodes, Tim Chu, Vanessa Eusebio.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80005?usp=email )
Change subject: soc/intel: Unify the definition of TCO registers
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80005/comment/0a511e16_f2ddba67 :
PS6, Line 9: Move TCO registers definition to a separate file and use it
: consistently.
> Added some explanation. […]
Acknowledged
Commit Message:
https://review.coreboot.org/c/coreboot/+/80005/comment/5d83020e_d1472ae8 :
PS8, Line 10: Only leaves those TCO register
: definitions that are incompatible.
"Do not unify TCO for older incompatible platforms"
--
To view, visit https://review.coreboot.org/c/coreboot/+/80005?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id64a635d106cea879ab08aa7beca101de14b1ee6
Gerrit-Change-Number: 80005
Gerrit-PatchSet: 8
Gerrit-Owner: Marek Maślanka <mmaslanka(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marek Maślanka <mmaslanka(a)google.com>
Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 16:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marek Maślanka <mmaslanka(a)google.com>
Comment-In-Reply-To: Jakub Czapiga <czapiga(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Nick Vaccaro.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79916?usp=email )
Change subject: mb/google/brya: Drop primus4es board
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79916/comment/f8d629cc_a3ed8f8a :
PS2, Line 10:
> appreciate if you can add a TEST line saying there is no impact of build w/ and w/o this cl.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79916?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0502b2eed6f80d648b422c8d1622d504a6c93822
Gerrit-Change-Number: 79916
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marek Maślanka <mmaslanka(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 18 Jan 2024 16:02:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Nick Vaccaro.
Hello Eric Lai, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79916?usp=email
to look at the new patch set (#3).
Change subject: mb/google/brya: Drop primus4es board
......................................................................
mb/google/brya: Drop primus4es board
Primus4es board is no longer supported thus drop it from the tree.
TEST=Build all Brya boards in CrOS-SDK - Primus4ES not built. No negative impact observed.
Change-Id: I0502b2eed6f80d648b422c8d1622d504a6c93822
Signed-off-by: Jakub Czapiga <czapiga(a)google.com>
---
M Documentation/security/vboot/list_vboot.md
M src/mainboard/google/brox/Kconfig
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/Kconfig.name
D src/mainboard/google/brya/variants/primus4es/Makefile.inc
D src/mainboard/google/brya/variants/primus4es/fw_config.c
D src/mainboard/google/brya/variants/primus4es/gpio.c
D src/mainboard/google/brya/variants/primus4es/include/variant/ec.h
D src/mainboard/google/brya/variants/primus4es/include/variant/gpio.h
D src/mainboard/google/brya/variants/primus4es/memory/Makefile.inc
D src/mainboard/google/brya/variants/primus4es/memory/dram_id.generated.txt
D src/mainboard/google/brya/variants/primus4es/memory/mem_parts_used.txt
D src/mainboard/google/brya/variants/primus4es/overridetree.cb
D src/mainboard/google/brya/variants/primus4es/variant.c
14 files changed, 0 insertions(+), 828 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/79916/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/79916?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0502b2eed6f80d648b422c8d1622d504a6c93822
Gerrit-Change-Number: 79916
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marek Maślanka <mmaslanka(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80062?usp=email )
Change subject: mb/google/brya/var/*: Ensure LCD device has a valid address
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/anahera/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80062/comment/28b88e32_8b4ae2ca :
PS1, Line 122: 0x80010400
> > the short answer is I copied it from the other Brya variants which did set it already 😊 (Also the […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80062?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id24e330cfb7c993d12665a704e1ca78e2e38874f
Gerrit-Change-Number: 80062
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:48:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Kapil Porwal, Matt DeVillier, Nick Vaccaro.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80062?usp=email
to look at the new patch set (#2).
Change subject: mb/google/brya/var/*: Ensure LCD device has a valid address
......................................................................
mb/google/brya/var/*: Ensure LCD device has a valid address
Some variants added the generic gfx driver with an LCD device without
specifying the address, which is required for the backlight controls
to be functional under Windows. Add the address value where missing.
Address value used (0x80010400) is same as on other Brya variants which
did properly set it, and is taken from the ACPI 6.5 spec section B.4.2,
_DOD (display output device enumeration), table B-2:
- bit 31 = use the ACPI-defined (vs vendor-defined) bit scheme for bits
15-0
- bit 16 = platform firmware can detect the device
- bit 10 = display type is internal/integrated flat panel (aka LCD)
TEST=build/boot Win11 on google/brya (osiris), verify ACPI backlight
controls functional.
Change-Id: Id24e330cfb7c993d12665a704e1ca78e2e38874f
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/brya/variants/anahera/overridetree.cb
M src/mainboard/google/brya/variants/anahera4es/overridetree.cb
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
M src/mainboard/google/brya/variants/banshee/overridetree.cb
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/crota/overridetree.cb
M src/mainboard/google/brya/variants/dochi/overridetree.cb
M src/mainboard/google/brya/variants/felwinter/overridetree.cb
M src/mainboard/google/brya/variants/gimble/overridetree.cb
M src/mainboard/google/brya/variants/gimble4es/overridetree.cb
M src/mainboard/google/brya/variants/kano/overridetree.cb
M src/mainboard/google/brya/variants/marasov/overridetree.cb
M src/mainboard/google/brya/variants/mithrax/overridetree.cb
M src/mainboard/google/brya/variants/omnigul/overridetree.cb
M src/mainboard/google/brya/variants/osiris/overridetree.cb
M src/mainboard/google/brya/variants/primus/overridetree.cb
M src/mainboard/google/brya/variants/primus4es/overridetree.cb
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
M src/mainboard/google/brya/variants/skolas/overridetree.cb
M src/mainboard/google/brya/variants/skolas4es/overridetree.cb
M src/mainboard/google/brya/variants/taeko/overridetree.cb
M src/mainboard/google/brya/variants/taeko4es/overridetree.cb
M src/mainboard/google/brya/variants/taniks/overridetree.cb
M src/mainboard/google/brya/variants/vell/overridetree.cb
M src/mainboard/google/brya/variants/volmar/overridetree.cb
26 files changed, 52 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/80062/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80062?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id24e330cfb7c993d12665a704e1ca78e2e38874f
Gerrit-Change-Number: 80062
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Kapil Porwal, Matt DeVillier, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80062?usp=email )
Change subject: mb/google/brya/var/*: Ensure LCD device has a valid address
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/anahera/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80062/comment/af4d5c38_9a75e6e3 :
PS1, Line 122: 0x80010400
> the short answer is I copied it from the other Brya variants which did set it already 😊 (Also the same value used by the GMA driver for the LCD as device 0 on first port).
>
> Long answer:
> - bit 31 = use the ACPI-defined (vs vendor-defined) bit scheme for bits 15-0
> - bit 16 = platform firmware can detect the device
> - bit 10 = display type is internal/integrated flat panel (aka LCD)
>
> from ACPI spec 6.5, table B-2.
can u please capture that as part of commit msg
--
To view, visit https://review.coreboot.org/c/coreboot/+/80062?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id24e330cfb7c993d12665a704e1ca78e2e38874f
Gerrit-Change-Number: 80062
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:43:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80062?usp=email )
Change subject: mb/google/brya/var/*: Ensure LCD device has a valid address
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/anahera/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80062/comment/477287de_9c946c70 :
PS1, Line 122: 0x80010400
> can u please mention the formula used to derive this hex value ?
the short answer is I copied it from the other Brya variants which did set it already 😊 (Also the same value used by the GMA driver for the LCD as device 0 on first port).
Long answer:
- bit 31 = use the ACPI-defined (vs vendor-defined) bit scheme for bits 15-0
- bit 16 = platform firmware can detect the device
- bit 10 = display type is internal/integrated flat panel (aka LCD)
from ACPI spec 6.5, table B-2.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80062?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id24e330cfb7c993d12665a704e1ca78e2e38874f
Gerrit-Change-Number: 80062
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:36:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Maximilian Brune, Philipp Hug, ron minnich.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79948?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: arch/riscv: Add OPENSBI_FW_DYNAMIC_BOOT_HART option
......................................................................
Patch Set 1:
(1 comment)
File src/arch/riscv/Kconfig:
https://review.coreboot.org/c/coreboot/+/79948/comment/7b7055f6_6afcddf5 :
PS1, Line 76: It is not OpenSBI will again
this parts sounds odd to me
--
To view, visit https://review.coreboot.org/c/coreboot/+/79948?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id58bd6ae3b55a5ef3f1a5c97dfa07c79aa4c78d0
Gerrit-Change-Number: 79948
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:33:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Kapil Porwal, Matt DeVillier, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80062?usp=email )
Change subject: mb/google/brya/var/*: Ensure LCD device has a valid address
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/anahera/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80062/comment/d4411513_4f712bf4 :
PS1, Line 122: 0x80010400
can u please mention the formula used to derive this hex value ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80062?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id24e330cfb7c993d12665a704e1ca78e2e38874f
Gerrit-Change-Number: 80062
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:31:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment