Attention is currently required from: Felix Held, Name of user not set #1005314.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80003?usp=email )
Change subject: util/superiotool: add support for Nuvoton NCT6796D
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> i'd expect some of the bytes in the gpio ldns that correspond to the states of the inputs to be NANA
This part doesn't have dedicated input registers, but instead uses port data registers that have both input and output state, so NANA doesn't apply for all cases. One would need to check the associated status register first to see if the GPIO is configured as an input to determine if the data register should be NANA.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0ff940a17b0c38a5ca66e90dd4e075a2b04dcfc1
Gerrit-Change-Number: 80003
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Name of user not set #1005314
Gerrit-Attention: Name of user not set #1005314
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Chen, Gang C, Cliff Huang, Jincheng Li, Lance Zhao, Paul Menzel, Shuo Liu, Tim Wawrzynczak.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78334?usp=email )
Change subject: device/device.h: Drop acpi_inject_dsdt
......................................................................
Patch Set 15: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78334?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iffefc865901b15fa299931b6ed4c27a9e3a1c330
Gerrit-Change-Number: 78334
Gerrit-PatchSet: 15
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:05:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80022?usp=email )
Change subject: mb/siemens/chili: Use chipset dt reference names
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2:
Part of the chipset-devicetree idea is that we don't have to repeat as much
on/off state in the mainboard devicetrees. So for the future, it would reduce
effort to remove the now unnecessary lines first.
File src/mainboard/siemens/chili/variants/base/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80022/comment/e8a76b41_d0b14acb :
PS2, Line 13:
Nit, it looks like the second tab isn't needed in any line.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80022?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3a4c85ec6bfdc858f9b6f79b114cf612ad3a153
Gerrit-Change-Number: 80022
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:04:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Name of user not set #1005314.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80003?usp=email )
Change subject: util/superiotool: add support for Nuvoton NCT6796D
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
i'd expect some of the bytes in the gpio ldns that correspond to the states of the inputs to be NANA
--
To view, visit https://review.coreboot.org/c/coreboot/+/80003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0ff940a17b0c38a5ca66e90dd4e075a2b04dcfc1
Gerrit-Change-Number: 80003
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Name of user not set #1005314
Gerrit-Attention: Name of user not set #1005314
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 15:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Karthik Ramasubramanian, Krishna P Bhat D, Nick Vaccaro, Paul Menzel, Poornima Tom, Subrata Banik, Vamshi Krishna Gopal.
Vamshi Krishna Gopal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79415?usp=email )
Change subject: mb/intel/adlrvp: Add Realtek ALC256 audio verb table
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
> > > > Subrata, I just relooked into the other designs where we are using verb table, (eg: src/mainboard/starlabs/starbook/variants/tgl/hda_verb.c) , Verb table holds register values for multiple audio endpoint and for chrome designs these values are same most of the time but in few rare cases where we need some tunning
> > >
> > > can you please point me to the endpoint configuration section belongs to the verb table ?
> > >
> > To give an overview on endpoints , we can look into the each widget NID (node id)defined , each widget NID is mapped to corresponding applicable endpoints based on codec.
> > to operate the codec we send the instructions in verbs (32-bit registers),31:28 reserved bit, 27:20 indicates NID , 19:8 verb id , 0:7 payload bits.
> >
> >
> > the current widget NID for ALC256 endpoints are mapped like this
> >
> > NID 0x01 : CODEC power reset
> > NID 0x12 : CODEC DMIC
> > NID 0x13 : CODEC DMIC
> > NID 0x14 : front jack , lineout for jack device
> > NID 0x18 : MIC1 , mic input for MIC device
> > NID 0x19 : MIC2 , mic input for MIC device
> > NID 0x1A : Line1 jack, Linein for jack device
> > NID 0x1B : NPC audio effect
> > NID 0x1D : BEEP-IN, input for codec beep
> > NID 0x1E : SPDIF-OUT, S/PDIF out device
> > NID 0x21 : Line2 jack, Headphone out for jack device
> > NID 0x20 : for codec common settings
> >
> >
> > > > or we dont want custom set of endpoints wrt design needs, we wont be able to change them if we have verb table as generic, so i was thinking
> > >
> > > based on your response, i might be able to share some further thoughts
> > >
> > > >
> > > > we can have 2 options here,
> > > >
> > > > 1. If the current design audio endpoints aligns with generic verb table we can use generic verbtable.
> > > > 2. If the current design audio endpoints doesnt align with generic verb table we can have custome verbtable specific to that design.
> > > >
> > > > Let me know your thoughts.
> > >
> > > I agree with you.
>
> thanks for the details. can we generate the verb table depending on those configurable value ? for example: can we skip NID -x14 if front jack is not present in some design ?
yes correct , we can keep only required NID based on design. In current verb table as well we have skipped CODEC DMIC (NID,12,13).
--
To view, visit https://review.coreboot.org/c/coreboot/+/79415?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8215e445dae4760ad15f69860968013e88a77af0
Gerrit-Change-Number: 79415
Gerrit-PatchSet: 7
Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com>
Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 13:51:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.corp-partner.google.com>
Gerrit-MessageType: comment