Attention is currently required from: Eric Lai, Kapil Porwal, Leo Chou, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80024?usp=email )
Change subject: mb/google/brya/var/pujjo: Add i2c device for Parade touch screen
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80024?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I51bd89beffd912fc147da11d19f38cb44cbe570a
Gerrit-Change-Number: 80024
Gerrit-PatchSet: 3
Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 11:07:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Karthik Ramasubramanian, Krishna P Bhat D, Nick Vaccaro, Paul Menzel, Poornima Tom, Vamshi Krishna Gopal, Vamshi Krishna Gopal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79415?usp=email )
Change subject: mb/intel/adlrvp: Add Realtek ALC256 audio verb table
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
> Subrata, I just relooked into the other designs where we are using verb table, (eg: src/mainboard/starlabs/starbook/variants/tgl/hda_verb.c) , Verb table holds register values for multiple audio endpoint and for chrome designs these values are same most of the time but in few rare cases where we need some tunning
can you please point me to the endpoint configuration section belongs to the verb table ?
> or we dont want custom set of endpoints wrt design needs, we wont be able to change them if we have verb table as generic, so i was thinking
based on your response, i might be able to share some further thoughts
>
> we can have 2 options here,
>
> 1. If the current design audio endpoints aligns with generic verb table we can use generic verbtable.
> 2. If the current design audio endpoints doesnt align with generic verb table we can have custome verbtable specific to that design.
>
> Let me know your thoughts.
I agree with you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79415?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8215e445dae4760ad15f69860968013e88a77af0
Gerrit-Change-Number: 79415
Gerrit-PatchSet: 7
Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com>
Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 11:06:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.corp-partner.google.com>
Gerrit-MessageType: comment
Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78329?usp=email )
Change subject: device/device.h: Fix outdated comment
......................................................................
device/device.h: Fix outdated comment
LAPIC devices in devicetree is not possible any longer since commit
3eba665 "util/sconfig: Remove lapic devices from devicetree parsers".
TEST=intel/archercity CRB
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: I02192c9a11c35d9625837a8a9f3ba798ff0ae611
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78329
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Shuo Liu <shuo.liu(a)intel.com>
Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com>
---
M src/include/device/device.h
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
build bot (Jenkins): Verified
Lean Sheng Tan: Looks good to me, approved
Shuo Liu: Looks good to me, but someone else must approve
diff --git a/src/include/device/device.h b/src/include/device/device.h
index 50307e6..752e1c0 100644
--- a/src/include/device/device.h
+++ b/src/include/device/device.h
@@ -229,14 +229,7 @@
void mp_init_cpus(DEVTREE_CONST struct bus *cpu_bus);
static inline void mp_cpu_bus_init(struct device *dev)
{
- /*
- * When no LAPIC device is specified in the devicetree inside the CPU cluster device,
- * neither a LAPIC device nor the link/bus between the CPU cluster and the LAPIC device
- * will be present in the static device tree and the link_list struct element of the
- * CPU cluster device will be NULL. In this case add one link, so that the
- * alloc_find_dev calls in init_bsp and allocate_cpu_devices will be able to add a
- * LAPIC device for the BSP and the APs on this link/bus.
- */
+ /* Make sure the cpu cluster has a downstream bus for LAPICs to be allocated. */
if (!dev->link_list)
add_more_links(dev, 1);
--
To view, visit https://review.coreboot.org/c/coreboot/+/78329?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I02192c9a11c35d9625837a8a9f3ba798ff0ae611
Gerrit-Change-Number: 78329
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-CC: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-MessageType: merged
Attention is currently required from: Arthur Heymans, Felix Held, Paul Menzel, Shuo Liu.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78329?usp=email )
Change subject: device/device.h: Fix outdated comment
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
Only commit message update and rebase since patch set 8 that has been +2. getting this merged.
--
To view, visit https://review.coreboot.org/c/coreboot/+/78329?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I02192c9a11c35d9625837a8a9f3ba798ff0ae611
Gerrit-Change-Number: 78329
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-CC: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 10:47:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Chen, Gang C, Cliff Huang, Felix Held, Jincheng Li, Lance Zhao, Paul Menzel, Shuo Liu, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78334?usp=email )
Change subject: device/device.h: Drop acpi_inject_dsdt
......................................................................
Patch Set 15: Code-Review+1
(1 comment)
Patchset:
PS15:
If it'd be ever needed again, we can just get it back.
--
To view, visit https://review.coreboot.org/c/coreboot/+/78334?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iffefc865901b15fa299931b6ed4c27a9e3a1c330
Gerrit-Change-Number: 78334
Gerrit-PatchSet: 15
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 10:33:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Kapil Porwal, Leo Chou, Nick Vaccaro, Subrata Banik.
Hello Derek Huang, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80024?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by Eric Lai
Change subject: mb/google/brya/var/pujjo: Add i2c device for Parade touch screen
......................................................................
mb/google/brya/var/pujjo: Add i2c device for Parade touch screen
Add new i2c address 0x24 of touch IC for Parade touch panel.
BUG=b:320731709
Test=emerge-nissa coreboot
Change-Id: I51bd89beffd912fc147da11d19f38cb44cbe570a
Signed-off-by: leo.chou <leo.chou(a)lcfc.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/pujjo/overridetree.cb
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/80024/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80024?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I51bd89beffd912fc147da11d19f38cb44cbe570a
Gerrit-Change-Number: 80024
Gerrit-PatchSet: 3
Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-MessageType: newpatchset