Attention is currently required from: Jonathon Hall.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80055?usp=email )
Change subject: mb/purism/librem_l1um_v2: Use chipset dt reference names
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/purism/librem_l1um_v2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80055/comment/dc8634ae_c2f9362f :
PS1, Line 44: device pci 01.0 on # PCIE6 - x16 or x8
> PCIE6, PCIE4, PCIE5, and M2_1 are silkscreened on the board, those comments are still relevant to re […]
I thought they might be superfluous since the smbios lines say the same. Should I still restore them? I'm fine with it, just checking.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80055?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id592241a1dc33559115800da10a57a5fc10867f9
Gerrit-Change-Number: 80055
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Comment-Date: Thu, 18 Jan 2024 18:50:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80056?usp=email )
Change subject: mb/purism/librem_cnl: Use chipset dt reference names
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80056?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I87cec9026bcb621ceb7eae51f65ae35bc31d584a
Gerrit-Change-Number: 80056
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 17:54:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80055?usp=email )
Change subject: mb/purism/librem_l1um_v2: Use chipset dt reference names
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/purism/librem_l1um_v2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80055/comment/13285999_8c361c6d :
PS1, Line 44: device pci 01.0 on # PCIE6 - x16 or x8
PCIE6, PCIE4, PCIE5, and M2_1 are silkscreened on the board, those comments are still relevant to relate the device tree to the physical slots. Please restore those.
Otherwise I think this looks good, thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80055?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id592241a1dc33559115800da10a57a5fc10867f9
Gerrit-Change-Number: 80055
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 17:51:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email )
Change subject: Makefiles: Rename top-level Makefiles from .inc to .mak
......................................................................
Makefiles: Rename top-level Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
The rest of the Makefiles will be renamed in following commits.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
---
M Makefile
R Makefile.mak
R payloads/Makefile.mak
M payloads/coreinfo/Makefile
M payloads/libpayload/Makefile
R tests/Makefile.mak
R toolchain.mak
R util/kconfig/Makefile.mak
M util/lint/kconfig_lint
R util/testing/Makefile.mak
10 files changed, 19 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/80063/1
diff --git a/Makefile b/Makefile
index b521f04..fad7f44 100644
--- a/Makefile
+++ b/Makefile
@@ -50,7 +50,7 @@
SYMLINK_LIST = $(call rwildcard,site-local/,symlink.txt)
-# directory containing the toplevel Makefile.inc
+# Directory containing the toplevel Makefile.mak
TOPLEVEL := .
CONFIG_SHELL := sh
@@ -102,7 +102,7 @@
# This include must come _before_ the pattern rules below!
# Order _does_ matter for pattern rules.
-include $(srck)/Makefile.inc
+include $(srck)/Makefile.mak
# The cases where we don't need fully populated $(obj) lists:
# 1. when no .config exists
@@ -153,11 +153,12 @@
HOSTCC ?= $(if $(shell type gcc 2>/dev/null),gcc,cc)
HOSTCXX ?= g++
-include $(TOPLEVEL)/Makefile.inc
-include $(TOPLEVEL)/payloads/Makefile.inc
-include $(TOPLEVEL)/util/testing/Makefile.inc
+include $(TOPLEVEL)/Makefile.mak
+include $(TOPLEVEL)/payloads/Makefile.mak
+include $(TOPLEVEL)/util/testing/Makefile.mak
+-include $(TOPLEVEL)/site-local/Makefile.mak
-include $(TOPLEVEL)/site-local/Makefile.inc
-include $(TOPLEVEL)/tests/Makefile.inc
+include $(TOPLEVEL)/tests/Makefile.mak
printall real-all:
@echo "Error: Trying to build, but NOCOMPILE is set." >&2
@echo " Please file a bug with the following information:"
@@ -198,7 +199,7 @@
export LANG LC_ALL TZ SOURCE_DATE_EPOCH
ifneq ($(UNIT_TEST),1)
-include toolchain.inc
+include toolchain.mak
endif
strip_quotes = $(strip $(subst ",,$(subst \",,$(1))))
@@ -276,7 +277,7 @@
$(subst .$(1),,\
$(filter %.ads %.adb,$(2)))))))))
-# Clean -y variables, include Makefile.inc
+# Clean -y variables, include Makefile.mak & Makefile.inc
# Add paths to files in X-y to X-srcs
# Add subdirs-y to subdirs
includemakefiles= \
@@ -295,10 +296,13 @@
# For each path in $(subdirs) call includemakefiles
# Repeat until subdirs is empty
+# TODO: Remove Makefile.inc support
evaluate_subdirs= \
$(eval cursubdirs:=$(subdirs)) \
$(eval subdirs:=) \
$(foreach dir,$(cursubdirs), \
+ $(eval $(call includemakefiles,$(dir)/Makefile.mak))) \
+ $(foreach dir,$(cursubdirs), \
$(eval $(call includemakefiles,$(dir)/Makefile.inc))) \
$(if $(subdirs),$(eval $(call evaluate_subdirs)))
@@ -306,11 +310,11 @@
subdirs:=$(TOPLEVEL)
postinclude-hooks :=
-# Don't iterate through Makefile.incs under src/ when building tests
+# Don't iterate through Makefiles under src/ when building tests
ifneq ($(UNIT_TEST),1)
$(eval $(call evaluate_subdirs))
else
-include $(TOPLEVEL)/tests/Makefile.inc
+include $(TOPLEVEL)/tests/Makefile.mak
endif
ifeq ($(FAILBUILD),1)
diff --git a/Makefile.inc b/Makefile.mak
similarity index 99%
rename from Makefile.inc
rename to Makefile.mak
index 23f56a4..de2598c 100644
--- a/Makefile.inc
+++ b/Makefile.mak
@@ -1158,7 +1158,7 @@
endif # ifeq ($(CONFIG_ARCH_X86),y)
-$(obj)/fmap.fmd: $(top)/Makefile.inc $(DEFAULT_FLASHMAP) $(obj)/config.h
+$(obj)/fmap.fmd: $(top)/Makefile.mak $(DEFAULT_FLASHMAP) $(obj)/config.h
sed -e "s,##ROM_BASE##,$(FMAP_ROM_ADDR)," \
-e "s,##ROM_SIZE##,$(FMAP_ROM_SIZE)," \
-e "s,##BIOS_BASE##,$(FMAP_BIOS_BASE)," \
diff --git a/payloads/Makefile.inc b/payloads/Makefile.mak
similarity index 100%
rename from payloads/Makefile.inc
rename to payloads/Makefile.mak
diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile
index 096e9c6..332d9f6 100644
--- a/payloads/coreinfo/Makefile
+++ b/payloads/coreinfo/Makefile
@@ -70,7 +70,7 @@
$(shell mkdir -p $(objk)/lxdialog $(KCONFIG_SPLITCONFIG))
-include $(srck)/Makefile.inc
+include $(srck)/Makefile.mak
.PHONY: $(PHONY) prepare all real-all defaultbuild
diff --git a/payloads/libpayload/Makefile b/payloads/libpayload/Makefile
index 0104a11..4c72dc1 100644
--- a/payloads/libpayload/Makefile
+++ b/payloads/libpayload/Makefile
@@ -103,7 +103,7 @@
# This include must come _before_ the pattern rules below!
# Order _does_ matter for pattern rules.
-include $(srck)/Makefile.inc
+include $(srck)/Makefile.mak
include $(HAVE_DOTCONFIG)
@@ -127,7 +127,7 @@
# 3. when make distclean is run
# 4. when make help% or make clean% is run
# 5. when make %-test or make %-tests or make %coverage-report is run
-# Don't waste time on reading all Makefile.incs in these cases
+# Don't waste time on reading all Makefiles in these cases
ifeq ($(strip $(HAVE_DOTCONFIG)),)
NOCOMPILE := 1
endif
diff --git a/tests/Makefile.inc b/tests/Makefile.mak
similarity index 100%
rename from tests/Makefile.inc
rename to tests/Makefile.mak
diff --git a/toolchain.inc b/toolchain.mak
similarity index 100%
rename from toolchain.inc
rename to toolchain.mak
diff --git a/util/kconfig/Makefile.inc b/util/kconfig/Makefile.mak
similarity index 100%
rename from util/kconfig/Makefile.inc
rename to util/kconfig/Makefile.mak
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index e67aebd..0a43769 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -36,7 +36,7 @@
'^build/\|^coreboot-builds/\|^configs/\|^util/\|^\.git/\|^payloads\|^Documentation\|^3rdparty'
. '\|' . # directories to exclude when searching for used symbols
'\.config\|\.txt$\|\.tex$\|\.tags\|/kconfig.h\|\.fmd'; #files to exclude when looking for symbols
-my $payload_files_to_check='payloads/Makefile.inc payloads/external/Makefile.inc';
+my $payload_files_to_check='payloads/Makefile.mak payloads/external/Makefile.inc';
my $config_file = ""; # name of config file to load symbol values from.
my @wholeconfig; # document the entire kconfig structure
my %loaded_files; # list of each Kconfig file loaded
diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.mak
similarity index 100%
rename from util/testing/Makefile.inc
rename to util/testing/Makefile.mak
--
To view, visit https://review.coreboot.org/c/coreboot/+/80063?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
Gerrit-Change-Number: 80063
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Andrey Petrov, Julius Werner, Jérémy Compostella, Martin L Roth, Maximilian Brune, Ronak Kanabar.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79905?usp=email )
Change subject: [RFC] region: Introduce region_create() functions
......................................................................
Patch Set 6:
(1 comment)
File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/c/coreboot/+/79905/comment/5fbf05c6_2ab8fbe8 :
PS1, Line 106: offset > SIZE_MAX || size > SIZE_MAX
> Hmmm... well, okay, if you feel strongly about it I guess it doesn't really hurt.
>
> However, don't you need to cast down to `size_t` for the overlap check?
Thanks! absolutely, yes, when the check is written like this.
>
> (Also, it would be a little more efficient to just create the region struct directly rather than calling `region_create()`, since you've already checked the overlap here, you don't need to go through that `assert()` again.)
Also true, good suggestion.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79905?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ae3e6274c981c9ab4fb1263c2a72fa68ef1c32b
Gerrit-Change-Number: 79905
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 17:11:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79945?usp=email )
Change subject: [NEEDS TEST] region: Check for overflows after offset calculation
......................................................................
Patch Set 3:
(1 comment)
File src/commonlib/region.c:
https://review.coreboot.org/c/coreboot/+/79945/comment/5ddb4a65_63635f9d :
PS3, Line 25: return region_end(inner) - 1 >= region_offset(inner) &&
> I haven't been able to think of a use case for it yet, so I'd say let's try forbidding it and see if […]
Technically, we don't have to decide. It's just a little more code to
support both cases. Anyway, what do you think about leaving an assert in
region_is_subregion()? and all the other public APIs? would that be too
much overhead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79945?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia6054e6e9b6f13502351a2d94c8a0af15266e43e
Gerrit-Change-Number: 79945
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 18 Jan 2024 17:11:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79983?usp=email )
Change subject: soc/amd/phoenix/Kconfig: factor out FSP-specific options
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/phoenix/Kconfig:
https://review.coreboot.org/c/coreboot/+/79983/comment/28173e64_e72cf4e0 :
PS2, Line 197: config FSP_M_SIZE
> Should these be protected in the FSP section?
verified that the actual usage of those depends on PLATFORM_USES_FSP2_0 being selected, so i moved those into an if SOC_AMD_PHOENIX_FSP block
--
To view, visit https://review.coreboot.org/c/coreboot/+/79983?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e95fbfd9d16930ba3e6cc497557d61adba5a6fa
Gerrit-Change-Number: 79983
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 17:07:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier.
Hello Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79983?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by Martin Roth, Verified+1 by build bot (Jenkins)
Change subject: soc/amd/phoenix/Kconfig: factor out FSP-specific options
......................................................................
soc/amd/phoenix/Kconfig: factor out FSP-specific options
Split the SOC_AMD_PHOENIX Kconfig option into SOC_AMD_PHOENIX_BASE that
selects the non-FSP-specific options and SOC_AMD_PHOENIX_FSP that
selects both SOC_AMD_PHOENIX_BASE and the FSP-specific options. This
will help to separate the FSP-specific from the FSP-agnostic code. The
mainboards using this SoC now select SOC_AMD_PHOENIX_FSP instead of
SOC_AMD_PHOENIX.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I5e95fbfd9d16930ba3e6cc497557d61adba5a6fa
---
M src/mainboard/amd/birman/Kconfig
M src/mainboard/amd/mayan/Kconfig
M src/mainboard/google/myst/Kconfig
M src/soc/amd/phoenix/Kconfig
M src/soc/amd/phoenix/Makefile.inc
5 files changed, 47 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/79983/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/79983?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e95fbfd9d16930ba3e6cc497557d61adba5a6fa
Gerrit-Change-Number: 79983
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79983?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/amd/phoenix/Kconfig: factor out FSP-specific options
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/phoenix/Kconfig:
https://review.coreboot.org/c/coreboot/+/79983/comment/05fe2860_28f73edc :
PS2, Line 197: config FSP_M_SIZE
Should these be protected in the FSP section?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79983?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e95fbfd9d16930ba3e6cc497557d61adba5a6fa
Gerrit-Change-Number: 79983
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 16:58:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment