Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Hello Fred Reitberger, Jason Glenesk, Matt DeVillier,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80002?usp=email
to look at the new patch set (#2).
Change subject: soc/amd/*/romstage: factor out FSP-M call
......................................................................
soc/amd/*/romstage: factor out FSP-M call
Move the call into the FSP code to a file in the common AMD FSP code to
isolate the FSP-specific parts of the code and a preparation to make the
romstage of all non-CAR AMD SoCs common. Without isolating the call into
the FSP-M code, building the common romstage would fail for genoa_poc
due to fsp/api.h not being in the include path.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I30cf1bee2ec1a507dc8e61eaf44067663e2505ae
---
M src/soc/amd/cezanne/romstage.c
A src/soc/amd/common/block/include/amdblocks/fsp.h
M src/soc/amd/common/fsp/Makefile.inc
A src/soc/amd/common/fsp/fsp_romstage.c
M src/soc/amd/glinda/romstage.c
M src/soc/amd/mendocino/romstage.c
M src/soc/amd/phoenix/romstage.c
M src/soc/amd/picasso/romstage.c
8 files changed, 29 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/80002/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80002?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I30cf1bee2ec1a507dc8e61eaf44067663e2505ae
Gerrit-Change-Number: 80002
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jakub Czapiga, Martin L Roth.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Makefiles: Rename top-level Makefiles from .inc to .mak
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80063/comment/77c982e2_f969c59d :
PS2, Line 10: This means that editors don't recognize the files, and don't
: open them with highlighting and any other specific editor functionality.
:
Do editors know the .mak file suffix as Makefile? Linux seems to use Makefile everywhere. make would generally not be able to do anything useful in most dirs, instead of complaining about the lack of a makefile. I don't know if that's so much better to warrant using a suffix?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80063?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
Gerrit-Change-Number: 80063
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 20:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Cliff Huang, Julius Werner, Jérémy Compostella, Lance Zhao, Martin L Roth, Philipp Hug, Tim Wawrzynczak, ron minnich.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80066?usp=email )
Change subject: acpi,arch,commonlib: Rename Makefiles from .inc to Makefile.mak
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80066/comment/d940840a_7063896a :
PS1, Line 7: Makefile
I guess that's not intended? The others only have the file extension
Patchset:
PS1:
> Let me know if you'd prefer that I just move all of the name changes into a single patch, then clean […]
I think separate patches are good. We could make the patches ready and then submit them in one go.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80066?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice5dadd3eaadfa9962225520a3a75b05b44518ca
Gerrit-Change-Number: 80066
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 19:56:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Cliff Huang, Julius Werner, Jérémy Compostella, Lance Zhao, Philipp Hug, Tim Wawrzynczak, ron minnich.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80066?usp=email )
Change subject: acpi,arch,commonlib: Rename Makefiles from .inc to Makefile.mak
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Let me know if you'd prefer that I just move all of the name changes into a single patch, then clean up things after that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80066?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice5dadd3eaadfa9962225520a3a75b05b44518ca
Gerrit-Change-Number: 80066
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 19:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80071?usp=email )
Change subject: soc/amd/*: Rename Makefiles from .inc to .mak
......................................................................
soc/amd/*: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ie449267fe4fdd75110f577e1b9f748cd06140950
---
R src/soc/amd/cezanne/Makefile.mak
R src/soc/amd/cezanne/psp_verstage/Makefile.mak
R src/soc/amd/common/Makefile.mak
R src/soc/amd/common/block/Makefile.mak
R src/soc/amd/common/block/acp/Makefile.mak
R src/soc/amd/common/block/acpi/Makefile.mak
R src/soc/amd/common/block/acpimmio/Makefile.mak
R src/soc/amd/common/block/alink/Makefile.mak
R src/soc/amd/common/block/aoac/Makefile.mak
R src/soc/amd/common/block/apob/Makefile.mak
R src/soc/amd/common/block/cpu/Makefile.mak
R src/soc/amd/common/block/cpu/car/Makefile.mak
R src/soc/amd/common/block/cpu/mca/Makefile.mak
R src/soc/amd/common/block/cpu/noncar/Makefile.mak
R src/soc/amd/common/block/cpu/smm/Makefile.mak
R src/soc/amd/common/block/cpu/tsc/Makefile.mak
R src/soc/amd/common/block/data_fabric/Makefile.mak
R src/soc/amd/common/block/emmc/Makefile.mak
R src/soc/amd/common/block/gpio/Makefile.mak
R src/soc/amd/common/block/graphics/Makefile.mak
R src/soc/amd/common/block/hda/Makefile.mak
R src/soc/amd/common/block/i2c/Makefile.mak
R src/soc/amd/common/block/iommu/Makefile.mak
R src/soc/amd/common/block/lpc/Makefile.mak
R src/soc/amd/common/block/pci/Makefile.mak
R src/soc/amd/common/block/pm/Makefile.mak
R src/soc/amd/common/block/psp/Makefile.mak
R src/soc/amd/common/block/root_complex/Makefile.mak
R src/soc/amd/common/block/sata/Makefile.mak
R src/soc/amd/common/block/simnow/Makefile.mak
R src/soc/amd/common/block/smbus/Makefile.mak
R src/soc/amd/common/block/smi/Makefile.mak
R src/soc/amd/common/block/smn/Makefile.mak
R src/soc/amd/common/block/smu/Makefile.mak
R src/soc/amd/common/block/spi/Makefile.mak
R src/soc/amd/common/block/stb/Makefile.mak
R src/soc/amd/common/block/uart/Makefile.mak
R src/soc/amd/common/block/xhci/Makefile.mak
R src/soc/amd/common/fsp/Makefile.mak
R src/soc/amd/common/fsp/pci/Makefile.mak
R src/soc/amd/common/pi/Makefile.mak
R src/soc/amd/common/psp_verstage/Makefile.mak
R src/soc/amd/common/vboot/Makefile.mak
R src/soc/amd/genoa_poc/Makefile.mak
R src/soc/amd/glinda/Makefile.mak
R src/soc/amd/glinda/psp_verstage/Makefile.mak
R src/soc/amd/mendocino/Makefile.mak
R src/soc/amd/mendocino/psp_verstage/Makefile.mak
R src/soc/amd/phoenix/Makefile.mak
R src/soc/amd/phoenix/psp_verstage/Makefile.mak
R src/soc/amd/picasso/Makefile.mak
R src/soc/amd/picasso/psp_verstage/Makefile.mak
R src/soc/amd/stoneyridge/Makefile.mak
53 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/80071/1
diff --git a/src/soc/amd/cezanne/Makefile.inc b/src/soc/amd/cezanne/Makefile.mak
similarity index 100%
rename from src/soc/amd/cezanne/Makefile.inc
rename to src/soc/amd/cezanne/Makefile.mak
diff --git a/src/soc/amd/cezanne/psp_verstage/Makefile.inc b/src/soc/amd/cezanne/psp_verstage/Makefile.mak
similarity index 100%
rename from src/soc/amd/cezanne/psp_verstage/Makefile.inc
rename to src/soc/amd/cezanne/psp_verstage/Makefile.mak
diff --git a/src/soc/amd/common/Makefile.inc b/src/soc/amd/common/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/Makefile.inc
rename to src/soc/amd/common/Makefile.mak
diff --git a/src/soc/amd/common/block/Makefile.inc b/src/soc/amd/common/block/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/Makefile.inc
rename to src/soc/amd/common/block/Makefile.mak
diff --git a/src/soc/amd/common/block/acp/Makefile.inc b/src/soc/amd/common/block/acp/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/acp/Makefile.inc
rename to src/soc/amd/common/block/acp/Makefile.mak
diff --git a/src/soc/amd/common/block/acpi/Makefile.inc b/src/soc/amd/common/block/acpi/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/acpi/Makefile.inc
rename to src/soc/amd/common/block/acpi/Makefile.mak
diff --git a/src/soc/amd/common/block/acpimmio/Makefile.inc b/src/soc/amd/common/block/acpimmio/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/acpimmio/Makefile.inc
rename to src/soc/amd/common/block/acpimmio/Makefile.mak
diff --git a/src/soc/amd/common/block/alink/Makefile.inc b/src/soc/amd/common/block/alink/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/alink/Makefile.inc
rename to src/soc/amd/common/block/alink/Makefile.mak
diff --git a/src/soc/amd/common/block/aoac/Makefile.inc b/src/soc/amd/common/block/aoac/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/aoac/Makefile.inc
rename to src/soc/amd/common/block/aoac/Makefile.mak
diff --git a/src/soc/amd/common/block/apob/Makefile.inc b/src/soc/amd/common/block/apob/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/apob/Makefile.inc
rename to src/soc/amd/common/block/apob/Makefile.mak
diff --git a/src/soc/amd/common/block/cpu/Makefile.inc b/src/soc/amd/common/block/cpu/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/cpu/Makefile.inc
rename to src/soc/amd/common/block/cpu/Makefile.mak
diff --git a/src/soc/amd/common/block/cpu/car/Makefile.inc b/src/soc/amd/common/block/cpu/car/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/cpu/car/Makefile.inc
rename to src/soc/amd/common/block/cpu/car/Makefile.mak
diff --git a/src/soc/amd/common/block/cpu/mca/Makefile.inc b/src/soc/amd/common/block/cpu/mca/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/cpu/mca/Makefile.inc
rename to src/soc/amd/common/block/cpu/mca/Makefile.mak
diff --git a/src/soc/amd/common/block/cpu/noncar/Makefile.inc b/src/soc/amd/common/block/cpu/noncar/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/cpu/noncar/Makefile.inc
rename to src/soc/amd/common/block/cpu/noncar/Makefile.mak
diff --git a/src/soc/amd/common/block/cpu/smm/Makefile.inc b/src/soc/amd/common/block/cpu/smm/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/cpu/smm/Makefile.inc
rename to src/soc/amd/common/block/cpu/smm/Makefile.mak
diff --git a/src/soc/amd/common/block/cpu/tsc/Makefile.inc b/src/soc/amd/common/block/cpu/tsc/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/cpu/tsc/Makefile.inc
rename to src/soc/amd/common/block/cpu/tsc/Makefile.mak
diff --git a/src/soc/amd/common/block/data_fabric/Makefile.inc b/src/soc/amd/common/block/data_fabric/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/data_fabric/Makefile.inc
rename to src/soc/amd/common/block/data_fabric/Makefile.mak
diff --git a/src/soc/amd/common/block/emmc/Makefile.inc b/src/soc/amd/common/block/emmc/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/emmc/Makefile.inc
rename to src/soc/amd/common/block/emmc/Makefile.mak
diff --git a/src/soc/amd/common/block/gpio/Makefile.inc b/src/soc/amd/common/block/gpio/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/gpio/Makefile.inc
rename to src/soc/amd/common/block/gpio/Makefile.mak
diff --git a/src/soc/amd/common/block/graphics/Makefile.inc b/src/soc/amd/common/block/graphics/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/graphics/Makefile.inc
rename to src/soc/amd/common/block/graphics/Makefile.mak
diff --git a/src/soc/amd/common/block/hda/Makefile.inc b/src/soc/amd/common/block/hda/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/hda/Makefile.inc
rename to src/soc/amd/common/block/hda/Makefile.mak
diff --git a/src/soc/amd/common/block/i2c/Makefile.inc b/src/soc/amd/common/block/i2c/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/i2c/Makefile.inc
rename to src/soc/amd/common/block/i2c/Makefile.mak
diff --git a/src/soc/amd/common/block/iommu/Makefile.inc b/src/soc/amd/common/block/iommu/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/iommu/Makefile.inc
rename to src/soc/amd/common/block/iommu/Makefile.mak
diff --git a/src/soc/amd/common/block/lpc/Makefile.inc b/src/soc/amd/common/block/lpc/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/lpc/Makefile.inc
rename to src/soc/amd/common/block/lpc/Makefile.mak
diff --git a/src/soc/amd/common/block/pci/Makefile.inc b/src/soc/amd/common/block/pci/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/pci/Makefile.inc
rename to src/soc/amd/common/block/pci/Makefile.mak
diff --git a/src/soc/amd/common/block/pm/Makefile.inc b/src/soc/amd/common/block/pm/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/pm/Makefile.inc
rename to src/soc/amd/common/block/pm/Makefile.mak
diff --git a/src/soc/amd/common/block/psp/Makefile.inc b/src/soc/amd/common/block/psp/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/psp/Makefile.inc
rename to src/soc/amd/common/block/psp/Makefile.mak
diff --git a/src/soc/amd/common/block/root_complex/Makefile.inc b/src/soc/amd/common/block/root_complex/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/root_complex/Makefile.inc
rename to src/soc/amd/common/block/root_complex/Makefile.mak
diff --git a/src/soc/amd/common/block/sata/Makefile.inc b/src/soc/amd/common/block/sata/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/sata/Makefile.inc
rename to src/soc/amd/common/block/sata/Makefile.mak
diff --git a/src/soc/amd/common/block/simnow/Makefile.inc b/src/soc/amd/common/block/simnow/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/simnow/Makefile.inc
rename to src/soc/amd/common/block/simnow/Makefile.mak
diff --git a/src/soc/amd/common/block/smbus/Makefile.inc b/src/soc/amd/common/block/smbus/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/smbus/Makefile.inc
rename to src/soc/amd/common/block/smbus/Makefile.mak
diff --git a/src/soc/amd/common/block/smi/Makefile.inc b/src/soc/amd/common/block/smi/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/smi/Makefile.inc
rename to src/soc/amd/common/block/smi/Makefile.mak
diff --git a/src/soc/amd/common/block/smn/Makefile.inc b/src/soc/amd/common/block/smn/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/smn/Makefile.inc
rename to src/soc/amd/common/block/smn/Makefile.mak
diff --git a/src/soc/amd/common/block/smu/Makefile.inc b/src/soc/amd/common/block/smu/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/smu/Makefile.inc
rename to src/soc/amd/common/block/smu/Makefile.mak
diff --git a/src/soc/amd/common/block/spi/Makefile.inc b/src/soc/amd/common/block/spi/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/spi/Makefile.inc
rename to src/soc/amd/common/block/spi/Makefile.mak
diff --git a/src/soc/amd/common/block/stb/Makefile.inc b/src/soc/amd/common/block/stb/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/stb/Makefile.inc
rename to src/soc/amd/common/block/stb/Makefile.mak
diff --git a/src/soc/amd/common/block/uart/Makefile.inc b/src/soc/amd/common/block/uart/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/uart/Makefile.inc
rename to src/soc/amd/common/block/uart/Makefile.mak
diff --git a/src/soc/amd/common/block/xhci/Makefile.inc b/src/soc/amd/common/block/xhci/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/block/xhci/Makefile.inc
rename to src/soc/amd/common/block/xhci/Makefile.mak
diff --git a/src/soc/amd/common/fsp/Makefile.inc b/src/soc/amd/common/fsp/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/fsp/Makefile.inc
rename to src/soc/amd/common/fsp/Makefile.mak
diff --git a/src/soc/amd/common/fsp/pci/Makefile.inc b/src/soc/amd/common/fsp/pci/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/fsp/pci/Makefile.inc
rename to src/soc/amd/common/fsp/pci/Makefile.mak
diff --git a/src/soc/amd/common/pi/Makefile.inc b/src/soc/amd/common/pi/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/pi/Makefile.inc
rename to src/soc/amd/common/pi/Makefile.mak
diff --git a/src/soc/amd/common/psp_verstage/Makefile.inc b/src/soc/amd/common/psp_verstage/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/psp_verstage/Makefile.inc
rename to src/soc/amd/common/psp_verstage/Makefile.mak
diff --git a/src/soc/amd/common/vboot/Makefile.inc b/src/soc/amd/common/vboot/Makefile.mak
similarity index 100%
rename from src/soc/amd/common/vboot/Makefile.inc
rename to src/soc/amd/common/vboot/Makefile.mak
diff --git a/src/soc/amd/genoa_poc/Makefile.inc b/src/soc/amd/genoa_poc/Makefile.mak
similarity index 100%
rename from src/soc/amd/genoa_poc/Makefile.inc
rename to src/soc/amd/genoa_poc/Makefile.mak
diff --git a/src/soc/amd/glinda/Makefile.inc b/src/soc/amd/glinda/Makefile.mak
similarity index 100%
rename from src/soc/amd/glinda/Makefile.inc
rename to src/soc/amd/glinda/Makefile.mak
diff --git a/src/soc/amd/glinda/psp_verstage/Makefile.inc b/src/soc/amd/glinda/psp_verstage/Makefile.mak
similarity index 100%
rename from src/soc/amd/glinda/psp_verstage/Makefile.inc
rename to src/soc/amd/glinda/psp_verstage/Makefile.mak
diff --git a/src/soc/amd/mendocino/Makefile.inc b/src/soc/amd/mendocino/Makefile.mak
similarity index 100%
rename from src/soc/amd/mendocino/Makefile.inc
rename to src/soc/amd/mendocino/Makefile.mak
diff --git a/src/soc/amd/mendocino/psp_verstage/Makefile.inc b/src/soc/amd/mendocino/psp_verstage/Makefile.mak
similarity index 100%
rename from src/soc/amd/mendocino/psp_verstage/Makefile.inc
rename to src/soc/amd/mendocino/psp_verstage/Makefile.mak
diff --git a/src/soc/amd/phoenix/Makefile.inc b/src/soc/amd/phoenix/Makefile.mak
similarity index 100%
rename from src/soc/amd/phoenix/Makefile.inc
rename to src/soc/amd/phoenix/Makefile.mak
diff --git a/src/soc/amd/phoenix/psp_verstage/Makefile.inc b/src/soc/amd/phoenix/psp_verstage/Makefile.mak
similarity index 100%
rename from src/soc/amd/phoenix/psp_verstage/Makefile.inc
rename to src/soc/amd/phoenix/psp_verstage/Makefile.mak
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.mak
similarity index 100%
rename from src/soc/amd/picasso/Makefile.inc
rename to src/soc/amd/picasso/Makefile.mak
diff --git a/src/soc/amd/picasso/psp_verstage/Makefile.inc b/src/soc/amd/picasso/psp_verstage/Makefile.mak
similarity index 100%
rename from src/soc/amd/picasso/psp_verstage/Makefile.inc
rename to src/soc/amd/picasso/psp_verstage/Makefile.mak
diff --git a/src/soc/amd/stoneyridge/Makefile.inc b/src/soc/amd/stoneyridge/Makefile.mak
similarity index 100%
rename from src/soc/amd/stoneyridge/Makefile.inc
rename to src/soc/amd/stoneyridge/Makefile.mak
--
To view, visit https://review.coreboot.org/c/coreboot/+/80071?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie449267fe4fdd75110f577e1b9f748cd06140950
Gerrit-Change-Number: 80071
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Attention is currently required from: Angel Pons.
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80070?usp=email )
Change subject: northbridge: Rename Makefiles from .inc to .mak
......................................................................
northbridge: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Iddac15cc42532f44dda44032be0f8525f6347abd
---
R src/northbridge/amd/pi/00730F01/Makefile.mak
R src/northbridge/amd/pi/Makefile.mak
R src/northbridge/intel/e7505/Makefile.mak
R src/northbridge/intel/gm45/Makefile.mak
R src/northbridge/intel/haswell/Makefile.mak
R src/northbridge/intel/haswell/broadwell_mrc/Makefile.mak
R src/northbridge/intel/haswell/haswell_mrc/Makefile.mak
R src/northbridge/intel/haswell/native_raminit/Makefile.mak
R src/northbridge/intel/i440bx/Makefile.mak
R src/northbridge/intel/i945/Makefile.mak
R src/northbridge/intel/ironlake/Makefile.mak
R src/northbridge/intel/pineview/Makefile.mak
R src/northbridge/intel/sandybridge/Makefile.mak
R src/northbridge/intel/x4x/Makefile.mak
14 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/80070/1
diff --git a/src/northbridge/amd/pi/00730F01/Makefile.inc b/src/northbridge/amd/pi/00730F01/Makefile.mak
similarity index 100%
rename from src/northbridge/amd/pi/00730F01/Makefile.inc
rename to src/northbridge/amd/pi/00730F01/Makefile.mak
diff --git a/src/northbridge/amd/pi/Makefile.inc b/src/northbridge/amd/pi/Makefile.mak
similarity index 100%
rename from src/northbridge/amd/pi/Makefile.inc
rename to src/northbridge/amd/pi/Makefile.mak
diff --git a/src/northbridge/intel/e7505/Makefile.inc b/src/northbridge/intel/e7505/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/e7505/Makefile.inc
rename to src/northbridge/intel/e7505/Makefile.mak
diff --git a/src/northbridge/intel/gm45/Makefile.inc b/src/northbridge/intel/gm45/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/gm45/Makefile.inc
rename to src/northbridge/intel/gm45/Makefile.mak
diff --git a/src/northbridge/intel/haswell/Makefile.inc b/src/northbridge/intel/haswell/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/haswell/Makefile.inc
rename to src/northbridge/intel/haswell/Makefile.mak
diff --git a/src/northbridge/intel/haswell/broadwell_mrc/Makefile.inc b/src/northbridge/intel/haswell/broadwell_mrc/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/haswell/broadwell_mrc/Makefile.inc
rename to src/northbridge/intel/haswell/broadwell_mrc/Makefile.mak
diff --git a/src/northbridge/intel/haswell/haswell_mrc/Makefile.inc b/src/northbridge/intel/haswell/haswell_mrc/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/haswell/haswell_mrc/Makefile.inc
rename to src/northbridge/intel/haswell/haswell_mrc/Makefile.mak
diff --git a/src/northbridge/intel/haswell/native_raminit/Makefile.inc b/src/northbridge/intel/haswell/native_raminit/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/haswell/native_raminit/Makefile.inc
rename to src/northbridge/intel/haswell/native_raminit/Makefile.mak
diff --git a/src/northbridge/intel/i440bx/Makefile.inc b/src/northbridge/intel/i440bx/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/i440bx/Makefile.inc
rename to src/northbridge/intel/i440bx/Makefile.mak
diff --git a/src/northbridge/intel/i945/Makefile.inc b/src/northbridge/intel/i945/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/i945/Makefile.inc
rename to src/northbridge/intel/i945/Makefile.mak
diff --git a/src/northbridge/intel/ironlake/Makefile.inc b/src/northbridge/intel/ironlake/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/ironlake/Makefile.inc
rename to src/northbridge/intel/ironlake/Makefile.mak
diff --git a/src/northbridge/intel/pineview/Makefile.inc b/src/northbridge/intel/pineview/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/pineview/Makefile.inc
rename to src/northbridge/intel/pineview/Makefile.mak
diff --git a/src/northbridge/intel/sandybridge/Makefile.inc b/src/northbridge/intel/sandybridge/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/sandybridge/Makefile.inc
rename to src/northbridge/intel/sandybridge/Makefile.mak
diff --git a/src/northbridge/intel/x4x/Makefile.inc b/src/northbridge/intel/x4x/Makefile.mak
similarity index 100%
rename from src/northbridge/intel/x4x/Makefile.inc
rename to src/northbridge/intel/x4x/Makefile.mak
--
To view, visit https://review.coreboot.org/c/coreboot/+/80070?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iddac15cc42532f44dda44032be0f8525f6347abd
Gerrit-Change-Number: 80070
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Alexander Couzens, Caveh Jalali, Forest Mittelberg, Jeremy Soller, Nicholas Chin, Sean Rhodes, Tim Crawford.
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80069?usp=email )
Change subject: ec: Rename Makefiles from .inc to .mak
......................................................................
ec: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ic060f3605cd18d4bf774573c21957f626f984e2c
---
R src/ec/51nb/npce985la0dx/Makefile.mak
R src/ec/acpi/Makefile.mak
R src/ec/clevo/it5570e/Makefile.mak
R src/ec/compal/ene932/Makefile.mak
R src/ec/dell/mec5035/Makefile.mak
R src/ec/google/chromeec/Makefile.mak
R src/ec/google/chromeec/audio_codec/Makefile.mak
R src/ec/google/chromeec/i2c_tunnel/Makefile.mak
R src/ec/google/chromeec/mux/Makefile.mak
R src/ec/google/chromeec/mux/conn/Makefile.mak
R src/ec/google/common/Makefile.mak
R src/ec/google/wilco/Makefile.mak
R src/ec/hp/kbc1126/Makefile.mak
R src/ec/intel/Makefile.mak
R src/ec/kontron/it8516e/Makefile.mak
R src/ec/kontron/kempld/Makefile.mak
R src/ec/lenovo/h8/Makefile.mak
R src/ec/lenovo/pmh7/Makefile.mak
R src/ec/purism/librem-ec/Makefile.mak
R src/ec/quanta/ene_kb3940q/Makefile.mak
R src/ec/quanta/it8518/Makefile.mak
R src/ec/roda/it8518/Makefile.mak
R src/ec/smsc/mec1308/Makefile.mak
R src/ec/starlabs/merlin/Makefile.mak
R src/ec/system76/ec/Makefile.mak
25 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/80069/1
diff --git a/src/ec/51nb/npce985la0dx/Makefile.inc b/src/ec/51nb/npce985la0dx/Makefile.mak
similarity index 100%
rename from src/ec/51nb/npce985la0dx/Makefile.inc
rename to src/ec/51nb/npce985la0dx/Makefile.mak
diff --git a/src/ec/acpi/Makefile.inc b/src/ec/acpi/Makefile.mak
similarity index 100%
rename from src/ec/acpi/Makefile.inc
rename to src/ec/acpi/Makefile.mak
diff --git a/src/ec/clevo/it5570e/Makefile.inc b/src/ec/clevo/it5570e/Makefile.mak
similarity index 100%
rename from src/ec/clevo/it5570e/Makefile.inc
rename to src/ec/clevo/it5570e/Makefile.mak
diff --git a/src/ec/compal/ene932/Makefile.inc b/src/ec/compal/ene932/Makefile.mak
similarity index 100%
rename from src/ec/compal/ene932/Makefile.inc
rename to src/ec/compal/ene932/Makefile.mak
diff --git a/src/ec/dell/mec5035/Makefile.inc b/src/ec/dell/mec5035/Makefile.mak
similarity index 100%
rename from src/ec/dell/mec5035/Makefile.inc
rename to src/ec/dell/mec5035/Makefile.mak
diff --git a/src/ec/google/chromeec/Makefile.inc b/src/ec/google/chromeec/Makefile.mak
similarity index 100%
rename from src/ec/google/chromeec/Makefile.inc
rename to src/ec/google/chromeec/Makefile.mak
diff --git a/src/ec/google/chromeec/audio_codec/Makefile.inc b/src/ec/google/chromeec/audio_codec/Makefile.mak
similarity index 100%
rename from src/ec/google/chromeec/audio_codec/Makefile.inc
rename to src/ec/google/chromeec/audio_codec/Makefile.mak
diff --git a/src/ec/google/chromeec/i2c_tunnel/Makefile.inc b/src/ec/google/chromeec/i2c_tunnel/Makefile.mak
similarity index 100%
rename from src/ec/google/chromeec/i2c_tunnel/Makefile.inc
rename to src/ec/google/chromeec/i2c_tunnel/Makefile.mak
diff --git a/src/ec/google/chromeec/mux/Makefile.inc b/src/ec/google/chromeec/mux/Makefile.mak
similarity index 100%
rename from src/ec/google/chromeec/mux/Makefile.inc
rename to src/ec/google/chromeec/mux/Makefile.mak
diff --git a/src/ec/google/chromeec/mux/conn/Makefile.inc b/src/ec/google/chromeec/mux/conn/Makefile.mak
similarity index 100%
rename from src/ec/google/chromeec/mux/conn/Makefile.inc
rename to src/ec/google/chromeec/mux/conn/Makefile.mak
diff --git a/src/ec/google/common/Makefile.inc b/src/ec/google/common/Makefile.mak
similarity index 100%
rename from src/ec/google/common/Makefile.inc
rename to src/ec/google/common/Makefile.mak
diff --git a/src/ec/google/wilco/Makefile.inc b/src/ec/google/wilco/Makefile.mak
similarity index 100%
rename from src/ec/google/wilco/Makefile.inc
rename to src/ec/google/wilco/Makefile.mak
diff --git a/src/ec/hp/kbc1126/Makefile.inc b/src/ec/hp/kbc1126/Makefile.mak
similarity index 100%
rename from src/ec/hp/kbc1126/Makefile.inc
rename to src/ec/hp/kbc1126/Makefile.mak
diff --git a/src/ec/intel/Makefile.inc b/src/ec/intel/Makefile.mak
similarity index 100%
rename from src/ec/intel/Makefile.inc
rename to src/ec/intel/Makefile.mak
diff --git a/src/ec/kontron/it8516e/Makefile.inc b/src/ec/kontron/it8516e/Makefile.mak
similarity index 100%
rename from src/ec/kontron/it8516e/Makefile.inc
rename to src/ec/kontron/it8516e/Makefile.mak
diff --git a/src/ec/kontron/kempld/Makefile.inc b/src/ec/kontron/kempld/Makefile.mak
similarity index 100%
rename from src/ec/kontron/kempld/Makefile.inc
rename to src/ec/kontron/kempld/Makefile.mak
diff --git a/src/ec/lenovo/h8/Makefile.inc b/src/ec/lenovo/h8/Makefile.mak
similarity index 100%
rename from src/ec/lenovo/h8/Makefile.inc
rename to src/ec/lenovo/h8/Makefile.mak
diff --git a/src/ec/lenovo/pmh7/Makefile.inc b/src/ec/lenovo/pmh7/Makefile.mak
similarity index 100%
rename from src/ec/lenovo/pmh7/Makefile.inc
rename to src/ec/lenovo/pmh7/Makefile.mak
diff --git a/src/ec/purism/librem-ec/Makefile.inc b/src/ec/purism/librem-ec/Makefile.mak
similarity index 100%
rename from src/ec/purism/librem-ec/Makefile.inc
rename to src/ec/purism/librem-ec/Makefile.mak
diff --git a/src/ec/quanta/ene_kb3940q/Makefile.inc b/src/ec/quanta/ene_kb3940q/Makefile.mak
similarity index 100%
rename from src/ec/quanta/ene_kb3940q/Makefile.inc
rename to src/ec/quanta/ene_kb3940q/Makefile.mak
diff --git a/src/ec/quanta/it8518/Makefile.inc b/src/ec/quanta/it8518/Makefile.mak
similarity index 100%
rename from src/ec/quanta/it8518/Makefile.inc
rename to src/ec/quanta/it8518/Makefile.mak
diff --git a/src/ec/roda/it8518/Makefile.inc b/src/ec/roda/it8518/Makefile.mak
similarity index 100%
rename from src/ec/roda/it8518/Makefile.inc
rename to src/ec/roda/it8518/Makefile.mak
diff --git a/src/ec/smsc/mec1308/Makefile.inc b/src/ec/smsc/mec1308/Makefile.mak
similarity index 100%
rename from src/ec/smsc/mec1308/Makefile.inc
rename to src/ec/smsc/mec1308/Makefile.mak
diff --git a/src/ec/starlabs/merlin/Makefile.inc b/src/ec/starlabs/merlin/Makefile.mak
similarity index 100%
rename from src/ec/starlabs/merlin/Makefile.inc
rename to src/ec/starlabs/merlin/Makefile.mak
diff --git a/src/ec/system76/ec/Makefile.inc b/src/ec/system76/ec/Makefile.mak
similarity index 100%
rename from src/ec/system76/ec/Makefile.inc
rename to src/ec/system76/ec/Makefile.mak
--
To view, visit https://review.coreboot.org/c/coreboot/+/80069?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic060f3605cd18d4bf774573c21957f626f984e2c
Gerrit-Change-Number: 80069
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Jérémy Compostella, ron minnich.
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80068?usp=email )
Change subject: cpu: Rename Makefiles from .inc to .mak
......................................................................
cpu: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I552d487978906f5ea74c3d0d85373fe5b2de3f38
---
R src/cpu/Makefile.mak
R src/cpu/amd/Makefile.mak
R src/cpu/amd/mtrr/Makefile.mak
R src/cpu/amd/pi/00730F01/Makefile.mak
R src/cpu/amd/pi/Makefile.mak
R src/cpu/armltd/Makefile.mak
R src/cpu/intel/Makefile.mak
R src/cpu/intel/common/Makefile.mak
R src/cpu/intel/fit/Makefile.mak
R src/cpu/intel/haswell/Makefile.mak
R src/cpu/intel/microcode/Makefile.mak
R src/cpu/intel/model_1067x/Makefile.mak
R src/cpu/intel/model_106cx/Makefile.mak
R src/cpu/intel/model_2065x/Makefile.mak
R src/cpu/intel/model_206ax/Makefile.mak
R src/cpu/intel/model_65x/Makefile.mak
R src/cpu/intel/model_67x/Makefile.mak
R src/cpu/intel/model_68x/Makefile.mak
R src/cpu/intel/model_6bx/Makefile.mak
R src/cpu/intel/model_6ex/Makefile.mak
R src/cpu/intel/model_6fx/Makefile.mak
R src/cpu/intel/model_6xx/Makefile.mak
R src/cpu/intel/model_f2x/Makefile.mak
R src/cpu/intel/model_f3x/Makefile.mak
R src/cpu/intel/model_f4x/Makefile.mak
R src/cpu/intel/slot_1/Makefile.mak
R src/cpu/intel/smm/Makefile.mak
R src/cpu/intel/smm/gen1/Makefile.mak
R src/cpu/intel/socket_441/Makefile.mak
R src/cpu/intel/socket_BGA956/Makefile.mak
R src/cpu/intel/socket_FCBGA559/Makefile.mak
R src/cpu/intel/socket_LGA775/Makefile.mak
R src/cpu/intel/socket_m/Makefile.mak
R src/cpu/intel/socket_mPGA604/Makefile.mak
R src/cpu/intel/socket_p/Makefile.mak
R src/cpu/intel/speedstep/Makefile.mak
R src/cpu/intel/turbo/Makefile.mak
R src/cpu/power9/Makefile.mak
R src/cpu/qemu-power8/Makefile.mak
R src/cpu/qemu-x86/Makefile.mak
R src/cpu/x86/64bit/Makefile.mak
R src/cpu/x86/Makefile.mak
R src/cpu/x86/cache/Makefile.mak
R src/cpu/x86/lapic/Makefile.mak
R src/cpu/x86/mtrr/Makefile.mak
R src/cpu/x86/name/Makefile.mak
R src/cpu/x86/pae/Makefile.mak
R src/cpu/x86/smm/Makefile.mak
R src/cpu/x86/tsc/Makefile.mak
49 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/80068/1
diff --git a/src/cpu/Makefile.inc b/src/cpu/Makefile.mak
similarity index 100%
rename from src/cpu/Makefile.inc
rename to src/cpu/Makefile.mak
diff --git a/src/cpu/amd/Makefile.inc b/src/cpu/amd/Makefile.mak
similarity index 100%
rename from src/cpu/amd/Makefile.inc
rename to src/cpu/amd/Makefile.mak
diff --git a/src/cpu/amd/mtrr/Makefile.inc b/src/cpu/amd/mtrr/Makefile.mak
similarity index 100%
rename from src/cpu/amd/mtrr/Makefile.inc
rename to src/cpu/amd/mtrr/Makefile.mak
diff --git a/src/cpu/amd/pi/00730F01/Makefile.inc b/src/cpu/amd/pi/00730F01/Makefile.mak
similarity index 100%
rename from src/cpu/amd/pi/00730F01/Makefile.inc
rename to src/cpu/amd/pi/00730F01/Makefile.mak
diff --git a/src/cpu/amd/pi/Makefile.inc b/src/cpu/amd/pi/Makefile.mak
similarity index 100%
rename from src/cpu/amd/pi/Makefile.inc
rename to src/cpu/amd/pi/Makefile.mak
diff --git a/src/cpu/armltd/Makefile.inc b/src/cpu/armltd/Makefile.mak
similarity index 100%
rename from src/cpu/armltd/Makefile.inc
rename to src/cpu/armltd/Makefile.mak
diff --git a/src/cpu/intel/Makefile.inc b/src/cpu/intel/Makefile.mak
similarity index 92%
rename from src/cpu/intel/Makefile.inc
rename to src/cpu/intel/Makefile.mak
index dc0bc53..bc8f537 100644
--- a/src/cpu/intel/Makefile.inc
+++ b/src/cpu/intel/Makefile.mak
@@ -3,7 +3,7 @@
# Note: From here on down, we are socket-centric. Socket choice determines
# what other CPU files are included.
#
-# Therefore: ONLY include Makefile.inc from socket directories!
+# Therefore: ONLY include Makefiles from socket directories!
subdirs-$(CONFIG_CPU_INTEL_FIRMWARE_INTERFACE_TABLE) += fit
subdirs-$(CONFIG_CPU_INTEL_SOCKET_441) += socket_441
diff --git a/src/cpu/intel/common/Makefile.inc b/src/cpu/intel/common/Makefile.mak
similarity index 100%
rename from src/cpu/intel/common/Makefile.inc
rename to src/cpu/intel/common/Makefile.mak
diff --git a/src/cpu/intel/fit/Makefile.inc b/src/cpu/intel/fit/Makefile.mak
similarity index 100%
rename from src/cpu/intel/fit/Makefile.inc
rename to src/cpu/intel/fit/Makefile.mak
diff --git a/src/cpu/intel/haswell/Makefile.inc b/src/cpu/intel/haswell/Makefile.mak
similarity index 100%
rename from src/cpu/intel/haswell/Makefile.inc
rename to src/cpu/intel/haswell/Makefile.mak
diff --git a/src/cpu/intel/microcode/Makefile.inc b/src/cpu/intel/microcode/Makefile.mak
similarity index 100%
rename from src/cpu/intel/microcode/Makefile.inc
rename to src/cpu/intel/microcode/Makefile.mak
diff --git a/src/cpu/intel/model_1067x/Makefile.inc b/src/cpu/intel/model_1067x/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_1067x/Makefile.inc
rename to src/cpu/intel/model_1067x/Makefile.mak
diff --git a/src/cpu/intel/model_106cx/Makefile.inc b/src/cpu/intel/model_106cx/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_106cx/Makefile.inc
rename to src/cpu/intel/model_106cx/Makefile.mak
diff --git a/src/cpu/intel/model_2065x/Makefile.inc b/src/cpu/intel/model_2065x/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_2065x/Makefile.inc
rename to src/cpu/intel/model_2065x/Makefile.mak
diff --git a/src/cpu/intel/model_206ax/Makefile.inc b/src/cpu/intel/model_206ax/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_206ax/Makefile.inc
rename to src/cpu/intel/model_206ax/Makefile.mak
diff --git a/src/cpu/intel/model_65x/Makefile.inc b/src/cpu/intel/model_65x/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_65x/Makefile.inc
rename to src/cpu/intel/model_65x/Makefile.mak
diff --git a/src/cpu/intel/model_67x/Makefile.inc b/src/cpu/intel/model_67x/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_67x/Makefile.inc
rename to src/cpu/intel/model_67x/Makefile.mak
diff --git a/src/cpu/intel/model_68x/Makefile.inc b/src/cpu/intel/model_68x/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_68x/Makefile.inc
rename to src/cpu/intel/model_68x/Makefile.mak
diff --git a/src/cpu/intel/model_6bx/Makefile.inc b/src/cpu/intel/model_6bx/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_6bx/Makefile.inc
rename to src/cpu/intel/model_6bx/Makefile.mak
diff --git a/src/cpu/intel/model_6ex/Makefile.inc b/src/cpu/intel/model_6ex/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_6ex/Makefile.inc
rename to src/cpu/intel/model_6ex/Makefile.mak
diff --git a/src/cpu/intel/model_6fx/Makefile.inc b/src/cpu/intel/model_6fx/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_6fx/Makefile.inc
rename to src/cpu/intel/model_6fx/Makefile.mak
diff --git a/src/cpu/intel/model_6xx/Makefile.inc b/src/cpu/intel/model_6xx/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_6xx/Makefile.inc
rename to src/cpu/intel/model_6xx/Makefile.mak
diff --git a/src/cpu/intel/model_f2x/Makefile.inc b/src/cpu/intel/model_f2x/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_f2x/Makefile.inc
rename to src/cpu/intel/model_f2x/Makefile.mak
diff --git a/src/cpu/intel/model_f3x/Makefile.inc b/src/cpu/intel/model_f3x/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_f3x/Makefile.inc
rename to src/cpu/intel/model_f3x/Makefile.mak
diff --git a/src/cpu/intel/model_f4x/Makefile.inc b/src/cpu/intel/model_f4x/Makefile.mak
similarity index 100%
rename from src/cpu/intel/model_f4x/Makefile.inc
rename to src/cpu/intel/model_f4x/Makefile.mak
diff --git a/src/cpu/intel/slot_1/Makefile.inc b/src/cpu/intel/slot_1/Makefile.mak
similarity index 100%
rename from src/cpu/intel/slot_1/Makefile.inc
rename to src/cpu/intel/slot_1/Makefile.mak
diff --git a/src/cpu/intel/smm/Makefile.inc b/src/cpu/intel/smm/Makefile.mak
similarity index 100%
rename from src/cpu/intel/smm/Makefile.inc
rename to src/cpu/intel/smm/Makefile.mak
diff --git a/src/cpu/intel/smm/gen1/Makefile.inc b/src/cpu/intel/smm/gen1/Makefile.mak
similarity index 100%
rename from src/cpu/intel/smm/gen1/Makefile.inc
rename to src/cpu/intel/smm/gen1/Makefile.mak
diff --git a/src/cpu/intel/socket_441/Makefile.inc b/src/cpu/intel/socket_441/Makefile.mak
similarity index 100%
rename from src/cpu/intel/socket_441/Makefile.inc
rename to src/cpu/intel/socket_441/Makefile.mak
diff --git a/src/cpu/intel/socket_BGA956/Makefile.inc b/src/cpu/intel/socket_BGA956/Makefile.mak
similarity index 100%
rename from src/cpu/intel/socket_BGA956/Makefile.inc
rename to src/cpu/intel/socket_BGA956/Makefile.mak
diff --git a/src/cpu/intel/socket_FCBGA559/Makefile.inc b/src/cpu/intel/socket_FCBGA559/Makefile.mak
similarity index 100%
rename from src/cpu/intel/socket_FCBGA559/Makefile.inc
rename to src/cpu/intel/socket_FCBGA559/Makefile.mak
diff --git a/src/cpu/intel/socket_LGA775/Makefile.inc b/src/cpu/intel/socket_LGA775/Makefile.mak
similarity index 100%
rename from src/cpu/intel/socket_LGA775/Makefile.inc
rename to src/cpu/intel/socket_LGA775/Makefile.mak
diff --git a/src/cpu/intel/socket_m/Makefile.inc b/src/cpu/intel/socket_m/Makefile.mak
similarity index 100%
rename from src/cpu/intel/socket_m/Makefile.inc
rename to src/cpu/intel/socket_m/Makefile.mak
diff --git a/src/cpu/intel/socket_mPGA604/Makefile.inc b/src/cpu/intel/socket_mPGA604/Makefile.mak
similarity index 100%
rename from src/cpu/intel/socket_mPGA604/Makefile.inc
rename to src/cpu/intel/socket_mPGA604/Makefile.mak
diff --git a/src/cpu/intel/socket_p/Makefile.inc b/src/cpu/intel/socket_p/Makefile.mak
similarity index 100%
rename from src/cpu/intel/socket_p/Makefile.inc
rename to src/cpu/intel/socket_p/Makefile.mak
diff --git a/src/cpu/intel/speedstep/Makefile.inc b/src/cpu/intel/speedstep/Makefile.mak
similarity index 100%
rename from src/cpu/intel/speedstep/Makefile.inc
rename to src/cpu/intel/speedstep/Makefile.mak
diff --git a/src/cpu/intel/turbo/Makefile.inc b/src/cpu/intel/turbo/Makefile.mak
similarity index 100%
rename from src/cpu/intel/turbo/Makefile.inc
rename to src/cpu/intel/turbo/Makefile.mak
diff --git a/src/cpu/power9/Makefile.inc b/src/cpu/power9/Makefile.mak
similarity index 100%
rename from src/cpu/power9/Makefile.inc
rename to src/cpu/power9/Makefile.mak
diff --git a/src/cpu/qemu-power8/Makefile.inc b/src/cpu/qemu-power8/Makefile.mak
similarity index 100%
rename from src/cpu/qemu-power8/Makefile.inc
rename to src/cpu/qemu-power8/Makefile.mak
diff --git a/src/cpu/qemu-x86/Makefile.inc b/src/cpu/qemu-x86/Makefile.mak
similarity index 100%
rename from src/cpu/qemu-x86/Makefile.inc
rename to src/cpu/qemu-x86/Makefile.mak
diff --git a/src/cpu/x86/64bit/Makefile.inc b/src/cpu/x86/64bit/Makefile.mak
similarity index 100%
rename from src/cpu/x86/64bit/Makefile.inc
rename to src/cpu/x86/64bit/Makefile.mak
diff --git a/src/cpu/x86/Makefile.inc b/src/cpu/x86/Makefile.mak
similarity index 100%
rename from src/cpu/x86/Makefile.inc
rename to src/cpu/x86/Makefile.mak
diff --git a/src/cpu/x86/cache/Makefile.inc b/src/cpu/x86/cache/Makefile.mak
similarity index 100%
rename from src/cpu/x86/cache/Makefile.inc
rename to src/cpu/x86/cache/Makefile.mak
diff --git a/src/cpu/x86/lapic/Makefile.inc b/src/cpu/x86/lapic/Makefile.mak
similarity index 100%
rename from src/cpu/x86/lapic/Makefile.inc
rename to src/cpu/x86/lapic/Makefile.mak
diff --git a/src/cpu/x86/mtrr/Makefile.inc b/src/cpu/x86/mtrr/Makefile.mak
similarity index 100%
rename from src/cpu/x86/mtrr/Makefile.inc
rename to src/cpu/x86/mtrr/Makefile.mak
diff --git a/src/cpu/x86/name/Makefile.inc b/src/cpu/x86/name/Makefile.mak
similarity index 100%
rename from src/cpu/x86/name/Makefile.inc
rename to src/cpu/x86/name/Makefile.mak
diff --git a/src/cpu/x86/pae/Makefile.inc b/src/cpu/x86/pae/Makefile.mak
similarity index 100%
rename from src/cpu/x86/pae/Makefile.inc
rename to src/cpu/x86/pae/Makefile.mak
diff --git a/src/cpu/x86/smm/Makefile.inc b/src/cpu/x86/smm/Makefile.mak
similarity index 100%
rename from src/cpu/x86/smm/Makefile.inc
rename to src/cpu/x86/smm/Makefile.mak
diff --git a/src/cpu/x86/tsc/Makefile.inc b/src/cpu/x86/tsc/Makefile.mak
similarity index 100%
rename from src/cpu/x86/tsc/Makefile.inc
rename to src/cpu/x86/tsc/Makefile.mak
--
To view, visit https://review.coreboot.org/c/coreboot/+/80068?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I552d487978906f5ea74c3d0d85373fe5b2de3f38
Gerrit-Change-Number: 80068
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newchange