Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80073?usp=email )
Change subject: soc/intel: Rename Makefiles from .inc to .mak
......................................................................
soc/intel: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ib479b93b7d0b2e790d0495b6a6b4b4298a515d9a
---
R src/soc/intel/Makefile.mak
R src/soc/intel/alderlake/Makefile.mak
R src/soc/intel/alderlake/romstage/Makefile.mak
R src/soc/intel/apollolake/Makefile.mak
R src/soc/intel/baytrail/Makefile.mak
R src/soc/intel/baytrail/romstage/Makefile.mak
R src/soc/intel/braswell/Makefile.mak
R src/soc/intel/braswell/romstage/Makefile.mak
R src/soc/intel/broadwell/Makefile.mak
R src/soc/intel/broadwell/pch/Makefile.mak
R src/soc/intel/cannonlake/Makefile.mak
M src/soc/intel/cannonlake/cnl_memcfg_init.c
R src/soc/intel/cannonlake/romstage/Makefile.mak
R src/soc/intel/common/Makefile.mak
R src/soc/intel/common/basecode/Makefile.mak
R src/soc/intel/common/basecode/debug/Makefile.mak
R src/soc/intel/common/basecode/ramtop/Makefile.mak
R src/soc/intel/common/block/Makefile.mak
R src/soc/intel/common/block/acpi/Makefile.mak
R src/soc/intel/common/block/chip/Makefile.mak
R src/soc/intel/common/block/cnvi/Makefile.mak
R src/soc/intel/common/block/cpu/Makefile.mak
R src/soc/intel/common/block/crashlog/Makefile.mak
R src/soc/intel/common/block/cse/Makefile.mak
R src/soc/intel/common/block/dsp/Makefile.mak
R src/soc/intel/common/block/dtt/Makefile.mak
R src/soc/intel/common/block/fast_spi/Makefile.mak
R src/soc/intel/common/block/gpio/Makefile.mak
R src/soc/intel/common/block/gpmr/Makefile.mak
R src/soc/intel/common/block/graphics/Makefile.mak
R src/soc/intel/common/block/gspi/Makefile.mak
R src/soc/intel/common/block/hda/Makefile.mak
R src/soc/intel/common/block/i2c/Makefile.mak
R src/soc/intel/common/block/ioc/Makefile.mak
R src/soc/intel/common/block/ipu/Makefile.mak
R src/soc/intel/common/block/irq/Makefile.mak
R src/soc/intel/common/block/itss/Makefile.mak
R src/soc/intel/common/block/lpc/Makefile.mak
R src/soc/intel/common/block/lpss/Makefile.mak
R src/soc/intel/common/block/memory/Makefile.mak
R src/soc/intel/common/block/oc_wdt/Makefile.mak
R src/soc/intel/common/block/p2sb/Makefile.mak
R src/soc/intel/common/block/pcie/Makefile.mak
R src/soc/intel/common/block/pcie/rtd3/Makefile.mak
R src/soc/intel/common/block/pcr/Makefile.mak
R src/soc/intel/common/block/pmc/Makefile.mak
R src/soc/intel/common/block/power_limit/Makefile.mak
R src/soc/intel/common/block/rtc/Makefile.mak
R src/soc/intel/common/block/sata/Makefile.mak
R src/soc/intel/common/block/scs/Makefile.mak
R src/soc/intel/common/block/sgx/Makefile.mak
R src/soc/intel/common/block/smbus/Makefile.mak
R src/soc/intel/common/block/smm/Makefile.mak
R src/soc/intel/common/block/spi/Makefile.mak
R src/soc/intel/common/block/sram/Makefile.mak
R src/soc/intel/common/block/systemagent/Makefile.mak
R src/soc/intel/common/block/tcss/Makefile.mak
R src/soc/intel/common/block/thermal/Makefile.mak
R src/soc/intel/common/block/timer/Makefile.mak
R src/soc/intel/common/block/tracehub/Makefile.mak
R src/soc/intel/common/block/uart/Makefile.mak
R src/soc/intel/common/block/usb4/Makefile.mak
R src/soc/intel/common/block/vtd/Makefile.mak
R src/soc/intel/common/block/xdci/Makefile.mak
R src/soc/intel/common/block/xhci/Makefile.mak
R src/soc/intel/common/pch/Makefile.mak
R src/soc/intel/common/pch/lockdown/Makefile.mak
R src/soc/intel/denverton_ns/Makefile.mak
R src/soc/intel/elkhartlake/Makefile.mak
R src/soc/intel/elkhartlake/romstage/Makefile.mak
R src/soc/intel/jasperlake/Makefile.mak
R src/soc/intel/jasperlake/romstage/Makefile.mak
R src/soc/intel/meteorlake/Makefile.mak
R src/soc/intel/meteorlake/romstage/Makefile.mak
R src/soc/intel/skylake/Makefile.mak
R src/soc/intel/skylake/nhlt/Makefile.mak
R src/soc/intel/skylake/romstage/Makefile.mak
R src/soc/intel/tigerlake/Makefile.mak
R src/soc/intel/tigerlake/romstage/Makefile.mak
R src/soc/intel/xeon_sp/Makefile.mak
R src/soc/intel/xeon_sp/cpx/Makefile.mak
R src/soc/intel/xeon_sp/ebg/Makefile.mak
R src/soc/intel/xeon_sp/lbg/Makefile.mak
R src/soc/intel/xeon_sp/ras/Makefile.mak
R src/soc/intel/xeon_sp/skx/Makefile.mak
R src/soc/intel/xeon_sp/spr/Makefile.mak
86 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/80073/1
diff --git a/src/soc/intel/Makefile.inc b/src/soc/intel/Makefile.mak
similarity index 100%
rename from src/soc/intel/Makefile.inc
rename to src/soc/intel/Makefile.mak
diff --git a/src/soc/intel/alderlake/Makefile.inc b/src/soc/intel/alderlake/Makefile.mak
similarity index 100%
rename from src/soc/intel/alderlake/Makefile.inc
rename to src/soc/intel/alderlake/Makefile.mak
diff --git a/src/soc/intel/alderlake/romstage/Makefile.inc b/src/soc/intel/alderlake/romstage/Makefile.mak
similarity index 100%
rename from src/soc/intel/alderlake/romstage/Makefile.inc
rename to src/soc/intel/alderlake/romstage/Makefile.mak
diff --git a/src/soc/intel/apollolake/Makefile.inc b/src/soc/intel/apollolake/Makefile.mak
similarity index 100%
rename from src/soc/intel/apollolake/Makefile.inc
rename to src/soc/intel/apollolake/Makefile.mak
diff --git a/src/soc/intel/baytrail/Makefile.inc b/src/soc/intel/baytrail/Makefile.mak
similarity index 100%
rename from src/soc/intel/baytrail/Makefile.inc
rename to src/soc/intel/baytrail/Makefile.mak
diff --git a/src/soc/intel/baytrail/romstage/Makefile.inc b/src/soc/intel/baytrail/romstage/Makefile.mak
similarity index 100%
rename from src/soc/intel/baytrail/romstage/Makefile.inc
rename to src/soc/intel/baytrail/romstage/Makefile.mak
diff --git a/src/soc/intel/braswell/Makefile.inc b/src/soc/intel/braswell/Makefile.mak
similarity index 100%
rename from src/soc/intel/braswell/Makefile.inc
rename to src/soc/intel/braswell/Makefile.mak
diff --git a/src/soc/intel/braswell/romstage/Makefile.inc b/src/soc/intel/braswell/romstage/Makefile.mak
similarity index 100%
rename from src/soc/intel/braswell/romstage/Makefile.inc
rename to src/soc/intel/braswell/romstage/Makefile.mak
diff --git a/src/soc/intel/broadwell/Makefile.inc b/src/soc/intel/broadwell/Makefile.mak
similarity index 100%
rename from src/soc/intel/broadwell/Makefile.inc
rename to src/soc/intel/broadwell/Makefile.mak
diff --git a/src/soc/intel/broadwell/pch/Makefile.inc b/src/soc/intel/broadwell/pch/Makefile.mak
similarity index 100%
rename from src/soc/intel/broadwell/pch/Makefile.inc
rename to src/soc/intel/broadwell/pch/Makefile.mak
diff --git a/src/soc/intel/cannonlake/Makefile.inc b/src/soc/intel/cannonlake/Makefile.mak
similarity index 100%
rename from src/soc/intel/cannonlake/Makefile.inc
rename to src/soc/intel/cannonlake/Makefile.mak
diff --git a/src/soc/intel/cannonlake/cnl_memcfg_init.c b/src/soc/intel/cannonlake/cnl_memcfg_init.c
index 448e56c..27a21ea 100644
--- a/src/soc/intel/cannonlake/cnl_memcfg_init.c
+++ b/src/soc/intel/cannonlake/cnl_memcfg_init.c
@@ -74,7 +74,7 @@
/*
* Initialize default memory settings using the spd file specified by
* spd_index. The spd_index is an index into the SPD_SOURCES array defined
- * in spd/Makefile.inc.
+ * in spd/Makefile.mak.
*/
static void meminit_cbfs_spd_index(FSP_M_CONFIG *mem_cfg,
int spd_index, uint8_t mem_slot)
diff --git a/src/soc/intel/cannonlake/romstage/Makefile.inc b/src/soc/intel/cannonlake/romstage/Makefile.mak
similarity index 100%
rename from src/soc/intel/cannonlake/romstage/Makefile.inc
rename to src/soc/intel/cannonlake/romstage/Makefile.mak
diff --git a/src/soc/intel/common/Makefile.inc b/src/soc/intel/common/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/Makefile.inc
rename to src/soc/intel/common/Makefile.mak
diff --git a/src/soc/intel/common/basecode/Makefile.inc b/src/soc/intel/common/basecode/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/basecode/Makefile.inc
rename to src/soc/intel/common/basecode/Makefile.mak
diff --git a/src/soc/intel/common/basecode/debug/Makefile.inc b/src/soc/intel/common/basecode/debug/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/basecode/debug/Makefile.inc
rename to src/soc/intel/common/basecode/debug/Makefile.mak
diff --git a/src/soc/intel/common/basecode/ramtop/Makefile.inc b/src/soc/intel/common/basecode/ramtop/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/basecode/ramtop/Makefile.inc
rename to src/soc/intel/common/basecode/ramtop/Makefile.mak
diff --git a/src/soc/intel/common/block/Makefile.inc b/src/soc/intel/common/block/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/Makefile.inc
rename to src/soc/intel/common/block/Makefile.mak
diff --git a/src/soc/intel/common/block/acpi/Makefile.inc b/src/soc/intel/common/block/acpi/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/acpi/Makefile.inc
rename to src/soc/intel/common/block/acpi/Makefile.mak
diff --git a/src/soc/intel/common/block/chip/Makefile.inc b/src/soc/intel/common/block/chip/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/chip/Makefile.inc
rename to src/soc/intel/common/block/chip/Makefile.mak
diff --git a/src/soc/intel/common/block/cnvi/Makefile.inc b/src/soc/intel/common/block/cnvi/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/cnvi/Makefile.inc
rename to src/soc/intel/common/block/cnvi/Makefile.mak
diff --git a/src/soc/intel/common/block/cpu/Makefile.inc b/src/soc/intel/common/block/cpu/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/cpu/Makefile.inc
rename to src/soc/intel/common/block/cpu/Makefile.mak
diff --git a/src/soc/intel/common/block/crashlog/Makefile.inc b/src/soc/intel/common/block/crashlog/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/crashlog/Makefile.inc
rename to src/soc/intel/common/block/crashlog/Makefile.mak
diff --git a/src/soc/intel/common/block/cse/Makefile.inc b/src/soc/intel/common/block/cse/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/cse/Makefile.inc
rename to src/soc/intel/common/block/cse/Makefile.mak
diff --git a/src/soc/intel/common/block/dsp/Makefile.inc b/src/soc/intel/common/block/dsp/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/dsp/Makefile.inc
rename to src/soc/intel/common/block/dsp/Makefile.mak
diff --git a/src/soc/intel/common/block/dtt/Makefile.inc b/src/soc/intel/common/block/dtt/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/dtt/Makefile.inc
rename to src/soc/intel/common/block/dtt/Makefile.mak
diff --git a/src/soc/intel/common/block/fast_spi/Makefile.inc b/src/soc/intel/common/block/fast_spi/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/fast_spi/Makefile.inc
rename to src/soc/intel/common/block/fast_spi/Makefile.mak
diff --git a/src/soc/intel/common/block/gpio/Makefile.inc b/src/soc/intel/common/block/gpio/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/gpio/Makefile.inc
rename to src/soc/intel/common/block/gpio/Makefile.mak
diff --git a/src/soc/intel/common/block/gpmr/Makefile.inc b/src/soc/intel/common/block/gpmr/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/gpmr/Makefile.inc
rename to src/soc/intel/common/block/gpmr/Makefile.mak
diff --git a/src/soc/intel/common/block/graphics/Makefile.inc b/src/soc/intel/common/block/graphics/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/graphics/Makefile.inc
rename to src/soc/intel/common/block/graphics/Makefile.mak
diff --git a/src/soc/intel/common/block/gspi/Makefile.inc b/src/soc/intel/common/block/gspi/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/gspi/Makefile.inc
rename to src/soc/intel/common/block/gspi/Makefile.mak
diff --git a/src/soc/intel/common/block/hda/Makefile.inc b/src/soc/intel/common/block/hda/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/hda/Makefile.inc
rename to src/soc/intel/common/block/hda/Makefile.mak
diff --git a/src/soc/intel/common/block/i2c/Makefile.inc b/src/soc/intel/common/block/i2c/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/i2c/Makefile.inc
rename to src/soc/intel/common/block/i2c/Makefile.mak
diff --git a/src/soc/intel/common/block/ioc/Makefile.inc b/src/soc/intel/common/block/ioc/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/ioc/Makefile.inc
rename to src/soc/intel/common/block/ioc/Makefile.mak
diff --git a/src/soc/intel/common/block/ipu/Makefile.inc b/src/soc/intel/common/block/ipu/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/ipu/Makefile.inc
rename to src/soc/intel/common/block/ipu/Makefile.mak
diff --git a/src/soc/intel/common/block/irq/Makefile.inc b/src/soc/intel/common/block/irq/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/irq/Makefile.inc
rename to src/soc/intel/common/block/irq/Makefile.mak
diff --git a/src/soc/intel/common/block/itss/Makefile.inc b/src/soc/intel/common/block/itss/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/itss/Makefile.inc
rename to src/soc/intel/common/block/itss/Makefile.mak
diff --git a/src/soc/intel/common/block/lpc/Makefile.inc b/src/soc/intel/common/block/lpc/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/lpc/Makefile.inc
rename to src/soc/intel/common/block/lpc/Makefile.mak
diff --git a/src/soc/intel/common/block/lpss/Makefile.inc b/src/soc/intel/common/block/lpss/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/lpss/Makefile.inc
rename to src/soc/intel/common/block/lpss/Makefile.mak
diff --git a/src/soc/intel/common/block/memory/Makefile.inc b/src/soc/intel/common/block/memory/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/memory/Makefile.inc
rename to src/soc/intel/common/block/memory/Makefile.mak
diff --git a/src/soc/intel/common/block/oc_wdt/Makefile.inc b/src/soc/intel/common/block/oc_wdt/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/oc_wdt/Makefile.inc
rename to src/soc/intel/common/block/oc_wdt/Makefile.mak
diff --git a/src/soc/intel/common/block/p2sb/Makefile.inc b/src/soc/intel/common/block/p2sb/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/p2sb/Makefile.inc
rename to src/soc/intel/common/block/p2sb/Makefile.mak
diff --git a/src/soc/intel/common/block/pcie/Makefile.inc b/src/soc/intel/common/block/pcie/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/pcie/Makefile.inc
rename to src/soc/intel/common/block/pcie/Makefile.mak
diff --git a/src/soc/intel/common/block/pcie/rtd3/Makefile.inc b/src/soc/intel/common/block/pcie/rtd3/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/pcie/rtd3/Makefile.inc
rename to src/soc/intel/common/block/pcie/rtd3/Makefile.mak
diff --git a/src/soc/intel/common/block/pcr/Makefile.inc b/src/soc/intel/common/block/pcr/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/pcr/Makefile.inc
rename to src/soc/intel/common/block/pcr/Makefile.mak
diff --git a/src/soc/intel/common/block/pmc/Makefile.inc b/src/soc/intel/common/block/pmc/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/pmc/Makefile.inc
rename to src/soc/intel/common/block/pmc/Makefile.mak
diff --git a/src/soc/intel/common/block/power_limit/Makefile.inc b/src/soc/intel/common/block/power_limit/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/power_limit/Makefile.inc
rename to src/soc/intel/common/block/power_limit/Makefile.mak
diff --git a/src/soc/intel/common/block/rtc/Makefile.inc b/src/soc/intel/common/block/rtc/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/rtc/Makefile.inc
rename to src/soc/intel/common/block/rtc/Makefile.mak
diff --git a/src/soc/intel/common/block/sata/Makefile.inc b/src/soc/intel/common/block/sata/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/sata/Makefile.inc
rename to src/soc/intel/common/block/sata/Makefile.mak
diff --git a/src/soc/intel/common/block/scs/Makefile.inc b/src/soc/intel/common/block/scs/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/scs/Makefile.inc
rename to src/soc/intel/common/block/scs/Makefile.mak
diff --git a/src/soc/intel/common/block/sgx/Makefile.inc b/src/soc/intel/common/block/sgx/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/sgx/Makefile.inc
rename to src/soc/intel/common/block/sgx/Makefile.mak
diff --git a/src/soc/intel/common/block/smbus/Makefile.inc b/src/soc/intel/common/block/smbus/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/smbus/Makefile.inc
rename to src/soc/intel/common/block/smbus/Makefile.mak
diff --git a/src/soc/intel/common/block/smm/Makefile.inc b/src/soc/intel/common/block/smm/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/smm/Makefile.inc
rename to src/soc/intel/common/block/smm/Makefile.mak
diff --git a/src/soc/intel/common/block/spi/Makefile.inc b/src/soc/intel/common/block/spi/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/spi/Makefile.inc
rename to src/soc/intel/common/block/spi/Makefile.mak
diff --git a/src/soc/intel/common/block/sram/Makefile.inc b/src/soc/intel/common/block/sram/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/sram/Makefile.inc
rename to src/soc/intel/common/block/sram/Makefile.mak
diff --git a/src/soc/intel/common/block/systemagent/Makefile.inc b/src/soc/intel/common/block/systemagent/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/systemagent/Makefile.inc
rename to src/soc/intel/common/block/systemagent/Makefile.mak
diff --git a/src/soc/intel/common/block/tcss/Makefile.inc b/src/soc/intel/common/block/tcss/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/tcss/Makefile.inc
rename to src/soc/intel/common/block/tcss/Makefile.mak
diff --git a/src/soc/intel/common/block/thermal/Makefile.inc b/src/soc/intel/common/block/thermal/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/thermal/Makefile.inc
rename to src/soc/intel/common/block/thermal/Makefile.mak
diff --git a/src/soc/intel/common/block/timer/Makefile.inc b/src/soc/intel/common/block/timer/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/timer/Makefile.inc
rename to src/soc/intel/common/block/timer/Makefile.mak
diff --git a/src/soc/intel/common/block/tracehub/Makefile.inc b/src/soc/intel/common/block/tracehub/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/tracehub/Makefile.inc
rename to src/soc/intel/common/block/tracehub/Makefile.mak
diff --git a/src/soc/intel/common/block/uart/Makefile.inc b/src/soc/intel/common/block/uart/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/uart/Makefile.inc
rename to src/soc/intel/common/block/uart/Makefile.mak
diff --git a/src/soc/intel/common/block/usb4/Makefile.inc b/src/soc/intel/common/block/usb4/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/usb4/Makefile.inc
rename to src/soc/intel/common/block/usb4/Makefile.mak
diff --git a/src/soc/intel/common/block/vtd/Makefile.inc b/src/soc/intel/common/block/vtd/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/vtd/Makefile.inc
rename to src/soc/intel/common/block/vtd/Makefile.mak
diff --git a/src/soc/intel/common/block/xdci/Makefile.inc b/src/soc/intel/common/block/xdci/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/xdci/Makefile.inc
rename to src/soc/intel/common/block/xdci/Makefile.mak
diff --git a/src/soc/intel/common/block/xhci/Makefile.inc b/src/soc/intel/common/block/xhci/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/block/xhci/Makefile.inc
rename to src/soc/intel/common/block/xhci/Makefile.mak
diff --git a/src/soc/intel/common/pch/Makefile.inc b/src/soc/intel/common/pch/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/pch/Makefile.inc
rename to src/soc/intel/common/pch/Makefile.mak
diff --git a/src/soc/intel/common/pch/lockdown/Makefile.inc b/src/soc/intel/common/pch/lockdown/Makefile.mak
similarity index 100%
rename from src/soc/intel/common/pch/lockdown/Makefile.inc
rename to src/soc/intel/common/pch/lockdown/Makefile.mak
diff --git a/src/soc/intel/denverton_ns/Makefile.inc b/src/soc/intel/denverton_ns/Makefile.mak
similarity index 100%
rename from src/soc/intel/denverton_ns/Makefile.inc
rename to src/soc/intel/denverton_ns/Makefile.mak
diff --git a/src/soc/intel/elkhartlake/Makefile.inc b/src/soc/intel/elkhartlake/Makefile.mak
similarity index 100%
rename from src/soc/intel/elkhartlake/Makefile.inc
rename to src/soc/intel/elkhartlake/Makefile.mak
diff --git a/src/soc/intel/elkhartlake/romstage/Makefile.inc b/src/soc/intel/elkhartlake/romstage/Makefile.mak
similarity index 100%
rename from src/soc/intel/elkhartlake/romstage/Makefile.inc
rename to src/soc/intel/elkhartlake/romstage/Makefile.mak
diff --git a/src/soc/intel/jasperlake/Makefile.inc b/src/soc/intel/jasperlake/Makefile.mak
similarity index 100%
rename from src/soc/intel/jasperlake/Makefile.inc
rename to src/soc/intel/jasperlake/Makefile.mak
diff --git a/src/soc/intel/jasperlake/romstage/Makefile.inc b/src/soc/intel/jasperlake/romstage/Makefile.mak
similarity index 100%
rename from src/soc/intel/jasperlake/romstage/Makefile.inc
rename to src/soc/intel/jasperlake/romstage/Makefile.mak
diff --git a/src/soc/intel/meteorlake/Makefile.inc b/src/soc/intel/meteorlake/Makefile.mak
similarity index 100%
rename from src/soc/intel/meteorlake/Makefile.inc
rename to src/soc/intel/meteorlake/Makefile.mak
diff --git a/src/soc/intel/meteorlake/romstage/Makefile.inc b/src/soc/intel/meteorlake/romstage/Makefile.mak
similarity index 100%
rename from src/soc/intel/meteorlake/romstage/Makefile.inc
rename to src/soc/intel/meteorlake/romstage/Makefile.mak
diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.mak
similarity index 100%
rename from src/soc/intel/skylake/Makefile.inc
rename to src/soc/intel/skylake/Makefile.mak
diff --git a/src/soc/intel/skylake/nhlt/Makefile.inc b/src/soc/intel/skylake/nhlt/Makefile.mak
similarity index 100%
rename from src/soc/intel/skylake/nhlt/Makefile.inc
rename to src/soc/intel/skylake/nhlt/Makefile.mak
diff --git a/src/soc/intel/skylake/romstage/Makefile.inc b/src/soc/intel/skylake/romstage/Makefile.mak
similarity index 100%
rename from src/soc/intel/skylake/romstage/Makefile.inc
rename to src/soc/intel/skylake/romstage/Makefile.mak
diff --git a/src/soc/intel/tigerlake/Makefile.inc b/src/soc/intel/tigerlake/Makefile.mak
similarity index 100%
rename from src/soc/intel/tigerlake/Makefile.inc
rename to src/soc/intel/tigerlake/Makefile.mak
diff --git a/src/soc/intel/tigerlake/romstage/Makefile.inc b/src/soc/intel/tigerlake/romstage/Makefile.mak
similarity index 100%
rename from src/soc/intel/tigerlake/romstage/Makefile.inc
rename to src/soc/intel/tigerlake/romstage/Makefile.mak
diff --git a/src/soc/intel/xeon_sp/Makefile.inc b/src/soc/intel/xeon_sp/Makefile.mak
similarity index 100%
rename from src/soc/intel/xeon_sp/Makefile.inc
rename to src/soc/intel/xeon_sp/Makefile.mak
diff --git a/src/soc/intel/xeon_sp/cpx/Makefile.inc b/src/soc/intel/xeon_sp/cpx/Makefile.mak
similarity index 100%
rename from src/soc/intel/xeon_sp/cpx/Makefile.inc
rename to src/soc/intel/xeon_sp/cpx/Makefile.mak
diff --git a/src/soc/intel/xeon_sp/ebg/Makefile.inc b/src/soc/intel/xeon_sp/ebg/Makefile.mak
similarity index 100%
rename from src/soc/intel/xeon_sp/ebg/Makefile.inc
rename to src/soc/intel/xeon_sp/ebg/Makefile.mak
diff --git a/src/soc/intel/xeon_sp/lbg/Makefile.inc b/src/soc/intel/xeon_sp/lbg/Makefile.mak
similarity index 100%
rename from src/soc/intel/xeon_sp/lbg/Makefile.inc
rename to src/soc/intel/xeon_sp/lbg/Makefile.mak
diff --git a/src/soc/intel/xeon_sp/ras/Makefile.inc b/src/soc/intel/xeon_sp/ras/Makefile.mak
similarity index 100%
rename from src/soc/intel/xeon_sp/ras/Makefile.inc
rename to src/soc/intel/xeon_sp/ras/Makefile.mak
diff --git a/src/soc/intel/xeon_sp/skx/Makefile.inc b/src/soc/intel/xeon_sp/skx/Makefile.mak
similarity index 100%
rename from src/soc/intel/xeon_sp/skx/Makefile.inc
rename to src/soc/intel/xeon_sp/skx/Makefile.mak
diff --git a/src/soc/intel/xeon_sp/spr/Makefile.inc b/src/soc/intel/xeon_sp/spr/Makefile.mak
similarity index 100%
rename from src/soc/intel/xeon_sp/spr/Makefile.inc
rename to src/soc/intel/xeon_sp/spr/Makefile.mak
--
To view, visit https://review.coreboot.org/c/coreboot/+/80073?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib479b93b7d0b2e790d0495b6a6b4b4298a515d9a
Gerrit-Change-Number: 80073
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Cliff Huang, Julius Werner, Jérémy Compostella, Lance Zhao, Martin L Roth, Philipp Hug, Tim Wawrzynczak, ron minnich.
Hello Cliff Huang, Julius Werner, Jérémy Compostella, Lance Zhao, Philipp Hug, Tim Wawrzynczak, build bot (Jenkins), ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80066?usp=email
to look at the new patch set (#2).
Change subject: acpi,arch,commonlib: Rename Makefiles from .inc to .mak
......................................................................
acpi,arch,commonlib: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ice5dadd3eaadfa9962225520a3a75b05b44518ca
---
R src/acpi/Makefile.mak
R src/arch/arm/Makefile.mak
R src/arch/arm/armv4/Makefile.mak
R src/arch/arm/armv7/Makefile.mak
R src/arch/arm/libgcc/Makefile.mak
R src/arch/arm64/Makefile.mak
R src/arch/arm64/armv8/Makefile.mak
R src/arch/ppc64/Makefile.mak
R src/arch/riscv/Makefile.mak
R src/arch/x86/Makefile.mak
R src/commonlib/Makefile.mak
R src/commonlib/storage/Makefile.mak
12 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/80066/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80066?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice5dadd3eaadfa9962225520a3a75b05b44518ca
Gerrit-Change-Number: 80066
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80084?usp=email )
Change subject: soc/amd/*/chip: factor out FSP-S call
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80084?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8236db7ac80275a65020b7e7a9acce8314c831c
Gerrit-Change-Number: 80084
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 23:30:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80083?usp=email )
Change subject: soc/amd: factor out non-CAR romstage to common code
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/amd/common/block/cpu/noncar/romstage.c:
https://review.coreboot.org/c/coreboot/+/80083/comment/bdb6b1c1_0e1b5adb :
PS2, Line 32: Fixup
> that part is from one of the files where i copied the code from, but since i'm reworking the patches […]
Heh, typical. Complaints about code that you didn't even write. I hate that. :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/80083?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a0695714ba08b13a58b12a490da50cb7f5a1ca9
Gerrit-Change-Number: 80083
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 23:29:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80002?usp=email )
Change subject: soc/amd/*/romstage: factor out FSP-M call
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/amd/cezanne/romstage.c:
https://review.coreboot.org/c/coreboot/+/80002/comment/44b3149c_d5d8baaf :
PS2, Line 20: call
> i agree that one is better than fsp_m_call. […]
Awesome. Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80002?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I30cf1bee2ec1a507dc8e61eaf44067663e2505ae
Gerrit-Change-Number: 80002
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 23:28:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80084?usp=email )
Change subject: soc/amd/*/chip: factor out FSP-S call
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/chip.c:
https://review.coreboot.org/c/coreboot/+/80084/comment/16778b46_5641f0ae :
PS1, Line 40: fsp_s_call
> same comment as for fsp_m_call. I just don't like the "call" part. […]
yep, you got a point there. renamed it to amd_fsp_silicon_init
--
To view, visit https://review.coreboot.org/c/coreboot/+/80084?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8236db7ac80275a65020b7e7a9acce8314c831c
Gerrit-Change-Number: 80084
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 23:26:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80083?usp=email )
Change subject: soc/amd: factor out non-CAR romstage to common code
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/common/block/acpimmio/Kconfig:
https://review.coreboot.org/c/coreboot/+/80083/comment/c9c30428_3b94bdbd :
PS2, Line 21: config SOC_AMD_COMMON_ROMSTAGE_LEGACY_DMA_FIXUP
> Put this in the soc/amd/common/block/cpu Kconfig?
wasn't sure if i should put this into the acpimmio or the cpu block's kconfig, but thinking a bit more about it, the cpu block's kconfig is probably the better choice, since now i can put that option inside the noncar part
File src/soc/amd/common/block/cpu/noncar/romstage.c:
https://review.coreboot.org/c/coreboot/+/80083/comment/4419f27c_351cb5fe :
PS2, Line 32: Fixup
> Nit: This should just be 'fix' or two words, 'fix up'. […]
that part is from one of the files where i copied the code from, but since i'm reworking the patches anyway, i'll just fix that up ;P
--
To view, visit https://review.coreboot.org/c/coreboot/+/80083?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a0695714ba08b13a58b12a490da50cb7f5a1ca9
Gerrit-Change-Number: 80083
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 23:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80002?usp=email )
Change subject: soc/amd/*/romstage: factor out FSP-M call
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/romstage.c:
https://review.coreboot.org/c/coreboot/+/80002/comment/39f13f14_a93ef0dd :
PS2, Line 20: call
> fsp_early_init() ?
i agree that one is better than fsp_m_call. since the fsp1 driver uses that function name for something else, i'll use amd_fsp_early_init(), since this is also not a function from the fsp driver, but from the common amd fsp code
--
To view, visit https://review.coreboot.org/c/coreboot/+/80002?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I30cf1bee2ec1a507dc8e61eaf44067663e2505ae
Gerrit-Change-Number: 80002
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 23:24:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier.
Hello Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80084?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by Martin Roth, Verified+1 by build bot (Jenkins)
Change subject: soc/amd/*/chip: factor out FSP-S call
......................................................................
soc/amd/*/chip: factor out FSP-S call
Move the call into the FSP code to a file in the common AMD FSP code to
isolate the FSP-specific parts of the code.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Ic8236db7ac80275a65020b7e7a9acce8314c831c
---
M src/soc/amd/cezanne/chip.c
M src/soc/amd/common/block/include/amdblocks/fsp.h
M src/soc/amd/common/fsp/Makefile.inc
A src/soc/amd/common/fsp/fsp_ramstage.c
M src/soc/amd/glinda/chip.c
M src/soc/amd/mendocino/chip.c
M src/soc/amd/phoenix/chip.c
M src/soc/amd/picasso/chip.c
8 files changed, 21 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/80084/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80084?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8236db7ac80275a65020b7e7a9acce8314c831c
Gerrit-Change-Number: 80084
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Hello Fred Reitberger, Jason Glenesk, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80083?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/amd: factor out non-CAR romstage to common code
......................................................................
soc/amd: factor out non-CAR romstage to common code
Since the romstage code is very similar between all AMD non-CAR SoCs,
factor out a common romstage implementation. All SoCs that select
SOC_AMD_COMMON_BLOCK_PM_CHIPSET_STATE_SAVE call fill_chipset_state, so
this Kconfig option can be used to determine whether to make that call.
In the FSP case, amd_fsp_early_init gets called, while in the case of an
implementation that doesn't rely on an FSP to do the initialization,
cbmem_initialize_empty gets called to set up CBMEM which otherwise would
be done inside the FSP driver code. Since only some SoCs call
fch_disable_legacy_dma_io again in romstage right after
amd_fsp_early_init, introduce the new
SOC_AMD_COMMON_ROMSTAGE_LEGACY_DMA_FIXUP Kconfig option, so that the
SoCs can specify if this call is needed or not.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I4a0695714ba08b13a58b12a490da50cb7f5a1ca9
---
M src/soc/amd/cezanne/Kconfig
M src/soc/amd/cezanne/Makefile.inc
D src/soc/amd/cezanne/romstage.c
M src/soc/amd/common/block/cpu/Kconfig
M src/soc/amd/common/block/cpu/noncar/Makefile.inc
A src/soc/amd/common/block/cpu/noncar/romstage.c
M src/soc/amd/genoa_poc/Makefile.inc
D src/soc/amd/genoa_poc/romstage.c
M src/soc/amd/glinda/Kconfig
M src/soc/amd/glinda/Makefile.inc
D src/soc/amd/glinda/romstage.c
M src/soc/amd/mendocino/Kconfig
M src/soc/amd/mendocino/Makefile.inc
D src/soc/amd/mendocino/romstage.c
M src/soc/amd/phoenix/Kconfig
M src/soc/amd/phoenix/Makefile.inc
D src/soc/amd/phoenix/romstage.c
M src/soc/amd/picasso/Makefile.inc
D src/soc/amd/picasso/romstage.c
19 files changed, 50 insertions(+), 165 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/80083/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80083?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a0695714ba08b13a58b12a490da50cb7f5a1ca9
Gerrit-Change-Number: 80083
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset