coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in libgfxinit[master]: gma: Work around GNATprove issue with nested loops
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Angel Pons, Nico Huber. Hello Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/68112?usp=email to look at the new patch set (#2). Change subject: gma: Work around GNATprove issue with nested loops ...................................................................... gma: Work around GNATprove issue with nested loops Add some explicit `Loop_Invariant (True)` to work around odd check messages. These show up since about the spark- community-2019 release and still with newer versions, which almost seem to hang (takes a some minutes longer than expected). Example messages are Provided below. Given that the values are in the ranges as stated by the `for` loops, they can't be out of range. hw-gfx-gma-plls.adb:323:14: medium: range check might fail 323 | for M1 in reverse M1_Range range Limits.M1_Lower .. Limits.M1_Upper | ^~ hw-gfx-gma-plls.adb:325:17: medium: range check might fail 325 | for M2 in reverse M2_Range range Limits.M2_Lower .. Int64'Min (Limits.M2_Upper, M1) | ^~ hw-gfx-gma-plls.adb:327:20: medium: range check might fail 327 | for P1 in reverse P1_Range range Limits.P1_Lower .. Limits.P1_Upper | ^~ hw-gfx-gma-plls.adb:332:41: medium: range check might fail 332 | M2 => M2, | ^~ reason for check: input value must fit in parameter type Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/g45/hw-gfx-gma-plls.adb M common/ironlake/hw-gfx-gma-plls.adb 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/12/68112/2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68112?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Gerrit-Change-Number: 68112 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: soc/intel/meteorlake: Add support for crashlog
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Kane Chen, Kapil Porwal, Paul Menzel, Pratikkumar V Prajapati, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769?usp=email ) Change subject: soc/intel/meteorlake: Add support for crashlog ...................................................................... Patch Set 21: (4 comments) File src/soc/intel/meteorlake/crashlog.c: https://review.coreboot.org/c/coreboot/+/74769/comment/3572f02f_cc2a2d96 : PS21, Line 61: /* Program BAR 0 and enable command register memory space decoding */ before programming the BAR the best practice says, try to disable the MMIO and IO space and then write the BAR. https://review.coreboot.org/c/coreboot/+/74769/comment/500397ae_6c8b3138 : PS21, Line 75: BIOS_DEBUG should be BIOS_ERROR? https://review.coreboot.org/c/coreboot/+/74769/comment/a08e104a_53dea3ae : PS21, Line 80: BIOS_DEBUG same? https://review.coreboot.org/c/coreboot/+/74769/comment/2151191f_b83486b1 : PS21, Line 85: BIOS_DEBUG same? -- To view, visit https://review.coreboot.org/c/coreboot/+/74769?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0abd697fba35edf1c03d2a3a325b7785b985cd5 Gerrit-Change-Number: 74769 Gerrit-PatchSet: 21 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 09:14:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/rex0: Add new GFX devices with custom _PLD
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Kapil Porwal, Tarun Tuli, Won Chung. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74367?usp=email ) Change subject: mb/google/rex/var/rex0: Add new GFX devices with custom _PLD ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74367?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I193b95e8bd8ae538c4f25fbe772b174ef455d744 Gerrit-Change-Number: 74367 Gerrit-PatchSet: 9 Gerrit-Owner: Won Chung <wonchung(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Benson Leung <bleung(a)google.com> Gerrit-CC: Prashant Malani <pmalani(a)chromium.org> Gerrit-CC: Sean Paul <seanpaul(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Won Chung <wonchung(a)google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 09:08:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/rex0: probe for i2c1 touchscreen
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75565?usp=email ) Change subject: mb/google/rex/var/rex0: probe for i2c1 touchscreen ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: can u please rebase this CL as an independent one ? and we should merge this ASAP. -- To view, visit https://review.coreboot.org/c/coreboot/+/75565?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0bee176298fddd2aee35cf084db037a3ce7672f7 Gerrit-Change-Number: 75565 Gerrit-PatchSet: 1 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 09:07:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/rex0: include Elan HID over SPI ASL
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74887?usp=email ) Change subject: mb/google/rex/var/rex0: include Elan HID over SPI ASL ...................................................................... Patch Set 16: (1 comment) Patchset: PS16: it can be merged with CB:74886 CL -- To view, visit https://review.coreboot.org/c/coreboot/+/74887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8af72b7c2a62145da4d2bcefb7c568e0964d0969 Gerrit-Change-Number: 74887 Gerrit-PatchSet: 16 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 09:06:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex: introduce the mainboard.asl for all rex variants
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74886?usp=email ) Change subject: mb/google/rex: introduce the mainboard.asl for all rex variants ...................................................................... Patch Set 13: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/74886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 Gerrit-Change-Number: 74886 Gerrit-PatchSet: 13 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 09:05:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex: introduce the mainboard.asl for all rex variants
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74886?usp=email ) Change subject: mb/google/rex: introduce the mainboard.asl for all rex variants ...................................................................... Patch Set 13: (2 comments) Patchset: PS13: how about a File src/mainboard/google/rex/dsdt.asl: https://review.coreboot.org/c/coreboot/+/74886/comment/a8fd9266_7a5d4fd3 : PS13, Line 40: /* Mainboard specific */ : #include "variant/acpi/mainboard.asl" how about adding HID_SPI elan driver based on a Kconfig ? that way, we don't need to keep mainboard.asl for each variant -- To view, visit https://review.coreboot.org/c/coreboot/+/74886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 Gerrit-Change-Number: 74886 Gerrit-PatchSet: 13 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 09:05:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex: introduce the mainboard.asl for all rex variants
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74886?usp=email ) Change subject: mb/google/rex: introduce the mainboard.asl for all rex variants ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 Gerrit-Change-Number: 74886 Gerrit-PatchSet: 13 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 09:03:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex: introduce the mainboard.asl for all rex variants
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74886?usp=email ) Change subject: mb/google/rex: introduce the mainboard.asl for all rex variants ...................................................................... Patch Set 13: (1 comment) Patchset: PS13: I guess Ovis is now added too? -- To view, visit https://review.coreboot.org/c/coreboot/+/74886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 Gerrit-Change-Number: 74886 Gerrit-PatchSet: 13 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 09:03:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex/var/rex0: add HID over SPI ACPI driver
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Matt DeVillier, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74885?usp=email ) Change subject: mb/google/rex/var/rex0: add HID over SPI ACPI driver ...................................................................... Patch Set 10: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74885/comment/2d97ffff_c8d1255b : PS10, Line 15: waiting for HW to be available please add a test line with S0ix being enabled -- To view, visit https://review.coreboot.org/c/coreboot/+/74885?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Gerrit-Change-Number: 74885 Gerrit-PatchSet: 10 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 09:02:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023