coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[M] Change in coreboot[master]: Documentation: Final 4.20 release notes
by Felix Singer (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth, Nico Huber. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75636?usp=email ) Change subject: Documentation: Final 4.20 release notes ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75636/comment/5c2117ff_54181700 : PS1, Line 12: , > I think the comma is at least allowed here. Adding a note is independent […] That's why I marked it as nit. I am unsure and don't stick to it :D -- To view, visit https://review.coreboot.org/c/coreboot/+/75636?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I350535b8aa531642e161f1cad4752452f9171647 Gerrit-Change-Number: 75636 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 12:36:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/amd/picasso/root_complex: reserve PCI config IO ports
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75556?usp=email ) Change subject: soc/amd/picasso/root_complex: reserve PCI config IO ports ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/75556?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie42260902ee2b383dd5867ac813cae029f706f2d Gerrit-Change-Number: 75556 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 04 Jun 2023 12:28:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common/data_fabric/domain: provide amd_pci_domain_fill_ssdt
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74843?usp=email ) Change subject: soc/amd/common/data_fabric/domain: provide amd_pci_domain_fill_ssdt ...................................................................... Patch Set 14: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74843?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf6d38a8ef5bb0163c4d1c021bf892c323d9a448 Gerrit-Change-Number: 74843 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 04 Jun 2023 12:27:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common/data_fabric/domain: provide amd_pci_domain_fill_ssdt
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74843?usp=email ) Change subject: soc/amd/common/data_fabric/domain: provide amd_pci_domain_fill_ssdt ...................................................................... Patch Set 14: (1 comment) File src/soc/amd/common/block/data_fabric/domain.c: https://review.coreboot.org/c/coreboot/+/74843/comment/40cfdf79_ac19753d : PS11, Line 169: if (base > PCI_IO_CONFIG_LAST_PORT || limit < PCI_IO_CONFIG_INDEX) { > i'd keep the code as it is right now with the updated comment that points out why this is done. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/74843?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf6d38a8ef5bb0163c4d1c021bf892c323d9a448 Gerrit-Change-Number: 74843 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 04 Jun 2023 12:26:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: gma i2c: Update for Tiger Lake
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

Nico Huber has submitted this change. ( https://review.coreboot.org/c/libgfxinit/+/67492?usp=email ) Change subject: gma i2c: Update for Tiger Lake ...................................................................... gma i2c: Update for Tiger Lake Tiger Lake GMBUS is different only in the pin pairs because it has a different set of ports. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I46248b9c55948aa9bc4c047624c7dc3f62dba766 Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/67492 Tested-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-i2c.adb 2 files changed, 27 insertions(+), 3 deletions(-) Approvals: Nico Huber: Verified; Looks good to me, approved diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index a2bc2e8..b438c40 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -275,7 +275,7 @@ (not Haswell_On or else (CPU_Haswell and Is_ULX)); ----------- GMBUS: ----------- - Ungate_GMBUS_Unit_Level : <genbool> := Skylake_On; + Ungate_GMBUS_Unit_Level : <genbool> := Skylake_On and not Tigerlake_On; GMBUS_Alternative_Pins : <genbool> := Gen_Broxton or Cannon_Point_On; Has_PCH_GMBUS : <genbool> := Ironlake_On; diff --git a/common/hw-gfx-gma-i2c.adb b/common/hw-gfx-gma-i2c.adb index 67e90ab..29ce9c1 100644 --- a/common/hw-gfx-gma-i2c.adb +++ b/common/hw-gfx-gma-i2c.adb @@ -27,10 +27,12 @@ PCH_DSPCLK_GATE_D_GMBUS_UNIT_LVL : constant := 1 * 2 ** 31; + function GMBUS0_PIN_PAIR_SELECT_MASK return Word32 is + (if Config.Has_Type_C_Ports then 15 * 2 ** 0 else 7 * 2 ** 0); + GMBUS0_GMBUS_RATE_SELECT_MASK : constant := 7 * 2 ** 8; GMBUS0_GMBUS_RATE_SELECT_100KHZ : constant := 0 * 2 ** 8; GMBUS0_GMBUS_RATE_SELECT_50KHZ : constant := 1 * 2 ** 8; - GMBUS0_PIN_PAIR_SELECT_MASK : constant := 7 * 2 ** 0; GMBUS0_PIN_PAIR_SELECT_NONE : constant := 0 * 2 ** 0; GMBUS0_PIN_PAIR_SELECT_DAC : constant := 2 * 2 ** 0; GMBUS0_PIN_PAIR_SELECT_LVDS : constant := 3 * 2 ** 0; @@ -42,6 +44,16 @@ GMBUS0_PIN_PAIR_SELECT_BXT_B : constant := 1 * 2 ** 0; GMBUS0_PIN_PAIR_SELECT_BXT_C : constant := 2 * 2 ** 0; GMBUS0_PIN_PAIR_SELECT_BXT_D : constant := 3 * 2 ** 0; + -- Tiger Lake and later use even different pins + GMBUS0_PIN_PAIR_SELECT_TGL_1 : constant := 1 * 2 ** 0; + GMBUS0_PIN_PAIR_SELECT_TGL_2 : constant := 2 * 2 ** 0; + GMBUS0_PIN_PAIR_SELECT_TGL_3 : constant := 3 * 2 ** 0; + GMBUS0_PIN_PAIR_SELECT_TGL_TC1 : constant := 9 * 2 ** 0; + GMBUS0_PIN_PAIR_SELECT_TGL_TC2 : constant := 10 * 2 ** 0; + GMBUS0_PIN_PAIR_SELECT_TGL_TC3 : constant := 11 * 2 ** 0; + GMBUS0_PIN_PAIR_SELECT_TGL_TC4 : constant := 12 * 2 ** 0; + GMBUS0_PIN_PAIR_SELECT_TGL_TC5 : constant := 13 * 2 ** 0; + GMBUS0_PIN_PAIR_SELECT_TGL_TC6 : constant := 14 * 2 ** 0; GMBUS1_SOFTWARE_CLEAR_INTERRUPT : constant := 1 * 2 ** 31; GMBUS1_SOFTWARE_READY : constant := 1 * 2 ** 30; @@ -106,7 +118,19 @@ function GMBUS0_PIN_PAIR_SELECT (Port : PCH_Port) return Word32 is begin return - (if Config.GMBUS_Alternative_Pins then + (if Config.Has_Type_C_Ports then + (case Port is + when PCH_HDMI_A => GMBUS0_PIN_PAIR_SELECT_TGL_1, + when PCH_HDMI_B => GMBUS0_PIN_PAIR_SELECT_TGL_2, + when PCH_HDMI_C => GMBUS0_PIN_PAIR_SELECT_TGL_3, + when PCH_TC1 => GMBUS0_PIN_PAIR_SELECT_TGL_TC1, + when PCH_TC2 => GMBUS0_PIN_PAIR_SELECT_TGL_TC2, + when PCH_TC3 => GMBUS0_PIN_PAIR_SELECT_TGL_TC3, + when PCH_TC4 => GMBUS0_PIN_PAIR_SELECT_TGL_TC4, + when PCH_TC5 => GMBUS0_PIN_PAIR_SELECT_TGL_TC5, + when PCH_TC6 => GMBUS0_PIN_PAIR_SELECT_TGL_TC6, + when others => GMBUS0_PIN_PAIR_SELECT_NONE) + elsif Config.GMBUS_Alternative_Pins then (case Port is when PCH_HDMI_B => GMBUS0_PIN_PAIR_SELECT_BXT_B, when PCH_HDMI_C => GMBUS0_PIN_PAIR_SELECT_BXT_C, -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67492?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I46248b9c55948aa9bc4c047624c7dc3f62dba766 Gerrit-Change-Number: 67492 Gerrit-PatchSet: 20 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: merged

1 0

[S] Change in libgfxinit[master]: gma: Update PCH Rawclk programming for TGL
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

Nico Huber has submitted this change. ( https://review.coreboot.org/c/libgfxinit/+/67491?usp=email ) Change subject: gma: Update PCH Rawclk programming for TGL ...................................................................... gma: Update PCH Rawclk programming for TGL Tigerlake onwards needs the Rawclk numerator programmed into the RAWCLK register in addition the fields from to prior generations. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: Iad36221a44db4128332392bd6610132ea08c0e35 Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/67491 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma.adb 2 files changed, 21 insertions(+), 2 deletions(-) Approvals: Nico Huber: Verified; Looks good to me, approved diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index e759a0c..a2bc2e8 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -293,6 +293,9 @@ ----------- Type-C: ---------- Has_Type_C_Ports : <genbool> := Tigerlake_On; + ----------- Rawclk ----------- + Need_Rawclk_Numerator : <genbool> := Tigerlake_On; + ---------------------------------------------------------------------------- Max_Pipe : <ilkvar> Pipe_Index := diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index 83ded92..cacafd3 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -97,8 +97,20 @@ ---------------------------------------------------------------------------- - PCH_RAWCLK_FREQ_MASK : constant := - (if Config.Has_Fractional_RawClk then 16#3fff# * 2 ** 16 else 16#3ff# * 2 ** 0); + ICP_RAWCLK_NUM : constant := 1 * 2 ** 11; + + function PCH_RAWCLK_FREQ_MASK return Word32 is + Mask : Word32; + begin + if Config.Need_Rawclk_Numerator then + Mask := 16#ffff_ffff#; + elsif Config.Has_Fractional_RawClk then + Mask := 16#3fff# * 2 ** 16; + else + Mask := 16#3ff# * 2 ** 0; + end if; + return Mask; + end PCH_RAWCLK_FREQ_MASK; function PCH_RAWCLK_FREQ (Freq : Frequency_Type) return Word32 is @@ -112,6 +124,10 @@ Freq32 := Freq32 or Shift_Left (Word32 (Div_Round_Closest (1_000, Fraction_K) - 1), 26); end if; + + if Config.Need_Rawclk_Numerator then + Freq32 := Freq32 or ICP_RAWCLK_NUM; + end if; return Freq32; end; else -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67491?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Iad36221a44db4128332392bd6610132ea08c0e35 Gerrit-Change-Number: 67491 Gerrit-PatchSet: 20 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: Documentation: Move 4.20 release notes to 4.20.1
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75637?usp=email ) Change subject: Documentation: Move 4.20 release notes to 4.20.1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/75637?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2fb35f1bf9fa7dc16d324882cd6057a1a4b05ed Gerrit-Change-Number: 75637 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 12:08:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation: Final 4.20 release notes
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75636?usp=email ) Change subject: Documentation: Final 4.20 release notes ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75636/comment/d8ad9c93_ca7c977e : PS1, Line 12: , > nit: Remove comma I think the comma is at least allowed here. Adding a note is independent from updating statistics etc. Note: German rules differ slightly. -- To view, visit https://review.coreboot.org/c/coreboot/+/75636?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I350535b8aa531642e161f1cad4752452f9171647 Gerrit-Change-Number: 75636 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 12:06:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in libgfxinit[master]: gma: Work around GNATprove issue with nested loops
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68112?usp=email ) Change subject: gma: Work around GNATprove issue with nested loops ...................................................................... Patch Set 3: Verified+1 (1 comment) Commit Message: https://review.coreboot.org/c/libgfxinit/+/68112/comment/bac4618d_7fdc1608 : PS1, Line 10: weird check messages. > Problems were varying from toolchain version to version, I'll check with something newish. Done -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68112?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Gerrit-Change-Number: 68112 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 11:56:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in libgfxinit[master]: gma: Work around GNATprove issue with nested loops
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Angel Pons, Nico Huber. Hello Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/68112?usp=email to look at the new patch set (#3). Change subject: gma: Work around GNATprove issue with nested loops ...................................................................... gma: Work around GNATprove issue with nested loops Add some explicit `Loop_Invariant (True)` to work around odd check messages. These show up since about the spark- community-2019 release and still with newer versions, which almost seem to hang (takes some minutes longer than expected). Example messages are provided below. Given that the values are in the ranges as stated by the `for` loops, they can't be out of range. hw-gfx-gma-plls.adb:323:14: medium: range check might fail 323 | for M1 in reverse M1_Range range Limits.M1_Lower .. Limits.M1_Upper | ^~ hw-gfx-gma-plls.adb:325:17: medium: range check might fail 325 | for M2 in reverse M2_Range range Limits.M2_Lower .. Int64'Min (Limits.M2_Upper, M1) | ^~ hw-gfx-gma-plls.adb:327:20: medium: range check might fail 327 | for P1 in reverse P1_Range range Limits.P1_Lower .. Limits.P1_Upper | ^~ hw-gfx-gma-plls.adb:332:41: medium: range check might fail 332 | M2 => M2, | ^~ reason for check: input value must fit in parameter type Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/g45/hw-gfx-gma-plls.adb M common/ironlake/hw-gfx-gma-plls.adb 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/12/68112/3 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68112?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Gerrit-Change-Number: 68112 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023