coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[S] Change in coreboot[master]: soc/intel/meteorlake: Introduce different SoC flavors of Meteor Lake
by Kapil Porwal (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Felix Singer, Ivy Jian, Paul Menzel, Subrata Banik. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75606?usp=email ) Change subject: soc/intel/meteorlake: Introduce different SoC flavors of Meteor Lake ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75606?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27404bbbd0b489412953118e140f6f39b6e43426 Gerrit-Change-Number: 75606 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 17:15:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Hook up UPD PchHdaSdiEnable
by Kapil Porwal (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eric Lai, Himanshu Sahdev, Paul Menzel, Ronak Kanabar, Subrata Banik. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75529?usp=email ) Change subject: soc/intel/meteorlake: Hook up UPD PchHdaSdiEnable ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43f1e59d28fc07218f8e25266f8ce3bdcf3f6e5c Gerrit-Change-Number: 75529 Gerrit-PatchSet: 5 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 17:15:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libgfxinit[master]: gma pipe_setup: Update for TGL
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

1 0

[M] Change in coreboot[master]: mb/google/rex: Create karis variant
by 9elements QA (Code Review) 04 Jun '23

04 Jun '23

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75551?usp=email ) Change subject: mb/google/rex: Create karis variant ...................................................................... Patch Set 5: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/166987 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/166985 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/166984 FAIL: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/166983 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/166982 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/166981 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/166980 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/166979 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/166978 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/166977 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/166976 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/166975 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/166974 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/166973 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/166972 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/166971 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/75551?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I16d8b43390401789b87a6233238e37f32a17b46b Gerrit-Change-Number: 75551 Gerrit-PatchSet: 5 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 04 Jun 2023 16:37:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/intel/mtlrvp: Select SOC_INTEL_METEORLAKE_U_P
by Tarun Tuli (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Ivy Jian, Kapil Porwal, Subrata Banik. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75607?usp=email ) Change subject: mb/intel/mtlrvp: Select SOC_INTEL_METEORLAKE_U_P ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75607?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b1dec47ef9d12ac50317b86c4f0bc5fbe4e4dc3 Gerrit-Change-Number: 75607 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 16:13:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Introduce different SoC flavors of Meteor Lake
by Tarun Tuli (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Felix Singer, Ivy Jian, Kapil Porwal, Paul Menzel, Subrata Banik. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75606?usp=email ) Change subject: soc/intel/meteorlake: Introduce different SoC flavors of Meteor Lake ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75606?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27404bbbd0b489412953118e140f6f39b6e43426 Gerrit-Change-Number: 75606 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 16:13:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Hook up UPD PchHdaSdiEnable
by Tarun Tuli (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eric Lai, Himanshu Sahdev, Kapil Porwal, Paul Menzel, Ronak Kanabar, Subrata Banik. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75529?usp=email ) Change subject: soc/intel/meteorlake: Hook up UPD PchHdaSdiEnable ...................................................................... Patch Set 5: Code-Review+2 (1 comment) File src/soc/intel/meteorlake/romstage/fsp_params.c: https://review.coreboot.org/c/coreboot/+/75529/comment/281e425f_57325539 : PS5, Line 228: m_cfg->PchHdaSdiEnable[i] = config->pch_hda_sdi_enable[i]; > maybe memcpy? im okay either way. i think this code is clearer than the memcpy and shouldnt be any appreciable performance difference given the few elements. -- To view, visit https://review.coreboot.org/c/coreboot/+/75529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43f1e59d28fc07218f8e25266f8ce3bdcf3f6e5c Gerrit-Change-Number: 75529 Gerrit-PatchSet: 5 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 16:12:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: vc/intel/fsp/mtl: Update header files from 3165_81 to 3194_81
by Tarun Tuli (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Kilari Raasi, Martin L Roth, Paul Menzel, Ronak Kanabar, Subrata Banik. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75519?usp=email ) Change subject: vc/intel/fsp/mtl: Update header files from 3165_81 to 3194_81 ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75519?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43f276e9b8e46edc76dc7749d2a610cfa836a718 Gerrit-Change-Number: 75519 Gerrit-PatchSet: 10 Gerrit-Owner: Kilari Raasi <kilari.raasi(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kilari Raasi <kilari.raasi(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 16:10:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libgfxinit[master]: gma pipe_setup: Update for TGL
by Nico Huber (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Angel Pons, Jérémy Compostella, Tarun Tuli, Tim Wawrzynczak. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67494?usp=email ) Change subject: gma pipe_setup: Update for TGL ...................................................................... Patch Set 23: Code-Review+1 (12 comments) Patchset: PS23: Only style nits and some suggestions, the logic looks good! I noticed that IS_ALDERLAKE_S() in `i915` includes ADL-N, so that should cover all the IDs we have added so far. Only ADL-S would differ (at least wrt. the DBOX credits). NB. I'm currently following the chain as pushed on February 15th. Hope that's right. Some changes were updated individually since then. Let me know if you need help rebasing w/o losing such changes. File common/hw-gfx-gma-config.ads.template: https://review.coreboot.org/c/libgfxinit/+/67494/comment/63eb8691_8124c6b0 : PS23, Line 217: Alderlake_On I see the changed register interface in TGL docs already. I haven't found much documentation about the arbitration slots. Only that it seems optional if the hardware defaults are ok. Has it been tested w/o this 'override'? Update: Seems to be about `/* Wa_22012358565:adl-p */` ? https://review.coreboot.org/c/libgfxinit/+/67494/comment/2bc6a565_c4c1a6cc : PS23, Line 223: Has_New_Mbus_Dbox_Credits : <tglbool> := Alderlake_On; `and Is_LP` AFAICT File common/hw-gfx-gma-pipe_setup.adb: https://review.coreboot.org/c/libgfxinit/+/67494/comment/e62ab921_c011f55b : PS10, Line 350: MBUS_DBOX_A_CREDIT (2)); > I'll you close this one if you agree. Thanks for the update. I'm still missing the ABOX configuration. But that is probably not done per pipe setup... closing. File common/hw-gfx-gma-pipe_setup.adb: https://review.coreboot.org/c/libgfxinit/+/67494/comment/9fe6668b_30ff2766 : PS23, Line 46: 16#2000# The notation may look confusing, but it's valuable to have the bit number visible, i.e. ``` PLANE_COLOR_CTL_GAMMA_DISABLE : constant := 1 * 2 ** 13; ``` https://review.coreboot.org/c/libgfxinit/+/67494/comment/e736e70d_3cb1ee77 : PS23, Line 48: PLANE_CTL_PLANE_ENABLE : constant := 1 * 2 ** 31; : PLANE_CTL_SRC_PIX_FMT_RGB_32B_8888 : constant := 4 * 2 ** 24; : PLANE_CTL_PLANE_GAMMA_DISABLE : constant := 1 * 2 ** 13; : PLANE_CTL_TILED_SURFACE_MASK : constant := 7 * 2 ** 10; : PLANE_CTL_TILED_SURFACE_LINEAR : constant := 0 * 2 ** 10; : PLANE_CTL_TILED_SURFACE_X_TILED : constant := 1 * 2 ** 10; : PLANE_CTL_TILED_SURFACE_Y_TILED : constant := 4 * 2 ** 10; : PLANE_CTL_TILED_SURFACE_YF_TILED : constant := 5 * 2 ** 10; Whitespace changes are not needed (anymore). https://review.coreboot.org/c/libgfxinit/+/67494/comment/bfa54e00_08ba5073 : PS23, Line 95: natural It's commonly written as `Natural`, i.e. upper-case `N` (I wonder if we can enable a warning for this). https://review.coreboot.org/c/libgfxinit/+/67494/comment/bb38e6d2_f6dc2df3 : PS23, Line 95: ARB_SLOTS No all-caps for types, please. Same for other types (around `MBUS_DBOX_*`) below. https://review.coreboot.org/c/libgfxinit/+/67494/comment/d0ff20f6_e2fcf94e : PS23, Line 218: Config.Variable)), Would prefer to have this above `Controller` so that globals and parameters are grouped. https://review.coreboot.org/c/libgfxinit/+/67494/comment/8cab48a3_d15d4740 : PS23, Line 225: function PLANE_CTL_ARB_SLOTS (N : Word32) return Word32 : is (Shift_Left (N, 28)); Could reside above with the other PLANE_CTL constants. https://review.coreboot.org/c/libgfxinit/+/67494/comment/e799aa95_6591aeee : PS23, Line 342: MBUS_DBOX_REGULATE_B2B_TRANSACTIONS_EN : constant := 1 * 2 ** 16; If we are scoping them anyway, all these types and functions could go into Program_Mbux_Dbox_Credits(). https://review.coreboot.org/c/libgfxinit/+/67494/comment/d58883e2_23902648 : PS23, Line 438: IPEMISC_PIXEL_ROUNDING_TRUNC or HDR_MODE Please add such constants. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67494?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I93329c0a012da83abc379d6782fabe257dc180f3 Gerrit-Change-Number: 67494 Gerrit-PatchSet: 23 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 15:26:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: security/intel/cbnt: Remove unneeded go steps
by Elyes Haouas (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Arthur Heymans. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55845?usp=email ) Change subject: security/intel/cbnt: Remove unneeded go steps ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55845?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2012d519b07321317fef415df892bbb966512ee2 Gerrit-Change-Number: 55845 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 04 Jun 2023 14:53:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023