coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[M] Change in coreboot[master]: mb/google/rex/var/rex0: add HID over SPI ACPI driver
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Matt DeVillier, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74885?usp=email ) Change subject: mb/google/rex/var/rex0: add HID over SPI ACPI driver ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74885?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Gerrit-Change-Number: 74885 Gerrit-PatchSet: 10 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 09:02:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex/var/rex0: add HID over SPI ACPI driver
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Matt DeVillier, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74885?usp=email ) Change subject: mb/google/rex/var/rex0: add HID over SPI ACPI driver ...................................................................... Patch Set 10: (1 comment) Patchset: PS2: > why use ASL here vs runtime-generated AML, like i2c touchscreens do? creating runtime SSDT for Elan-SPI requires more time to complete the exact ACPI source code, plus we are still evolving around the requirement. The plan is to enable the HID-SPI using ASL and the migrate to the runtime ASL. By then we can retire this static ASL implementation. -- To view, visit https://review.coreboot.org/c/coreboot/+/74885?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Gerrit-Change-Number: 74885 Gerrit-PatchSet: 10 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 09:00:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex: add macro for touchscreen IRQ
by Subrata Banik (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74944?usp=email ) Change subject: mb/google/rex: add macro for touchscreen IRQ ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74944?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a6de778c7ab30a9946e100cb70c092ba98496e3 Gerrit-Change-Number: 74944 Gerrit-PatchSet: 7 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 08:57:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: security/intel/cbnt/Makefile: Fix invalid char '*'
by Elyes Haouas (Code Review) 04 Jun '23

04 Jun '23

Elyes Haouas has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/75638?usp=email ) Change subject: security/intel/cbnt/Makefile: Fix invalid char '*' ...................................................................... security/intel/cbnt/Makefile: Fix invalid char '*' Change-Id: I953e06f1ff70a2b61bc5f505f7df9936b7f9b55b Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/security/intel/cbnt/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/75638/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75638?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I953e06f1ff70a2b61bc5f505f7df9936b7f9b55b Gerrit-Change-Number: 75638 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: crossgcc: Upgrade LLVM from version 16.0.4 to 16.0.5
by Elyes Haouas (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75635?usp=email ) Change subject: crossgcc: Upgrade LLVM from version 16.0.4 to 16.0.5 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75635/comment/ade16061_e49c2583 : PS1, Line 7: LLVM version > nit: from version Thank you -- To view, visit https://review.coreboot.org/c/coreboot/+/75635?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f227bf55bac51e6226ca5d13156e54220e33629 Gerrit-Change-Number: 75635 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 04 Jun 2023 05:33:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: crossgcc: Upgrade LLVM from version 16.0.4 to 16.0.5
by Elyes Haouas (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Angel Pons, Elyes Haouas, Jason Glenesk, Martin L Roth. Hello Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75635?usp=email to look at the new patch set (#2). Change subject: crossgcc: Upgrade LLVM from version 16.0.4 to 16.0.5 ...................................................................... crossgcc: Upgrade LLVM from version 16.0.4 to 16.0.5 Change-Id: I1f227bf55bac51e6226ca5d13156e54220e33629 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Documentation/releases/coreboot-4.21-relnotes.md M util/crossgcc/buildgcc D util/crossgcc/sum/clang-16.0.4.src.tar.xz.cksum A util/crossgcc/sum/clang-16.0.5.src.tar.xz.cksum D util/crossgcc/sum/clang-tools-extra-16.0.4.src.tar.xz.cksum A util/crossgcc/sum/clang-tools-extra-16.0.5.src.tar.xz.cksum D util/crossgcc/sum/cmake-16.0.4.src.tar.xz.cksum A util/crossgcc/sum/cmake-16.0.5.src.tar.xz.cksum D util/crossgcc/sum/compiler-rt-16.0.4.src.tar.xz.cksum A util/crossgcc/sum/compiler-rt-16.0.5.src.tar.xz.cksum D util/crossgcc/sum/llvm-16.0.4.src.tar.xz.cksum A util/crossgcc/sum/llvm-16.0.5.src.tar.xz.cksum 12 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/75635/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75635?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f227bf55bac51e6226ca5d13156e54220e33629 Gerrit-Change-Number: 75635 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: security/intel/cbnt/Makefile: Fix invalid char '*'
by Elyes Haouas (Code Review) 04 Jun '23

04 Jun '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75638?usp=email ) Change subject: security/intel/cbnt/Makefile: Fix invalid char '*' ...................................................................... security/intel/cbnt/Makefile: Fix invalid char '*' Change-Id: I953e06f1ff70a2b61bc5f505f7df9936b7f9b55b Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/security/intel/cbnt/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/75638/1 diff --git a/src/security/intel/cbnt/Makefile.inc b/src/security/intel/cbnt/Makefile.inc index 9a29fa6..8801156 100644 --- a/src/security/intel/cbnt/Makefile.inc +++ b/src/security/intel/cbnt/Makefile.inc @@ -36,7 +36,7 @@ cd 3rdparty/intel-sec-tools; \ GO111MODULE=on go mod download; \ GO111MODULE=on go mod verify; \ - GO111MODULE=on go build -o $(abspath $@) cmd/cbnt-prov/*.go + GO111MODULE=on go build -o $(abspath $@) cmd/cbnt-prov/%.go else $(CBNT_PROV): $(call strip_quotes, $(CONFIG_INTEL_CBNT_PROV_EXTERNAL_BIN_PATH)) cp $< $@ -- To view, visit https://review.coreboot.org/c/coreboot/+/75638?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I953e06f1ff70a2b61bc5f505f7df9936b7f9b55b Gerrit-Change-Number: 75638 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: crossgcc: Upgrade LLVM version 16.0.4 to 16.0.5
by Felix Singer (Code Review) 04 Jun '23

04 Jun '23

Attention is currently required from: Angel Pons, Elyes Haouas, Jason Glenesk, Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75635?usp=email ) Change subject: crossgcc: Upgrade LLVM version 16.0.4 to 16.0.5 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75635?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f227bf55bac51e6226ca5d13156e54220e33629 Gerrit-Change-Number: 75635 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 03 Jun 2023 23:45:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Docs: Update sphinx targets with the build directory
by Felix Singer (Code Review) 03 Jun '23

03 Jun '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75499?usp=email ) Change subject: Docs: Update sphinx targets with the build directory ...................................................................... Docs: Update sphinx targets with the build directory Because Makefile.sphinx looks like a standard makefile from the sphinx project, it probably shouldn't be updated without good reason. This change lets us update the output directory and tell the Makefile.sphinx where we want the output. Also fix the spacing on PDFLATEX to match the new SPHINXDIR variable. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iab111e8feea8ec02260f39636e7c17fd1cae7c30 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75499 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M Documentation/Makefile 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/Documentation/Makefile b/Documentation/Makefile index 17aec29..19b1f80 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -4,7 +4,8 @@ # hacked together by Stefan Reinauer <stepan(a)openbios.org> # -PDFLATEX=pdflatex -t a4 +PDFLATEX = pdflatex -t a4 +SPHINXDIR = _build FIGS=codeflow.pdf hypertransport.pdf @@ -32,6 +33,9 @@ convert $< $@ endif +$(SPHINXDIR): + mkdir -p $(SPHINXDIR) + corebootPortingGuide.toc: $(FIGS) corebootBuildingGuide.tex # 2 times to make sure we have a current toc. $(PDFLATEX) corebootBuildingGuide.tex @@ -40,11 +44,11 @@ corebootPortingGuide.pdf: $(FIGS) corebootBuildingGuide.tex corebootPortingGuide.toc $(PDFLATEX) corebootBuildingGuide.tex -sphinx: - $(MAKE) -f Makefile.sphinx html +sphinx: $(SPHINXDIR) + $(MAKE) -f Makefile.sphinx html BUILDDIR="$(SPHINXDIR)"" clean-sphinx: - $(MAKE) -f Makefile.sphinx clean + $(MAKE) -f Makefile.sphinx clean BUILDDIR="$(SPHINXDIR)" clean: clean-sphinx rm -f *.aux *.idx *.log *.toc *.out $(FIGS) @@ -52,8 +56,8 @@ distclean: clean rm -f corebootPortingGuide.pdf -livesphinx: - $(MAKE) -f Makefile.sphinx livehtml SPHINXOPTS="$(SPHINXOPTS)" +livesphinx: $(SPHINXDIR) + $(MAKE) -f Makefile.sphinx livehtml SPHINXOPTS="$(SPHINXOPTS)" BUILDDIR="$(SPHINXDIR)" test: @echo "Test for logging purposes - Failing tests will not fail the build" -- To view, visit https://review.coreboot.org/c/coreboot/+/75499?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab111e8feea8ec02260f39636e7c17fd1cae7c30 Gerrit-Change-Number: 75499 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: Docs: Add a test target for the documentation
by Felix Singer (Code Review) 03 Jun '23

03 Jun '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75497?usp=email ) Change subject: Docs: Add a test target for the documentation ...................................................................... Docs: Add a test target for the documentation The test target will run, but won't fail the build if there are issues. This is so it can be added to the jenkins build and run until it passes. At that point, it can be made to fail if there's an error. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I5810643ee143f9db4f1cd388531161d4398d596c Reviewed-on: https://review.coreboot.org/c/coreboot/+/75497 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M Documentation/Makefile 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/Documentation/Makefile b/Documentation/Makefile index 12f0ec7..17aec29 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -55,12 +55,18 @@ livesphinx: $(MAKE) -f Makefile.sphinx livehtml SPHINXOPTS="$(SPHINXOPTS)" +test: + @echo "Test for logging purposes - Failing tests will not fail the build" + -$(MAKE) -f Makefile.sphinx clean && $(MAKE) -K -f Makefile.sphinx html + -$(MAKE) -f Makefile.sphinx clean && $(MAKE) -K -f Makefile.sphinx doctest + help: @echo "all - Builds coreboot porting guide PDF (outdated)" @echo "sphinx - Builds html documentation in _build directory" @echo "clean - Cleans intermediate files" @echo "clean-sphinx - Removes sphinx output files" @echo "distclean - Removes PDF files as well" + @echo "test - Runs documentation tests" @echo @echo " Makefile.sphinx builds - run with $(MAKE) -f Makefile-sphinx [target]" @echo -- To view, visit https://review.coreboot.org/c/coreboot/+/75497?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5810643ee143f9db4f1cd388531161d4398d596c Gerrit-Change-Number: 75497 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023