coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: Documentation: fix link to Driver Devicetree Entries page
by Martin Roth (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Felix Singer, Marshall Dawson. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75695?usp=email ) Change subject: Documentation: fix link to Driver Devicetree Entries page ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08057576c23cef0343816c3b14c48db77b8dc416 Gerrit-Change-Number: 75695 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Wed, 07 Jun 2023 23:10:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: Documentation: fix link to Driver Devicetree Entries page
by Marshall Dawson (Code Review) 08 Jun '23

08 Jun '23

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75695?usp=email ) Change subject: Documentation: fix link to Driver Devicetree Entries page ...................................................................... Documentation: fix link to Driver Devicetree Entries page Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Change-Id: I08057576c23cef0343816c3b14c48db77b8dc416 --- M Documentation/getting_started/devicetree.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/75695/1 diff --git a/Documentation/getting_started/devicetree.md b/Documentation/getting_started/devicetree.md index 824c512..2585846 100644 --- a/Documentation/getting_started/devicetree.md +++ b/Documentation/getting_started/devicetree.md @@ -79,7 +79,7 @@ ## Device drivers Platform independent device drivers are hooked up via entries in a devicetree. -See [Driver Devicetree Entries](drivers/dt_entries.md) for more info. +See [Driver Devicetree Entries](../drivers/dt_entries.md) for more info. ## Notes -- To view, visit https://review.coreboot.org/c/coreboot/+/75695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08057576c23cef0343816c3b14c48db77b8dc416 Gerrit-Change-Number: 75695 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-MessageType: newchange

1 0

[NoOp] Change in blobs[master]: mb/google/skyrim/var/markarth: Add custom ABL
by Tim Van Patten (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Jon Murphy, Karthik Ramasubramanian. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/75693?usp=email ) Change subject: mb/google/skyrim/var/markarth: Add custom ABL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/75693?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I3e48a16e0a46b2948260fd427b76a2ed88303996 Gerrit-Change-Number: 75693 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 07 Jun 2023 22:57:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/markarth: Add amdfw.cfg
by Tim Van Patten (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Jason Nien, Jon Murphy, Karthik Ramasubramanian, Martin Roth. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75694?usp=email ) Change subject: mb/google/skyrim/var/markarth: Add amdfw.cfg ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75694?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9237c5dddda25da84e2578495a3b5ed7983d6e63 Gerrit-Change-Number: 75694 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 07 Jun 2023 22:57:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Configure ISH GPIO's based on FW_CONFIG
by Li1 Feng (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Bernardo Perez Priego, Jamie Ryu, Jay Patel, Kapil Porwal, Subrata Banik, Tarun Tuli, Wonkyu Kim. Li1 Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75525?usp=email ) Change subject: mb/google/rex: Configure ISH GPIO's based on FW_CONFIG ...................................................................... Patch Set 6: (3 comments) File src/mainboard/google/rex/variants/rex0/fw_config.c: https://review.coreboot.org/c/coreboot/+/75525/comment/18e7988b_51c3796f : PS6, Line 50: net NC is not present in the given design SOC_ISH_ACCEL_INT_L https://review.coreboot.org/c/coreboot/+/75525/comment/ab5a3c82_d91b8ce8 : PS6, Line 52: net NC is not present in the given design SOC_ISH_ALS_INT_L https://review.coreboot.org/c/coreboot/+/75525/comment/f6282fe4_de2f61da : PS6, Line 58: static const struct pad_config ish_gpp_pads_board2[] = { Those two are also needed in proto 2. PAD_CFG_NF(GPP_B08, NONE, DEEP, NF4), PAD_CFG_NF(GPP_F22, NONE, DEEP, NF8), -- To view, visit https://review.coreboot.org/c/coreboot/+/75525?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f0f9a7c8318fa9ae59b6f613eafdacbfa07c749 Gerrit-Change-Number: 75525 Gerrit-PatchSet: 6 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Li1 Feng <li1.feng(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Comment-Date: Wed, 07 Jun 2023 22:51:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/brya/acpi: NV12 enable signal should be off on GCOFF entry
by Eran Mitrani (Code Review) 08 Jun '23

08 Jun '23

Attention is currently required from: Eric Lai, Tarun Tuli. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75533?usp=email ) Change subject: mb/google/brya/acpi: NV12 enable signal should be off on GCOFF entry ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75533?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d338fc4a96f119617aff558413a5a9ac44c27d7 Gerrit-Change-Number: 75533 Gerrit-PatchSet: 5 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 07 Jun 2023 22:38:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/myst: Correct CROS_WP_GPIO to active high
by Felix Held (Code Review) 08 Jun '23

08 Jun '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75628?usp=email ) Change subject: mb/google/myst: Correct CROS_WP_GPIO to active high ...................................................................... mb/google/myst: Correct CROS_WP_GPIO to active high HW has invert the signal, set it to active high. BUG=b:285964562 TEST=check crossystem wpsw_cur change as expected. Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: I54c578e5df5f1b24743cc9506e1e31b0b18bfb25 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75628 Reviewed-by: Jon Murphy <jpmurphy(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Van Patten <timvp(a)google.com> Reviewed-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> --- M src/mainboard/google/myst/chromeos.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ivy Jian: Looks good to me, approved Tim Van Patten: Looks good to me, approved build bot (Jenkins): Verified Jon Murphy: Looks good to me, approved diff --git a/src/mainboard/google/myst/chromeos.c b/src/mainboard/google/myst/chromeos.c index e488e81..83ff403 100644 --- a/src/mainboard/google/myst/chromeos.c +++ b/src/mainboard/google/myst/chromeos.c @@ -8,6 +8,6 @@ static const struct cros_gpio cros_gpios[] = { CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, GPIO_DEVICE_NAME), - CROS_GPIO_WP_AL(CROS_WP_GPIO, GPIO_DEVICE_NAME), + CROS_GPIO_WP_AH(CROS_WP_GPIO, GPIO_DEVICE_NAME), }; DECLARE_CROS_GPIOS(cros_gpios); -- To view, visit https://review.coreboot.org/c/coreboot/+/75628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54c578e5df5f1b24743cc9506e1e31b0b18bfb25 Gerrit-Change-Number: 75628 Gerrit-PatchSet: 2 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: soc/intel/common: Make get_ramtop_addr non static
by Felix Held (Code Review) 08 Jun '23

08 Jun '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75624?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/common: Make get_ramtop_addr non static ...................................................................... soc/intel/common: Make get_ramtop_addr non static Make get_ramtop_addr not static to allow other code to use it. Bug=b:276120526 TEST=Able to build rex Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.com> Change-Id: I8ef8a65b93645f25ca5e887342b18679d65e74b4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75624 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/common/basecode/include/intelbasecode/ramtop.h M src/soc/intel/common/basecode/ramtop/ramtop.c 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved diff --git a/src/soc/intel/common/basecode/include/intelbasecode/ramtop.h b/src/soc/intel/common/basecode/include/intelbasecode/ramtop.h index 067dd6b..fa3c8b1 100644 --- a/src/soc/intel/common/basecode/include/intelbasecode/ramtop.h +++ b/src/soc/intel/common/basecode/include/intelbasecode/ramtop.h @@ -11,4 +11,7 @@ /* Update the RAMTOP if required based on the input top_of_ram address */ void update_ramtop(uint32_t addr); +/* Get RAMTOP */ +uint32_t get_ramtop_addr(void); + #endif diff --git a/src/soc/intel/common/basecode/ramtop/ramtop.c b/src/soc/intel/common/basecode/ramtop/ramtop.c index 83af44d..90717e0 100644 --- a/src/soc/intel/common/basecode/ramtop/ramtop.c +++ b/src/soc/intel/common/basecode/ramtop/ramtop.c @@ -104,7 +104,7 @@ printk(BIOS_DEBUG, "Updated the RAMTOP address into CMOS 0x%x\n", ramtop.addr); } -static uint32_t get_ramtop_addr(void) +uint32_t get_ramtop_addr(void) { struct ramtop_table ramtop; -- To view, visit https://review.coreboot.org/c/coreboot/+/75624?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ef8a65b93645f25ca5e887342b18679d65e74b4 Gerrit-Change-Number: 75624 Gerrit-PatchSet: 3 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/myst: Enable USB WWAN
by Felix Held (Code Review) 07 Jun '23

07 Jun '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75660?usp=email ) Change subject: mb/google/myst: Enable USB WWAN ...................................................................... mb/google/myst: Enable USB WWAN Add usb wwan device tree entry. Also set wwan_rst to high due to HW design active high. BUG=b:285792436 TEST=check FM101 is detected by Linux kernel. Bus 002 Device 002: ID 2cb7:01a2 Fibocom Wireless Inc. Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: I0aa60cb284d4b7f99e16643a92ee58467a355026 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75660 Reviewed-by: Tim Van Patten <timvp(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/myst/variants/baseboard/devicetree.cb M src/mainboard/google/myst/variants/baseboard/gpio.c 2 files changed, 20 insertions(+), 1 deletion(-) Approvals: Paul Menzel: Looks good to me, but someone else must approve Tim Van Patten: Looks good to me, approved Martin Roth: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/myst/variants/baseboard/devicetree.cb b/src/mainboard/google/myst/variants/baseboard/devicetree.cb index f53f5b7..01a4389 100644 --- a/src/mainboard/google/myst/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/myst/variants/baseboard/devicetree.cb @@ -293,6 +293,25 @@ end end end + device ref xhci_1 on + chip drivers/usb/acpi + register "type" = "UPC_TYPE_HUB" + device ref xhci_1_root_hub on + chip drivers/usb/acpi + register "desc" = ""USB3 WWAN"" + register "type" = "UPC_TYPE_INTERNAL" + register "has_power_resource" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_6)" + register "enable_delay_ms" = "20" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_11)" + register "reset_off_delay_ms" = "20" + device ref usb3_port7 on + probe WWAN WWAN_FM101GL + end + end + end + end + end device ref acp on end # Audio Processor (ACP) device ref mp2 on end # Sensor Fusion Hub (MP2) end diff --git a/src/mainboard/google/myst/variants/baseboard/gpio.c b/src/mainboard/google/myst/variants/baseboard/gpio.c index 7979763..efd654e 100644 --- a/src/mainboard/google/myst/variants/baseboard/gpio.c +++ b/src/mainboard/google/myst/variants/baseboard/gpio.c @@ -28,7 +28,7 @@ /* EN_PP3300_WLAN */ PAD_GPO(GPIO_9, HIGH), /* WWAN_RST */ - PAD_GPO(GPIO_11, LOW), + PAD_GPO(GPIO_11, HIGH), /* Unused */ PAD_NC(GPIO_12), /* GPIO_13 - GPIO_15: Not available */ -- To view, visit https://review.coreboot.org/c/coreboot/+/75660?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0aa60cb284d4b7f99e16643a92ee58467a355026 Gerrit-Change-Number: 75660 Gerrit-PatchSet: 6 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/myst: Enable fingerprint on UART
by Felix Held (Code Review) 07 Jun '23

07 Jun '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75629?usp=email ) Change subject: mb/google/myst: Enable fingerprint on UART ...................................................................... mb/google/myst: Enable fingerprint on UART Add fingerprint into device tree. Also set RST to low per HW requirement. BUG=b:285799911 TEST=check ectool --name=cros_fp version. RO version: bloonchipper_v2.0.5938-197506c1 RO cros fwid: CROS_FWID_MISSING RW version: bloonchipper_v2.0.14348-e5fb0b9 RW cros fwid: bloonchipper_14931.0.0 Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: I09819037b80e55edeb56faef9e27fe0753748efc Reviewed-on: https://review.coreboot.org/c/coreboot/+/75629 Reviewed-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/myst/Kconfig M src/mainboard/google/myst/variants/baseboard/gpio.c M src/mainboard/google/myst/variants/myst/overridetree.cb 3 files changed, 20 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/mainboard/google/myst/Kconfig b/src/mainboard/google/myst/Kconfig index dbce4d8..a35596c 100644 --- a/src/mainboard/google/myst/Kconfig +++ b/src/mainboard/google/myst/Kconfig @@ -13,6 +13,7 @@ select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID select DRIVERS_WIFI_GENERIC + select DRIVERS_UART_ACPI select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_ESPI select EC_GOOGLE_CHROMEEC_SKUID diff --git a/src/mainboard/google/myst/variants/baseboard/gpio.c b/src/mainboard/google/myst/variants/baseboard/gpio.c index 9b0de5a..7979763 100644 --- a/src/mainboard/google/myst/variants/baseboard/gpio.c +++ b/src/mainboard/google/myst/variants/baseboard/gpio.c @@ -68,7 +68,7 @@ /* WWAN_AUX_RST_L */ PAD_GPO(GPIO_39, HIGH), /* SOC_FP_RST_L */ - PAD_GPO(GPIO_40, HIGH), + PAD_GPO(GPIO_40, LOW), /* GPIO_41 - GPIO_66: Not available */ /* GPIO_67 (Unused) */ PAD_NC(GPIO_67), diff --git a/src/mainboard/google/myst/variants/myst/overridetree.cb b/src/mainboard/google/myst/variants/myst/overridetree.cb index d701dea..d230e50 100644 --- a/src/mainboard/google/myst/variants/myst/overridetree.cb +++ b/src/mainboard/google/myst/variants/myst/overridetree.cb @@ -93,4 +93,22 @@ device i2c 2a on end end end # I2C3 + device ref uart_1 on + chip drivers/uart/acpi + register "name" = ""CRFP"" + register "desc" = ""Fingerprint Reader"" + register "hid" = "ACPI_DT_NAMESPACE_HID" + register "compat_string" = ""google,cros-ec-uart"" + register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_18)" + register "wake" = "GEVENT_14" + register "uart" = "ACPI_UART_RAW_DEVICE(3000000, 64)" + register "has_power_resource" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_40)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_4)" + register "enable_delay_ms" = "3" + device generic 0 alias fpmcu on + probe FP UART + end + end + end end # chip soc/amd/phoenix -- To view, visit https://review.coreboot.org/c/coreboot/+/75629?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09819037b80e55edeb56faef9e27fe0753748efc Gerrit-Change-Number: 75629 Gerrit-PatchSet: 4 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023