ChiaLing has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/75680?usp=email )
Change subject: mb/google/dedede: Support variant specific power limits
......................................................................
mb/google/dedede: Support variant specific power limits
With newer dedede design, it's required to config corresponding
psyspmax, psyspl1, psyspl2, pl1 and pl2 by different kind of
adapter.
BUG=b:281479111
TEST=emerge-dedede coreboot and check correct register value
on DUT
Signed-off-by: Chia-Ling Hou <chia-ling.hou(a)intel.com>
Change-Id: I583c930379233322c41027805369f81d02000ee7
---
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h
A src/mainboard/google/dedede/variants/baseboard/ramstage.c
2 files changed, 211 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/75680/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75680?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I583c930379233322c41027805369f81d02000ee7
Gerrit-Change-Number: 75680
Gerrit-PatchSet: 2
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: David Wu, Lucas Chen, Nick Vaccaro, Ren Kuo, Tarun Tuli, YH Lin.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75716?usp=email )
Change subject: mb/google/brya/var/kano: Add Micron MT53E2G32D4NQ-046 WT:C SPD
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75716?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0abf1f1105f9a6f16af23b0ed3eb4faeb669eee6
Gerrit-Change-Number: 75716
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 06:20:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Derek Huang, Lucas Chen, Nick Vaccaro, Ren Kuo, Tarun Tuli, YH Lin.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75716?usp=email )
Change subject: mb/google/brya/var/kano: Add Micron MT53E2G32D4NQ-046 WT:C SPD
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/75716?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0abf1f1105f9a6f16af23b0ed3eb4faeb669eee6
Gerrit-Change-Number: 75716
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 06:18:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Derek Huang, Lucas Chen, Nick Vaccaro, Ren Kuo, Tarun Tuli, Tyler Wang, YH Lin.
Hello Derek Huang, Lucas Chen, Nick Vaccaro, Ren Kuo, Tarun Tuli, Tyler Wang, YH Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75716?usp=email
to look at the new patch set (#2).
Change subject: mb/google/brya/var/kano: Add Micron MT53E2G32D4NQ-046 WT:C SPD
......................................................................
mb/google/brya/var/kano: Add Micron MT53E2G32D4NQ-046 WT:C SPD
Add support for Micron MT53E2G32D4NQ-046 WT:C LP4x DRAM.
BUG=b:216393391
TEST=build pass
Change-Id: I0abf1f1105f9a6f16af23b0ed3eb4faeb669eee6
Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/kano/memory/Makefile.inc
M src/mainboard/google/brya/variants/kano/memory/dram_id.generated.txt
M src/mainboard/google/brya/variants/kano/memory/mem_parts_used.txt
3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/75716/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75716?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0abf1f1105f9a6f16af23b0ed3eb4faeb669eee6
Gerrit-Change-Number: 75716
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: ChiaLing.
ChiaLing has uploaded a new patch set (#4). ( https://review.coreboot.org/c/coreboot/+/75679?usp=email )
Change subject: soc/intel/jasperlake: Add per-SKU power limits
......................................................................
soc/intel/jasperlake: Add per-SKU power limits
Add JSL SKUs ID and add PLx from JSL PDG in project devicetree.
BUG=b:281479111
TEST=emerge-dedede coreboot and read correct value on dibbi
Signed-off-by: Chia-Ling Hou <chia-ling.hou(a)intel.com>
Change-Id: Ic086e32a2692f4f5f9b661585b216fa207fc56fd
---
M src/mainboard/google/dedede/variants/baseboard/devicetree.cb
M src/mainboard/google/dedede/variants/blipper/overridetree.cb
M src/mainboard/google/dedede/variants/drawcia/overridetree.cb
M src/mainboard/google/dedede/variants/haboki/overridetree.cb
M src/mainboard/google/dedede/variants/kracko/overridetree.cb
M src/mainboard/google/dedede/variants/lalala/overridetree.cb
M src/mainboard/google/dedede/variants/lantis/overridetree.cb
M src/mainboard/google/dedede/variants/madoo/overridetree.cb
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
M src/mainboard/google/dedede/variants/metaknight/overridetree.cb
M src/mainboard/google/dedede/variants/sasukette/overridetree.cb
M src/mainboard/google/dedede/variants/shotzo/overridetree.cb
M src/mainboard/google/dedede/variants/storo/overridetree.cb
M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb
M src/soc/intel/jasperlake/chip.h
M src/soc/intel/jasperlake/systemagent.c
16 files changed, 211 insertions(+), 57 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/75679/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/75679?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic086e32a2692f4f5f9b661585b216fa207fc56fd
Gerrit-Change-Number: 75679
Gerrit-PatchSet: 4
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kapil Porwal, Subrata Banik, Tarun Tuli, zhongtian wu.
Rui Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75692?usp=email )
Change subject: mb/google/rex/var/screebo: Enable touchscreen
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> shouldn't we use CBI/FW_CONFIG for two different touch vendor device ?
I think we don't need much, although it is a different touch screen, but the i2c address is not the same, there will be no functional impact.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75692?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57d55c5f2621d6fafd53b19d12ecad20271cdbb1
Gerrit-Change-Number: 75692
Gerrit-PatchSet: 1
Gerrit-Owner: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 02:53:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment