Attention is currently required from: Reka Norman, Ryan Lin, Zhuohao Lee.
Hello Reka Norman, Ryan Lin, Zhuohao Lee, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75681?usp=email
to look at the new patch set (#3).
Change subject: mb/google/dedede/var/dibbi: Update power limits
......................................................................
mb/google/dedede/var/dibbi: Update power limits
Add ramstage.c in Makefile.inc and update Dibbi power limit in ramstage
BUG=b:281479111
TEST=emerge-dedede coreboot and check psys and PLx value on DUT
Signed-off-by: Chia-Ling Hou <chia-ling.hou(a)intel.com>
Change-Id: Ieaff856b762b546f3e99acb7ba2ce15791193da6
---
M src/mainboard/google/dedede/variants/dibbi/Makefile.inc
A src/mainboard/google/dedede/variants/dibbi/ramstage.c
2 files changed, 73 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/75681/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75681?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaff856b762b546f3e99acb7ba2ce15791193da6
Gerrit-Change-Number: 75681
Gerrit-PatchSet: 3
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-MessageType: newpatchset
Ziang Wang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/74054?usp=email )
Change subject: include/cpu/x86/lapic.h: Add constraint for SMM
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/74054?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96f371681b6f79f02a115126f7bd9b692293ece
Gerrit-Change-Number: 74054
Gerrit-PatchSet: 2
Gerrit-Owner: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Daocheng Bu <daocheng.bu(a)intel.com>
Gerrit-CC: Nill Ge <geshijian(a)bytedance.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: TangYiwei
Gerrit-MessageType: abandon
Attention is currently required from: Paul Menzel, Reka Norman, Ryan Lin, Zhuohao Lee.
ChiaLing has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75679?usp=email )
Change subject: soc/intel/jasperlake: Add per-SKU power limits
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75679/comment/aa4397a5_b9f9d8be :
PS1, Line 10: devicetree.
> Fits on the line above.
Acknowledged
https://review.coreboot.org/c/coreboot/+/75679/comment/d0602514_4fcd8a5a :
PS1, Line 11:
> Please document the source for these limits.
It shows in PDG.
https://review.coreboot.org/c/coreboot/+/75679/comment/9219b909_a9339b58 :
PS1, Line 13: TEST=emerge-dedede coreboot and read correct value
: on DUT register
> Fits into 72 characters.
Acknowledged
https://review.coreboot.org/c/coreboot/+/75679/comment/450eeae1_bc92c678 :
PS1, Line 15:
> On what board?
On Dibbi.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75679?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic086e32a2692f4f5f9b661585b216fa207fc56fd
Gerrit-Change-Number: 75679
Gerrit-PatchSet: 4
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 08:18:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Ryan Lin, Zhuohao Lee.
ChiaLing has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75678?usp=email )
Change subject: soc/intel/common: Add PsysPl1 support
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Fix patch relation chain at here. Sorry for the spam.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75678?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b2cf2c90ddef422c121e90edbe79dacb7e29320
Gerrit-Change-Number: 75678
Gerrit-PatchSet: 1
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 07:51:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Ryan Lin, Zhuohao Lee.
ChiaLing has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75679?usp=email )
Change subject: soc/intel/jasperlake: Add per-SKU power limits
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Fix patch relation chain at here. Sorry for the spam.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75679?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic086e32a2692f4f5f9b661585b216fa207fc56fd
Gerrit-Change-Number: 75679
Gerrit-PatchSet: 4
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 07:51:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Ryan Lin, Zhuohao Lee.
ChiaLing has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75680?usp=email )
Change subject: mb/google/dedede: Support variant specific power limits
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Fix patch relation chain at here. Sorry for the spam.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75680?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I583c930379233322c41027805369f81d02000ee7
Gerrit-Change-Number: 75680
Gerrit-PatchSet: 2
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 07:50:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Ryan Lin, Zhuohao Lee.
ChiaLing has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75681?usp=email )
Change subject: mb/google/dedede/var/dibbi: Update power limits
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Fix patch relation chain at here. Sorry for the spam.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75681?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaff856b762b546f3e99acb7ba2ce15791193da6
Gerrit-Change-Number: 75681
Gerrit-PatchSet: 2
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 07:50:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Subrata Banik, Tarun Tuli, zhongtian wu.
Rui Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75692?usp=email )
Change subject: mb/google/rex/var/screebo: Enable touchscreen
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I think we don't need much, although it is a different touch screen, but the i2c address is not the […]
Sorry, I made a mistake, it is the same screen, but the touch ic is different.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75692?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57d55c5f2621d6fafd53b19d12ecad20271cdbb1
Gerrit-Change-Number: 75692
Gerrit-PatchSet: 1
Gerrit-Owner: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 07:43:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment