Attention is currently required from: Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75533?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya/acpi: NV12 enable signal should be off on GCOFF entry
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75533/comment/8b4bb938_561c8c4f :
PS5, Line 7: NV12 enable signal should be off on GCOFF entry
Please make it a statement about the action and not a problem description – like you do in the body.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75533?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d338fc4a96f119617aff558413a5a9ac44c27d7
Gerrit-Change-Number: 75533
Gerrit-PatchSet: 5
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 13:07:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Felix Singer, Fred Reitberger, Jason Glenesk, Marvin Drees, Matt DeVillier, Naresh Solanki, Raul Rangel.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75451?usp=email )
Change subject: soc/amd/block/ivrs: Generalize IVRS table generation
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75451?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic471f05d6000c21081d70495b7dbd4350e68b774
Gerrit-Change-Number: 75451
Gerrit-PatchSet: 8
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 08 Jun 2023 13:04:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Benjamin Doron, Lance Zhao, Nico Huber, Paul Menzel.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75677?usp=email )
Change subject: acpi: Add a debug option to print out tables in ACPICA compatible hex
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75677?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b5d879014563f7a2e1f70c45cf871ba72f142dc
Gerrit-Change-Number: 75677
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 08 Jun 2023 12:57:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Subrata Banik, Tarun Tuli.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75578?usp=email )
Change subject: mb/google/rex/variants/ovis: Add USB and TCSS configuration
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/rex/variants/ovis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75578/comment/d3aa56dd_bbdcce5b :
PS1, Line 89: device ref tcss_dma0 on
: chip drivers/intel/usb4/retimer
: register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)"
: use tcss_usb3_port1 as dfp[0].typec_port
: device generic 0 on end
: end
: end
: device ref tcss_dma1 on
: chip drivers/intel/usb4/retimer
: register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)"
: use tcss_usb3_port2 as dfp[0].typec_port
: device generic 0 on end
: end
: end
> Shouldn't the port2 have `generic 1` to match dfp index?
We can but it will not have any impact because the retimer chip driver is not using the device ID.
You can confirm this by comparing the output of below commands with `generic 0` and `generic 1`
```
cd /tmp
cp /sys/firmware/acpi/tables/SSDT .
iasl -d SSDT
sed -n '/Scope.*TDM/,/^ }/ p' SSDT.dsl
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/75578?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc81f12ec6cc4af37bcc1fcf3164cbfa5612a443
Gerrit-Change-Number: 75578
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 12:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com>
Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jon Murphy, Martin Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/75693?usp=email )
Change subject: mb/google/skyrim/var/markarth: Add custom ABL
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/blobs/+/75693/comment/7cb58b92_2ca4ecf9 :
PS1, Line 9: boot issues during reset
It’d be great if you elaborated.
https://review.coreboot.org/c/blobs/+/75693/comment/29dfde75_53135fea :
PS1, Line 10:
If you could document how that issue was fixed in ABL, that’d be great too.
--
To view, visit https://review.coreboot.org/c/blobs/+/75693?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I3e48a16e0a46b2948260fd427b76a2ed88303996
Gerrit-Change-Number: 75693
Gerrit-PatchSet: 1
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 12:54:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Kun Liu, Rui Zhou, Tarun Tuli, zhongtian wu.
Hello Kapil Porwal, Kun Liu, Subrata Banik, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75692?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/google/rex/var/screebo: Enable touchscreen
......................................................................
mb/google/rex/var/screebo: Enable touchscreen
Enable ILI2901 and eKTH7B18 touchscreen for Google Screebo.
BUG=b:278167967
BRANCH=none
TEST=Build and boot to Google Screebo. Verify touchscreen works.
Change-Id: I57d55c5f2621d6fafd53b19d12ecad20271cdbb1
Signed-off-by: Zhongtian Wu <wuzhongtian(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/rex/variants/screebo/overridetree.cb
1 file changed, 42 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/75692/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75692?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57d55c5f2621d6fafd53b19d12ecad20271cdbb1
Gerrit-Change-Number: 75692
Gerrit-PatchSet: 3
Gerrit-Owner: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kapil Porwal, Kun Liu, Rui Zhou, Tarun Tuli, zhongtian wu.
Hello Kapil Porwal, Kun Liu, Subrata Banik, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75692?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Kun Liu, Verified+1 by build bot (Jenkins)
Change subject: mb/google/rex/var/screebo: Enable touchscreen
......................................................................
mb/google/rex/var/screebo: Enable touchscreen
Enable ILI2901 and eKTH7B18 touchscreen for Google Screebo.
BUG=b:278167967
BRANCH=none
TEST=Build and boot to Google Screebo. Verify touchscreen works.
Change-Id: I57d55c5f2621d6fafd53b19d12ecad20271cdbb1
Signed-off-by: Zhongtian Wu <wuzhongtian(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/rex/variants/screebo/overridetree.cb
1 file changed, 42 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/75692/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75692?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57d55c5f2621d6fafd53b19d12ecad20271cdbb1
Gerrit-Change-Number: 75692
Gerrit-PatchSet: 2
Gerrit-Owner: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset