Attention is currently required from: Caveh Jalali, Eric Lai, Kapil Porwal, Subrata Banik, Tarun Tuli.
Hello Eric Lai, Kapil Porwal, Subrata Banik, Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75827?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by Eric Lai
Change subject: mb/google/rex: Set AUX orientation at SoC to follow cable for anx7452
......................................................................
mb/google/rex: Set AUX orientation at SoC to follow cable for anx7452
This configures the SoC to flip the orientation of the AUX pins to
follow the orientation of the cable when using the anx7452 retimer. This
is necessary when there is no external retimer/mux or the retimer/mux
does not implement the flip. The anx7452 retimer does not appear to
support this feature, so let the SoC do the flip.
BUG=b:267589042,b:281006910
TEST=verified DP-ALT mode works on rex using both cable orientations
Change-Id: Ibb9f442d2afd81fb5dde4bca97c15457837f9f4a
Signed-off-by: Caveh Jalali <caveh(a)chromium.org>
---
M src/mainboard/google/rex/variants/rex0/variant.c
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/75827/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75827?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb9f442d2afd81fb5dde4bca97c15457837f9f4a
Gerrit-Change-Number: 75827
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Caveh Jalali, Kapil Porwal, Subrata Banik, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75827?usp=email )
Change subject: mb/google/rex: Set AUX orientation at SoC to follow cable for anx7452
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/rex/variants/rex0/variant.c:
https://review.coreboot.org/c/coreboot/+/75827/comment/36f8ab9b_438e71db :
PS1, Line 12: TCP_AUX_FOLLOW_CC2
nit: if you don't use this, you don't define it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75827?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb9f442d2afd81fb5dde4bca97c15457837f9f4a
Gerrit-Change-Number: 75827
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 15 Jun 2023 03:16:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Subrata Banik.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75827?usp=email )
Change subject: mb/google/rex: Set AUX orientation at SoC to follow cable for anx7452
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/75827?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb9f442d2afd81fb5dde4bca97c15457837f9f4a
Gerrit-Change-Number: 75827
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 15 Jun 2023 03:13:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli.
Hello Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75834?usp=email
to look at the new patch set (#2).
Change subject: mb/google/brya/var/gothrax: Generate RAM IDs for new memory parts
......................................................................
mb/google/brya/var/gothrax: Generate RAM IDs for new memory parts
Add the support RAM parts for gothrax.
Here is the ram part number list:
DRAM Part Name ID to assign
MT62F512M32D2DR-031 WT:B 0 (0000)
H58G56AK6BX069 1 (0001)
K3LKBKB0BM-MGCP 2 (0010)
BUG=b:284388714
BRANCH=None
TEST=emerge-nissa coreboot
Signed-off-by: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
---
M src/mainboard/google/brya/variants/gothrax/memory/Makefile.inc
M src/mainboard/google/brya/variants/gothrax/memory/dram_id.generated.txt
M src/mainboard/google/brya/variants/gothrax/memory/mem_parts_used.txt
3 files changed, 18 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/75834/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
Gerrit-Change-Number: 75834
Gerrit-PatchSet: 2
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-MessageType: newpatchset
Yunlong Jia has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75834?usp=email )
Change subject: mb/google/brya/var/gothrax: Generate RAM IDs for new memory parts
......................................................................
mb/google/brya/var/gothrax: Generate RAM IDs for new memory parts
Add the support RAM parts for gothrax.
Here is the ram part number list:
DRAM Part Name ID to assign
MT62F512M32D2DR-031 WT:B 0 (0000)
H58G56AK6BX069 1 (0001)
K3LKBKB0BM-MGCP 2 (0010)
BUG=b:284388714
BRANCH=None
TEST=emerge-nissa coreboot
Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
---
M src/mainboard/google/brya/variants/gothrax/memory/Makefile.inc
M src/mainboard/google/brya/variants/gothrax/memory/dram_id.generated.txt
M src/mainboard/google/brya/variants/gothrax/memory/mem_parts_used.txt
3 files changed, 18 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/75834/1
diff --git a/src/mainboard/google/brya/variants/gothrax/memory/Makefile.inc b/src/mainboard/google/brya/variants/gothrax/memory/Makefile.inc
index eace2e4..d3c1f68 100644
--- a/src/mainboard/google/brya/variants/gothrax/memory/Makefile.inc
+++ b/src/mainboard/google/brya/variants/gothrax/memory/Makefile.inc
@@ -1,5 +1,9 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
-# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+# Generated by:
+# ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/gothrax/memory src/mainboard/google/brya/variants/gothrax/memory/mem_parts_used.txt
-SPD_SOURCES = placeholder
+SPD_SOURCES =
+SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B
+SPD_SOURCES += spd/lp5/set-0/spd-3.hex # ID = 1(0b0001) Parts = H58G56AK6BX069
+SPD_SOURCES += spd/lp5/set-0/spd-3.hex # ID = 2(0b0010) Parts = K3LKBKB0BM-MGCP
diff --git a/src/mainboard/google/brya/variants/gothrax/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/gothrax/memory/dram_id.generated.txt
index fa24790..7db6e24 100644
--- a/src/mainboard/google/brya/variants/gothrax/memory/dram_id.generated.txt
+++ b/src/mainboard/google/brya/variants/gothrax/memory/dram_id.generated.txt
@@ -1 +1,9 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Generated by:
+# ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/gothrax/memory src/mainboard/google/brya/variants/gothrax/memory/mem_parts_used.txt
+
DRAM Part Name ID to assign
+MT62F512M32D2DR-031 WT:B 0 (0000)
+H58G56AK6BX069 1 (0001)
+K3LKBKB0BM-MGCP 2 (0010)
diff --git a/src/mainboard/google/brya/variants/gothrax/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/gothrax/memory/mem_parts_used.txt
index 9621137..d26ec66 100644
--- a/src/mainboard/google/brya/variants/gothrax/memory/mem_parts_used.txt
+++ b/src/mainboard/google/brya/variants/gothrax/memory/mem_parts_used.txt
@@ -9,3 +9,7 @@
# See util/spd_tools/README.md for more details and instructions.
# Part Name
+
+MT62F512M32D2DR-031 WT:B,
+H58G56AK6BX069,*1
+K3LKBKB0BM-MGCP,
--
To view, visit https://review.coreboot.org/c/coreboot/+/75834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
Gerrit-Change-Number: 75834
Gerrit-PatchSet: 1
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Felix Singer, Jonathan Zhang, Kyösti Mälkki, Nico Huber, Nill Ge, Patrick Rudolph, Paul Menzel, niehaitao(a)bytedance.com.
TangYiwei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75722?usp=email )
Change subject: mb/bytedance: Add 2 SPR sockets server board bd_egs
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/bytedance/bd_egs/bootblock.c:
https://review.coreboot.org/c/coreboot/+/75722/comment/a0d65428_0a6546b4 :
PS6, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
> I would assume these files are mostly forked from intel/archercity_crb and the owner of this commit […]
@Jonathan
hi Jonathan, could you help to check this?
--
To view, visit https://review.coreboot.org/c/coreboot/+/75722?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I091bc78e39cd76b3c6b9a10a1fcf58e9d671ef5d
Gerrit-Change-Number: 75722
Gerrit-PatchSet: 7
Gerrit-Owner: TangYiwei
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: niehaitao(a)bytedance.com
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: niehaitao(a)bytedance.com
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Thu, 15 Jun 2023 02:33:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Comment-In-Reply-To: TangYiwei
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Nick Vaccaro, Tarun Tuli.
Hello David Wu, Nick Vaccaro, Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75826?usp=email
to look at the new patch set (#2).
Change subject: mb/google/brya/var/volmar: Add Micron MT53E2G32D4NQ-046 WT:C SPD
......................................................................
mb/google/brya/var/volmar: Add Micron MT53E2G32D4NQ-046 WT:C SPD
Add support for Micron MT53E2G32D4NQ-046 WT:C LP4x DRAM.
BUG=b:216393391
TEST=build pass
Change-Id: I3797de01629fdb5ace4c610943d88db525da112b
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/volmar/memory/Makefile.inc
M src/mainboard/google/brya/variants/volmar/memory/dram_id.generated.txt
M src/mainboard/google/brya/variants/volmar/memory/mem_parts_used.txt
3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/75826/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75826?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3797de01629fdb5ace4c610943d88db525da112b
Gerrit-Change-Number: 75826
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset