coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: sb/intel: Fix IOAPIC resource entries
by Kyösti Mälkki (Code Review) 15 Jun '23

15 Jun '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/65004?usp=email ) Change subject: sb/intel: Fix IOAPIC resource entries ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/65004?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7699de010048c5c5b66890af6758b24e21bb5ac0 Gerrit-Change-Number: 65004 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: tree-wide: Collapse IORESOURCE_IO initialisations
by Kyösti Mälkki (Code Review) 15 Jun '23

15 Jun '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/55461?usp=email ) Change subject: tree-wide: Collapse IORESOURCE_IO initialisations ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/55461?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a75ba2c5214d02f909649f1e856eaa9ddf3c79b Gerrit-Change-Number: 55461 Gerrit-PatchSet: 16 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx(a)akumat.pl> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[L] Change in coreboot[master]: tree-wide: Collapse IORESOURCE_MEM initialisations
by Kyösti Mälkki (Code Review) 15 Jun '23

15 Jun '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/55428?usp=email ) Change subject: tree-wide: Collapse IORESOURCE_MEM initialisations ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/55428?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24a99e93b4067347c080ec025a49d141172817c6 Gerrit-Change-Number: 55428 Gerrit-PatchSet: 22 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx(a)akumat.pl> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: [WIP] drivers,ec: Add missing IORESOURCE_STORED flags
by Kyösti Mälkki (Code Review) 15 Jun '23

15 Jun '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/65003?usp=email ) Change subject: [WIP] drivers,ec: Add missing IORESOURCE_STORED flags ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/65003?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c334684f8bee1b6b9d81c55ee89490968b28180 Gerrit-Change-Number: 65003 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: sb,soc/amd,intel: Handle IORESOURCE_STORED flags
by Kyösti Mälkki (Code Review) 15 Jun '23

15 Jun '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/65002?usp=email ) Change subject: sb,soc/amd,intel: Handle IORESOURCE_STORED flags ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/65002?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad0ddde2638dd66b4ecf9c574f3c74e07ae9a00a Gerrit-Change-Number: 65002 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx(a)akumat.pl> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: soc/intel: Use fixed_io/mem_range_flags()
by Kyösti Mälkki (Code Review) 15 Jun '23

15 Jun '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/64762?usp=email ) Change subject: soc/intel: Use fixed_io/mem_range_flags() ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/64762?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I506e15bacc960aff8e64d8859325de342164a8d4 Gerrit-Change-Number: 64762 Gerrit-PatchSet: 11 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: sb/intel/bd82x6x: Fix comment
by Kyösti Mälkki (Code Review) 15 Jun '23

15 Jun '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/55978?usp=email ) Change subject: sb/intel/bd82x6x: Fix comment ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/55978?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74fdbcf2927fcdfbea8fc9b2b1db3c4606d07e6e Gerrit-Change-Number: 55978 Gerrit-PatchSet: 12 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: device/resource: Add more resource helpers
by Kyösti Mälkki (Code Review) 15 Jun '23

15 Jun '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/65425?usp=email ) Change subject: device/resource: Add more resource helpers ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/65425?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42a834af70366c36bcafe8e3dbcf41a9994ce0f5 Gerrit-Change-Number: 65425 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: [RFC] device/resource: IOINDEX_SUBTRACTIVE oddities
by Kyösti Mälkki (Code Review) 15 Jun '23

15 Jun '23

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/64972?usp=email ) Change subject: [RFC] device/resource: IOINDEX_SUBTRACTIVE oddities ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/64972?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieff703ed39d69c8ef9edb2e8292ce82eb4e41351 Gerrit-Change-Number: 64972 Gerrit-PatchSet: 6 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: lib/fw_config: Make basic functions always available
by Jakub Czapiga (Code Review) 15 Jun '23

15 Jun '23

Jakub Czapiga has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75835?usp=email ) Change subject: lib/fw_config: Make basic functions always available ...................................................................... lib/fw_config: Make basic functions always available Make fw_config_get() inline and return UNDEFINED_FW_CONFIG for CONFIG_FW_CONFIG=n. Make fw_config_is_provisioned() return false for disabled fw_config. Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: I2ea21b19339cd93ba78dbe25213cbfb40e012937 --- M src/include/fw_config.h M src/lib/fw_config.c 2 files changed, 14 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/75835/1 diff --git a/src/include/fw_config.h b/src/include/fw_config.h index 9f5e4b8..9bbcf59 100644 --- a/src/include/fw_config.h +++ b/src/include/fw_config.h @@ -42,6 +42,8 @@ .mask = FW_CONFIG_FIELD_##__field##_MASK, \ }) +#if CONFIG(FW_CONFIG) + /** * fw_config_get() - Provide firmware configuration value. * @@ -49,8 +51,6 @@ */ uint64_t fw_config_get(void); -#if CONFIG(FW_CONFIG) - /** * fw_config_get_field() - Provide firmware configuration field value. * @field: Structure containing field name and mask @@ -102,6 +102,18 @@ #else +static inline uint64_t fw_config_get(void) +{ + /* If fw_config is disabled, then its value is undefined. */ + return UNDEFINED_FW_CONFIG; +} + +static inline bool fw_config_is_provisioned(void) +{ + /* If fw_config is disabled, then it is unprovisioned. */ + return false; +} + static inline bool fw_config_probe(const struct fw_config *match) { /* Always return true when probing with disabled fw_config. */ diff --git a/src/lib/fw_config.c b/src/lib/fw_config.c index e1fbe74..268be07 100644 --- a/src/lib/fw_config.c +++ b/src/lib/fw_config.c @@ -95,11 +95,6 @@ return false; } -bool fw_config_is_provisioned(void) -{ - return fw_config_get() != UNDEFINED_FW_CONFIG; -} - bool fw_config_probe_dev(const struct device *dev, const struct fw_config **matching_probe) { const struct fw_config *probe; -- To view, visit https://review.coreboot.org/c/coreboot/+/75835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ea21b19339cd93ba78dbe25213cbfb40e012937 Gerrit-Change-Number: 75835 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023