Attention is currently required from: Reka Norman, Tarun Tuli.
Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75834?usp=email )
Change subject: mb/google/nissa/var/gothrax: Generate RAM IDs for new memory parts
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75834/comment/dc3bbcaf_97209d63 :
PS2, Line 7: brya
> Please tell your member for this. I'll submit this CL afternoon.
crystaldrift-odm-external
ecs.corp-partner
Do you need these?
--
To view, visit https://review.coreboot.org/c/coreboot/+/75834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
Gerrit-Change-Number: 75834
Gerrit-PatchSet: 3
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Comment-Date: Fri, 16 Jun 2023 02:33:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Ivy Jian, Kapil Porwal, Subrata Banik, Tarun Tuli.
Hello Ivy Jian, Kapil Porwal, Subrata Banik, Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75892?usp=email
to look at the new patch set (#3).
Change subject: soc/intel/meteorlake: Update tcss_usb3 alias
......................................................................
soc/intel/meteorlake: Update tcss_usb3 alias
TCSS and TBT use the same lane on schematic. Update the port start
from 0 to match the Intel schematic. You can better follow the it
without convert the port number.
Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Change-Id: Ic6631dcbbd9f6c79c756b015425e2da778eb395e
---
M src/mainboard/google/rex/variants/ovis/overridetree.cb
M src/mainboard/google/rex/variants/rex0/overridetree.cb
M src/mainboard/google/rex/variants/screebo/overridetree.cb
M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb
M src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb
M src/soc/intel/meteorlake/chipset.cb
M src/soc/intel/meteorlake/fsp_params.c
M src/soc/intel/meteorlake/retimer.c
8 files changed, 39 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/75892/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75892?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6631dcbbd9f6c79c756b015425e2da778eb395e
Gerrit-Change-Number: 75892
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Reka Norman, Tarun Tuli, Yunlong Jia.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75834?usp=email )
Change subject: mb/google/nissa/var/gothrax: Generate RAM IDs for new memory parts
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75834/comment/fca39742_9ab343fb :
PS2, Line 7: brya
> OK, I see.
Please tell your member for this. I'll submit this CL afternoon.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
Gerrit-Change-Number: 75834
Gerrit-PatchSet: 3
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Comment-Date: Fri, 16 Jun 2023 02:20:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Tarun Tuli.
Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75834?usp=email )
Change subject: mb/google/nissa/var/gothrax: Generate RAM IDs for new memory parts
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75834/comment/d6289f6d_bf6b15ba :
PS2, Line 7: brya
> you also can check brask for reference. https://review.coreboot. […]
OK, I see.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
Gerrit-Change-Number: 75834
Gerrit-PatchSet: 3
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Comment-Date: Fri, 16 Jun 2023 02:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Tarun Tuli, Yunlong Jia.
Hello Eric Lai, Henry Sun, Kangheui Won, Reka Norman, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75834?usp=email
to look at the new patch set (#3).
Change subject: mb/google/nissa/var/gothrax: Generate RAM IDs for new memory parts
......................................................................
mb/google/nissa/var/gothrax: Generate RAM IDs for new memory parts
Add the support RAM parts for gothrax.
Here is the ram part number list:
DRAM Part Name ID to assign
MT62F512M32D2DR-031 WT:B 0 (0000)
H58G56AK6BX069 1 (0001)
K3LKBKB0BM-MGCP 2 (0010)
BUG=b:284388714
BRANCH=None
TEST=emerge-nissa coreboot
Signed-off-by: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
---
M src/mainboard/google/brya/variants/gothrax/memory/Makefile.inc
M src/mainboard/google/brya/variants/gothrax/memory/dram_id.generated.txt
M src/mainboard/google/brya/variants/gothrax/memory/mem_parts_used.txt
3 files changed, 18 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/75834/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
Gerrit-Change-Number: 75834
Gerrit-PatchSet: 3
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Reka Norman, Tarun Tuli, Yunlong Jia.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75834?usp=email )
Change subject: mb/google/brya/var/gothrax: Generate RAM IDs for new memory parts
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75834/comment/08998b70_7ab70559 :
PS2, Line 7: brya
> please use this link to check https://review.coreboot. […]
you also can check brask for reference. https://review.coreboot.org/q/brask
--
To view, visit https://review.coreboot.org/c/coreboot/+/75834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
Gerrit-Change-Number: 75834
Gerrit-PatchSet: 2
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Comment-Date: Fri, 16 Jun 2023 02:03:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Ivy Jian, Kapil Porwal, Subrata Banik, Tarun Tuli.
Hello Ivy Jian, Kapil Porwal, Subrata Banik, Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75892?usp=email
to look at the new patch set (#2).
Change subject: soc/intel/meteorlake: Update tcss_usb3 alias
......................................................................
soc/intel/meteorlake: Update tcss_usb3 alias
TCSS and TBT use the same lane on schematic. Update the port start
from 0 to match the Intel schematic. You can better follow the it
without convert the port number.
Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Change-Id: Ic6631dcbbd9f6c79c756b015425e2da778eb395e
---
M src/mainboard/google/rex/variants/ovis/overridetree.cb
M src/mainboard/google/rex/variants/rex0/overridetree.cb
M src/mainboard/google/rex/variants/screebo/overridetree.cb
M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb
M src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb
M src/soc/intel/meteorlake/chipset.cb
M src/soc/intel/meteorlake/fsp_params.c
7 files changed, 38 insertions(+), 38 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/75892/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75892?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6631dcbbd9f6c79c756b015425e2da778eb395e
Gerrit-Change-Number: 75892
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Reka Norman, Tarun Tuli, Yunlong Jia.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75834?usp=email )
Change subject: mb/google/brya/var/gothrax: Generate RAM IDs for new memory parts
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75834/comment/8a4ec55e_9bb0d779 :
PS2, Line 7: brya
> I've seen projects like "nivviks" and "nereid" using nissa as the baseboard, using both "brya" and " […]
please use this link to check https://review.coreboot.org/q/nissa
--
To view, visit https://review.coreboot.org/c/coreboot/+/75834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
Gerrit-Change-Number: 75834
Gerrit-PatchSet: 2
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Comment-Date: Fri, 16 Jun 2023 01:54:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Reka Norman, Tarun Tuli.
Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75834?usp=email )
Change subject: mb/google/brya/var/gothrax: Generate RAM IDs for new memory parts
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75834/comment/e8b1f3c0_8fd9a386 :
PS2, Line 7: brya
> we use baseboard for the mb/ you can check the other commit.
I've seen projects like "nivviks" and "nereid" using nissa as the baseboard, using both "brya" and "nissa".
I don't know what details are there.
The commit
68164: mb/google/brya/nivviks:
66833: mb/google/brya/variants/nivviks:
64468: mb/google/brya/variants/nereid:
--
To view, visit https://review.coreboot.org/c/coreboot/+/75834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib16846f7b2061ee254db674ac7bac66c9b9f4e70
Gerrit-Change-Number: 75834
Gerrit-PatchSet: 2
Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 16 Jun 2023 01:51:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Ivy Jian, Kapil Porwal, Subrata Banik, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75892?usp=email )
Change subject: soc/intel/meteorlake: Update tcss_usb3 alias
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I compare Intel google and ODM schematic all 0 based for TCSS port.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75892?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6631dcbbd9f6c79c756b015425e2da778eb395e
Gerrit-Change-Number: 75892
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 16 Jun 2023 01:31:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment