coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[S] Change in coreboot[master]: soc/intel/alderlake/acpi: Add Kconfig options for SCM and FCM
by Paul Menzel (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Sean Rhodes. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64561?usp=email ) Change subject: soc/intel/alderlake/acpi: Add Kconfig options for SCM and FCM ...................................................................... Patch Set 11: (1 comment) File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/64561/comment/86ee2ec0_4b39da20 : PS11, Line 744: Disable SCM so that FCM can be used Please add a dot/period at the end. Please elaborate, what *Firmware Connection Manager* is. -- To view, visit https://review.coreboot.org/c/coreboot/+/64561?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac31d37c0873f41f7b14e1051fe214466d1ebdd8 Gerrit-Change-Number: 64561 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 15 Jun 2023 23:18:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: intelblocks/pep: Restrict TBT displays(DPOF) on S0ix transition to FWCM.
by Felix Singer (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Balaji Manigandan, Jamie Ryu, Subrata Banik, Tarun Tuli, Usha P, Utkarsh H Patel, Utkarsh H Patel, Vikrant Jadeja. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75717?usp=email ) Change subject: intelblocks/pep: Restrict TBT displays(DPOF) on S0ix transition to FWCM. ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75717/comment/52ff5fc5_a48d83ee : PS3, Line 7: . No periods in commit titles. https://review.coreboot.org/c/coreboot/+/75717/comment/8ea58593_0cec6cb7 : PS3, Line 9: IOM needed to be notified about DPOF(TBT Displays OFF) only when Firmware connection Manager in use during S0ix Entry/Exit. Reflow for 72 chars per line File src/soc/intel/common/block/acpi/pep.c: https://review.coreboot.org/c/coreboot/+/75717/comment/b4fec88b_1272304a : PS3, Line 278: #if CONFIG(FIRMWARE_CONNECTION_MANAGER) Please don't use preprocessor ifs when possible. For cases like this, just go with C code. The compiler will remove the code in case of `if (0)`. ``` if (CONFIG(FIRMWARE_CONNECTION_MANAGER)) { ... } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/75717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I110fb971846f110e7d93a524ceda3bf4bfc15c13 Gerrit-Change-Number: 75717 Gerrit-PatchSet: 3 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Utkarsh H Patel <utkarsh.h.patel(a)intel.com> Gerrit-Reviewer: Utkarsh H Patel <utkarsh.h.patel(a)intel.corp-partner.google.com> Gerrit-Reviewer: Vikrant Jadeja Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Vikrant Jadeja Gerrit-Attention: Utkarsh H Patel <utkarsh.h.patel(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Attention: Utkarsh H Patel <utkarsh.h.patel(a)intel.com> Gerrit-Comment-Date: Thu, 15 Jun 2023 22:39:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/spr-sp: Remove HWP related settings
by Felix Singer (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Paul Menzel, Tim Chu, Ziang Wang. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75741?usp=email ) Change subject: soc/intel/spr-sp: Remove HWP related settings ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Patchset: PS2: > Personally I also hope that we wont remove the capability to let coreboot own this as well instead o […] Then why do you give a +1? PS2: What's the advantage of letting FSP doing it? -- To view, visit https://review.coreboot.org/c/coreboot/+/75741?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4ff63cbff0dffb4cd65fdfa814eda85964130ee Gerrit-Change-Number: 75741 Gerrit-PatchSet: 2 Gerrit-Owner: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 15 Jun 2023 22:30:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/apollolake: Switch to snake case for SataPwrOptimizeDisable
by Felix Singer (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Mario Scheithauer, Sean Rhodes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75859?usp=email ) Change subject: soc/intel/apollolake: Switch to snake case for SataPwrOptimizeDisable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75859?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35b36f60d2f00bfad307dff7bd131c20ebccf60b Gerrit-Change-Number: 75859 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 15 Jun 2023 22:20:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/apollolake: Switch to snake case for DisableSataSalpSupport
by Felix Singer (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Mario Scheithauer, Sean Rhodes, Werner Zeh. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75858?usp=email ) Change subject: soc/intel/apollolake: Switch to snake case for DisableSataSalpSupport ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75858?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a68ffd2b68c92434da681b5e5567329c8784c72 Gerrit-Change-Number: 75858 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 15 Jun 2023 22:20:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/apollolake: Switch to snake case for PmicVdd2Voltage
by Felix Singer (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Mario Scheithauer, Sean Rhodes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75857?usp=email ) Change subject: soc/intel/apollolake: Switch to snake case for PmicVdd2Voltage ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75857?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I179b8f5b56c5bfe7f6fc3148e4c95954c0755ffd Gerrit-Change-Number: 75857 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 15 Jun 2023 22:19:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/apollolake: Switch to snake case for ModPhyVoltageBump
by Felix Singer (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Mario Scheithauer, Sean Rhodes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75856?usp=email ) Change subject: soc/intel/apollolake: Switch to snake case for ModPhyVoltageBump ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75856?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1e743e23bdfc45588411c584eecb839cc552faf Gerrit-Change-Number: 75856 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 15 Jun 2023 22:18:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/apollolake: Switch to snake case for ModPhyIfValue
by Felix Singer (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Mario Scheithauer, Sean Rhodes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75855?usp=email ) Change subject: soc/intel/apollolake: Switch to snake case for ModPhyIfValue ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75855?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cdf68e65cea4ab316af969cd6a8d096b456518d Gerrit-Change-Number: 75855 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 15 Jun 2023 22:18:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/apollolake: Switch to snake case for DisableComplianceMode
by Felix Singer (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Mario Scheithauer, Sean Rhodes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75854?usp=email ) Change subject: soc/intel/apollolake: Switch to snake case for DisableComplianceMode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d5605134a753f161a66857c7f78844ae7490cd6 Gerrit-Change-Number: 75854 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 15 Jun 2023 22:18:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/apollolake: Switch to snake case for PmicPmcIpcCtrl
by Felix Singer (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Mario Scheithauer, Sean Rhodes. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75853?usp=email ) Change subject: soc/intel/apollolake: Switch to snake case for PmicPmcIpcCtrl ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3632d1e83108221d3487b4f175133ad347238bc5 Gerrit-Change-Number: 75853 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 15 Jun 2023 22:16:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023