Attention is currently required from: Martin L Roth, Nicholas Chin, Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76101?usp=email )
Change subject: payloads/filo: Fix branch
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76101?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c355d757987551e850f9d24f6bfb14167cb8046
Gerrit-Change-Number: 76101
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sun, 25 Jun 2023 17:08:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Nicholas Chin, Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76100?usp=email )
Change subject: payloads/Memtest86Plus: Fix branch
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76100?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I269249518019f5d0d12c57f1c14012abca86b48b
Gerrit-Change-Number: 76100
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sun, 25 Jun 2023 17:05:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Nicholas Chin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76102?usp=email )
Change subject: [NEEDS-TEST] util/board_status: Fix branch for board-status repo
......................................................................
Abandoned
CB:75779 already exists
--
To view, visit https://review.coreboot.org/c/coreboot/+/76102?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fb8d14ab9628e8d9a9d2b0116262791a8e30b97
Gerrit-Change-Number: 76102
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: abandon
Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76102?usp=email )
Change subject: [NEEDS-TEST] util/board_status: Fix branch for board-status repo
......................................................................
[NEEDS-TEST] util/board_status: Fix branch for board-status repo
It seems like the default branch for the board-status repo was renamed
from master to main. Thus, change the branch so that `board-status -u`
can properly upload results to review.coreboot.org.
Change-Id: I5fb8d14ab9628e8d9a9d2b0116262791a8e30b97
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/board_status/board_status.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/76102/1
diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index 78f21a80..da19940 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -553,7 +553,7 @@
git add "${vendor}"
git commit -a -m "${mainboard_dir}/${tagged_version}/${timestamp}"
count=0
- until git push origin master || test $count -eq 3; do
+ until git push origin main || test $count -eq 3; do
git pull --rebase
count=$((count + 1))
done
--
To view, visit https://review.coreboot.org/c/coreboot/+/76102?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fb8d14ab9628e8d9a9d2b0116262791a8e30b97
Gerrit-Change-Number: 76102
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Martin L Roth, Stefan Reinauer.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76101?usp=email )
Change subject: payloads/filo: Fix branch
......................................................................
Patch Set 2:
(1 comment)
File payloads/external/FILO/coreboot:
PS1:
> Huh, somehow Git let me commit even though the linter fails because of the accidentally added symlin […]
Oh I see, symlinks don't show up in git ls-tree until after the code is committed, whereas those lint commit checks run pre-commit.
Anyway, removed the symlink.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76101?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c355d757987551e850f9d24f6bfb14167cb8046
Gerrit-Change-Number: 76101
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sun, 25 Jun 2023 16:41:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Stefan Reinauer.
Hello Martin L Roth, Stefan Reinauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76101?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: payloads/filo: Fix branch
......................................................................
payloads/filo: Fix branch
It seems like the default branch for FILO was renamed from 'master' to
'main'.
TEST: FILO builds correctly when selecting 'HEAD' for the FILO version
option.
Change-Id: I6c355d757987551e850f9d24f6bfb14167cb8046
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M payloads/external/FILO/Kconfig
M payloads/external/FILO/Makefile
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/76101/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76101?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c355d757987551e850f9d24f6bfb14167cb8046
Gerrit-Change-Number: 76101
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Stefan Reinauer.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76101?usp=email )
Change subject: payloads/filo: Fix branch
......................................................................
Patch Set 1:
(1 comment)
File payloads/external/FILO/coreboot:
PS1:
Huh, somehow Git let me commit even though the linter fails because of the accidentally added symlink. However, now that I'm trying to remove it won't let me simply amend because of the linter.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76101?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c355d757987551e850f9d24f6bfb14167cb8046
Gerrit-Change-Number: 76101
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sun, 25 Jun 2023 16:32:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76101?usp=email )
Change subject: payloads/filo: Fix branch
......................................................................
payloads/filo: Fix branch
It seems like the default branch for FILO was renamed from 'master' to
'main'.
TEST: FILO builds correctly when selecting 'HEAD' for the FILO version
option.
Change-Id: I6c355d757987551e850f9d24f6bfb14167cb8046
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M payloads/external/FILO/Kconfig
M payloads/external/FILO/Makefile
A payloads/external/FILO/coreboot
3 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/76101/1
diff --git a/payloads/external/FILO/Kconfig b/payloads/external/FILO/Kconfig
index 7dc14ed..dae8715 100644
--- a/payloads/external/FILO/Kconfig
+++ b/payloads/external/FILO/Kconfig
@@ -9,7 +9,7 @@
help
Tested FILO version
-config FILO_MASTER
+config FILO_HEAD
bool "HEAD"
help
Newest FILO version
diff --git a/payloads/external/FILO/Makefile b/payloads/external/FILO/Makefile
index e2fec36..a747527 100644
--- a/payloads/external/FILO/Makefile
+++ b/payloads/external/FILO/Makefile
@@ -1,5 +1,5 @@
-TAG-$(CONFIG_FILO_MASTER)=origin/master
-NAME-$(CONFIG_FILO_MASTER)=MASTER
+TAG-$(CONFIG_FILO_HEAD)=origin/main
+NAME-$(CONFIG_FILO_HEAD)=MAIN
TAG-$(CONFIG_FILO_STABLE)=c2fa1ea6125c63e84cdf7779c37d76da8c5bc412
NAME-$(CONFIG_FILO_STABLE)=STABLE
@@ -20,7 +20,7 @@
test -d filo || \
git clone $(project_git_repo) $(project_dir)
cd filo && \
- git checkout master && \
+ git checkout main && \
git remote update && \
test -n $(TAG-y) && \
git branch -f $(NAME-y) $(TAG-y) && \
diff --git a/payloads/external/FILO/coreboot b/payloads/external/FILO/coreboot
new file mode 120000
index 0000000..1b20c9f
--- /dev/null
+++ b/payloads/external/FILO/coreboot
@@ -0,0 +1 @@
+../../../
\ No newline at end of file
--
To view, visit https://review.coreboot.org/c/coreboot/+/76101?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c355d757987551e850f9d24f6bfb14167cb8046
Gerrit-Change-Number: 76101
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newchange
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76047?usp=email )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: commonlib/post_codes.h: Fix POST_EXIT_PCI_SCAN_BUS description
......................................................................
commonlib/post_codes.h: Fix POST_EXIT_PCI_SCAN_BUS description
Description of POST_EXIT_PCI_SCAN_BUS indicates the opposite of what
its name suggests. Secondly, POST_ENTER_PCI_SCAN_BUS and
POST_EXIT_PCI_SCAN_BUS have identical comments, which appears to be
a copy-paste issue.
Change the description accordingly.
Change-Id: Ifc920651255bacf033cac39f0208d817f9ee84fc
Signed-off-by: lilacious <yuchenhe126(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76047
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/commonlib/include/commonlib/console/post_codes.h
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Singer: Looks good to me, approved
diff --git a/src/commonlib/include/commonlib/console/post_codes.h b/src/commonlib/include/commonlib/console/post_codes.h
index 0c96ee5..c0b15c5 100644
--- a/src/commonlib/include/commonlib/console/post_codes.h
+++ b/src/commonlib/include/commonlib/console/post_codes.h
@@ -85,9 +85,9 @@
#define POSTCODE_ENTER_PCI_SCAN_BUS 0x24
/**
- * \brief Entry into pci_scan_bus
+ * \brief Exit out of pci_scan_bus
*
- * Entered pci_scan_bus()
+ * Exited pci_scan_bus()
*/
#define POSTCODE_EXIT_PCI_SCAN_BUS 0x25
--
To view, visit https://review.coreboot.org/c/coreboot/+/76047?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc920651255bacf033cac39f0208d817f9ee84fc
Gerrit-Change-Number: 76047
Gerrit-PatchSet: 4
Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged