coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: commonlib/post_codes.h: Change POST_EXIT_PCI_SCAN_BUS description
by Yuchen He (Code Review) 24 Jun '23

24 Jun '23

Attention is currently required from: Yuchen He. Hello Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76047?usp=email to look at the new patch set (#2). Change subject: commonlib/post_codes.h: Change POST_EXIT_PCI_SCAN_BUS description ...................................................................... commonlib/post_codes.h: Change POST_EXIT_PCI_SCAN_BUS description Description of POST_EXIT_PCI_SCAN_BUS indicates the opposite of what its name suggests. Secondly, POST_ENTER_PCI_SCAN_BUS and POST_EXIT_PCI_SCAN_BUS have identical comments, which appears to be a copy-paste issue. Change the description accordingly. Change-Id: Ifc920651255bacf033cac39f0208d817f9ee84fc Signed-off-by: lilacious <yuchenhe126(a)gmail.com> --- M src/commonlib/include/commonlib/console/post_codes.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/76047/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76047?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc920651255bacf033cac39f0208d817f9ee84fc Gerrit-Change-Number: 76047 Gerrit-PatchSet: 2 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: commonlib/post_codes.h: Change POST_EXIT_PCI_SCAN_BUS description
by Felix Singer (Code Review) 24 Jun '23

24 Jun '23

Attention is currently required from: Yuchen He. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76047?usp=email ) Change subject: commonlib/post_codes.h: Change POST_EXIT_PCI_SCAN_BUS description ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76047/comment/5f314e60_dddf9196 : PS1, Line 12: an error. rather say copy-paste issue. Patchset: PS1: Good catch! -- To view, visit https://review.coreboot.org/c/coreboot/+/76047?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc920651255bacf033cac39f0208d817f9ee84fc Gerrit-Change-Number: 76047 Gerrit-PatchSet: 1 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Comment-Date: Sat, 24 Jun 2023 19:14:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/{cfl,cml,whl}: Use true/false macros for ScsEmmcHs400Enabled dt op...
by Yuchen He (Code Review) 24 Jun '23

24 Jun '23

Yuchen He has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76014?usp=email ) Change subject: mb/{cfl,cml,whl}: Use true/false macros for ScsEmmcHs400Enabled dt option ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76014?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcf53179196ea65f81babfeb5fdd9157ca35362e Gerrit-Change-Number: 76014 Gerrit-PatchSet: 2 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/{cfl,cml,whl}: Use true/false macros for SkipExtGfxScan dt option
by Yuchen He (Code Review) 24 Jun '23

24 Jun '23

Yuchen He has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76017?usp=email ) Change subject: mb/{cfl,cml,whl}: Use true/false macros for SkipExtGfxScan dt option ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76017?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2058f21c971e054b06eaac86e8547f34f63bb575 Gerrit-Change-Number: 76017 Gerrit-PatchSet: 2 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: mb/{cfl,cml,whl}: Use true/false macros for DisableHeciRetry dt option
by Yuchen He (Code Review) 24 Jun '23

24 Jun '23

Yuchen He has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76016?usp=email ) Change subject: mb/{cfl,cml,whl}: Use true/false macros for DisableHeciRetry dt option ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76016?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I395b9cfe02fe1b98e3948e0a516341697f0bb51d Gerrit-Change-Number: 76016 Gerrit-PatchSet: 2 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: mb/{cfl,cml,whl}: Use true/false macros for ScsSdCardWpPinEnabled dt ...
by Yuchen He (Code Review) 24 Jun '23

24 Jun '23

Yuchen He has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76015?usp=email ) Change subject: mb/{cfl,cml,whl}: Use true/false macros for ScsSdCardWpPinEnabled dt option ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76015?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd3731ab878c1023028c8a482b16583612e5aa84 Gerrit-Change-Number: 76015 Gerrit-PatchSet: 2 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/{cfl,cml,whl}: Use true/false macros for enable_c6dram dt option
by Yuchen He (Code Review) 24 Jun '23

24 Jun '23

Yuchen He has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76021?usp=email ) Change subject: mb/{cfl,cml,whl}: Use true/false macros for enable_c6dram dt option ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76021?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9057ea9ec3b90002122990dd8a42c16081943b8 Gerrit-Change-Number: 76021 Gerrit-PatchSet: 2 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/{cfl,cml,whl}: Use true/false macros for DdiPortEdp dt option
by Yuchen He (Code Review) 24 Jun '23

24 Jun '23

Yuchen He has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76028?usp=email ) Change subject: mb/{cfl,cml,whl}: Use true/false macros for DdiPortEdp dt option ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76028?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24b0f738ed2cf336ee3e5f97a9eed1680caaff02 Gerrit-Change-Number: 76028 Gerrit-PatchSet: 2 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/{cfl,cml,whl}: Use true/false macros for TetonGlacierMode dt option
by Yuchen He (Code Review) 24 Jun '23

24 Jun '23

Yuchen He has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76019?usp=email ) Change subject: mb/{cfl,cml,whl}: Use true/false macros for TetonGlacierMode dt option ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76019?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2bb7d991739881c3377bbbd89e2e17b5aaf18ea8 Gerrit-Change-Number: 76019 Gerrit-PatchSet: 2 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/{cfl,cml,whl}: Use true/false macros for DdiPortBHpd dt option
by Yuchen He (Code Review) 24 Jun '23

24 Jun '23

Yuchen He has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76029?usp=email ) Change subject: mb/{cfl,cml,whl}: Use true/false macros for DdiPortBHpd dt option ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76029?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19a4368a224ffe3739157a2b6618ba84aa35d10f Gerrit-Change-Number: 76029 Gerrit-PatchSet: 2 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023