coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: soc/mediatek: Enable DRAM scramble on fast calibration flow
by Xixi Chen (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Hung-Te Lin, Yidi Lin. Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75818?usp=email ) Change subject: soc/mediatek: Enable DRAM scramble on fast calibration flow ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75818/comment/2a697b67_958437d2 : PS6, Line 9: > is Done -- To view, visit https://review.coreboot.org/c/coreboot/+/75818?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I907bccd4e68e040179e1971db6bf7a57b88dec1b Gerrit-Change-Number: 75818 Gerrit-PatchSet: 7 Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Mon, 26 Jun 2023 02:07:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/mediatek: Enable DRAM scramble on fast calibration flow
by Xixi Chen (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Hung-Te Lin, Xixi Chen, Yidi Lin. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75818?usp=email to look at the new patch set (#7). Change subject: soc/mediatek: Enable DRAM scramble on fast calibration flow ...................................................................... soc/mediatek: Enable DRAM scramble on fast calibration flow No matter what DRAM calibration is performed, DRAM scramble should be enabled as long as MEDIATEK_DRAM_SCRAMBLE is set to y. Currently, DRAM scramble is enabled only if full calibration is performed. Correct the behavior by adding DRAMC_CONFIG_SCRAMBLE to the header config in fast calibration flow. BUG=b:285474337 TEST=Check the scramble feature is disabled on serial build Signed-off-by: Xi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Change-Id: I907bccd4e68e040179e1971db6bf7a57b88dec1b --- M src/soc/mediatek/common/memory.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/75818/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/75818?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I907bccd4e68e040179e1971db6bf7a57b88dec1b Gerrit-Change-Number: 75818 Gerrit-PatchSet: 7 Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/pujjo: Tune SX9324 register for pujjoteen5
by Leo Chou (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Derek Huang, Leo Chou, Shou-Chieh Hsu, Tarun Tuli. Hello Derek Huang, Shou-Chieh Hsu, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75900?usp=email to look at the new patch set (#7). Change subject: mb/google/nissa/var/pujjo: Tune SX9324 register for pujjoteen5 ...................................................................... mb/google/nissa/var/pujjo: Tune SX9324 register for pujjoteen5 Update SX9324 register settings based on tuning value from P-sensor vendor. BUG=b:27951075 TEST=Check i2c register settings on Pujjoteen5 Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c --- M src/mainboard/google/brya/variants/pujjo/overridetree.cb 1 file changed, 74 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/75900/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/75900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c Gerrit-Change-Number: 75900 Gerrit-PatchSet: 7 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/hades: select DUMP_SMBIOS_TYPE17
by Ivy Jian (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Eric Lai, Tarun Tuli. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76088?usp=email ) Change subject: mb/google/hades: select DUMP_SMBIOS_TYPE17 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76088?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica44081228a3a1edc36e2110e84686582fbe8f33 Gerrit-Change-Number: 76088 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 26 Jun 2023 01:13:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/pujjo: Tune SX9324 register for pujjoteen5
by Leo Chou (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Derek Huang, Leo Chou, Shou-Chieh Hsu, Tarun Tuli. Hello Derek Huang, Shou-Chieh Hsu, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75900?usp=email to look at the new patch set (#6). Change subject: mb/google/nissa/var/pujjo: Tune SX9324 register for pujjoteen5 ...................................................................... mb/google/nissa/var/pujjo: Tune SX9324 register for pujjoteen5 Update SX9324 register settings based on tuning value from P-sensor vendor. BUG=b:27951075 TEST=check i2c register settings on Pujjoteen5 Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c --- M src/mainboard/google/brya/variants/pujjo/overridetree.cb 1 file changed, 74 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/75900/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/75900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c Gerrit-Change-Number: 75900 Gerrit-PatchSet: 6 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/pujjo: Tune SX9324 register for pujjoteen5
by Leo Chou (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Derek Huang, Leo Chou, Shou-Chieh Hsu, Tarun Tuli. Hello Derek Huang, Shou-Chieh Hsu, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75900?usp=email to look at the new patch set (#5). Change subject: mb/google/nissa/var/pujjo: Tune SX9324 register for pujjoteen5 ...................................................................... mb/google/nissa/var/pujjo: Tune SX9324 register for pujjoteen5 Update SX9324 register settings based on tuning value from P-sensor vendor. BUG=b:27951075 TEST=i2cdump -y -f 13 0x28 on Pujjoteen5 Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c --- M src/mainboard/google/brya/variants/pujjo/overridetree.cb 1 file changed, 74 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/75900/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/75900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc9a2dc817e027551e209c0a26eeebad398f710c Gerrit-Change-Number: 75900 Gerrit-PatchSet: 5 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/docker/coreboot-sdk: Declare SDK related variables only once
by Felix Singer (Code Review) 26 Jun '23

26 Jun '23

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76089?usp=email ) Change subject: util/docker/coreboot-sdk: Declare SDK related variables only once ...................................................................... util/docker/coreboot-sdk: Declare SDK related variables only once It's not needed to declare the variables related to the coreboot SDK twice, over the Docker way and the traditional way using bashrc. Just use the Docker way. Also, while on it, move the switch to the coreboot user before the RUN step which sets up directories for ccache and the CI. This makes the chown commands superfluous. Change-Id: I8ec8edb86cdac9ada58180fb21b7bb6ec975c668 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 5 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/76089/1 diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 3fb6da2..767d0ce 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -100,18 +100,15 @@ BUILD_LANGUAGES=c,ada CPUS=$(nproc) DEST=/opt/xgcc && \ rm -rf /tmp/coreboot -RUN mkdir /home/coreboot/.ccache && \ - chown coreboot:coreboot /home/coreboot/.ccache && \ - mkdir /home/coreboot/cb_build && \ - chown coreboot:coreboot /home/coreboot/cb_build && \ - echo "export PATH=$PATH:/opt/xgcc/bin" >> /home/coreboot/.bashrc && \ - echo "export SDK_VERSION={{SDK_VERSION}}" >> /home/coreboot/.bashrc && \ - echo "export SDK_COMMIT={{DOCKER_COMMIT}}" >> /home/coreboot/.bashrc +USER coreboot + +RUN \ + mkdir /home/coreboot/.ccache && \ + mkdir /home/coreboot/cb_build ENV PATH $PATH:/opt/xgcc/bin ENV SDK_VERSION={{SDK_VERSION}} ENV SDK_COMMIT={{DOCKER_COMMIT}} -USER coreboot FROM coreboot-sdk VOLUME /home/coreboot/.ccache -- To view, visit https://review.coreboot.org/c/coreboot/+/76089?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ec8edb86cdac9ada58180fb21b7bb6ec975c668 Gerrit-Change-Number: 76089 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: arch/x86/Kconfig: remove period from DUMP_SMBIOS_TYPE17 title
by Eric Lai (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Felix Held. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76087?usp=email ) Change subject: arch/x86/Kconfig: remove period from DUMP_SMBIOS_TYPE17 title ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76087/comment/bd68b9b9_93c741e8 : PS1, Line 7: arch/x86: remove period from DUMP_SMBIOS_TYPE17 > Suggestion: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id61d8961cad2cd311db7d9da3bdb86f0f28b57b4 Gerrit-Change-Number: 76087 Gerrit-PatchSet: 2 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 00:07:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: arch/x86/Kconfig: remove period from DUMP_SMBIOS_TYPE17 title
by Eric Lai (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Eric Lai, Felix Held. Hello Felix Held, Felix Singer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76087?usp=email to look at the new patch set (#2). Change subject: arch/x86/Kconfig: remove period from DUMP_SMBIOS_TYPE17 title ...................................................................... arch/x86/Kconfig: remove period from DUMP_SMBIOS_TYPE17 title Option name strings should not end with a period, remove it. Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: Id61d8961cad2cd311db7d9da3bdb86f0f28b57b4 --- M src/arch/x86/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/76087/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id61d8961cad2cd311db7d9da3bdb86f0f28b57b4 Gerrit-Change-Number: 76087 Gerrit-PatchSet: 2 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: arch/x86: remove period from DUMP_SMBIOS_TYPE17
by Felix Singer (Code Review) 26 Jun '23

26 Jun '23

Attention is currently required from: Eric Lai, Felix Held. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76087?usp=email ) Change subject: arch/x86: remove period from DUMP_SMBIOS_TYPE17 ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76087/comment/97f28bcb_4fed2541 : PS1, Line 7: arch/x86: remove period from DUMP_SMBIOS_TYPE17 Suggestion: `arch/x86/Kconfig: remove period from DUMP_SMBIOS_TYPE17 title` -- To view, visit https://review.coreboot.org/c/coreboot/+/76087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id61d8961cad2cd311db7d9da3bdb86f0f28b57b4 Gerrit-Change-Number: 76087 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 00:06:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023