Attention is currently required from: Eric Lai, Felix Held.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76087?usp=email )
Change subject: arch/x86: remove period from DUMP_SMBIOS_TYPE17
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Thank you!
--
To view, visit https://review.coreboot.org/c/coreboot/+/76087?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id61d8961cad2cd311db7d9da3bdb86f0f28b57b4
Gerrit-Change-Number: 76087
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 26 Jun 2023 00:04:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli.
Eric Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76088?usp=email )
Change subject: mb/google/hades: select DUMP_SMBIOS_TYPE17
......................................................................
mb/google/hades: select DUMP_SMBIOS_TYPE17
Hades uses DDR5 which can't read SPD from coreboot yet. Use smbios
dump to print memory information.
TEST=check the coreboot log.
memory Channel-0-DIMM-0 type is DDR5
memory part number is MTC8C1084S1SC56BG1
memory max speed is 5600 MT/s
memory speed is 5200 MT/s
memory size is 16384 MiB
Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Change-Id: Ica44081228a3a1edc36e2110e84686582fbe8f33
---
M src/mainboard/google/brya/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/76088/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig
index 2a9941a..d142465 100644
--- a/src/mainboard/google/brya/Kconfig
+++ b/src/mainboard/google/brya/Kconfig
@@ -67,6 +67,7 @@
def_bool n
select BOARD_GOOGLE_BRYA_COMMON
select BOARD_ROMSIZE_KB_32768
+ select DUMP_SMBIOS_TYPE17
select HAVE_SLP_S0_GATE
select INCLUDE_NVIDIA_GPU_ASL
select MEMORY_SODIMM
--
To view, visit https://review.coreboot.org/c/coreboot/+/76088?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica44081228a3a1edc36e2110e84686582fbe8f33
Gerrit-Change-Number: 76088
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-MessageType: newchange
Eric Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76087?usp=email )
Change subject: arch/x86: remove period from DUMP_SMBIOS_TYPE17
......................................................................
arch/x86: remove period from DUMP_SMBIOS_TYPE17
Option name strings should not end with a period, remove it.
Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Change-Id: Id61d8961cad2cd311db7d9da3bdb86f0f28b57b4
---
M src/arch/x86/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/76087/1
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 7b3f34a..ec1171b 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -360,7 +360,7 @@
Size of reserved space for EC firmware pointer
config DUMP_SMBIOS_TYPE17
- bool "Dump part of SMBIOS type17 dimm information."
+ bool "Dump part of SMBIOS type17 dimm information"
depends on GENERATE_SMBIOS_TABLES
endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/76087?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id61d8961cad2cd311db7d9da3bdb86f0f28b57b4
Gerrit-Change-Number: 76087
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76081?usp=email )
Change subject: util/docker/coreboot-sdk: Do system update before installing packages
......................................................................
Patch Set 3:
(3 comments)
File util/docker/coreboot-sdk/Dockerfile:
https://review.coreboot.org/c/coreboot/+/76081/comment/1a2578b5_2c6e51e3 :
PS2, Line 20: upgrade
> dist-upgrade […]
People on the internet suggest to run upgrade before dist-upgrade, which seems to work most. That's also what I did back in my Debian days. So I decided to do that.
Added autoremove.
https://review.coreboot.org/c/coreboot/+/76081/comment/330df8c4_0f687cfd :
PS2, Line 39: gnat-12
> This is already the default version for debian sid. […]
CB:76086
https://review.coreboot.org/c/coreboot/+/76081/comment/178bf727_11ed7882 :
PS2, Line 86: \
: && update-alternatives --install /usr/bin/python python /usr/bin/python3 1 \
: && ln -s /usr/bin/automake /usr/bin/automake-1.15 \
: && ln -s /usr/bin/aclocal /usr/bin/aclocal-1.15
> I think that those are not needed.
Not sure yet. I'm trying to reproduce what I have encountered months ago. That will go into a separate patch though.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76081?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ae80a753cffafc849325264f4acfbf09b8d0b9a
Gerrit-Change-Number: 76081
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sun, 25 Jun 2023 21:25:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76086?usp=email )
Change subject: util/docker/coreboot-sdk: Install GNAT meta package instead gnat-12
......................................................................
util/docker/coreboot-sdk: Install GNAT meta package instead gnat-12
The versions of both GCC and GNAT need to be in sync and the meta
package for GCC is already used. So use the meta package for GNAT as
well.
Change-Id: Ifcd6960731bc02c70a510e520b385ca300caf88f
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M util/docker/coreboot-sdk/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/76086/1
diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile
index 7bd5a39..3fb6da2 100644
--- a/util/docker/coreboot-sdk/Dockerfile
+++ b/util/docker/coreboot-sdk/Dockerfile
@@ -37,7 +37,7 @@
gawk \
gcc \
git \
- gnat-12 \
+ gnat \
golang \
graphicsmagick-imagemagick-compat \
graphviz \
--
To view, visit https://review.coreboot.org/c/coreboot/+/76086?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcd6960731bc02c70a510e520b385ca300caf88f
Gerrit-Change-Number: 76086
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Martin L Roth.
Hello Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76081?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/docker/coreboot-sdk: Do system update before installing packages
......................................................................
util/docker/coreboot-sdk: Do system update before installing packages
Even if the Debian Sid image is probably updated frequently, the
existing packages should be updated before installing new ones. So
update the base image in advance.
Also, while on it, add a step to remove superfluous packages by
running `apt-get autoremove`.
Change-Id: I7ae80a753cffafc849325264f4acfbf09b8d0b9a
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M util/docker/coreboot-sdk/Dockerfile
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/76081/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/76081?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ae80a753cffafc849325264f4acfbf09b8d0b9a
Gerrit-Change-Number: 76081
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Nicholas Chin, Stefan Reinauer.
Hello Felix Singer, Martin L Roth, Stefan Reinauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76101?usp=email
to look at the new patch set (#3).
Change subject: payloads/filo: Update branch name from master to main
......................................................................
payloads/filo: Update branch name from master to main
It seems like the default branch for FILO was renamed from 'master' to
'main'.
TEST: FILO builds correctly when selecting 'HEAD' for the FILO version
option.
Change-Id: I6c355d757987551e850f9d24f6bfb14167cb8046
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M payloads/external/FILO/Kconfig
M payloads/external/FILO/Makefile
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/76101/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/76101?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c355d757987551e850f9d24f6bfb14167cb8046
Gerrit-Change-Number: 76101
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Paul Menzel, Stefan Reinauer.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76100?usp=email )
Change subject: payloads/Memtest86Plus: Update branch name from master to main
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76100/comment/6b266c52_804476af :
PS1, Line 7: Fix branch
> Maybe more specific: Update branch name from *master* to *main*
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/76100?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I269249518019f5d0d12c57f1c14012abca86b48b
Gerrit-Change-Number: 76100
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sun, 25 Jun 2023 19:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Nicholas Chin, Stefan Reinauer.
Hello Felix Singer, Martin L Roth, Stefan Reinauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76100?usp=email
to look at the new patch set (#2).
Change subject: payloads/Memtest86Plus: Update branch name from master to main
......................................................................
payloads/Memtest86Plus: Update branch name from master to main
It seems like the default branch for coreboot's Memtest86+ fork was
renamed from 'master' to 'main'.
TEST: Memtest builds correctly when selecting 'Main' for the Memtest86+
version option.
Change-Id: I269249518019f5d0d12c57f1c14012abca86b48b
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M payloads/external/Makefile.inc
M payloads/external/Memtest86Plus/Kconfig.secondary
M payloads/external/Memtest86Plus/Makefile
3 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/76100/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76100?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I269249518019f5d0d12c57f1c14012abca86b48b
Gerrit-Change-Number: 76100
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Nicholas Chin, Stefan Reinauer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76100?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: payloads/Memtest86Plus: Fix branch
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76100/comment/9d8d0134_02a5f19c :
PS1, Line 7: Fix branch
Maybe more specific: Update branch name from *master* to *main*
--
To view, visit https://review.coreboot.org/c/coreboot/+/76100?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I269249518019f5d0d12c57f1c14012abca86b48b
Gerrit-Change-Number: 76100
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sun, 25 Jun 2023 18:54:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment