coreboot-gerrit May 2023

coreboot-gerrit@coreboot.org

1 participants
5262 discussions

[M] Change in coreboot[master]: drivers/sof: Add new driver to generate ACPI _DSD table
by Martin Roth (Code Review) 02 May '23

02 May '23

Attention is currently required from: Tarun Tuli, Martin L Roth, Matt DeVillier. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74813 ) Change subject: drivers/sof: Add new driver to generate ACPI _DSD table ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0431b2002287f35245cbf959828e931d7f375b2 Gerrit-Change-Number: 74813 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 02 May 2023 12:57:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/intel/microcode: Implement microcode info caching inside cbmem
by Subrata Banik (Code Review) 02 May '23

02 May '23

Attention is currently required from: Tarun Tuli, Reka Norman, Kapil Porwal, Julius Werner, Arthur Heymans, Lean Sheng Tan. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74873 ) Change subject: cpu/intel/microcode: Implement microcode info caching inside cbmem ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > > > > I assume this patch is in response to b/242473942? And your time savings aren't really from "searching", they're from bypassing CBFS verification? > > > > > > > > If we determined that we actually *want* to bypass CBFS verification, and that it is safe to do so, there are more straight-forward ways to do that (e.g. cbfs_unverified_area_map()). But my understanding from the previous discussion on the bug was that we don't actually want to do that because there could actually be some attack vector here (even if it's e.g. just a rollback attack). In that case, we obviously also can't do something like this. > > > > > > yes, your understanding is correct that we don't want to bypass the CBFS verification check > > > > also i have noticed ~10ms boot time impact with every new ucode (per cpu stepping) being added into the cpu_microcode_blob.bin > > > > for example: current REX (MTL) added 2 ucode for ES1 and ES2 hence, the timestamp ID 971 was around 20ms. if we drop ES2 support and keep only ES1 then the boot time (timestamp ID 971) is 10ms > > Instead of concatenating microcode you could add a cbfs file per cpuid? That would not bypass CBFS verification and result in the same speedup. isn't the expectation inside find_cbfs_microcode() function is that, there would be one single microcode entry inside CBFS? -- To view, visit https://review.coreboot.org/c/coreboot/+/74873 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I208a2e0e1dce96b2d4d63f882e8aaf4c25f77e3f Gerrit-Change-Number: 74873 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 02 May 2023 12:57:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/intel/microcode: Implement microcode info caching inside cbmem
by Arthur Heymans (Code Review) 02 May '23

02 May '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Reka Norman, Kapil Porwal, Julius Werner, Lean Sheng Tan. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74873 ) Change subject: cpu/intel/microcode: Implement microcode info caching inside cbmem ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > > > I assume this patch is in response to b/242473942? And your time savings aren't really from "searching", they're from bypassing CBFS verification? > > > > > > If we determined that we actually *want* to bypass CBFS verification, and that it is safe to do so, there are more straight-forward ways to do that (e.g. cbfs_unverified_area_map()). But my understanding from the previous discussion on the bug was that we don't actually want to do that because there could actually be some attack vector here (even if it's e.g. just a rollback attack). In that case, we obviously also can't do something like this. > > > > yes, your understanding is correct that we don't want to bypass the CBFS verification check > > also i have noticed ~10ms boot time impact with every new ucode (per cpu stepping) being added into the cpu_microcode_blob.bin > > for example: current REX (MTL) added 2 ucode for ES1 and ES2 hence, the timestamp ID 971 was around 20ms. if we drop ES2 support and keep only ES1 then the boot time (timestamp ID 971) is 10ms Instead of concatenating microcode you could add a cbfs file per cpuid? That would not bypass CBFS verification and result in the same speedup. -- To view, visit https://review.coreboot.org/c/coreboot/+/74873 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I208a2e0e1dce96b2d4d63f882e8aaf4c25f77e3f Gerrit-Change-Number: 74873 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 02 May 2023 12:51:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: doc/tutorial/part1.md: Fix package name to install qemu on Debian
by Felix Singer (Code Review) 02 May '23

02 May '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74894 ) Change subject: doc/tutorial/part1.md: Fix package name to install qemu on Debian ...................................................................... doc/tutorial/part1.md: Fix package name to install qemu on Debian Fix package name to install qemu on Debian. It used to be 'qemu' only but it is now called 'qemu-system'. Signed-off-by: Daniel R. Franzini <danielt3(a)usp.br> Change-Id: Ibae9031a3e397925db95b7283fa8c6573f6d5858 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74894 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Sean Rhodes <sean(a)starlabs.systems> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M Documentation/tutorial/part1.md 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved Sean Rhodes: Looks good to me, approved diff --git a/Documentation/tutorial/part1.md b/Documentation/tutorial/part1.md index 13d6478..9315b1b 100644 --- a/Documentation/tutorial/part1.md +++ b/Documentation/tutorial/part1.md @@ -147,7 +147,7 @@ ### Step 7 - Install QEMU -* Debian: `sudo apt-get install -y qemu` +* Debian: `sudo apt-get install -y qemu-system` * Arch: `sudo pacman -S qemu` * Redhat: `sudo dnf install qemu` -- To view, visit https://review.coreboot.org/c/coreboot/+/74894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibae9031a3e397925db95b7283fa8c6573f6d5858 Gerrit-Change-Number: 74894 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: cpu/intel/microcode: Implement microcode info caching inside cbmem
by Subrata Banik (Code Review) 02 May '23

02 May '23

Attention is currently required from: Tarun Tuli, Reka Norman, Kapil Porwal, Julius Werner, Arthur Heymans, Lean Sheng Tan. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74873 ) Change subject: cpu/intel/microcode: Implement microcode info caching inside cbmem ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > > I assume this patch is in response to b/242473942? And your time savings aren't really from "searching", they're from bypassing CBFS verification? > > > > If we determined that we actually *want* to bypass CBFS verification, and that it is safe to do so, there are more straight-forward ways to do that (e.g. cbfs_unverified_area_map()). But my understanding from the previous discussion on the bug was that we don't actually want to do that because there could actually be some attack vector here (even if it's e.g. just a rollback attack). In that case, we obviously also can't do something like this. > > yes, your understanding is correct that we don't want to bypass the CBFS verification check also i have noticed ~10ms boot time impact with every new ucode (per cpu stepping) being added into the cpu_microcode_blob.bin for example: current REX (MTL) added 2 ucode for ES1 and ES2 hence, the timestamp ID 971 was around 20ms. if we drop ES2 support and keep only ES1 then the boot time (timestamp ID 971) is 10ms -- To view, visit https://review.coreboot.org/c/coreboot/+/74873 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I208a2e0e1dce96b2d4d63f882e8aaf4c25f77e3f Gerrit-Change-Number: 74873 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 02 May 2023 12:41:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: doc/tutorial/part1.md: Fix package name to install qemu on Debian
by Felix Singer (Code Review) 02 May '23

02 May '23

Attention is currently required from: Daniel Rosa Franzini, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74894 ) Change subject: doc/tutorial/part1.md: Fix package name to install qemu on Debian ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibae9031a3e397925db95b7283fa8c6573f6d5858 Gerrit-Change-Number: 74894 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 02 May 2023 12:41:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Don't hardcode ramtop offset
by Nico Huber (Code Review) 02 May '23

02 May '23

Attention is currently required from: Sean Rhodes, Subrata Banik, Dinesh Gehlot, Lean Sheng Tan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 ) Change subject: soc/intel/common: Don't hardcode ramtop offset ...................................................................... Patch Set 11: Code-Review+1 (1 comment) File src/soc/intel/common/basecode/ramtop/ramtop.c: https://review.coreboot.org/c/coreboot/+/74511/comment/e06629a8_7dc93173 PS10, Line 19: */ > I assume it's already a compile-time error, just telling that it's undefined. […] Didn't realize that you brought the comment back. To me that's alright. `#error` would be nice but doesn't need to happen in this change. -- To view, visit https://review.coreboot.org/c/coreboot/+/74511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0 Gerrit-Change-Number: 74511 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 02 May 2023 11:59:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: doc/tutorial/part1.md: Fix package name to install qemu on Debian
by Sean Rhodes (Code Review) 02 May '23

02 May '23

Attention is currently required from: Felix Singer, Daniel Rosa Franzini, Paul Menzel. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74894 ) Change subject: doc/tutorial/part1.md: Fix package name to install qemu on Debian ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74894/comment/42ccdf4d_e56e2efd PS2, Line 7: fix > Nit: Fix Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibae9031a3e397925db95b7283fa8c6573f6d5858 Gerrit-Change-Number: 74894 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 02 May 2023 11:58:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: doc/tutorial/part1.md: Fix package name to install qemu on Debian
by Daniel Rosa Franzini (Code Review) 02 May '23

02 May '23

Attention is currently required from: Felix Singer, Daniel Rosa Franzini, Paul Menzel. Hello Felix Singer, build bot (Jenkins), Sean Rhodes, Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74894 to look at the new patch set (#3). Change subject: doc/tutorial/part1.md: Fix package name to install qemu on Debian ...................................................................... doc/tutorial/part1.md: Fix package name to install qemu on Debian Fix package name to install qemu on Debian. It used to be 'qemu' only but it is now called 'qemu-system'. Signed-off-by: Daniel R. Franzini <danielt3(a)usp.br> Change-Id: Ibae9031a3e397925db95b7283fa8c6573f6d5858 --- M Documentation/tutorial/part1.md 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/74894/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74894 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibae9031a3e397925db95b7283fa8c6573f6d5858 Gerrit-Change-Number: 74894 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Daniel Rosa Franzini <danielt3(a)usp.br> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: cpu/x86/smm_stub.S: Add a retpoline around the main C handler
by Jan Samek (Code Review) 02 May '23

02 May '23

Attention is currently required from: Nico Huber, Martin L Roth, Subrata Banik, Patrick Rudolph, Benjamin Doron, Julius Werner, Maximilian Brune, Arthur Heymans. Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67735 ) Change subject: cpu/x86/smm_stub.S: Add a retpoline around the main C handler ...................................................................... Patch Set 2: (1 comment) File src/cpu/x86/smm/smm_stub.S: https://review.coreboot.org/c/coreboot/+/67735/comment/4cf12ea2_cbeb1423 PS2, Line 256: 2f > The `2:` below (f for forward). OK, thanks for explanation. That was the lack of my knowledge of the forward and backward flags and I misinterpreted these values as hexadecimal offsets (which would have been written differently). -- To view, visit https://review.coreboot.org/c/coreboot/+/67735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93be3cd6a8c5f1ec29b3bc43195823ac49ec61c5 Gerrit-Change-Number: 67735 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 02 May 2023 11:52:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Jan Samek <jan.samek(a)siemens.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2023