coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: mainboard/google/rex/Kconfig: Enable EC boot timestamps for mtl-rex
by build bot (Jenkins) (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Tarun Tuli, Jamie Ryu, Wonkyu Kim, Paul Menzel, Kapil Porwal, Jay Patel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73192 ) Change subject: mainboard/google/rex/Kconfig: Enable EC boot timestamps for mtl-rex ...................................................................... Patch Set 12: (4 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175185): https://review.coreboot.org/c/coreboot/+/73192/comment/ec73bbd2_114102c1 PS12, Line 12: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4263103 Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175185): https://review.coreboot.org/c/coreboot/+/73192/comment/c2020e2d_321c135c PS12, Line 26: 990:CSME ROM started execution 4,994,005 (3,990,503) Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175185): https://review.coreboot.org/c/coreboot/+/73192/comment/219d449d_60f7ec22 PS12, Line 28: 945:CSE started to handle ICC configuration 5,235,005 (182,000) Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175185): https://review.coreboot.org/c/coreboot/+/73192/comment/d9105025_3439a95a PS12, Line 30: 947:CSE received 'CPU Reset Done Ack sent' from PMC 5,522,005 (287,000) Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/73192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0b773fb4c7abfcb3c3ab061d970327987536fb2 Gerrit-Change-Number: 73192 Gerrit-PatchSet: 12 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 00:23:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmn/blk: Request pre-reset EC boot timestamps
by build bot (Jenkins) (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Dinesh Gehlot, Jay Patel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72931 ) Change subject: soc/intel/cmn/blk: Request pre-reset EC boot timestamps ...................................................................... Patch Set 16: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175183): https://review.coreboot.org/c/coreboot/+/72931/comment/027f7a5e_190761e4 PS16, Line 13: The EC patches required to enable the feature in the EC: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/72931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecb88eaa085759ea9430708d45abf1ca69727ce9 Gerrit-Change-Number: 72931 Gerrit-PatchSet: 16 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 00:22:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard/google/rex/Kconfig: Enable EC boot timestamps for mtl-rex
by Jay Patel (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Tarun Tuli, Jamie Ryu, Wonkyu Kim, Paul Menzel, Kapil Porwal, Jay Patel. Hello Bora Guvendik, build bot (Jenkins), Hannah Williams, Tarun Tuli, Jamie Ryu, Subrata Banik, Wonkyu Kim, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73192 to look at the new patch set (#12). Change subject: mainboard/google/rex/Kconfig: Enable EC boot timestamps for mtl-rex ...................................................................... mainboard/google/rex/Kconfig: Enable EC boot timestamps for mtl-rex Enables feature to record pre-reset boot time using EC boot timestamps. Additional patch required in EC to enable the feature: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4263103 In EC, it is also required to enable the feature in program config file using SYSTEM_BOOT_TIME_LOGGING flag. BUG=b:271012752 TEST=Pre-reset boot timestamps added to the timestamp table, verified using cbmem -t Test Data: Cold reset 116:Cold reboot triggered 0 117:Platform reset low asserted 1,003,501 990:CSME ROM started execution 4,994,005 (3,990,503) 944:CSE sent 'Boot Stall Done' to PMC 5,053,005 (59,000) 945:CSE started to handle ICC configuration 5,235,005 (182,000) 946:CSE sent 'Host BIOS Prep Done' to PMC 5,235,005 (0) 947:CSE received 'CPU Reset Done Ack sent' from PMC 5,522,005 (287,000) 91:Die Management Unit (DMU) load completed 5,594,005 (72,000) 0:1st timestamp 5,605,440 (11,435) 11:start of bootblock 5,616,777 (11,336) 12:end of bootblock 5,619,869 (3,092) Warm reset 990:CSME ROM started execution 0 117:Platform reset low asserted 1,445 944:CSE sent 'Boot Stall Done' to PMC 35,000 (33,554) 945:CSE started to handle ICC configuration 195,000 (160,000) 946:CSE sent 'Host BIOS Prep Done' to PMC 195,000 (0) 947:CSE received 'CPU Reset Done Ack sent' from PMC 483,000 (288,000) 991:Die Management Unit (DMU) load completed 557,000 (74,000) 0:1st timestamp 565,924 (8,924) 11:start of bootblock 578,564 (12,639) 12:end of bootblock 582,973 (4,409) Signed-off-by: Jay Patel <jay2.patel(a)intel.com> Change-Id: Id0b773fb4c7abfcb3c3ab061d970327987536fb2 --- M src/mainboard/google/rex/Kconfig 1 file changed, 51 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/73192/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/73192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0b773fb4c7abfcb3c3ab061d970327987536fb2 Gerrit-Change-Number: 73192 Gerrit-PatchSet: 12 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/cmn/blk: Request pre-reset EC boot timestamps
by Jay Patel (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Dinesh Gehlot, Jay Patel. Hello Bora Guvendik, build bot (Jenkins), Hannah Williams, Wonkyu Kim, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72931 to look at the new patch set (#16). Change subject: soc/intel/cmn/blk: Request pre-reset EC boot timestamps ...................................................................... soc/intel/cmn/blk: Request pre-reset EC boot timestamps coreboot requests pre-reset power signal timestamps to the EC. These timestamps are used to calculate pre-reset boot time and inserted into the coreboot timestamp table. The EC patches required to enable the feature in the EC: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3794612 In EC, it is also required to enable the feature in program config file by using SYSTEM_BOOT_TIME_LOGGING flag. BUG=b:271012752 TEST=Pre-reset timestamps added to cbmem timestamp table if flag enabled in Kconfig file and feature enabled from romstage for specific board. Signed-off-by: Jay Patel <jay2.patel(a)intel.com> Change-Id: Iecb88eaa085759ea9430708d45abf1ca69727ce9 --- A src/soc/intel/common/block/ec_telemetry/Kconfig A src/soc/intel/common/block/ec_telemetry/Makefile.inc A src/soc/intel/common/block/ec_telemetry/ec_telemetry.c A src/soc/intel/common/block/include/intelblocks/ec_telemetry.h 4 files changed, 108 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/72931/16 -- To view, visit https://review.coreboot.org/c/coreboot/+/72931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecb88eaa085759ea9430708d45abf1ca69727ce9 Gerrit-Change-Number: 72931 Gerrit-PatchSet: 16 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Enable SPL fusing on Markarth
by Eric Lai (Code Review) 28 Apr '23

28 Apr '23

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74753 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/skyrim: Enable SPL fusing on Markarth ...................................................................... mb/google/skyrim: Enable SPL fusing on Markarth Because SPL fuse needs to be set before the FW lock. So enable Markarth project to send the fuse SPL (security patch level) command to the PSP. BUG=b:279499511 BRANCH=none TEST=FW_NAME="Markarth" emerge-skyrim coreboot chromeos-bootimage Then get "PSP: SPL Fusing Update Requested." in the firmware log. Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com> Change-Id: I8fbbd89d11b1bdb2c95c761955c10bedb366fd70 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74753 Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/skyrim/Kconfig 1 file changed, 25 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index 7b8618d..14ef71b 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -92,6 +92,7 @@ config SOC_AMD_COMMON_BLOCK_PSP_FUSE_SPL default y if BOARD_GOOGLE_WINTERHOLD default y if BOARD_GOOGLE_FROSTFLOW + default y if BOARD_GOOGLE_MARKARTH default n config FMDFILE -- To view, visit https://review.coreboot.org/c/coreboot/+/74753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fbbd89d11b1bdb2c95c761955c10bedb366fd70 Gerrit-Change-Number: 74753 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chao Gui <chaogui(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Huang <patrick.huang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/rex/variants/screebo: Generate RAM IDs
by Eric Lai (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal, Kun Liu. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74802 ) Change subject: mb/google/rex/variants/screebo: Generate RAM IDs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fb2e488c06ed74d3fd493e5ca0ab89a825a9349 Gerrit-Change-Number: 74802 Gerrit-PatchSet: 3 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 00:18:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/link: Apply symmetry for EC events defines
by build bot (Jenkins) (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Kyösti Mälkki. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74602 ) Change subject: mb/google/link: Apply symmetry for EC events defines ...................................................................... Patch Set 2: Verified+1 (1 comment) File src/mainboard/google/link/ec.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175174): https://review.coreboot.org/c/coreboot/+/74602/comment/e6f36739_95acec25 PS2, Line 11: #define MAINBOARD_EC_SCI_EVENTS \ Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/74602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97d9d28963c97e780156d75b39deac069028866a Gerrit-Change-Number: 74602 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 00:11:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/slippy: Use chromeec_smi_sleep()
by Kyösti Mälkki (Code Review) 28 Apr '23

28 Apr '23

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74824 ) Change subject: mb/google/slippy: Use chromeec_smi_sleep() ...................................................................... mb/google/slippy: Use chromeec_smi_sleep() Change-Id: I752d5644d6140e5a6d6f53543bbbc5ef7281f3b4 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/slippy/smihandler.c 1 file changed, 11 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/74824/1 diff --git a/src/mainboard/google/slippy/smihandler.c b/src/mainboard/google/slippy/smihandler.c index efc9486..091d70e 100644 --- a/src/mainboard/google/slippy/smihandler.c +++ b/src/mainboard/google/slippy/smihandler.c @@ -11,7 +11,6 @@ #include <cpu/intel/haswell/haswell.h> /* Include EC functions */ -#include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/smm.h> #include "ec.h" @@ -48,25 +47,7 @@ break; } - switch (slp_typ) { - case ACPI_S3: - /* Enable wake events */ - google_chromeec_set_wake_mask(MAINBOARD_EC_S3_WAKE_EVENTS); - break; - case ACPI_S4: - case ACPI_S5: - /* Enable wake events */ - google_chromeec_set_wake_mask(MAINBOARD_EC_S5_WAKE_EVENTS); - break; - } - - /* Disable SCI and SMI events */ - google_chromeec_set_smi_mask(0); - google_chromeec_set_sci_mask(0); - - /* Clear pending events that may trigger immediate wake */ - while (google_chromeec_get_event() != EC_HOST_EVENT_NONE) - ; + chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS); } int mainboard_smi_apmc(u8 apmc) -- To view, visit https://review.coreboot.org/c/coreboot/+/74824 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I752d5644d6140e5a6d6f53543bbbc5ef7281f3b4 Gerrit-Change-Number: 74824 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Handle ACPI S4 in chromeec_smi_sleep()
by Kyösti Mälkki (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Caveh Jalali, Boris Mittelberg. Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74823 ) Change subject: ec/google/chromeec: Handle ACPI S4 in chromeec_smi_sleep() ...................................................................... ec/google/chromeec: Handle ACPI S4 in chromeec_smi_sleep() While Chromebook hardware originally would not have the capacity to do suspend-to-disk (ACPI S4), the power management code in EC should react to S4 request as if it was S5 request. Change-Id: Ida9118919c8149d94f470847d0c4aad9c0b97d3e Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/ec/google/chromeec/smihandler.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/74823/1 diff --git a/src/ec/google/chromeec/smihandler.c b/src/ec/google/chromeec/smihandler.c index 599a66e..d2ce2a6 100644 --- a/src/ec/google/chromeec/smihandler.c +++ b/src/ec/google/chromeec/smihandler.c @@ -62,6 +62,7 @@ /* Enable wake events */ google_chromeec_set_wake_mask(s3_mask); break; + case ACPI_S4: case ACPI_S5: /* Enable wake events */ google_chromeec_set_wake_mask(s5_mask); -- To view, visit https://review.coreboot.org/c/coreboot/+/74823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida9118919c8149d94f470847d0c4aad9c0b97d3e Gerrit-Change-Number: 74823 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/slippy: Re-arrange mainboard_smi_sleep()
by Kyösti Mälkki (Code Review) 28 Apr '23

28 Apr '23

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74822 ) Change subject: mb/google/slippy: Re-arrange mainboard_smi_sleep() ...................................................................... mb/google/slippy: Re-arrange mainboard_smi_sleep() Change-Id: I9ac7293e03bba773753f48163aca9385f819a71b Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/slippy/smihandler.c 1 file changed, 17 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/74822/1 diff --git a/src/mainboard/google/slippy/smihandler.c b/src/mainboard/google/slippy/smihandler.c index 3ac2152..efc9486 100644 --- a/src/mainboard/google/slippy/smihandler.c +++ b/src/mainboard/google/slippy/smihandler.c @@ -38,23 +38,23 @@ switch (slp_typ) { case ACPI_S3: - /* Prevent leak from standby rail to WLAN rail in S3. */ + case ACPI_S4: + case ACPI_S5: + /* Prevent leak from standby rail to WLAN rail in S3/S4/S5. */ set_gpio(GPIO_WLAN_DISABLE_L, 0); set_gpio(GPIO_PP3300_CODEC_EN, 0); /* Disable LTE */ set_gpio(GPIO_LTE_DISABLE_L, 0); + break; + } + switch (slp_typ) { + case ACPI_S3: /* Enable wake events */ google_chromeec_set_wake_mask(MAINBOARD_EC_S3_WAKE_EVENTS); break; case ACPI_S4: case ACPI_S5: - /* Prevent leak from standby rail to WLAN rail in S5. */ - set_gpio(GPIO_WLAN_DISABLE_L, 0); - set_gpio(GPIO_PP3300_CODEC_EN, 0); - /* Disable LTE */ - set_gpio(GPIO_LTE_DISABLE_L, 0); - /* Enable wake events */ google_chromeec_set_wake_mask(MAINBOARD_EC_S5_WAKE_EVENTS); break; -- To view, visit https://review.coreboot.org/c/coreboot/+/74822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ac7293e03bba773753f48163aca9385f819a71b Gerrit-Change-Number: 74822 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023