coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/intel/xeon_sp/spr: Drop spurious FADT fields
by Kyösti Mälkki (Code Review) 28 Apr '23

28 Apr '23

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74827 ) Change subject: soc/intel/xeon_sp/spr: Drop spurious FADT fields ...................................................................... soc/intel/xeon_sp/spr: Drop spurious FADT fields Assigning duty_offset while duty_width==0 has no purpose. Under intel/common/block, previous assignment for fadt->gpe0_blk resolves GPE0_STS(0) from xeon_sp/ebg/.../soc_pm.h and also assigns value matching pmbase + 0x60. Change-Id: Iaf688d9471ac527ac20307cf16216abdab731a06 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/soc/intel/xeon_sp/spr/soc_acpi.c 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/74827/1 diff --git a/src/soc/intel/xeon_sp/spr/soc_acpi.c b/src/soc/intel/xeon_sp/spr/soc_acpi.c index 0233c37..18ebe72 100644 --- a/src/soc/intel/xeon_sp/spr/soc_acpi.c +++ b/src/soc/intel/xeon_sp/spr/soc_acpi.c @@ -47,8 +47,6 @@ fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; fadt->pm2_cnt_blk = pmbase + PM2_CNT; fadt->pm2_cnt_len = 1; - fadt->gpe0_blk = pmbase + 0x60; - fadt->duty_offset = 1; fadt->x_pm1b_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO; fadt->x_pm1b_cnt_blk.space_id = ACPI_ADDRESS_SPACE_IO; -- To view, visit https://review.coreboot.org/c/coreboot/+/74827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf688d9471ac527ac20307cf16216abdab731a06 Gerrit-Change-Number: 74827 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/uldren:Fix Touch screen power sequence
by Ian Feng (Code Review) 28 Apr '23

28 Apr '23

Ian Feng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74835 ) Change subject: mb/google/nissa/var/uldren:Fix Touch screen power sequence ...................................................................... mb/google/nissa/var/uldren:Fix Touch screen power sequence Set TCHSCR_RST_L (GPP_C1) to high as default when POST. BUG=b:279989974 TEST=Build and boot to OS in uldren. Touch screen is workable. Change-Id: Ib1b1ce80aa1dd8c312e3663fc50c9e9f53cc07fe Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/uldren/gpio.c 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/74835/1 diff --git a/src/mainboard/google/brya/variants/uldren/gpio.c b/src/mainboard/google/brya/variants/uldren/gpio.c index 9c427f6..cc12310 100644 --- a/src/mainboard/google/brya/variants/uldren/gpio.c +++ b/src/mainboard/google/brya/variants/uldren/gpio.c @@ -17,6 +17,8 @@ PAD_NC(GPP_B6, NONE), /* B15 : HP_RST_ODL */ PAD_CFG_GPO(GPP_B15, 1, DEEP), + /* C1 : SMBDA==> TCHSCR_RST_L */ + PAD_CFG_GPO(GPP_C1, 1, DEEP), /* D6 : SRCCLKREQ1# ==> WWAN_EN */ PAD_CFG_GPO(GPP_D6, 1, DEEP), /* D8 : SRCCLKREQ3# ==> NC */ -- To view, visit https://review.coreboot.org/c/coreboot/+/74835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1b1ce80aa1dd8c312e3663fc50c9e9f53cc07fe Gerrit-Change-Number: 74835 Gerrit-PatchSet: 1 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: Documentation/contributing: Add Sign-off procedure
by Patrick Georgi (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Martin L Roth, Nicholas Chin. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74825 ) Change subject: Documentation/contributing: Add Sign-off procedure ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If50b3827ab36234719f9a90239caec4612eb6762 Gerrit-Change-Number: 74825 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 05:27:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard/google/rex/Kconfig: Enable EC boot timestamps for mtl-rex
by Subrata Banik (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Jamie Ryu, Paul Menzel, Jay Patel. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73192 ) Change subject: mainboard/google/rex/Kconfig: Enable EC boot timestamps for mtl-rex ...................................................................... Patch Set 12: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/73192/comment/bcea6f88_3e3b342f PS12, Line 24: 116:Cold reboot triggered 0 : 117:Platform reset low asserted 1,003,501 : 990:CSME ROM started execution 4,994,005 (3,990,503) 3sec? between platform reset low asserted to CSE ROM start execution ? -- To view, visit https://review.coreboot.org/c/coreboot/+/73192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0b773fb4c7abfcb3c3ab061d970327987536fb2 Gerrit-Change-Number: 73192 Gerrit-PatchSet: 12 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 05:16:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/contributing: Add Sign-off procedure
by Nicholas Chin (Code Review) 28 Apr '23

28 Apr '23

Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74825 ) Change subject: Documentation/contributing: Add Sign-off procedure ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This isn't strictly related to Gerrit, but a lot of the contribution stuff is on this page. Taking inspiration from the comments on commit fb47404cb1 (developers.html: Add the sign-off procedure) from the homepage repo, perhaps Gerrit specific guidelines and general contribution guidelines could be split up in the future, as this page is rather long. -- To view, visit https://review.coreboot.org/c/coreboot/+/74825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If50b3827ab36234719f9a90239caec4612eb6762 Gerrit-Change-Number: 74825 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 03:46:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/contributing: Add Sign-off procedure
by Nicholas Chin (Code Review) 28 Apr '23

28 Apr '23

Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74825 ) Change subject: Documentation/contributing: Add Sign-off procedure ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Also updated developers.html on the homepage: CB:74826 -- To view, visit https://review.coreboot.org/c/coreboot/+/74825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If50b3827ab36234719f9a90239caec4612eb6762 Gerrit-Change-Number: 74825 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 03:37:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/contributing: Add Sign-off procedure
by Nicholas Chin (Code Review) 28 Apr '23

28 Apr '23

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74825 ) Change subject: Documentation/contributing: Add Sign-off procedure ...................................................................... Documentation/contributing: Add Sign-off procedure Currently, this only exists on the old wiki and the developers.html page on coreboot.org, but it really ought to be somewhere in the new docs alongside the other contribution guidelines. This was largely copied from the text from the developers.html page. In addition, the Linux kernel recently updated the wording of their sign off procedure, changing the ambiguous "real name" requirement to "a known identity" and dropping "no pseudonyms". Anonymous contributions remain uncommittable [1]. As discussed in the April 19, 2023 leadership meeting, update our policy to go along with Linux and flashrom (who also updated their policy). [1] Linux kernel commit d4563201f3 (Documentation: simplify and clarify DCO contribution example language) Change-Id: If50b3827ab36234719f9a90239caec4612eb6762 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M Documentation/contributing/gerrit_guidelines.md 1 file changed, 78 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/74825/1 diff --git a/Documentation/contributing/gerrit_guidelines.md b/Documentation/contributing/gerrit_guidelines.md index e23bff7..1b0a791 100644 --- a/Documentation/contributing/gerrit_guidelines.md +++ b/Documentation/contributing/gerrit_guidelines.md @@ -41,7 +41,7 @@ you wrote that might be owned by your employer, make sure that your employer is aware and you are authorized to submit the code. For clarification, see the Developer's Certificate of Origin in the coreboot -[Signed-off-by policy](https://www.coreboot.org/Development_Guidelines#Sign-off_Procedure). +[Signed-off-by policy](#sign-off-procedure). * In general, patches should remain open for review for at least 24 hours since the last significant modification to the change. The purpose is to @@ -127,6 +127,54 @@ must at least provide a path that will allow other platforms to continue working. +Sign-off Procedure +------------------ +The coreboot project employs a sign-off procedure similar to what is +used by the Linux kernel. Each gerrit commit requires a sign-off line +saying that the contributed code abides by the Developer's certificate +of origin, below. +```text +Signed-off-by: Random J Developer <random(a)developer.example.org> +``` + +Using '-s' with 'git commit' will automatically add a Signed-off-by line +to your commit message. Patches without a Signed-off-by should not be +pushed to gerrit, and will be rejected by coreboot's CI system. + +You must use a known identity in the Signed-off-by line. Anonymous +contributions cannot be committed! This can be anything sufficient to +identify and contact the source of a contribution, such as your name or +an established alias/nickname. Refer to [this LKML thread] and the +[SCO-Linux disputes] for the rationale behind the DCO. + +Developer's Certificate of Origin 1.1 +```text +By making a contribution to this project, I certify that: + +(a) The contribution was created in whole or in part by me and I have +the right to submit it under the open source license indicated in the +file; or + +(b) The contribution is based upon previous work that, to the best of my +knowledge, is covered under an appropriate open source license and I +have the right under that license to submit that work with +modifications, whether created in whole or in part by me, under the same +open source license (unless I am permitted to submit under a different +license), as indicated in the file; or + +(c) The contribution was provided directly to me by some other person +who certified (a), (b) or (c) and I have not modified it; and + +(d) In the case of each of (a), (b), or (c), I understand and agree that +this project and the contribution are public and that a record of the +contribution (including all personal information I submit with it, +including my sign-off) is maintained indefinitely and may be +redistributed consistent with this project or the open source license +indicated in the file. +``` +Note: The [Developer's Certificate of Origin 1.1] is licenced under the +terms of the [Creative Commons Attribution-ShareAlike 2.5 License]. + Recommendations for gerrit activity ----------------------------------- @@ -386,3 +434,7 @@ should be sent to the coreboot mailing list at <coreboot(a)coreboot.org>. [ready changes]: https://review.coreboot.org/q/age:1d+project:coreboot+status:open+is:mergea… +[Developer's Certificate of Origin 1.1]: https://developercertificate.org/ +[Creative Commons Attribution-ShareAlike 2.5 License]: https://creativecommons.org/licenses/by-sa/2.5/ +[this LKML thread]: https://lkml.org/lkml/2004/5/23/10 +[SCO-Linux disputes]: https://en.wikipedia.org/wiki/SCO%E2%80%93Linux_disputes -- To view, visit https://review.coreboot.org/c/coreboot/+/74825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If50b3827ab36234719f9a90239caec4612eb6762 Gerrit-Change-Number: 74825 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[master]: ACPI,SMBIOS : Provide ACPI and SMBIOS supports for RISC-V
by Lance Zhao (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Philipp Hug, weidongwd, Tim Wawrzynczak, ron minnich. Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74799 ) Change subject: ACPI,SMBIOS : Provide ACPI and SMBIOS supports for RISC-V ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Ideally ACPI spec not limited to X86, hardware reduced mode introduced from acpi 5.0, so probably we can avoid the condition using x86 or env_x86, but limited to ACPI itself. Will update more in upcoming reviews. -- To view, visit https://review.coreboot.org/c/coreboot/+/74799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c47d22e8e383e8c90387caab82796b6b4d5eff5 Gerrit-Change-Number: 74799 Gerrit-PatchSet: 1 Gerrit-Owner: weidongwd <weidong.wd(a)bytedance.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: weidongwd <weidong.wd(a)bytedance.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 02:52:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [WIP] mb/google/link: Use chromeec_smi_sleep()
by Kyösti Mälkki (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Subrata Banik, Matt DeVillier, Boris Mittelberg. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74603 ) Change subject: [WIP] mb/google/link: Use chromeec_smi_sleep() ...................................................................... Patch Set 2: (1 comment) File src/ec/google/chromeec/smihandler.c: https://review.coreboot.org/c/coreboot/+/74603/comment/1e9ca98f_76083df8 PS1, Line 67: ACPI_S4 > It's intentional here in the sense it should be discussed. […] Let's use CB:74823 for this discussion. -- To view, visit https://review.coreboot.org/c/coreboot/+/74603 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54c7d7455a6737f731c65e57c91b6457643c7cb2 Gerrit-Change-Number: 74603 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 00:33:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard/google/rex/Kconfig: Enable EC boot timestamps for mtl-rex
by Jay Patel (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Jamie Ryu, Paul Menzel. Jay Patel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73192 ) Change subject: mainboard/google/rex/Kconfig: Enable EC boot timestamps for mtl-rex ...................................................................... Patch Set 12: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/73192/comment/5e653e49_02afb420 PS6, Line 13: cbmem -t > > Attached on bug 271012752 […] provided here. Data based on ToT. -- To view, visit https://review.coreboot.org/c/coreboot/+/73192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0b773fb4c7abfcb3c3ab061d970327987536fb2 Gerrit-Change-Number: 73192 Gerrit-PatchSet: 12 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 28 Apr 2023 00:26:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jay Patel <jay2.patel(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023