coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: acpi: Add missing cbfs_unmap()
by Grzegorz Bernacki (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Lance Zhao, Konrad Adamczyk, Tim Wawrzynczak, Grzegorz Bernacki, Karthik Ramasubramanian. Hello Lance Zhao, build bot (Jenkins), Konrad Adamczyk, Jakub Czapiga, Tim Wawrzynczak, Tim Van Patten, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74715 to look at the new patch set (#5). Change subject: acpi: Add missing cbfs_unmap() ...................................................................... acpi: Add missing cbfs_unmap() cbfs_map() can allocate memory, so cbfs_unmap() should be called before leaving the function. BUG=b:278264488 TEST=Built and run with additional debugs on Skyrim device to confirm that data are correctly unmapped Change-Id: Ibf7ba6842f42404ad8bb415f8e7fda10403cbe2e Signed-off-by: Grzegorz Bernacki <bernacki(a)google.com> --- M src/acpi/acpi.c 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/74715/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf7ba6842f42404ad8bb415f8e7fda10403cbe2e Gerrit-Change-Number: 74715 Gerrit-PatchSet: 5 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Grzegorz Bernacki Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craask: avoid camera LED blinking during boot
by Jimmy Su (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Tarun Tuli, Paul Menzel, Reka Norman, Tyler Wang, Eric Lai. Jimmy Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74728 ) Change subject: mb/google/nissa/var/craask: avoid camera LED blinking during boot ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > There has a mechanism to handle two driver using the same power rails. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78ed5efe1e2c071d817c1e0455271886e89e63c7 Gerrit-Change-Number: 74728 Gerrit-PatchSet: 2 Gerrit-Owner: Jimmy Su <jimmy.su(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jimmy Su <jimmy.su(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Yeh <andy.yeh(a)intel.com> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-CC: Tian Shu Qiu <tian.shu.qiu(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 09:28:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jimmy Su <jimmy.su(a)intel.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mainboard/intel/mtlrvp: Refactor the kconfig selections
by Sridhar Siricilla (Code Review) 28 Apr '23

28 Apr '23

Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74838 ) Change subject: mainboard/intel/mtlrvp: Refactor the kconfig selections ...................................................................... mainboard/intel/mtlrvp: Refactor the kconfig selections The patch orders MTL RVP board Kconfigs alphabetically. TEST=Build the code for mtlrvp Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: Ib8557aab2848a384fba5203e5f3d62407b2566ef --- M src/mainboard/intel/mtlrvp/Kconfig 1 file changed, 18 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/74838/1 diff --git a/src/mainboard/intel/mtlrvp/Kconfig b/src/mainboard/intel/mtlrvp/Kconfig index 8a66ea0..de114c4 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig +++ b/src/mainboard/intel/mtlrvp/Kconfig @@ -1,14 +1,16 @@ config BOARD_INTEL_MTLRVP_COMMON def_bool n select BOARD_ROMSIZE_KB_32768 + select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID select DRIVERS_I2C_MAX98373 + select DRIVERS_INTEL_DPTF + select DRIVERS_INTEL_DPTF_SUPPORTS_TPCH select DRIVERS_INTEL_MIPI_CAMERA select DRIVERS_INTEL_SOUNDWIRE - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_SOUNDWIRE_ALC711 select DRIVERS_SOUNDWIRE_ALC5682 + select DRIVERS_SOUNDWIRE_ALC711 select DRIVERS_SOUNDWIRE_MAX98373 select DRIVERS_USB_ACPI select HAVE_ACPI_RESUME @@ -17,8 +19,6 @@ select MAINBOARD_HAS_CHROMEOS select SOC_INTEL_CSE_LITE_SKU select SOC_INTEL_METEORLAKE - select DRIVERS_INTEL_DPTF - select DRIVERS_INTEL_DPTF_SUPPORTS_TPCH config BOARD_INTEL_MTLRVP_P select BOARD_INTEL_MTLRVP_COMMON -- To view, visit https://review.coreboot.org/c/coreboot/+/74838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8557aab2848a384fba5203e5f3d62407b2566ef Gerrit-Change-Number: 74838 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/spr: Drop spurious FADT fields
by Paul Menzel (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74827 ) Change subject: soc/intel/xeon_sp/spr: Drop spurious FADT fields ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf688d9471ac527ac20307cf16216abdab731a06 Gerrit-Change-Number: 74827 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 08:51:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl: Remove wrong comment regarding spd.bin
by Paul Menzel (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Werner Zeh. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74801 ) Change subject: mb/siemens/mc_ehl: Remove wrong comment regarding spd.bin ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I669ee1c33d1d1c47764640982f71129195e63f14 Gerrit-Change-Number: 74801 Gerrit-PatchSet: 2 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 08:50:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/contributing: Add Sign-off procedure
by Paul Menzel (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Martin L Roth, Nicholas Chin. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74825 ) Change subject: Documentation/contributing: Add Sign-off procedure ...................................................................... Patch Set 1: Code-Review+1 (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74825/comment/65f41ff3_44d4828d PS1, Line 14: sign : off In the summary/title you spelled it Sign-off. https://review.coreboot.org/c/coreboot/+/74825/comment/1540efad_8df42d65 PS1, Line 14: In addition, the Linux kernel recently updated the wording of their sign : off procedure, changing the ambiguous "real name" requirement to "a : known identity" and dropping "no pseudonyms". Anonymous contributions : remain uncommittable [1]. As discussed in the April 19, 2023 leadership : meeting, update our policy to go along with Linux and flashrom (who also : updated their policy). I’d make that a separate commit. File Documentation/contributing/gerrit_guidelines.md: https://review.coreboot.org/c/coreboot/+/74825/comment/e498867d_08335806 PS1, Line 142: pushed to gerrit, and will be rejected by coreboot's CI system. Remove the trailing space? https://review.coreboot.org/c/coreboot/+/74825/comment/3d097797_bada9f9c PS1, Line 148: [SCO-Linux disputes] for the rationale behind the DCO. Remove the trailing space? https://review.coreboot.org/c/coreboot/+/74825/comment/b4e8d861_5f88dcd5 PS1, Line 151: ```text : By making a contribution to this project, I certify that: : : (a) The contribution was created in whole or in part by me and I have : the right to submit it under the open source license indicated in the : file; or : : (b) The contribution is based upon previous work that, to the best of my : knowledge, is covered under an appropriate open source license and I : have the right under that license to submit that work with : modifications, whether created in whole or in part by me, under the same : open source license (unless I am permitted to submit under a different : license), as indicated in the file; or : : (c) The contribution was provided directly to me by some other person : who certified (a), (b) or (c) and I have not modified it; and : : (d) In the case of each of (a), (b), or (c), I understand and agree that : this project and the contribution are public and that a record of the : contribution (including all personal information I submit with it, : including my sign-off) is maintained indefinitely and may be : redistributed consistent with this project or the open source license : indicated in the file. : ``` I’d mark this up as a citation? -- To view, visit https://review.coreboot.org/c/coreboot/+/74825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If50b3827ab36234719f9a90239caec4612eb6762 Gerrit-Change-Number: 74825 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 08:50:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: amdfwtool: Add --output-manifest option
by Grzegorz Bernacki (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Arthur Heymans, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Grzegorz Bernacki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74266 ) Change subject: amdfwtool: Add --output-manifest option ...................................................................... Patch Set 4: (4 comments) Patchset: PS1: > They look not very user readable at first, but amdfwtool seems more like a helper tool used in scrip […] Done & resolved File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/74266/comment/1e783399_1e279578 PS3, Line 853: fopen( > Done Done & resolved https://review.coreboot.org/c/coreboot/+/74266/comment/45325bec_97f5e38c PS3, Line 867: blob_fd = open(index->filename, O_RDONLY); : read(blob_fd, &hdr, sizeof(hdr)); : fprintf(version_file, "type: 0x%02x ver:%02x.%02x.%02x.%02x\n", : index->type, hdr.version[3], hdr.version[2], : hdr.version[1], hdr.version[0]); : close(blob_fd); > Done Done & resolved https://review.coreboot.org/c/coreboot/+/74266/comment/616cf2b7_563d4d01 PS3, Line 2145: if (manifest_file) { : dump_blob_version(manifest_file, amd_psp_fw_table); : } > Done Done & resolved -- To view, visit https://review.coreboot.org/c/coreboot/+/74266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idaa3a02ace524f44cfa656e34308bd896016dff6 Gerrit-Change-Number: 74266 Gerrit-PatchSet: 4 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 28 Apr 2023 08:42:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Grzegorz Bernacki Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl: Remove wrong comment regarding spd.bin
by Mario Scheithauer (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74801 ) Change subject: mb/siemens/mc_ehl: Remove wrong comment regarding spd.bin ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I669ee1c33d1d1c47764640982f71129195e63f14 Gerrit-Change-Number: 74801 Gerrit-PatchSet: 2 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 08:39:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/contributing: Add Sign-off procedure
by Sean Rhodes (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Martin L Roth, Nicholas Chin. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74825 ) Change subject: Documentation/contributing: Add Sign-off procedure ...................................................................... Patch Set 1: (1 comment) File Documentation/contributing/gerrit_guidelines.md: https://review.coreboot.org/c/coreboot/+/74825/comment/0f9e9d53_5a51444f PS1, Line 135: Should the spaces be there? -- To view, visit https://review.coreboot.org/c/coreboot/+/74825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If50b3827ab36234719f9a90239caec4612eb6762 Gerrit-Change-Number: 74825 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 28 Apr 2023 08:19:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: amdfwtool: Add --output-manifest option
by Grzegorz Bernacki (Code Review) 28 Apr '23

28 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Arthur Heymans, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Grzegorz Bernacki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74266 ) Change subject: amdfwtool: Add --output-manifest option ...................................................................... Patch Set 4: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/74266/comment/3e2c5531_3d81307e PS3, Line 864: case AMD_FW_PSP_BOOTLOADER: > This list should also include Stage2 Bootloader(AMD_FW_PSP_BOOTLOADER_AB) since Stage1 Bootloader is […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idaa3a02ace524f44cfa656e34308bd896016dff6 Gerrit-Change-Number: 74266 Gerrit-PatchSet: 4 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 28 Apr 2023 07:15:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023