Attention is currently required from: Jason Glenesk, Martin L Roth, Angel Pons, Arthur Heymans, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71711 )
Change subject: util/docker/coreboot-sdk: Remove Python 2 package
......................................................................
Patch Set 6:
(1 comment)
File util/docker/coreboot-sdk/Dockerfile:
https://review.coreboot.org/c/coreboot/+/71711/comment/f876c5a6_6d7a91da
PS3, Line 85: && update-alternatives --install /usr/bin/python python /usr/bin/python3 1 \
> > It symlinks /usr/bin/python to python3. That's already default now. […]
Will remove it in a separate patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4e298dc275c1dfaf57cd4c3f8e5f89410318ec0
Gerrit-Change-Number: 71711
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 01 Apr 2023 11:00:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Jason Glenesk, Martin L Roth, Angel Pons, Arthur Heymans, Elyes Haouas.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71711 )
Change subject: util/docker/coreboot-sdk: Remove Python 2 package
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File util/docker/coreboot-sdk/Dockerfile:
https://review.coreboot.org/c/coreboot/+/71711/comment/2fa514e0_5dac12a9
PS3, Line 85: && update-alternatives --install /usr/bin/python python /usr/bin/python3 1 \
> It symlinks /usr/bin/python to python3. That's already default now.
That doesn't seem to be correct. The symlink was removed and can be readded manually by installing `python-is-python3`. See https://wiki.debian.org/Python
--
To view, visit https://review.coreboot.org/c/coreboot/+/71711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4e298dc275c1dfaf57cd4c3f8e5f89410318ec0
Gerrit-Change-Number: 71711
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 01 Apr 2023 10:57:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Martin L Roth, Angel Pons, Arthur Heymans, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71711 )
Change subject: util/docker/coreboot-sdk: Remove Python 2 package
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Please review. I need this to test the Docker images properly.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4e298dc275c1dfaf57cd4c3f8e5f89410318ec0
Gerrit-Change-Number: 71711
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 01 Apr 2023 10:29:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Martin L Roth, Angel Pons, Arthur Heymans, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71711 )
Change subject: util/docker/coreboot-sdk: Remove Python 2 package
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS4:
> Add a note to the 4.20 release notes.
Will add the release note in a separate patch. Resolved for now.
File Documentation/releases/coreboot-4.19-relnotes.md:
https://review.coreboot.org/c/coreboot/+/71711/comment/4ce2a0a8_a5343230
PS3, Line 75: Debian removed Python 2 from their Sid repository and so it needs to
: be removed from the Dockerfile as well.
> Right, I will update it later. […]
Will add the release note in a separate patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4e298dc275c1dfaf57cd4c3f8e5f89410318ec0
Gerrit-Change-Number: 71711
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 01 Apr 2023 10:27:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Simon Chou, Johnny Lin, Shuming Chu (Shuming), Arthur Heymans, Lean Sheng Tan, Juan Sanchez.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71968 )
Change subject: mb/intel: add Archer City CRB support
......................................................................
Patch Set 28:
(1 comment)
File src/mainboard/intel/archercity_crb/romstage.c:
https://review.coreboot.org/c/coreboot/+/71968/comment/e1ba15b2_69962ce7
PS27, Line 96: "SerialIoUartDebugEnable to %d\n", FSP_LOG, FSP_LOG_DEFAULT);
It’s in the coding style, [section *Breaking long lines and strings*](https://doc.coreboot.org/contributing/coding_style.html#breaking-…:
> However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic02634cd615e2245e394f10aad24b0430cf5cd17
Gerrit-Change-Number: 71968
Gerrit-PatchSet: 28
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Daocheng Bu <daocheng.bu(a)intel.com>
Gerrit-CC: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-CC: Juan Sanchez
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Juan Sanchez
Gerrit-Comment-Date: Sat, 01 Apr 2023 10:13:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74155 )
Change subject: soc/intel/meteorlake: Set Power Performance Platform Override
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172869):
https://review.coreboot.org/c/coreboot/+/74155/comment/22047fe3_241cc4bf
PS4, Line 8:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172869):
https://review.coreboot.org/c/coreboot/+/74155/comment/1323d748_83709526
PS4, Line 11: This patch is backported from
Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 117770d32468 ("soc/intel/alderlake: Enable Energy/Performance Bias control")'
--
To view, visit https://review.coreboot.org/c/coreboot/+/74155
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic83225b619c49db0b49b521a83a2f1dc1ad69be8
Gerrit-Change-Number: 74155
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Sat, 01 Apr 2023 09:50:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai.
Hello Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74155
to look at the new patch set (#5).
Change subject: soc/intel/meteorlake: Set Power Performance Platform Override
......................................................................
soc/intel/meteorlake: Set Power Performance Platform Override
According to document 640858 MTL EDS Vol2, bit 18 (PWR_PERF_PLATFRM_OVR) of MSR_POWER_CTL must be set.
This patch is backported from
`commit 117770d32468e63df ("soc/intel/
alderlake: Enable Energy/Performance Bias control")`.
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
Change-Id: Ic83225b619c49db0b49b521a83a2f1dc1ad69be8
---
M src/soc/intel/meteorlake/cpu.c
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/74155/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/74155
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic83225b619c49db0b49b521a83a2f1dc1ad69be8
Gerrit-Change-Number: 74155
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai.
Hello Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74154
to look at the new patch set (#3).
Change subject: soc/intel/meteorlake: Add EPP override support
......................................................................
soc/intel/meteorlake: Add EPP override support
This updates energy performance preference value to all logical CPUs
when the corresponding chip config is true.
This patch is backported from
`commit 0bb2225718ef898c ("soc/intel/alderlake: Add EPP override
support")`.
BUG=b:266522659
TEST=Able to build and boot google/rex.
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
Change-Id: I8172276159fe3987dae36ec30ebceb76dd0ef326
---
M src/soc/intel/meteorlake/chip.h
M src/soc/intel/meteorlake/cpu.c
2 files changed, 44 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/74154/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/74154
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8172276159fe3987dae36ec30ebceb76dd0ef326
Gerrit-Change-Number: 74154
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset