coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/intel/meteorlake: Add EPP override support
by Eric Lai (Code Review) 01 Apr '23

01 Apr '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74154 ) Change subject: soc/intel/meteorlake: Add EPP override support ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8172276159fe3987dae36ec30ebceb76dd0ef326 Gerrit-Change-Number: 74154 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 01 Apr 2023 09:54:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Set Power Performance Platform Override
by build bot (Jenkins) (Code Review) 01 Apr '23

01 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74155 ) Change subject: soc/intel/meteorlake: Set Power Performance Platform Override ...................................................................... Patch Set 4: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172869): https://review.coreboot.org/c/coreboot/+/74155/comment/22047fe3_241cc4bf PS4, Line 8: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172869): https://review.coreboot.org/c/coreboot/+/74155/comment/1323d748_83709526 PS4, Line 11: This patch is backported from Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 117770d32468 ("soc/intel/alderlake: Enable Energy/Performance Bias control")' -- To view, visit https://review.coreboot.org/c/coreboot/+/74155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic83225b619c49db0b49b521a83a2f1dc1ad69be8 Gerrit-Change-Number: 74155 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 01 Apr 2023 09:50:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Set Power Performance Platform Override
by Subrata Banik (Code Review) 01 Apr '23

01 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai. Hello Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74155 to look at the new patch set (#5). Change subject: soc/intel/meteorlake: Set Power Performance Platform Override ...................................................................... soc/intel/meteorlake: Set Power Performance Platform Override According to document 640858 MTL EDS Vol2, bit 18 (PWR_PERF_PLATFRM_OVR) of MSR_POWER_CTL must be set. This patch is backported from `commit 117770d32468e63df ("soc/intel/ alderlake: Enable Energy/Performance Bias control")`. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ic83225b619c49db0b49b521a83a2f1dc1ad69be8 --- M src/soc/intel/meteorlake/cpu.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/74155/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic83225b619c49db0b49b521a83a2f1dc1ad69be8 Gerrit-Change-Number: 74155 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add EPP override support
by Subrata Banik (Code Review) 01 Apr '23

01 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai. Hello Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74154 to look at the new patch set (#3). Change subject: soc/intel/meteorlake: Add EPP override support ...................................................................... soc/intel/meteorlake: Add EPP override support This updates energy performance preference value to all logical CPUs when the corresponding chip config is true. This patch is backported from `commit 0bb2225718ef898c ("soc/intel/alderlake: Add EPP override support")`. BUG=b:266522659 TEST=Able to build and boot google/rex. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I8172276159fe3987dae36ec30ebceb76dd0ef326 --- M src/soc/intel/meteorlake/chip.h M src/soc/intel/meteorlake/cpu.c 2 files changed, 44 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/74154/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8172276159fe3987dae36ec30ebceb76dd0ef326 Gerrit-Change-Number: 74154 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add EPP override support
by Subrata Banik (Code Review) 01 Apr '23

01 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai. Hello Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74154 to look at the new patch set (#2). Change subject: soc/intel/meteorlake: Add EPP override support ...................................................................... soc/intel/meteorlake: Add EPP override support This updates energy performance preference value to all logical CPUs when the corresponding chip config is true. This patch is backported from commit 0bb2225718ef898c ("soc/intel/alderlake: Add EPP override support"). BUG=b:266522659 TEST=Able to build and boot google/rex. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I8172276159fe3987dae36ec30ebceb76dd0ef326 --- M src/soc/intel/meteorlake/chip.h M src/soc/intel/meteorlake/cpu.c 2 files changed, 44 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/74154/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8172276159fe3987dae36ec30ebceb76dd0ef326 Gerrit-Change-Number: 74154 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Set Power Performance Platform Override
by Subrata Banik (Code Review) 01 Apr '23

01 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal. Hello Tarun Tuli, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74155 to look at the new patch set (#3). Change subject: soc/intel/meteorlake: Set Power Performance Platform Override ...................................................................... soc/intel/meteorlake: Set Power Performance Platform Override According to document 640858 MTL EDS Vol2, bit 18 (PWR_PERF_PLATFRM_OVR) of MSR_POWER_CTL must be set. This patch is backported from commit hash 117770d32468e63df37aee1c041b5dc7cc1d56d2 (soc/intel/ alderlake: Enable Energy/Performance Bias control). Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ic83225b619c49db0b49b521a83a2f1dc1ad69be8 --- M src/soc/intel/meteorlake/cpu.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/74155/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic83225b619c49db0b49b521a83a2f1dc1ad69be8 Gerrit-Change-Number: 74155 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Allow building CMake with multiple threads
by Felix Singer (Code Review) 01 Apr '23

01 Apr '23

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74156 ) Change subject: util/crossgcc/buildgcc: Allow building CMake with multiple threads ...................................................................... util/crossgcc/buildgcc: Allow building CMake with multiple threads Change-Id: I89d6728a0985946b702f83770bedf767afb12690 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/crossgcc/buildgcc 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/74156/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 3fd4163..3a9cd4d 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -893,6 +893,7 @@ build_CMAKE() { CC="$(hostcc host)" CXX="$(hostcxx host)" CFLAGS="$HOSTCFLAGS" \ ../${CMAKE_DIR}/configure \ + --parallel=${THREADS} \ --prefix="$TARGETDIR" || touch .failed # shellcheck disable=SC2086 $MAKE $JOBS || touch .failed -- To view, visit https://review.coreboot.org/c/coreboot/+/74156 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89d6728a0985946b702f83770bedf767afb12690 Gerrit-Change-Number: 74156 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/Meteorlake: Set Power Performance Platform Override
by Subrata Banik (Code Review) 01 Apr '23

01 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal. Hello Tarun Tuli, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74155 to look at the new patch set (#2). Change subject: soc/intel/Meteorlake: Set Power Performance Platform Override ...................................................................... soc/intel/Meteorlake: Set Power Performance Platform Override According to document 640858 MTL EDS Vol2, bit 18 (PWR_PERF_PLATFRM_OVR) of MSR_POWER_CTL must be set. This patch is backported from commit hash 117770d32468e63df37aee1c041b5dc7cc1d56d2 (soc/intel/ alderlake: Enable Energy/Performance Bias control). Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ic83225b619c49db0b49b521a83a2f1dc1ad69be8 --- M src/soc/intel/meteorlake/cpu.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/74155/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic83225b619c49db0b49b521a83a2f1dc1ad69be8 Gerrit-Change-Number: 74155 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/Meteorlake: Set Power Performance Platform Override
by build bot (Jenkins) (Code Review) 01 Apr '23

01 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74155 ) Change subject: soc/intel/Meteorlake: Set Power Performance Platform Override ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172867): https://review.coreboot.org/c/coreboot/+/74155/comment/56ee59fe_5473e82a PS1, Line 12: This patch is backported from Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 117770d32468 ("soc/intel/alderlake: Enable Energy/Performance Bias control")' -- To view, visit https://review.coreboot.org/c/coreboot/+/74155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic83225b619c49db0b49b521a83a2f1dc1ad69be8 Gerrit-Change-Number: 74155 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sat, 01 Apr 2023 09:39:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add EPP override support
by build bot (Jenkins) (Code Review) 01 Apr '23

01 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74154 ) Change subject: soc/intel/meteorlake: Add EPP override support ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-172866): https://review.coreboot.org/c/coreboot/+/74154/comment/c0b9adbb_cdf3397b PS1, Line 12: This patch is backported from Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0bb2225718ef ("soc/intel/alderlake: Add EPP override support")' -- To view, visit https://review.coreboot.org/c/coreboot/+/74154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8172276159fe3987dae36ec30ebceb76dd0ef326 Gerrit-Change-Number: 74154 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sat, 01 Apr 2023 09:39:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023