Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74153 )
Change subject: drivers/pc80/pc/Makefile: use all_x86 make target
......................................................................
drivers/pc80/pc/Makefile: use all_x86 make target
Use the newly introduced all_x86 make target to add the compilation unit
to all stages that run on the x86 cores, but not to verstage on PSP.
TEST=Timeless build for Mandolin results in identical image.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I23c6977ae8acebb8dcd546f86f7f7b677272a6cb
---
M src/drivers/pc80/pc/Makefile.inc
1 file changed, 16 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/74153/1
diff --git a/src/drivers/pc80/pc/Makefile.inc b/src/drivers/pc80/pc/Makefile.inc
index 63ed998..7cf2957 100644
--- a/src/drivers/pc80/pc/Makefile.inc
+++ b/src/drivers/pc80/pc/Makefile.inc
@@ -6,11 +6,7 @@
ramstage-$(CONFIG_SPKMODEM) += spkmodem.c
romstage-$(CONFIG_SPKMODEM) += spkmodem.c
-bootblock-y += i8254.c
-verstage_x86-y += i8254.c
-romstage-y += i8254.c
-ramstage-y += i8254.c
-postcar-y += i8254.c
+all_x86-y += i8254.c
smm-y += i8254.c
endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/74153
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23c6977ae8acebb8dcd546f86f7f7b677272a6cb
Gerrit-Change-Number: 74153
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Attention is currently required from: Martin L Roth.
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74150 )
Change subject: Makefile.inc: introduce all_x86 target
......................................................................
Makefile.inc: introduce all_x86 target
For compilation units that should be built for all stages that run on
the x86 cores in a newer AMD SoC, but can't be built for verstage on PSP
which is an ARM core, the all target can't be used, since that would
result in the compilation unit also being added to the verstage target
in the verstage on PSP case. In order to not need to add a compilation
unit to bootblock, verstage_x8, romstage and ramstage in separate lines
in the makefile, introduce the all_x86 target that adds a file to
bootblock, verstage_x86, romstage, postcar, ramstage. The compilation
units also need to be added to the postcar stage which is only present
on the pre-Zen SoCs to be able to also use the all_x86 target in common
AMD code that is also used in those per-Zen SoCs.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I9d0184182b931185990094d0874b49c0b5cb9f7e
---
M Makefile.inc
1 file changed, 25 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/74150/1
diff --git a/Makefile.inc b/Makefile.inc
index d2d3f88..3b34a99 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -114,6 +114,9 @@
verstage_x86-handler =
endif
+$(call add-special-class,all_x86)
+all_x86-handler = $(foreach class,bootblock verstage_x86 romstage postcar ramstage,$(eval $(class)-y += $(2)))
+
# Add dynamic classes for rmodules
$(foreach supported_arch,$(ARCH_SUPPORTED), \
$(eval $(call define_class,rmodules_$(supported_arch),$(supported_arch))))
--
To view, visit https://review.coreboot.org/c/coreboot/+/74150
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d0184182b931185990094d0874b49c0b5cb9f7e
Gerrit-Change-Number: 74150
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange